From directory-dev-return-2082-apmail-incubator-directory-dev-archive=incubator.apache.org@incubator.apache.org Fri Oct 08 16:38:15 2004 Return-Path: Delivered-To: apmail-incubator-directory-dev-archive@www.apache.org Received: (qmail 4872 invoked from network); 8 Oct 2004 16:38:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 8 Oct 2004 16:38:14 -0000 Received: (qmail 37912 invoked by uid 500); 8 Oct 2004 16:38:13 -0000 Delivered-To: apmail-incubator-directory-dev-archive@incubator.apache.org Received: (qmail 37824 invoked by uid 500); 8 Oct 2004 16:38:12 -0000 Mailing-List: contact directory-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list directory-dev@incubator.apache.org Received: (qmail 37794 invoked by uid 99); 8 Oct 2004 16:38:11 -0000 X-ASF-Spam-Status: No, hits=0.6 required=10.0 tests=FROM_ENDS_IN_NUMS,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of aok123@bellsouth.net designates 205.152.59.70 as permitted sender) Received: from [205.152.59.70] (HELO imf22aec.mail.bellsouth.net) (205.152.59.70) by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 08 Oct 2004 09:38:10 -0700 Received: from [172.16.1.7] ([65.80.200.112]) by imf22aec.mail.bellsouth.net (InterMail vM.5.01.06.11 201-253-122-130-111-20040605) with ESMTP id <20041008163759.FFJG1792.imf22aec.mail.bellsouth.net@[172.16.1.7]>; Fri, 8 Oct 2004 12:37:59 -0400 Subject: Re: svn commit: rev 54098 - in incubator/directory/seda/trunk/src: examples/org/apache/seda/examples java/org/apache/seda java/org/apache/seda/decoder java/org/apache/seda/encoder java/org/apache/seda/input java/org/apache/seda/listener java/org/apache/seda/output java/org/apache/seda/stage test/org/apache/seda test/org/apache/seda/examples From: Alex Karasulu To: directory-dev@incubator.apache.org Cc: directory-cvs@incubator.apache.org In-Reply-To: <20041008162423.96495.qmail@minotaur.apache.org> References: <20041008162423.96495.qmail@minotaur.apache.org> Content-Type: text/plain Message-Id: <1097253482.30589.13.camel@newton> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Fri, 08 Oct 2004 12:38:03 -0400 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Awesome! It feels good don't it. Thanks Noel for helping out with this. Alex On Fri, 2004-10-08 at 12:24, trustin@apache.org wrote: > Author: trustin > Date: Fri Oct 8 09:24:21 2004 > New Revision: 54098 > > Modified: > incubator/directory/seda/trunk/src/examples/org/apache/seda/examples/EchoTest.java > incubator/directory/seda/trunk/src/java/org/apache/seda/DefaultFrontendFactory.java > incubator/directory/seda/trunk/src/java/org/apache/seda/FrontendFactory.java > incubator/directory/seda/trunk/src/java/org/apache/seda/decoder/DecodeStageHandler.java > incubator/directory/seda/trunk/src/java/org/apache/seda/decoder/DecoderManagerMonitor.java > incubator/directory/seda/trunk/src/java/org/apache/seda/encoder/EncodeStageHandler.java > incubator/directory/seda/trunk/src/java/org/apache/seda/input/TCPInputManager.java > incubator/directory/seda/trunk/src/java/org/apache/seda/listener/AvailablePortFinder.java > incubator/directory/seda/trunk/src/java/org/apache/seda/listener/TCPListenerManager.java > incubator/directory/seda/trunk/src/java/org/apache/seda/output/OutputMonitor.java > incubator/directory/seda/trunk/src/java/org/apache/seda/stage/StageConfig.java > incubator/directory/seda/trunk/src/test/org/apache/seda/DefaultFrontendFactoryTest.java > incubator/directory/seda/trunk/src/test/org/apache/seda/ProtocolTestCase.java > incubator/directory/seda/trunk/src/test/org/apache/seda/examples/DiscardProtocolProviderTest.java > Log: > I'll never forget this moment, 'the first commit'. > > * Removed unused imports > * Removed unthrows throws clauses > * Fixed some broken JavaDoc tags > > > > > Modified: incubator/directory/seda/trunk/src/examples/org/apache/seda/examples/EchoTest.java > ============================================================================== > --- incubator/directory/seda/trunk/src/examples/org/apache/seda/examples/EchoTest.java (original) > +++ incubator/directory/seda/trunk/src/examples/org/apache/seda/examples/EchoTest.java Fri Oct 8 09:24:21 2004 > @@ -1,3 +1,5 @@ > +package org.apache.seda.examples; > + > import org.apache.commons.net.EchoTCPClient; > > > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/DefaultFrontendFactory.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/DefaultFrontendFactory.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/DefaultFrontendFactory.java Fri Oct 8 09:24:21 2004 > @@ -161,7 +161,7 @@ > > > private ListenerManager createListenerManager( EventRouter router ) > - throws IOException, InterruptedException > + throws IOException > { > TCPListenerManager listMan = new TCPListenerManager( router ); > listMan.start(); > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/FrontendFactory.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/FrontendFactory.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/FrontendFactory.java Fri Oct 8 09:24:21 2004 > @@ -16,8 +16,6 @@ > */ > package org.apache.seda; > > -import java.io.IOException; > - > /** > * Document me. > * > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/decoder/DecodeStageHandler.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/decoder/DecodeStageHandler.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/decoder/DecodeStageHandler.java Fri Oct 8 09:24:21 2004 > @@ -64,7 +64,7 @@ > InputEvent e = ( InputEvent ) event; > ClientKey key = e.getClientKey(); > ByteBuffer buf = e.claimInterest( this ); > - StatefulDecoder decoder = ( StatefulDecoder ) manager.getDecoder( key ); > + StatefulDecoder decoder = manager.getDecoder( key ); > > try > { > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/decoder/DecoderManagerMonitor.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/decoder/DecoderManagerMonitor.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/decoder/DecoderManagerMonitor.java Fri Oct 8 09:24:21 2004 > @@ -20,8 +20,6 @@ > import java.util.EventObject; > > import org.apache.seda.event.Subscriber; > -import org.apache.seda.event.Subscriber; > - > > /** > * Monitors DecoderManagers. > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/encoder/EncodeStageHandler.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/encoder/EncodeStageHandler.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/encoder/EncodeStageHandler.java Fri Oct 8 09:24:21 2004 > @@ -52,7 +52,7 @@ > { > ResponseEvent re = ( ResponseEvent ) event; > ClientKey key = re.getClientKey(); > - StatefulEncoder encoder = ( StatefulEncoder ) encMan.getEncoder( key ); > + StatefulEncoder encoder = encMan.getEncoder( key ); > > try > { > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/input/TCPInputManager.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/input/TCPInputManager.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/input/TCPInputManager.java Fri Oct 8 09:24:21 2004 > @@ -291,9 +291,7 @@ > /** > * Cancel/Unregister dropped connections since the last call to select. > * > - * @see - * "http://nagoya.apache.org/jira/secure/ViewIssue.jspa?id=13574">JIRA Issue > - * > + * @see JIRA Issue > */ > private void unregisterDroppedConnections() > { > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/listener/AvailablePortFinder.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/listener/AvailablePortFinder.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/listener/AvailablePortFinder.java Fri Oct 8 09:24:21 2004 > @@ -30,7 +30,7 @@ > * @author Trustin Lee > * @author Apache Directory Project > * @version $Rev$ > - * @see > + * @see IANA.org > */ > public class AvailablePortFinder { > > @@ -125,11 +125,11 @@ > > > /** > - * Returns the {@link Set| of currently avaliable port numbers ({@link Integer}) > + * Returns the {@link Set} of currently avaliable port numbers ({@link Integer}) > * between the specified port range. > * > * @throws IllegalArgumentException if port range is not between > - * {@link MIN_PORT_NUMBER} and {@link MAX_PORT_NUMBER} or > + * {@link #MIN_PORT_NUMBER} and {@link #MAX_PORT_NUMBER} or > * fromPort if greater than toPort. > */ > public Set getAvailablePorts( int fromPort, int toPort ) > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/listener/TCPListenerManager.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/listener/TCPListenerManager.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/listener/TCPListenerManager.java Fri Oct 8 09:24:21 2004 > @@ -349,10 +349,9 @@ > /** > * Starts up this ListnerManager service. > * > - * @throws InterruptedException if this service's driver thread cannot start > * @throws IllegalStateException if this service has already started > */ > - public void start() throws InterruptedException > + public void start() > { > if ( hasStarted.booleanValue() ) > { > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/output/OutputMonitor.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/output/OutputMonitor.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/output/OutputMonitor.java Fri Oct 8 09:24:21 2004 > @@ -19,13 +19,10 @@ > > import java.util.EventObject; > > -import org.apache.seda.listener.ClientKey; > import org.apache.seda.event.ConnectEvent; > import org.apache.seda.event.DisconnectEvent; > -import org.apache.seda.listener.KeyExpiryException; > -import org.apache.seda.event.ConnectEvent; > import org.apache.seda.listener.ClientKey; > -import org.apache.seda.output.OutputManager; > +import org.apache.seda.listener.KeyExpiryException; > > > /** > > Modified: incubator/directory/seda/trunk/src/java/org/apache/seda/stage/StageConfig.java > ============================================================================== > --- incubator/directory/seda/trunk/src/java/org/apache/seda/stage/StageConfig.java (original) > +++ incubator/directory/seda/trunk/src/java/org/apache/seda/stage/StageConfig.java Fri Oct 8 09:24:21 2004 > @@ -20,7 +20,6 @@ > import java.util.List; > > import org.apache.seda.thread.ThreadPool; > -import org.apache.seda.thread.ThreadPool; > > > /** > > Modified: incubator/directory/seda/trunk/src/test/org/apache/seda/DefaultFrontendFactoryTest.java > ============================================================================== > --- incubator/directory/seda/trunk/src/test/org/apache/seda/DefaultFrontendFactoryTest.java (original) > +++ incubator/directory/seda/trunk/src/test/org/apache/seda/DefaultFrontendFactoryTest.java Fri Oct 8 09:24:21 2004 > @@ -102,7 +102,7 @@ > } > > > - public void testEcho() throws IOException, InterruptedException > + public void testEcho() throws IOException > { > InetServiceEntry srvEntry = new InetServiceEntry( "echo", > AvailablePortFinder.getNextAvailable( 6666 ) ); > > Modified: incubator/directory/seda/trunk/src/test/org/apache/seda/ProtocolTestCase.java > ============================================================================== > --- incubator/directory/seda/trunk/src/test/org/apache/seda/ProtocolTestCase.java (original) > +++ incubator/directory/seda/trunk/src/test/org/apache/seda/ProtocolTestCase.java Fri Oct 8 09:24:21 2004 > @@ -16,18 +16,16 @@ > */ > package org.apache.seda; > > - > -import java.io.IOException; > import java.net.InetAddress; > > -import org.apache.seda.protocol.InetServiceEntry; > -import org.apache.seda.protocol.DefaultInetServicesDatabase; > -import org.apache.seda.protocol.ProtocolProvider; > +import junit.framework.TestCase; > + > import org.apache.seda.listener.AvailablePortFinder; > import org.apache.seda.listener.ListenerConfig; > import org.apache.seda.listener.TCPListenerConfig; > - > -import junit.framework.TestCase; > +import org.apache.seda.protocol.DefaultInetServicesDatabase; > +import org.apache.seda.protocol.InetServiceEntry; > +import org.apache.seda.protocol.ProtocolProvider; > > > /** > @@ -47,7 +45,7 @@ > protected ListenerConfig config = null; > > > - public ProtocolTestCase( ProtocolProvider proto ) throws IOException > + public ProtocolTestCase( ProtocolProvider proto ) > { > this.proto = proto; > } > > Modified: incubator/directory/seda/trunk/src/test/org/apache/seda/examples/DiscardProtocolProviderTest.java > ============================================================================== > --- incubator/directory/seda/trunk/src/test/org/apache/seda/examples/DiscardProtocolProviderTest.java (original) > +++ incubator/directory/seda/trunk/src/test/org/apache/seda/examples/DiscardProtocolProviderTest.java Fri Oct 8 09:24:21 2004 > @@ -16,12 +16,7 @@ > */ > package org.apache.seda.examples; > > - > -import java.io.IOException; > - > import org.apache.seda.ProtocolTestCase; > -import org.apache.commons.net.DiscardTCPClient; > - > > /** > * Document me. > @@ -33,7 +28,7 @@ > public class DiscardProtocolProviderTest extends ProtocolTestCase > { > > - public DiscardProtocolProviderTest() throws IOException > + public DiscardProtocolProviderTest() > { > super( new DiscardProtocolProvider() ); > }