Return-Path: Delivered-To: apmail-incubator-directory-dev-archive@www.apache.org Received: (qmail 40037 invoked from network); 26 Aug 2004 07:32:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 26 Aug 2004 07:32:09 -0000 Received: (qmail 30274 invoked by uid 500); 26 Aug 2004 07:31:46 -0000 Delivered-To: apmail-incubator-directory-dev-archive@incubator.apache.org Received: (qmail 30212 invoked by uid 500); 26 Aug 2004 07:31:45 -0000 Mailing-List: contact directory-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Apache Directory Developers List" Reply-To: "Apache Directory Developers List" Delivered-To: mailing list directory-dev@incubator.apache.org Received: (qmail 30191 invoked by uid 99); 26 Aug 2004 07:31:45 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [192.18.33.10] (HELO exchange.sun.com) (192.18.33.10) by apache.org (qpsmtpd/0.27.1) with SMTP; Thu, 26 Aug 2004 00:31:42 -0700 Received: (qmail 20960 invoked from network); 26 Aug 2004 07:33:21 -0000 Received: from localhost (HELO nagoya) (127.0.0.1) by nagoya.betaversion.org with SMTP; 26 Aug 2004 07:33:21 -0000 Message-ID: <1757122226.1093505601838.JavaMail.apache@nagoya> Date: Thu, 26 Aug 2004 00:33:21 -0700 (PDT) From: directory-dev@incubator.apache.org To: directory-dev@incubator.apache.org Subject: [jira] Closed: (DIRSNICKERS-93) without equals implementation in Add/Delete stubs tests are invalid In-Reply-To: <1674780341.1093500199990.JavaMail.apache@nagoya> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Message: The following issue has been closed. Resolver: Alex Karasulu Date: Thu, 26 Aug 2004 12:32 AM Committed test cases and equals additions for both Add and Delete requests on revision 37062. --------------------------------------------------------------------- View the issue: http://issues.apache.org/jira/browse/DIRSNICKERS-93 Here is an overview of the issue: --------------------------------------------------------------------- Key: DIRSNICKERS-93 Summary: without equals implementation in Add/Delete stubs tests are invalid Type: Bug Status: Closed Priority: Major Resolution: FIXED Project: Directory Snickers Components: LDAP Provider Assignee: Alex Karasulu Reporter: Alex Karasulu Created: Wed, 25 Aug 2004 11:02 PM Updated: Thu, 26 Aug 2004 12:32 AM Description: I just realized that the tests for add and delete req/resp pairs are using the parent equals() methods from the AbstractMessage base class which only compares the type, controls and message ids of Messages. We need to make sure the req/resp pairs factor in additional attributes while determining equality. For the responses we can kill two birds with one stone by overriding AbstractMessage.equals() within the AbstractResultResponse. This way we can compare the result properties in one place to determine equality. The Add and Delete requests are going to need their own equals() overrides within AddRequestImpl and DeleteRequestImpl. --------------------------------------------------------------------- JIRA INFORMATION: This message is automatically generated by JIRA. If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira