directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r1774774 [7/10] - in /directory/shared/branches/shared-value: ./ asn1/ber/src/main/java/org/apache/directory/api/asn1/actions/ asn1/ber/src/main/java/org/apache/directory/api/asn1/ber/ asn1/ber/src/main/java/org/apache/directory/api/asn1/be...
Date Sat, 17 Dec 2016 15:18:17 GMT
Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java Sat Dec 17 15:18:15 2016
@@ -150,7 +150,6 @@ public class LdifAnonymizer
         }
         catch ( Exception e )
         {
-            // Todo : we need a schemaManager
             println( "Missing a SchemaManager !" );
             System.exit( -1 );
         }

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/MonitoringLdapConnection.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/MonitoringLdapConnection.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/MonitoringLdapConnection.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/MonitoringLdapConnection.java Sat Dec 17 15:18:15 2016
@@ -62,12 +62,18 @@ public final class MonitoringLdapConnect
     }
 
 
+    /**
+     * @return tells if a Bind has been issued 
+     */
     public boolean bindCalled()
     {
         return bindCalled;
     }
 
 
+    /**
+     * Reset the Bind and StartTLS flags
+     */
     public void resetMonitors()
     {
         bindCalled = false;
@@ -75,6 +81,9 @@ public final class MonitoringLdapConnect
     }
 
 
+    /**
+     * @return tells if the StarTLS extended operation has been called
+     */
     public boolean startTlsCalled()
     {
         return startTlsCalled;

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/ValidatingPoolableLdapConnectionFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/ValidatingPoolableLdapConnectionFactory.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/ValidatingPoolableLdapConnectionFactory.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/ValidatingPoolableLdapConnectionFactory.java Sat Dec 17 15:18:15 2016
@@ -21,7 +21,11 @@
 package org.apache.directory.ldap.client.api;
 
 
+import org.apache.directory.api.asn1.util.Oid;
 import org.apache.directory.api.ldap.model.exception.LdapException;
+import org.apache.directory.api.ldap.model.message.BindRequest;
+import org.apache.directory.api.ldap.model.message.ExtendedRequest;
+import org.apache.directory.api.ldap.model.name.Dn;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/Wrapper.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/Wrapper.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/Wrapper.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/Wrapper.java Sat Dec 17 15:18:15 2016
@@ -24,6 +24,8 @@ package org.apache.directory.ldap.client
  * An interface for defining wrapper objects.  An implementation of this class
  * <b>MUST</b> implement <code>T</code> as well
  *
+ * @param <T> The wrapped type
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public interface Wrapper<T>

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/future/ResponseFuture.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/future/ResponseFuture.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/future/ResponseFuture.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/future/ResponseFuture.java Sat Dec 17 15:18:15 2016
@@ -108,7 +108,9 @@ public class ResponseFuture<R extends Re
 
 
     /**
-     * {@inheritDoc}
+     * Set the associated Response in this Future
+     * 
+     * @param response The response to add into the Future
      * @throws InterruptedException if the operation has been cancelled by client
      */
     public void set( R response ) throws InterruptedException

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java Sat Dec 17 15:18:15 2016
@@ -53,7 +53,7 @@ package org.apache.directory.ldap.client
     /**
      * Constructs a NOT filter with the associated inner Filter
      *
-     * @param Filter The inner Filter
+     * @param filter The inner Filter
      * @return The constructed NOT Filter
      */
     public static UnaryFilter not( Filter filter )

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/AbstractPasswordPolicyResponder.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/AbstractPasswordPolicyResponder.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/AbstractPasswordPolicyResponder.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/AbstractPasswordPolicyResponder.java Sat Dec 17 15:18:15 2016
@@ -33,9 +33,9 @@ import org.apache.directory.ldap.client.
 
 /**
  * A base, abstract, implementation of <code>PasswordPolicyResponder</code>.  
- * Extend this class and override {@link #success(PasswordPolicy)}, 
- * {@link #fail(ResultResponse, PasswordPolicy, ResultCodeEnum)}, or
- * {@link #exception(LdapException)}.  If that does not offer enough
+ * Extend this class and override success(PasswordPolicy), 
+ * fail(ResultResponse, PasswordPolicy, ResultCodeEnum), or
+ * exception(LdapException).  If that does not offer enough
  * flexibility, you must implement PasswordPolicyResponder yourself.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/ConnectionCallback.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/ConnectionCallback.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/ConnectionCallback.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/ConnectionCallback.java Sat Dec 17 15:18:15 2016
@@ -27,6 +27,8 @@ import org.apache.directory.ldap.client.
 /**
  * A callback for running code against a managed {@link LdapConnection}.
  * 
+ * @param <T> The callback type
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public interface ConnectionCallback<T>

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java Sat Dec 17 15:18:15 2016
@@ -96,6 +96,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public AddResponse add( Dn dn, final Attribute... attributes )
     {
@@ -111,6 +114,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public AddResponse add( Dn dn, RequestBuilder<AddRequest> requestBuilder )
     {
@@ -127,6 +133,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public AddResponse add( AddRequest addRequest )
     {
@@ -147,6 +156,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public PasswordWarning authenticate( String baseDn, String filter, SearchScope scope, char[] password )
         throws PasswordException
@@ -155,6 +167,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public PasswordWarning authenticate( Dn baseDn, String filter, SearchScope scope, char[] password )
         throws PasswordException
@@ -163,6 +178,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public PasswordWarning authenticate( SearchRequest searchRequest, char[] password ) throws PasswordException
     {
@@ -176,6 +194,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public PasswordWarning authenticate( Dn userDn, char[] password ) throws PasswordException
     {
@@ -224,6 +245,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public DeleteResponse delete( Dn dn )
     {
@@ -231,6 +255,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public DeleteResponse delete( Dn dn, RequestBuilder<DeleteRequest> requestBuilder )
     {
@@ -250,6 +277,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public DeleteResponse delete( DeleteRequest deleteRequest )
     {
@@ -270,6 +300,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T execute( ConnectionCallback<T> connectionCallback )
     {
@@ -290,6 +323,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T lookup( Dn dn, EntryMapper<T> entryMapper )
     {
@@ -297,6 +333,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T lookup( Dn dn, String[] attributes, EntryMapper<T> entryMapper )
     {
@@ -352,6 +391,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public void modifyPassword( Dn userDn, char[] newPassword )
         throws PasswordException
@@ -360,6 +402,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public void modifyPassword( Dn userDn, char[] oldPassword,
         char[] newPassword ) throws PasswordException
@@ -368,6 +413,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public void modifyPassword( Dn userDn, char[] oldPassword,
         char[] newPassword, boolean asAdmin ) throws PasswordException
@@ -394,6 +442,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public ModifyResponse modify( Dn dn, RequestBuilder<ModifyRequest> requestBuilder )
     {
@@ -410,6 +461,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public ModifyResponse modify( ModifyRequest modifyRequest )
     {
@@ -430,6 +484,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public AddRequest newAddRequest( Entry entry )
     {
@@ -437,6 +494,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public Attribute newAttribute( String name )
     {
@@ -444,13 +504,18 @@ public class LdapConnectionTemplate impl
     }
 
 
-    @Override
+    /**
+     * {@inheritDoc}
+     */
     public Attribute newAttribute( String name, byte[]... values )
     {
         return modelFactory.newAttribute( name, values );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public Attribute newAttribute( String name, String... values )
     {
@@ -458,6 +523,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public Attribute newAttribute( String name, Value... values )
     {
@@ -465,6 +533,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public DeleteRequest newDeleteRequest( Dn dn )
     {
@@ -472,6 +543,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public Dn newDn( String dn )
     {
@@ -479,6 +553,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public Entry newEntry( String dn )
     {
@@ -486,6 +563,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public Entry newEntry( Dn dn )
     {
@@ -493,6 +573,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public ModifyRequest newModifyRequest( String dn )
     {
@@ -500,6 +583,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public ModifyRequest newModifyRequest( Dn dn )
     {
@@ -507,6 +593,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public SearchRequest newSearchRequest( String baseDn, FilterBuilder filter, SearchScope scope )
     {
@@ -514,6 +603,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public SearchRequest newSearchRequest( String baseDn, String filter, SearchScope scope )
     {
@@ -521,6 +613,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public SearchRequest newSearchRequest( Dn baseDn, FilterBuilder filter, SearchScope scope )
     {
@@ -528,6 +623,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public SearchRequest newSearchRequest( Dn baseDn, String filter, SearchScope scope )
     {
@@ -535,6 +633,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public SearchRequest newSearchRequest( String baseDn, FilterBuilder filter, SearchScope scope, String... attributes )
     {
@@ -542,6 +643,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public SearchRequest newSearchRequest( String baseDn, String filter, SearchScope scope, String... attributes )
     {
@@ -549,6 +653,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public SearchRequest newSearchRequest( Dn baseDn, FilterBuilder filter, SearchScope scope, String... attributes )
     {
@@ -556,6 +663,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public SearchRequest newSearchRequest( Dn baseDn, String filter, SearchScope scope, String... attributes )
     {
@@ -563,6 +673,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T extends ResultResponse> T responseOrException( T response )
     {
@@ -590,6 +703,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( String baseDn, FilterBuilder filter, SearchScope scope,
         EntryMapper<T> entryMapper )
@@ -600,6 +716,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( String baseDn, String filter, SearchScope scope,
         EntryMapper<T> entryMapper )
@@ -610,6 +729,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( Dn baseDn, FilterBuilder filter, SearchScope scope,
         EntryMapper<T> entryMapper )
@@ -620,6 +742,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( Dn baseDn, String filter, SearchScope scope,
         EntryMapper<T> entryMapper )
@@ -630,6 +755,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( String baseDn, FilterBuilder filter, SearchScope scope,
         String[] attributes, EntryMapper<T> entryMapper )
@@ -640,6 +768,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( String baseDn, String filter, SearchScope scope,
         String[] attributes, EntryMapper<T> entryMapper )
@@ -650,6 +781,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( Dn baseDn, FilterBuilder filter, SearchScope scope,
         String[] attributes, EntryMapper<T> entryMapper )
@@ -660,6 +794,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( Dn baseDn, String filter, SearchScope scope,
         String[] attributes, EntryMapper<T> entryMapper )
@@ -670,11 +807,14 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> List<T> search( SearchRequest searchRequest,
         EntryMapper<T> entryMapper )
     {
-        List<T> entries = new ArrayList<T>();
+        List<T> entries = new ArrayList<>();
 
         LdapConnection connection = null;
         try
@@ -699,6 +839,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( String baseDn, FilterBuilder filter, SearchScope scope,
         EntryMapper<T> entryMapper )
@@ -709,6 +852,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( String baseDn, String filter, SearchScope scope,
         EntryMapper<T> entryMapper )
@@ -719,6 +865,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( Dn baseDn, FilterBuilder filter, SearchScope scope,
         EntryMapper<T> entryMapper )
@@ -729,6 +878,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( Dn baseDn, String filter, SearchScope scope,
         EntryMapper<T> entryMapper )
@@ -739,6 +891,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( String baseDn, FilterBuilder filter, SearchScope scope,
         String[] attributes, EntryMapper<T> entryMapper )
@@ -749,6 +904,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( String baseDn, String filter, SearchScope scope,
         String[] attributes, EntryMapper<T> entryMapper )
@@ -759,6 +917,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( Dn baseDn, FilterBuilder filter, SearchScope scope,
         String[] attributes, EntryMapper<T> entryMapper )
@@ -769,6 +930,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( Dn baseDn, String filter, SearchScope scope,
         String[] attributes, EntryMapper<T> entryMapper )
@@ -779,6 +943,9 @@ public class LdapConnectionTemplate impl
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public <T> T searchFirst( SearchRequest searchRequest,
         EntryMapper<T> entryMapper )

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java Sat Dec 17 15:18:15 2016
@@ -224,7 +224,7 @@ public final class MemoryClearingBuffer
 
     /**
      * Returns the <code>byte[]</code> used to create this buffer, or 
-     * {@link #getComputedBytes()} if created with a <code>char[]</code>.
+     * getComputedBytes() if created with a <code>char[]</code>.
      *
      * @return A byte[]
      */
@@ -237,7 +237,7 @@ public final class MemoryClearingBuffer
 
     /**
      * Returns the <code>char[]</code> used to create this buffer, or 
-     * {@link #getComputedChars()} if created with a <code>byte[]</code>.
+     * getComputedChars() if created with a <code>byte[]</code>.
      *
      * @return A byte[]
      */

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java Sat Dec 17 15:18:15 2016
@@ -66,6 +66,9 @@ final class PasswordWarningImpl implemen
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public int getTimeBeforeExpiration()
     {
@@ -73,6 +76,9 @@ final class PasswordWarningImpl implemen
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public int getGraceAuthNsRemaining()
     {
@@ -80,6 +86,9 @@ final class PasswordWarningImpl implemen
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public boolean isChangeAfterReset()
     {

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/RequestBuilder.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/RequestBuilder.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/RequestBuilder.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/RequestBuilder.java Sat Dec 17 15:18:15 2016
@@ -25,6 +25,8 @@ import org.apache.directory.api.ldap.mod
 
 /**
  * Edits a supplied request adding specifics.
+ * 
+ * @param <T> The request type
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/LdapRequestUnsuccessfulException.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/LdapRequestUnsuccessfulException.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/LdapRequestUnsuccessfulException.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/LdapRequestUnsuccessfulException.java Sat Dec 17 15:18:15 2016
@@ -36,7 +36,11 @@ public class LdapRequestUnsuccessfulExce
 
     private final transient ResultResponse response;
 
-
+    /**
+     * Creates a new LdapRequestUnsuccessfulException instance
+     * 
+     * @param response The associated LDAP Response
+     */
     public LdapRequestUnsuccessfulException( ResultResponse response )
     {
         super();
@@ -44,9 +48,11 @@ public class LdapRequestUnsuccessfulExce
     }
 
 
+    /**
+     * @return the associate LDAP Response
+     */
     public ResultResponse getResponse()
     {
         return response;
     }
-
 }

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/LdapRuntimeException.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/LdapRuntimeException.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/LdapRuntimeException.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/LdapRuntimeException.java Sat Dec 17 15:18:15 2016
@@ -33,7 +33,11 @@ public class LdapRuntimeException extend
 {
     private static final long serialVersionUID = 3618077059423567243L;
 
-
+    /**
+     * Creates a new LdapRuntimeException instance
+     * 
+     * @param exception The wrapped exception
+     */
     public LdapRuntimeException( LdapException exception )
     {
         super( exception );

Modified: directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/PasswordException.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/PasswordException.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/PasswordException.java (original)
+++ directory/shared/branches/shared-value/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/exception/PasswordException.java Sat Dec 17 15:18:15 2016
@@ -40,6 +40,9 @@ public class PasswordException extends E
     private PasswordPolicyErrorEnum passwordPolicyError;
 
 
+    /**
+     * Creates a new PasswordException instance
+     */
     public PasswordException()
     {
         super();
@@ -81,6 +84,12 @@ public class PasswordException extends E
     }
 
 
+    /**
+     * Sets the wrapped exception
+     * 
+     * @param ldapException The wrapped exception
+     * @return The wrapping exception
+     */
     public PasswordException setLdapException( LdapException ldapException )
     {
         this.ldapException = ldapException;
@@ -88,6 +97,12 @@ public class PasswordException extends E
     }
 
 
+    /**
+     * Set the Password Policy error
+     * 
+     * @param passwordPolicyError The Password Policy error
+     * @return The wrapping exception
+     */
     public PasswordException setPasswordPolicyError( PasswordPolicyErrorEnum passwordPolicyError )
     {
         this.passwordPolicyError = passwordPolicyError;
@@ -95,6 +110,12 @@ public class PasswordException extends E
     }
 
 
+    /**
+     * Sets the LDAP Result code
+     * 
+     * @param resultCode The LDAP error code
+     * @return The wrapping exception
+     */
     public PasswordException setResultCode( ResultCodeEnum resultCode )
     {
         this.resultCode = resultCode;

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/CodecControl.java Sat Dec 17 15:18:15 2016
@@ -29,6 +29,8 @@ import org.apache.directory.api.ldap.mod
  * The codec uses this interface to add additional information to LDAP Model
  * Control objects during encoding and decoding.
  *
+ * @param <E> The control being handled by this codec
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public interface CodecControl<E extends Control> extends Control, Decorator<E>

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlDecorator.java Sat Dec 17 15:18:15 2016
@@ -29,8 +29,9 @@ import org.apache.directory.api.ldap.mod
  * so the codec to store transient information associated with the Control in the
  * decorator while processing.
  * 
- * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @param <E> The control type
+ * 
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public abstract class ControlDecorator<E extends Control> implements CodecControl<E>, Asn1Object
 {
@@ -71,7 +72,9 @@ public abstract class ControlDecorator<E
 
 
     /**
-     * {@inheritDoc}
+     * Set the control to be decorated.
+     * 
+     * @param decorated The decorated control
      */
     public void setDecorated( E decorated )
     {

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ControlFactory.java Sat Dec 17 15:18:15 2016
@@ -29,6 +29,8 @@ import org.apache.directory.api.ldap.mod
  * then registered with the codec and used by the codec to encode and decode
  * those controls.
  *
+ * @param <C> The Control to create
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public interface ControlFactory<C extends Control>

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/Decorator.java Sat Dec 17 15:18:15 2016
@@ -29,6 +29,8 @@ import org.apache.directory.api.asn1.Enc
  * The codec uses this interface to add additional information to LDAP Model
  * objects during encoding and decoding,
  *
+ * @param <E> The element to decorate
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public interface Decorator<E>

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedRequestDecorator.java Sat Dec 17 15:18:15 2016
@@ -35,6 +35,8 @@ import org.apache.directory.api.util.Str
 /**
  * A decorator for the ExtendedRequest message
  *
+ * @param <Q> The extended request to decorate
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public class ExtendedRequestDecorator<Q extends ExtendedRequest>
@@ -89,7 +91,9 @@ public class ExtendedRequestDecorator<Q
 
 
     /**
-     * {@inheritDoc}
+     * Gets the Extended request payload 
+     * 
+     * @return The extended payload
      */
     public byte[] getRequestValue()
     {
@@ -98,7 +102,9 @@ public class ExtendedRequestDecorator<Q
 
 
     /**
-     * {@inheritDoc}
+     * sets the Extended request payload 
+     * 
+     * @param requestValue The extended payload
      */
     public void setRequestValue( byte[] requestValue )
     {

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/ExtendedResponseDecorator.java Sat Dec 17 15:18:15 2016
@@ -35,6 +35,8 @@ import org.apache.directory.api.util.Str
 /**
  * A decorator for the ExtendedResponse message
  *
+ * @param <R> The extended response to decorate
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public class ExtendedResponseDecorator<R extends ExtendedResponse> extends ResponseDecorator<R>
@@ -87,7 +89,9 @@ public class ExtendedResponseDecorator<R
 
 
     /**
-     * {@inheritDoc}
+     * Gets the Extended response payload 
+     * 
+     * @return The extended payload
      */
     public byte[] getResponseValue()
     {
@@ -96,7 +100,9 @@ public class ExtendedResponseDecorator<R
 
 
     /**
-     * {@inheritDoc}
+     * sets the Extended response payload 
+     * 
+     * @param responseValue The extended payload
      */
     public void setResponseValue( byte[] responseValue )
     {

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapApiService.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapApiService.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapApiService.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapApiService.java Sat Dec 17 15:18:15 2016
@@ -39,6 +39,7 @@ import org.apache.mina.filter.codec.Prot
  */
 public interface LdapApiService
 {
+    /** The default codec factory */
     String DEFAULT_PROTOCOL_CODEC_FACTORY =
         "org.apache.directory.api.ldap.codec.protocol.mina.LdapProtocolCodecFactory";
 

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapCodecConstants.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapCodecConstants.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapCodecConstants.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapCodecConstants.java Sat Dec 17 15:18:15 2016
@@ -27,13 +27,6 @@ package org.apache.directory.api.ldap.co
  */
 public final class LdapCodecConstants
 {
-    /**
-     * Private constructor.
-     */
-    private LdapCodecConstants()
-    {
-    }
-
     /** The scope constants */
     public static final int SCOPE_BASE_OBJECT = 0;
 
@@ -168,4 +161,11 @@ public final class LdapCodecConstants
     public static final int APPROX_MATCH_FILTER_TAG = 0xA8;
 
     public static final int EXTENSIBLE_MATCH_FILTER_TAG = 0xA9;
+
+    /**
+     * Private constructor.
+     */
+    private LdapCodecConstants()
+    {
+    }
 }

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/LdapMessageContainer.java Sat Dec 17 15:18:15 2016
@@ -32,6 +32,8 @@ import org.apache.directory.api.ldap.mod
  * When dealing with an encoding PDU, we will obtain a LdapMessage in the
  * container.
  *
+ * @param <E> The decorated message
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public class LdapMessageContainer<E extends MessageDecorator<? extends Message>> extends AbstractContainer

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/MessageDecorator.java Sat Dec 17 15:18:15 2016
@@ -72,6 +72,8 @@ import org.apache.directory.api.ldap.mod
 /**
  * A decorator for the generic LDAP Message
  *
+ * @param <E> The message to decorate
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public abstract class MessageDecorator<E extends Message> implements Message, Decorator<E>, Asn1Object

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/SchemaBinaryAttributeDetector.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/SchemaBinaryAttributeDetector.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/SchemaBinaryAttributeDetector.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/api/SchemaBinaryAttributeDetector.java Sat Dec 17 15:18:15 2016
@@ -41,6 +41,11 @@ public class SchemaBinaryAttributeDetect
     }
     
     
+    /**
+     * Create an instance of SchemaBinaryAttributeDetector.
+     * 
+     * @param schemaManager The SchemaManager to use
+     */
     public SchemaBinaryAttributeDetector( SchemaManager schemaManager )
     {
         this.schemaManager = schemaManager;

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeDecorator.java Sat Dec 17 15:18:15 2016
@@ -48,7 +48,7 @@ import org.apache.directory.api.util.Str
  */
 public class EntryChangeDecorator extends ControlDecorator<EntryChange> implements EntryChange
 {
-
+    /** Default value when no change number is provided */
     public static final int UNDEFINED_CHANGE_NUMBER = -1;
 
     /** A temporary storage for the previous Dn */

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsContainer.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsContainer.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsContainer.java Sat Dec 17 15:18:15 2016
@@ -77,6 +77,11 @@ public class PagedResultsContainer exten
     }
 
 
+    /**
+     * Decorate the PageResult control
+     * 
+     * @param control The PageResult control instance
+     */
     public void decorate( PagedResults control )
     {
         if ( control instanceof PagedResultsDecorator )

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchDecorator.java Sat Dec 17 15:18:15 2016
@@ -231,6 +231,16 @@ public void setChangesOnly( boolean chan
      * {@inheritDoc}
      */
     @Override
+    public void disableNotification( ChangeType changeType )
+    {
+        getPersistentSearch().disableNotification( changeType );
+    }
+
+    
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public Asn1Object decode( byte[] controlBytes ) throws DecoderException
     {
         ByteBuffer bb = ByteBuffer.wrap( controlBytes );

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java Sat Dec 17 15:18:15 2016
@@ -27,7 +27,7 @@ import org.apache.directory.api.ldap.mod
 
 
 /**
- * 
+ * A factory to create a PersistentSearch control 
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
@@ -37,6 +37,11 @@ public class PersistentSearchFactory imp
     private LdapApiService codec;
 
 
+    /**
+     * Create a new PersistentSearchFactory instance
+     * 
+     * @param codec The LdapApiService instance
+     */
     public PersistentSearchFactory( LdapApiService codec )
     {
         this.codec = codec;

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestContainer.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestContainer.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestContainer.java Sat Dec 17 15:18:15 2016
@@ -71,7 +71,9 @@ public class SortRequestContainer extend
 
 
     /**
-     * {@inheritDoc}
+     * Decorate a SortRequest control
+     * 
+     * @param control The control to decorate
      */
     public void decorate( SortRequest control )
     {

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestDecorator.java Sat Dec 17 15:18:15 2016
@@ -54,8 +54,10 @@ public class SortRequestDecorator extend
 
     private List<Integer> sortKeyLenList = new ArrayList<>();
 
+    /** ASN.1 BER tag for the forward ordering rule */
     public static final int ORDERING_RULE_TAG = 0x80;
 
+    /** ASN.1 BER tag for the backward ordering rule */
     public static final int REVERSE_ORDER_TAG = 0x81;
 
 

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestStates.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestStates.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestStates.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestStates.java Sat Dec 17 15:18:15 2016
@@ -30,18 +30,25 @@ import org.apache.directory.api.asn1.ber
  */
 public enum SortRequestStates implements States
 {
+    /** Initial state */
     START_STATE,
 
+    /** SortKeyList ::= SEQUENCE OF transition */
     SEQUENCE_OF_SEQUENCE_STATE,
     
+    /** SortKeyList ::= SEQUENCE OF SEQUENCE transition */
     SORT_KEY_SEQUENCE_STATE,
 
+    /** attributeType   AttributeDescription transition */
     AT_DESC_STATE,
 
+    /** orderingRule    [0] MatchingRuleId OPTIONAL transition */
     ORDER_RULE_STATE,
 
+    /** reverseOrder    [1] BOOLEAN DEFAULT FALSE transition */
     REVERSE_ORDER_STATE,
 
+    /** Final state */
     END_STATE;
 
     /**

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseContainer.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseContainer.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseContainer.java Sat Dec 17 15:18:15 2016
@@ -67,7 +67,9 @@ public class SortResponseContainer exten
 
 
     /**
-     * {@inheritDoc} 
+     * Decorate the SortResponse control
+     * 
+     * @param control The Sort Response control to decorate
      */
     public void decorate( SortResponse control )
     {

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseStates.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseStates.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseStates.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseStates.java Sat Dec 17 15:18:15 2016
@@ -30,14 +30,19 @@ import org.apache.directory.api.asn1.ber
  */
 public enum SortResponseStates implements States
 {
+    /** Initialstate */ 
     START_STATE,
 
+    /** SortResult ::= SEQUENCE transition */
     SEQUENCE_STATE,
 
+    /** sortResult  ENUMERATED transition */
     RESULT_CODE_STATE,
     
+    /** attributeType [0] AttributeDescription OPTIONAL transition */
     AT_DESC_STATE,
 
+    /** Final state */
     END_STATE;
 
     /**

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java Sat Dec 17 15:18:15 2016
@@ -28,6 +28,8 @@ import org.apache.directory.api.ldap.mod
 /**
  * The action used to store the result code of a SortResponseControl
  * 
+ * @param <C> The Asn1Container type to use
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public class StoreSortResponseResultCode<C extends Asn1Container> extends AbstractReadInteger<C>

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java Sat Dec 17 15:18:15 2016
@@ -27,6 +27,8 @@ import org.apache.directory.api.ldap.mod
 
 /**
  * A decorator for the LdapResultResponse message
+ * 
+ * @param <M> The Request to decorate
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
@@ -60,6 +62,7 @@ public abstract class AbandonableRequest
     /**
      * {@inheritDoc}
      */
+    @Override
     public void abandon()
     {
         getAbandonableRequest().abandon();
@@ -69,6 +72,7 @@ public abstract class AbandonableRequest
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isAbandoned()
     {
         return getAbandonableRequest().isAbandoned();
@@ -78,6 +82,7 @@ public abstract class AbandonableRequest
     /**
      * {@inheritDoc}
      */
+    @Override
     public AbandonableRequest addAbandonListener( AbandonListener listener )
     {
         getAbandonableRequest().addAbandonListener( listener );

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java Sat Dec 17 15:18:15 2016
@@ -27,6 +27,8 @@ import org.apache.directory.api.ldap.mod
 
 /**
  * A decorator for the LdapResultResponse message
+ * 
+ * @param <M> The message response to decorate
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/RequestDecorator.java Sat Dec 17 15:18:15 2016
@@ -27,9 +27,9 @@ import org.apache.directory.api.ldap.mod
 
 /**
  * A decorator for the LdapResultResponse message
+ * 
+ * @param <M> The request to decorate
  *
- * TODO make this extend AbstractDsmlMessageDecorator instead of codec's 
- * MessageDecorator.
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public abstract class RequestDecorator<M extends Request> extends MessageDecorator<M> implements Request

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResponseDecorator.java Sat Dec 17 15:18:15 2016
@@ -28,6 +28,8 @@ import org.apache.directory.api.ldap.mod
 
 /**
  * A decorator for the Response message. It will store the LdapResult.
+ * 
+ * @param <M> The response to be decorated
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ResultResponseRequestDecorator.java Sat Dec 17 15:18:15 2016
@@ -28,6 +28,8 @@ import org.apache.directory.api.ldap.mod
 /**
  * A decorator for the LdapResultResponse message
  *
+ * @param <M> The request to be decorated
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public abstract class ResultResponseRequestDecorator<M extends ResultResponseRequest>

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SearchRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SearchRequestDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SearchRequestDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SearchRequestDecorator.java Sat Dec 17 15:18:15 2016
@@ -130,6 +130,9 @@ public class SearchRequestDecorator exte
     }
 
 
+    /**
+     * @return The current search filter
+     */
     public Filter getCurrentFilter()
     {
         return currentFilter;

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SearchResultEntryDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SearchResultEntryDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SearchResultEntryDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SearchResultEntryDecorator.java Sat Dec 17 15:18:15 2016
@@ -84,6 +84,9 @@ public class SearchResultEntryDecorator
     }
 
 
+    /**
+     * @return The current attribute
+     */
     public Attribute getCurrentAttribute()
     {
         return currentAttribute;

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/SingleReplyRequestDecorator.java Sat Dec 17 15:18:15 2016
@@ -30,6 +30,8 @@ import org.apache.directory.api.ldap.mod
 /**
  * A decorator for the LdapResultResponse message
  *
+ * @param <M> The request to be decorated
+ * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
 public abstract class SingleReplyRequestDecorator<M extends SingleReplyRequest>

Modified: directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/osgi/DefaultActivator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/osgi/DefaultActivator.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/osgi/DefaultActivator.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/osgi/DefaultActivator.java Sat Dec 17 15:18:15 2016
@@ -38,6 +38,9 @@ public class DefaultActivator implements
     private ServiceRegistration<?> registration;
 
 
+    /**
+     * Creates a new instance of DefaultActivator 
+     */
     public DefaultActivator()
     {
         this.codec = new DefaultLdapCodecService();
@@ -47,6 +50,7 @@ public class DefaultActivator implements
     /**
      * {@inheritDoc}
      */
+    @Override
     public void start( BundleContext bundleContext ) throws Exception
     {
         registration = bundleContext.registerService( LdapApiService.class.getName(), codec, null );
@@ -57,6 +61,7 @@ public class DefaultActivator implements
     /**
      * {@inheritDoc}
      */
+    @Override
     public void stop( BundleContext bundleContext ) throws Exception
     {
         registration.unregister();

Modified: directory/shared/branches/shared-value/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java (original)
+++ directory/shared/branches/shared-value/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java Sat Dec 17 15:18:15 2016
@@ -184,6 +184,22 @@ public final class CodecFactoryUtil
     }
 
 
+    /**
+     * Load the standard extended operations :
+     * <ul>
+     * <li>cancel</li>
+     * <li>certGeneration</li>
+     * <li>gracefuShutdown</li>
+     * <li>storedProcedure</li>
+     * <li>gracefulDisconnect</li>
+     * <li>passwordModify</li>
+     * <li>whoAmI</li>
+     * <li>startTls</li>
+     * </ul>
+     * 
+     * @param extendendOperationsFactories The map of extended operation factories
+     * @param apiService The LdapApiService to use
+     */
     public static void loadStockExtendedOperations(
         Map<String, ExtendedOperationFactory> extendendOperationsFactories, LdapApiService apiService )
     {

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/SyncModifyDnType.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/SyncModifyDnType.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/SyncModifyDnType.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/SyncModifyDnType.java Sat Dec 17 15:18:15 2016
@@ -28,8 +28,13 @@ package org.apache.directory.api.ldap.ex
  */
 public enum SyncModifyDnType
 {
+    /** A Move operation */
     MOVE(0),
+    
+    /** A Rename operation */
     RENAME(1),
+    
+    /** A Move and Rename operation */
     MOVE_AND_RENAME(2);
 
     /** Internal value for each tag */

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/SynchronizationModeEnum.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/SynchronizationModeEnum.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/SynchronizationModeEnum.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/SynchronizationModeEnum.java Sat Dec 17 15:18:15 2016
@@ -40,9 +40,16 @@ package org.apache.directory.api.ldap.ex
  */
 public enum SynchronizationModeEnum
 {
+    /** Unused */
     UNUSED(0),
+    
+    /** Refresh only mode */
     REFRESH_ONLY(1),
+
+    /** Unused */
     RESERVED(2),
+    
+    /** Refresh and Persist mode */
     REFRESH_AND_PERSIST(3);
 
     /** The internal value */

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdDirSyncFlag.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdDirSyncFlag.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdDirSyncFlag.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdDirSyncFlag.java Sat Dec 17 15:18:15 2016
@@ -29,9 +29,16 @@ import java.util.Set;
  */
 public enum AdDirSyncFlag
 {
+    /** The Object Security flag */
     LDAP_DIRSYNC_OBJECT_SECURITY( 0x0001, "Object Security" ),
+
+    /** The Ancestors First Order flag */
     LDAP_DIRSYNC_ANCESTORS_FIRST_ORDER( 0x0800, "Ancestors First Order" ),
+    
+    /** The Public Data Only flag */
     LDAP_DIRSYNC_PUBLIC_DATA_ONLY( 0x2000, "Public Data Only" ),
+    
+    /** The Incremental Values flag */
     LDAP_DIRSYNC_INCREMENTAL_VALUES( 0x80000000, "Incremental Values" );
 
     /** The int value */

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyErrorEnum.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyErrorEnum.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyErrorEnum.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyErrorEnum.java Sat Dec 17 15:18:15 2016
@@ -28,15 +28,31 @@ package org.apache.directory.api.ldap.ex
  */
 public enum PasswordPolicyErrorEnum
 {
+    /** The password has expired */
     PASSWORD_EXPIRED(0),
+    
+    /** The account is locked */
     ACCOUNT_LOCKED(1),
+    
+    /** */
     CHANGE_AFTER_RESET(2),
+    
+    /** the password modification is not allowed */
     PASSWORD_MOD_NOT_ALLOWED(3),
-    MUST_SUPPLY_OLD_PASSWORD(
-        4),
+    
+    /** The ld password must be supplied */
+    MUST_SUPPLY_OLD_PASSWORD(4),
+    
+    /** The password quality is not sufficient */
     INSUFFICIENT_PASSWORD_QUALITY(5),
+    
+    /** The password is too short */
     PASSWORD_TOO_SHORT(6),
+    
+    /** The password has been changed too recently to be used */
     PASSWORD_TOO_YOUNG(7),
+    
+    /** The password is in history */
     PASSWORD_IN_HISTORY(8);
 
     private int value;
@@ -48,6 +64,12 @@ public enum PasswordPolicyErrorEnum
     }
 
 
+    /**
+     * Get the PasswordPolicyErrorEnum gien its numeric value
+     * 
+     * @param val The numeric value to retrieve
+     * @return The associated PasswordPolicyErrorEnum
+     */
     public static PasswordPolicyErrorEnum get( int val )
     {
         switch ( val )
@@ -86,9 +108,11 @@ public enum PasswordPolicyErrorEnum
     }
 
 
+    /**
+     * @return the PasswordPolicyError interned value
+     */
     public int getValue()
     {
         return value;
     }
-
 }

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyImpl.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyImpl.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyImpl.java Sat Dec 17 15:18:15 2016
@@ -79,6 +79,7 @@ public class PasswordPolicyImpl implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return PasswordPolicy.OID;
@@ -88,6 +89,7 @@ public class PasswordPolicyImpl implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isCritical()
     {
         return criticality;
@@ -97,6 +99,7 @@ public class PasswordPolicyImpl implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setCritical( boolean isCritical )
     {
         this.criticality = isCritical;
@@ -107,6 +110,7 @@ public class PasswordPolicyImpl implemen
      * 
      * {@inheritDoc}
      */
+    @Override
     public void setResponse( PasswordPolicyResponse response )
     {
         this.response = response;
@@ -116,6 +120,7 @@ public class PasswordPolicyImpl implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean hasResponse()
     {
         return response != null;
@@ -126,6 +131,7 @@ public class PasswordPolicyImpl implemen
      * 
      * {@inheritDoc}
      */
+    @Override
     public PasswordPolicyResponse setResponse( boolean hasResponse )
     {
         PasswordPolicyResponse old = this.response;
@@ -146,6 +152,7 @@ public class PasswordPolicyImpl implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public PasswordPolicyResponse getResponse()
     {
         return response;
@@ -157,6 +164,7 @@ public class PasswordPolicyImpl implemen
      * 
      * @return A BindResponse String
      */
+    @Override
     public String toString()
     {
         StringBuilder sb = new StringBuilder();

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyResponseImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyResponseImpl.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyResponseImpl.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ppolicy/PasswordPolicyResponseImpl.java Sat Dec 17 15:18:15 2016
@@ -41,6 +41,7 @@ public class PasswordPolicyResponseImpl
     /**
      * {@inheritDoc}
      */
+    @Override
     public int getTimeBeforeExpiration()
     {
         return timeBeforeExpiration;
@@ -50,6 +51,7 @@ public class PasswordPolicyResponseImpl
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setTimeBeforeExpiration( int timeBeforeExpiration )
     {
         this.timeBeforeExpiration = timeBeforeExpiration;
@@ -59,6 +61,7 @@ public class PasswordPolicyResponseImpl
     /**
      * {@inheritDoc}
      */
+    @Override
     public int getGraceAuthNRemaining()
     {
         return graceAuthNRemaining;
@@ -68,6 +71,7 @@ public class PasswordPolicyResponseImpl
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setGraceAuthNRemaining( int graceAuthNRemaining )
     {
         this.graceAuthNRemaining = graceAuthNRemaining;
@@ -77,6 +81,7 @@ public class PasswordPolicyResponseImpl
     /**
      * {@inheritDoc}
      */
+    @Override
     public PasswordPolicyErrorEnum getPasswordPolicyError()
     {
         return ppolicyError;
@@ -86,12 +91,16 @@ public class PasswordPolicyResponseImpl
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setPasswordPolicyError( PasswordPolicyErrorEnum ppolicyError )
     {
         this.ppolicyError = ppolicyError;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public String toString()
     {

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncDone/SyncDoneValueImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncDone/SyncDoneValueImpl.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncDone/SyncDoneValueImpl.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncDone/SyncDoneValueImpl.java Sat Dec 17 15:18:15 2016
@@ -65,6 +65,7 @@ public class SyncDoneValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getCookie()
     {
         return cookie;
@@ -74,6 +75,7 @@ public class SyncDoneValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setCookie( byte[] cookie )
     {
         this.cookie = cookie;
@@ -83,6 +85,7 @@ public class SyncDoneValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isRefreshDeletes()
     {
         return refreshDeletes;
@@ -92,6 +95,7 @@ public class SyncDoneValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setRefreshDeletes( boolean refreshDeletes )
     {
         this.refreshDeletes = refreshDeletes;

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SyncInfoValueImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SyncInfoValueImpl.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SyncInfoValueImpl.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SyncInfoValueImpl.java Sat Dec 17 15:18:15 2016
@@ -76,6 +76,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public SynchronizationInfoEnum getType()
     {
         return type;
@@ -85,6 +86,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setType( SynchronizationInfoEnum type )
     {
         this.type = type;
@@ -94,6 +96,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getCookie()
     {
         return cookie;
@@ -103,6 +106,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setCookie( byte[] cookie )
     {
         this.cookie = cookie;
@@ -112,6 +116,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isRefreshDone()
     {
         return refreshDone;
@@ -121,6 +126,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setRefreshDone( boolean refreshDone )
     {
         this.refreshDone = refreshDone;
@@ -130,6 +136,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isRefreshDeletes()
     {
         return refreshDeletes;
@@ -139,6 +146,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setRefreshDeletes( boolean refreshDeletes )
     {
         this.refreshDeletes = refreshDeletes;
@@ -148,6 +156,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public List<byte[]> getSyncUUIDs()
     {
         return syncUUIDs;
@@ -157,6 +166,7 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setSyncUUIDs( List<byte[]> syncUUIDs )
     {
         this.syncUUIDs = syncUUIDs;
@@ -166,11 +176,12 @@ public class SyncInfoValueImpl extends A
     /**
      * {@inheritDoc}
      */
+    @Override
     public void addSyncUUID( byte[] syncUUID )
     {
         if ( syncUUIDs == null )
         {
-            syncUUIDs = new ArrayList<byte[]>();
+            syncUUIDs = new ArrayList<>();
         }
 
         syncUUIDs.add( syncUUID );
@@ -333,7 +344,7 @@ public class SyncInfoValueImpl extends A
                 sb.append( "            refreshDeletes : " ).append( isRefreshDeletes() ).append( '\n' );
                 sb.append( "            syncUUIDS : " );
 
-                if ( getSyncUUIDs().size() != 0 )
+                if ( !getSyncUUIDs().isEmpty() )
                 {
                     boolean isFirst = true;
 

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SyncRequestValueImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SyncRequestValueImpl.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SyncRequestValueImpl.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SyncRequestValueImpl.java Sat Dec 17 15:18:15 2016
@@ -91,6 +91,7 @@ public class SyncRequestValueImpl extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getCookie()
     {
         return this.cookie;
@@ -100,6 +101,7 @@ public class SyncRequestValueImpl extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setCookie( byte[] cookie )
     {
         this.cookie = cookie;
@@ -109,6 +111,7 @@ public class SyncRequestValueImpl extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public SynchronizationModeEnum getMode()
     {
         return mode;
@@ -118,6 +121,7 @@ public class SyncRequestValueImpl extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setMode( SynchronizationModeEnum mode )
     {
         this.mode = mode;
@@ -127,6 +131,7 @@ public class SyncRequestValueImpl extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isReloadHint()
     {
         return isReloadHint;
@@ -136,6 +141,7 @@ public class SyncRequestValueImpl extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setReloadHint( boolean reloadHint )
     {
         this.isReloadHint = reloadHint;

Modified: directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SynchronizationInfoEnum.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SynchronizationInfoEnum.java?rev=1774774&r1=1774773&r2=1774774&view=diff
==============================================================================
--- directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SynchronizationInfoEnum.java (original)
+++ directory/shared/branches/shared-value/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/syncrepl/syncInfoValue/SynchronizationInfoEnum.java Sat Dec 17 15:18:15 2016
@@ -35,9 +35,16 @@ package org.apache.directory.api.ldap.ex
  */
 public enum SynchronizationInfoEnum
 {
+    /** A new cookie */
     NEW_COOKIE(0),
+    
+    /** The refresh delete phase */
     REFRESH_DELETE(1),
+
+    /** The refresh present phase */
     REFRESH_PRESENT(2),
+    
+    /** The sync ID set */
     SYNC_ID_SET(3);
 
     /** The internal value */



Mime
View raw message