directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r1771436 [2/3] - in /directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec: ./ actions/bindRequest/ actions/bindResponse/ actions/compareRequest/ actions/controls/ actions/delRequest/ actions/extendedReque...
Date Sat, 26 Nov 2016 07:48:58 GMT
Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/manageDsaIT/ManageDsaITFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/manageDsaIT/ManageDsaITFactory.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/manageDsaIT/ManageDsaITFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/manageDsaIT/ManageDsaITFactory.java Sat Nov 26 07:48:58 2016
@@ -53,6 +53,7 @@ public class ManageDsaITFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return ManageDsaIT.OID;
@@ -62,6 +63,7 @@ public class ManageDsaITFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<ManageDsaIT> newCodecControl()
     {
         return new ManageDsaITDecorator( codec, new ManageDsaITImpl() );
@@ -71,6 +73,7 @@ public class ManageDsaITFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<ManageDsaIT> newCodecControl( ManageDsaIT control )
     {
         return new ManageDsaITDecorator( codec, control );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/proxiedauthz/ProxiedAuthzDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/proxiedauthz/ProxiedAuthzDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/proxiedauthz/ProxiedAuthzDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/proxiedauthz/ProxiedAuthzDecorator.java Sat Nov 26 07:48:58 2016
@@ -79,7 +79,7 @@ public class ProxiedAuthzDecorator exten
      */
     private ProxiedAuthz getProxiedAuthz()
     {
-        return ( ProxiedAuthz ) getDecorated();
+        return getDecorated();
     }
 
 
@@ -91,6 +91,7 @@ public class ProxiedAuthzDecorator exten
      *  
      * @return the control length.
      */
+    @Override
     public int computeLength()
     {
         int valueLength = 0;
@@ -112,6 +113,7 @@ public class ProxiedAuthzDecorator exten
      * @return A ByteBuffer that contains the encoded PDU
      * @throws EncoderException If anything goes wrong.
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         if ( buffer == null )
@@ -131,6 +133,7 @@ public class ProxiedAuthzDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getValue()
     {
         if ( value == null )
@@ -164,6 +167,7 @@ public class ProxiedAuthzDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getAuthzId()
     {
         return getProxiedAuthz().getAuthzId();
@@ -173,6 +177,7 @@ public class ProxiedAuthzDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setAuthzId( String authzId )
     {
         getProxiedAuthz().setAuthzId( authzId );
@@ -182,6 +187,7 @@ public class ProxiedAuthzDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public Asn1Object decode( byte[] controlBytes ) throws DecoderException
     {
         getProxiedAuthz().setAuthzId( Strings.utf8ToString( controlBytes ) );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/proxiedauthz/ProxiedAuthzFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/proxiedauthz/ProxiedAuthzFactory.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/proxiedauthz/ProxiedAuthzFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/proxiedauthz/ProxiedAuthzFactory.java Sat Nov 26 07:48:58 2016
@@ -52,6 +52,7 @@ public class ProxiedAuthzFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return ProxiedAuthz.OID;
@@ -61,6 +62,7 @@ public class ProxiedAuthzFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<ProxiedAuthz> newCodecControl()
     {
         return new ProxiedAuthzDecorator( codec );
@@ -70,6 +72,7 @@ public class ProxiedAuthzFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<ProxiedAuthz> newCodecControl( ProxiedAuthz control )
     {
         return new ProxiedAuthzDecorator( codec, control );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeContainer.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeContainer.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeContainer.java Sat Nov 26 07:48:58 2016
@@ -112,6 +112,7 @@ public class EntryChangeContainer extend
     /**
      * Clean the container
      */
+    @Override
     public void clean()
     {
         super.clean();

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeDecorator.java Sat Nov 26 07:48:58 2016
@@ -93,7 +93,7 @@ public class EntryChangeDecorator extend
      */
     private EntryChange getEntryChange()
     {
-        return ( EntryChange ) getDecorated();
+        return getDecorated();
     }
 
 
@@ -110,6 +110,7 @@ public class EntryChangeDecorator extend
      *  
      * @return the control length.
      */
+    @Override
     public int computeLength()
     {
         int changeTypesLength = 1 + 1 + 1;
@@ -142,6 +143,7 @@ public class EntryChangeDecorator extend
      * @return A ByteBuffer that contains the encoded PDU
      * @throws EncoderException If anything goes wrong.
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         if ( buffer == null )
@@ -173,6 +175,7 @@ public class EntryChangeDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getValue()
     {
         if ( value == null )
@@ -214,6 +217,7 @@ public class EntryChangeDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public ChangeType getChangeType()
     {
         return getEntryChange().getChangeType();
@@ -223,6 +227,7 @@ public class EntryChangeDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setChangeType( ChangeType changeType )
     {
         getEntryChange().setChangeType( changeType );
@@ -232,6 +237,7 @@ public class EntryChangeDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public Dn getPreviousDn()
     {
         return getEntryChange().getPreviousDn();
@@ -241,6 +247,7 @@ public class EntryChangeDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setPreviousDn( Dn previousDn )
     {
         getEntryChange().setPreviousDn( previousDn );
@@ -250,6 +257,7 @@ public class EntryChangeDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public long getChangeNumber()
     {
         return getEntryChange().getChangeNumber();
@@ -259,6 +267,7 @@ public class EntryChangeDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setChangeNumber( long changeNumber )
     {
         getEntryChange().setChangeNumber( changeNumber );
@@ -268,6 +277,7 @@ public class EntryChangeDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public Asn1Object decode( byte[] controlBytes ) throws DecoderException
     {
         ByteBuffer bb = ByteBuffer.wrap( controlBytes );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeFactory.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeFactory.java Sat Nov 26 07:48:58 2016
@@ -52,6 +52,7 @@ public class EntryChangeFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return EntryChange.OID;
@@ -61,6 +62,7 @@ public class EntryChangeFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<EntryChange> newCodecControl()
     {
         return new EntryChangeDecorator( codec );
@@ -70,6 +72,7 @@ public class EntryChangeFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<EntryChange> newCodecControl( EntryChange control )
     {
         return new EntryChangeDecorator( codec, control );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeStates.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeStates.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeStates.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/entryChange/EntryChangeStates.java Sat Nov 26 07:48:58 2016
@@ -96,13 +96,14 @@ public enum EntryChangeStates implements
      */
     public String getState( int state )
     {
-        return ( ( state == END_STATE.ordinal() ) ? "EC_END_STATE" : name() );
+        return ( state == END_STATE.ordinal() ) ? "EC_END_STATE" : name();
     }
 
 
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isEndState()
     {
         return this == END_STATE;
@@ -112,6 +113,7 @@ public enum EntryChangeStates implements
     /**
      * {@inheritDoc}
      */
+    @Override
     public EntryChangeStates getStartState()
     {
         return START_STATE;

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsContainer.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsContainer.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsContainer.java Sat Nov 26 07:48:58 2016
@@ -77,6 +77,11 @@ public class PagedResultsContainer exten
     }
 
 
+    /**
+     * Decorate the PageResult control
+     * 
+     * @param control The PageResult control instance
+     */
     public void decorate( PagedResults control )
     {
         if ( control instanceof PagedResultsDecorator )
@@ -105,6 +110,7 @@ public class PagedResultsContainer exten
     /**
      * Clean the container
      */
+    @Override
     public void clean()
     {
         super.clean();

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsDecorator.java Sat Nov 26 07:48:58 2016
@@ -92,6 +92,7 @@ public class PagedResultsDecorator exten
      *  
      * @return the control length.
      */
+    @Override
     public int computeLength()
     {
         int sizeLength = 1 + 1 + BerValue.getNbBytes( getSize() );
@@ -121,6 +122,7 @@ public class PagedResultsDecorator exten
      * @return A ByteBuffer that contains the encoded PDU
      * @throws EncoderException If anything goes wrong.
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         if ( buffer == null )
@@ -142,6 +144,7 @@ public class PagedResultsDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getValue()
     {
         if ( value == null )
@@ -173,6 +176,7 @@ public class PagedResultsDecorator exten
     /**
      * @return The requested or returned number of entries
      */
+    @Override
     public int getSize()
     {
         return getDecorated().getSize();
@@ -184,6 +188,7 @@ public class PagedResultsDecorator exten
      *
      * @param size The number of entries 
      */
+    @Override
     public void setSize( int size )
     {
         getDecorated().setSize( size );
@@ -193,6 +198,7 @@ public class PagedResultsDecorator exten
     /**
      * @return The stored cookie
      */
+    @Override
     public byte[] getCookie()
     {
         return getDecorated().getCookie();
@@ -204,6 +210,7 @@ public class PagedResultsDecorator exten
      *
      * @param cookie The cookie to store in this control
      */
+    @Override
     public void setCookie( byte[] cookie )
     {
         // Copy the bytes
@@ -223,6 +230,7 @@ public class PagedResultsDecorator exten
     /**
      * @return The integer value for the current cookie
      */
+    @Override
     public int getCookieValue()
     {
         int value = 0;
@@ -290,9 +298,10 @@ public class PagedResultsDecorator exten
     /**
      * Return a String representing this PagedSearchControl.
      */
+    @Override
     public String toString()
     {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
 
         sb.append( "    Paged Search Control\n" );
         sb.append( "        oid : " ).append( getOid() ).append( '\n' );
@@ -307,6 +316,7 @@ public class PagedResultsDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public Asn1Object decode( byte[] controlBytes ) throws DecoderException
     {
         ByteBuffer bb = ByteBuffer.wrap( controlBytes );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsFactory.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsFactory.java Sat Nov 26 07:48:58 2016
@@ -52,6 +52,7 @@ public class PagedResultsFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return PagedResults.OID;
@@ -61,6 +62,7 @@ public class PagedResultsFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<PagedResults> newCodecControl()
     {
         return new PagedResultsDecorator( codec );
@@ -70,6 +72,7 @@ public class PagedResultsFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<PagedResults> newCodecControl( PagedResults control )
     {
         return new PagedResultsDecorator( codec, control );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsGrammar.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsGrammar.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsGrammar.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsGrammar.java Sat Nov 26 07:48:58 2016
@@ -30,7 +30,7 @@ import org.apache.directory.api.asn1.ber
 import org.apache.directory.api.asn1.ber.tlv.IntegerDecoderException;
 import org.apache.directory.api.asn1.ber.tlv.UniversalTag;
 import org.apache.directory.api.i18n.I18n;
-import org.apache.directory.api.util.StringConstants;
+import org.apache.directory.api.util.Strings;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -150,7 +150,7 @@ public final class PagedResultsGrammar e
 
                         if ( container.getCurrentTLV().getLength() == 0 )
                         {
-                            container.getDecorator().setCookie( StringConstants.EMPTY_BYTES );
+                            container.getDecorator().setCookie( Strings.EMPTY_BYTES );
                         }
                         else
                         {

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsStates.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsStates.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsStates.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/pagedSearch/PagedResultsStates.java Sat Nov 26 07:48:58 2016
@@ -59,10 +59,9 @@ public enum PagedResultsStates implement
     /**
      * Get the grammar name
      * 
-     * @param grammar The grammar code
      * @return The grammar name
      */
-    public String getGrammarName( int grammar )
+    public String getGrammarName()
     {
         return "PAGED_SEARCH_GRAMMAR";
     }
@@ -93,13 +92,14 @@ public enum PagedResultsStates implement
      */
     public String getState( int state )
     {
-        return ( ( state == END_STATE.ordinal() ) ? "PAGED_SEARCH_END_STATE" : name() );
+        return ( state == END_STATE.ordinal() ) ? "PAGED_SEARCH_END_STATE" : name();
     }
 
 
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isEndState()
     {
         return this == END_STATE;
@@ -109,6 +109,7 @@ public enum PagedResultsStates implement
     /**
      * {@inheritDoc}
      */
+    @Override
     public PagedResultsStates getStartState()
     {
         return START_STATE;

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchContainer.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchContainer.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchContainer.java Sat Nov 26 07:48:58 2016
@@ -110,6 +110,7 @@ public class PersistentSearchContainer e
     /**
      * Clean the container
      */
+    @Override
     public void clean()
     {
         super.clean();

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchDecorator.java Sat Nov 26 07:48:58 2016
@@ -92,6 +92,7 @@ public class PersistentSearchDecorator e
      *  
      * @return the control length.
      */
+    @Override
     public int computeLength()
     {
         int changeTypesLength = 1 + 1 + BerValue.getNbBytes( getChangeTypes() );
@@ -99,9 +100,8 @@ public class PersistentSearchDecorator e
         int returnRCsLength = 1 + 1 + 1;
 
         psearchSeqLength = changeTypesLength + changesOnlyLength + returnRCsLength;
-        int valueLength = 1 + TLV.getNbBytes( psearchSeqLength ) + psearchSeqLength;
-
-        return valueLength;
+        
+        return 1 + TLV.getNbBytes( psearchSeqLength ) + psearchSeqLength;
     }
 
 
@@ -112,6 +112,7 @@ public class PersistentSearchDecorator e
      * @return A ByteBuffer that contains the encoded PDU
      * @throws EncoderException If anything goes wrong.
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         if ( buffer == null )
@@ -134,6 +135,7 @@ public class PersistentSearchDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getValue()
     {
         if ( value == null )
@@ -153,7 +155,7 @@ public class PersistentSearchDecorator e
 
                 value = buffer.array();
             }
-            catch ( Exception e )
+            catch ( EncoderException ee )
             {
                 return null;
             }
@@ -165,52 +167,84 @@ public class PersistentSearchDecorator e
 
     private PersistentSearch getPersistentSearch()
     {
-        return ( PersistentSearch ) getDecorated();
+        return getDecorated();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public void setChangesOnly( boolean changesOnly )
     {
         getPersistentSearch().setChangesOnly( changesOnly );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public boolean isChangesOnly()
     {
         return getPersistentSearch().isChangesOnly();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public void setReturnECs( boolean returnECs )
     {
         getPersistentSearch().setReturnECs( returnECs );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public boolean isReturnECs()
     {
         return getPersistentSearch().isReturnECs();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public void setChangeTypes( int changeTypes )
     {
         getPersistentSearch().setChangeTypes( changeTypes );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public int getChangeTypes()
     {
         return getPersistentSearch().getChangeTypes();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public boolean isNotificationEnabled( ChangeType changeType )
     {
         return getPersistentSearch().isNotificationEnabled( changeType );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public void enableNotification( ChangeType changeType )
     {
         getPersistentSearch().enableNotification( changeType );
@@ -220,6 +254,7 @@ public class PersistentSearchDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public Asn1Object decode( byte[] controlBytes ) throws DecoderException
     {
         ByteBuffer bb = ByteBuffer.wrap( controlBytes );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchFactory.java Sat Nov 26 07:48:58 2016
@@ -37,6 +37,11 @@ public class PersistentSearchFactory imp
     private LdapApiService codec;
 
 
+    /**
+     * Create a new PersistentSearchFactory instance
+     * 
+     * @param codec The LdapApiService instance
+     */
     public PersistentSearchFactory( LdapApiService codec )
     {
         this.codec = codec;
@@ -46,6 +51,7 @@ public class PersistentSearchFactory imp
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return PersistentSearch.OID;
@@ -55,6 +61,7 @@ public class PersistentSearchFactory imp
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<PersistentSearch> newCodecControl()
     {
         return new PersistentSearchDecorator( codec );
@@ -64,6 +71,7 @@ public class PersistentSearchFactory imp
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<PersistentSearch> newCodecControl( PersistentSearch control )
     {
         return new PersistentSearchDecorator( codec, control );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchStates.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchStates.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchStates.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/persistentSearch/PersistentSearchStates.java Sat Nov 26 07:48:58 2016
@@ -95,13 +95,14 @@ public enum PersistentSearchStates imple
      */
     public String getState( int state )
     {
-        return ( ( state == END_STATE.ordinal() ) ? "PSEARCH_END_STATE" : name() );
+        return ( state == END_STATE.ordinal() ) ? "PSEARCH_END_STATE" : name();
     }
 
 
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isEndState()
     {
         return this == END_STATE;
@@ -111,6 +112,7 @@ public enum PersistentSearchStates imple
     /**
      * {@inheritDoc}
      */
+    @Override
     public PersistentSearchStates getStartState()
     {
         return START_STATE;

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesContainer.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesContainer.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesContainer.java Sat Nov 26 07:48:58 2016
@@ -83,6 +83,7 @@ public class SubentriesContainer extends
     /**
      * Clean the current container
      */
+    @Override
     public void clean()
     {
         super.clean();

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesDecorator.java Sat Nov 26 07:48:58 2016
@@ -78,6 +78,7 @@ public class SubentriesDecorator extends
      * 
      * @return the control length.
      */
+    @Override
     public int computeLength()
     {
         return 1 + 1 + 1;
@@ -91,6 +92,7 @@ public class SubentriesDecorator extends
      * @return A ByteBuffer that contains the encoded PDU
      * @throws org.apache.directory.api.asn1.EncoderException If anything goes wrong.
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         if ( buffer == null )
@@ -108,6 +110,7 @@ public class SubentriesDecorator extends
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getValue()
     {
         if ( value == null )
@@ -132,12 +135,20 @@ public class SubentriesDecorator extends
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public boolean isVisible()
     {
         return getDecorated().isVisible();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public void setVisibility( boolean visibility )
     {
         getDecorated().setVisibility( visibility );
@@ -147,6 +158,7 @@ public class SubentriesDecorator extends
     /**
      * {@inheritDoc}
      */
+    @Override
     public Asn1Object decode( byte[] controlBytes ) throws DecoderException
     {
         ByteBuffer bb = ByteBuffer.wrap( controlBytes );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesFactory.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesFactory.java Sat Nov 26 07:48:58 2016
@@ -54,6 +54,7 @@ public class SubentriesFactory implement
      * 
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return Subentries.OID;
@@ -64,6 +65,7 @@ public class SubentriesFactory implement
      * 
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<Subentries> newCodecControl()
     {
         return new SubentriesDecorator( codec );
@@ -74,6 +76,7 @@ public class SubentriesFactory implement
      * 
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<Subentries> newCodecControl( Subentries control )
     {
         return new SubentriesDecorator( codec, control );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesStates.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesStates.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesStates.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/search/subentries/SubentriesStates.java Sat Nov 26 07:48:58 2016
@@ -54,10 +54,9 @@ public enum SubentriesStates implements
     /**
      * Get the grammar name
      * 
-     * @param grammar The grammar code
      * @return The grammar name
      */
-    public String getGrammarName( int grammar )
+    public String getGrammarName()
     {
         return "SUB_ENTRY_GRAMMAR";
     }
@@ -88,13 +87,14 @@ public enum SubentriesStates implements
      */
     public String getState( int state )
     {
-        return ( ( state == END_STATE.ordinal() ) ? "SUB_ENTRY_END_STATE" : name() );
+        return ( state == END_STATE.ordinal() ) ? "SUB_ENTRY_END_STATE" : name();
     }
 
 
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isEndState()
     {
         return this == END_STATE;
@@ -104,6 +104,7 @@ public enum SubentriesStates implements
     /**
      * {@inheritDoc}
      */
+    @Override
     public SubentriesStates getStartState()
     {
         return START_STATE;

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestContainer.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestContainer.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestContainer.java Sat Nov 26 07:48:58 2016
@@ -107,6 +107,7 @@ public class SortRequestContainer extend
     /**
      * Clean the container
      */
+    @Override
     public void clean()
     {
         super.clean();

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -52,7 +52,7 @@ public class SortRequestDecorator extend
 
     private int sortReqLen = 0;
 
-    private List<Integer> sortKeyLenList = new ArrayList<Integer>();
+    private List<Integer> sortKeyLenList = new ArrayList<>();
 
     public static final int ORDERING_RULE_TAG = 0x80;
 
@@ -181,6 +181,7 @@ public class SortRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getValue()
     {
         if ( value == null )

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestFactory.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestFactory.java Sat Nov 26 07:48:58 2016
@@ -52,6 +52,7 @@ public class SortRequestFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return SortRequest.OID;
@@ -61,6 +62,7 @@ public class SortRequestFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<SortRequest> newCodecControl()
     {
         return new SortRequestDecorator( codec );
@@ -70,6 +72,7 @@ public class SortRequestFactory implemen
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<SortRequest> newCodecControl( SortRequest control )
     {
         return new SortRequestDecorator( codec, control );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestGrammar.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestGrammar.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestGrammar.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestGrammar.java Sat Nov 26 07:48:58 2016
@@ -105,8 +105,6 @@ public final class SortRequestGrammar ex
                 }
                 catch ( BooleanDecoderException bde )
                 {
-                    //String msg = I18n.err( I18n.ERR_04050 );
-                    //LOG.error( msg, e );
                     throw new DecoderException( bde.getMessage(), bde );
                 }
             }

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestStates.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestStates.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestStates.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortRequestStates.java Sat Nov 26 07:48:58 2016
@@ -48,10 +48,9 @@ public enum SortRequestStates implements
     /**
      * Get the grammar name
      * 
-     * @param grammar The grammar code
      * @return The grammar name
      */
-    public String getGrammarName( int grammar )
+    public String getGrammarName()
     {
         return "SORT_REQUEST_GRAMMAR";
     }
@@ -82,21 +81,26 @@ public enum SortRequestStates implements
      */
     public String getState( int state )
     {
-        return ( ( state == END_STATE.ordinal() ) ? "SORT_REQUEST_END_STATE" : name() );
+        return ( state == END_STATE.ordinal() ) ? "SORT_REQUEST_END_STATE" : name();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public boolean isEndState()
     {
-        return ( this == END_STATE );
+        return this == END_STATE;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public Enum<?> getStartState()
     {
         return START_STATE;
     }
-
 }

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseContainer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseContainer.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseContainer.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseContainer.java Sat Nov 26 07:48:58 2016
@@ -103,10 +103,10 @@ public class SortResponseContainer exten
     /**
      * Clean the container
      */
+    @Override
     public void clean()
     {
         super.clean();
         control = null;
     }
-
 }

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseDecorator.java Sat Nov 26 07:48:58 2016
@@ -135,6 +135,7 @@ public class SortResponseDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getValue()
     {
         if ( value == null )

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseFactory.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseFactory.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseFactory.java Sat Nov 26 07:48:58 2016
@@ -52,6 +52,7 @@ public class SortResponseFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getOid()
     {
         return SortResponse.OID;
@@ -61,6 +62,7 @@ public class SortResponseFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<SortResponse> newCodecControl()
     {
         return new SortResponseDecorator( codec );
@@ -70,6 +72,7 @@ public class SortResponseFactory impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public CodecControl<SortResponse> newCodecControl( SortResponse control )
     {
         return new SortResponseDecorator( codec, control );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseStates.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseStates.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseStates.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/SortResponseStates.java Sat Nov 26 07:48:58 2016
@@ -44,10 +44,9 @@ public enum SortResponseStates implement
     /**
      * Get the grammar name
      * 
-     * @param grammar The grammar code
      * @return The grammar name
      */
-    public String getGrammarName( int grammar )
+    public String getGrammarName()
     {
         return "SORT_RESPONSE_GRAMMAR";
     }
@@ -78,14 +77,14 @@ public enum SortResponseStates implement
      */
     public String getState( int state )
     {
-        return ( ( state == END_STATE.ordinal() ) ? "SORT_REQUEST_END_STATE" : name() );
+        return ( state == END_STATE.ordinal() ) ? "SORT_REQUEST_END_STATE" : name();
     }
 
 
     @Override
     public boolean isEndState()
     {
-        return ( this == END_STATE );
+        return this == END_STATE;
     }
 
 

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/controls/sort/StoreSortResponseResultCode.java Sat Nov 26 07:48:58 2016
@@ -29,6 +29,8 @@ import org.apache.directory.api.ldap.mod
  * The action used to store the result code of a SortResponseControl
  * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * 
+ * @param <C> The Asn1Container type to use
  */
 public class StoreSortResponseResultCode<C extends Asn1Container> extends AbstractReadInteger<C>
 {

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -58,6 +58,7 @@ public final class AbandonRequestDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public int getAbandoned()
     {
         return getDecorated().getAbandoned();
@@ -67,6 +68,7 @@ public final class AbandonRequestDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public AbandonRequest setAbandoned( int requestId )
     {
         getDecorated().setAbandoned( requestId );
@@ -78,6 +80,7 @@ public final class AbandonRequestDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public AbandonRequest setMessageId( int messageId )
     {
         super.setMessageId( messageId );
@@ -89,6 +92,7 @@ public final class AbandonRequestDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public AbandonRequest addControl( Control control )
     {
         return ( AbandonRequest ) super.addControl( control );
@@ -98,6 +102,7 @@ public final class AbandonRequestDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public AbandonRequest addAllControls( Control[] controls )
     {
         return ( AbandonRequest ) super.addAllControls( controls );
@@ -107,6 +112,7 @@ public final class AbandonRequestDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public AbandonRequest removeControl( Control control )
     {
         return ( AbandonRequest ) super.removeControl( control );
@@ -120,6 +126,7 @@ public final class AbandonRequestDecorat
     /**
      * Encode the Abandon protocolOp part
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try
@@ -154,10 +161,9 @@ public final class AbandonRequestDecorat
      * Length(AbandonRequest) = Length(0x50) + 1 + Length(abandoned MessageId)
      * </pre>
      */
+    @Override
     public int computeLength()
     {
-        int length = 1 + 1 + BerValue.getNbBytes( getAbandoned() );
-
-        return length;
+        return 1 + 1 + BerValue.getNbBytes( getAbandoned() );
     }
 }

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -29,6 +29,8 @@ import org.apache.directory.api.ldap.mod
  * A decorator for the LdapResultResponse message
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * 
+ * @param <M> The Request to decorate
  */
 public abstract class AbandonableRequestDecorator<M extends AbandonableResultResponseRequest>
     extends ResultResponseRequestDecorator<M>
@@ -60,6 +62,7 @@ public abstract class AbandonableRequest
     /**
      * {@inheritDoc}
      */
+    @Override
     public void abandon()
     {
         getAbandonableRequest().abandon();
@@ -69,6 +72,7 @@ public abstract class AbandonableRequest
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isAbandoned()
     {
         return getAbandonableRequest().isAbandoned();
@@ -78,6 +82,7 @@ public abstract class AbandonableRequest
     /**
      * {@inheritDoc}
      */
+    @Override
     public AbandonableRequest addAbandonListener( AbandonListener listener )
     {
         getAbandonableRequest().addAbandonListener( listener );

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AbandonableResultResponseRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -29,6 +29,8 @@ import org.apache.directory.api.ldap.mod
  * A decorator for the LdapResultResponse message
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * 
+ * @param <M> The message response to decorate
  */
 public abstract class AbandonableResultResponseRequestDecorator<M extends AbandonableResultResponseRequest>
     extends AbandonableRequestDecorator<M> implements ResultResponseRequest
@@ -48,6 +50,7 @@ public abstract class AbandonableResultR
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean hasResponse()
     {
         return getDecorated().hasResponse();
@@ -57,6 +60,7 @@ public abstract class AbandonableResultR
     /**
      * {@inheritDoc}
      */
+    @Override
     public ResultResponse getResultResponse()
     {
         return getDecorated().getResultResponse();

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AddRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AddRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AddRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AddRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -88,6 +88,7 @@ public final class AddRequestDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public AddRequest setMessageId( int messageId )
     {
         super.setMessageId( messageId );
@@ -99,6 +100,7 @@ public final class AddRequestDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public AddRequest addControl( Control control )
     {
         return ( AddRequest ) super.addControl( control );
@@ -108,6 +110,7 @@ public final class AddRequestDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public AddRequest addAllControls( Control[] controls )
     {
         return ( AddRequest ) super.addAllControls( controls );
@@ -117,6 +120,7 @@ public final class AddRequestDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public AddRequest removeControl( Control control )
     {
         return ( AddRequest ) super.removeControl( control );
@@ -130,6 +134,7 @@ public final class AddRequestDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public Dn getEntryDn()
     {
         return getDecorated().getEntryDn();
@@ -139,6 +144,7 @@ public final class AddRequestDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public AddRequest setEntryDn( Dn entry )
     {
         getDecorated().setEntryDn( entry );
@@ -150,6 +156,7 @@ public final class AddRequestDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public Entry getEntry()
     {
         return getDecorated().getEntry();
@@ -159,6 +166,7 @@ public final class AddRequestDecorator e
     /**
      * {@inheritDoc}
      */
+    @Override
     public AddRequest setEntry( Entry entry )
     {
         getDecorated().setEntry( entry );
@@ -276,6 +284,7 @@ public final class AddRequestDecorator e
      *                    +--&gt; 0x04 L7-m-n value
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         AddRequest addRequest = getDecorated();
@@ -297,15 +306,15 @@ public final class AddRequestDecorator e
 
         if ( entry.size() != 0 )
         {
-            attributesLength = new LinkedList<Integer>();
-            attributeIds = new LinkedList<byte[]>();
-            valuesLength = new LinkedList<Integer>();
+            attributesLength = new LinkedList<>();
+            attributeIds = new LinkedList<>();
+            valuesLength = new LinkedList<>();
 
             // Compute the attributes length
             for ( Attribute attribute : entry )
             {
-                int localAttributeLength = 0;
-                int localValuesLength = 0;
+                int localAttributeLength;
+                int localValuesLength;
 
                 // Get the type length
                 byte[] attributeIdBytes = Strings.getBytesUtf8( attribute.getUpId() );
@@ -381,6 +390,7 @@ public final class AddRequestDecorator e
      * 
      * @param buffer The buffer where to put the PDU
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try
@@ -431,7 +441,7 @@ public final class AddRequestDecorator e
                         BerValue.encode( buffer, Strings.EMPTY_BYTES );
                     }
 
-                    // Go to the next attribute number;
+                    // Go to the next attribute number
                     attributeNumber++;
                 }
             }

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AddResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AddResponseDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AddResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/AddResponseDecorator.java Sat Nov 26 07:48:58 2016
@@ -59,7 +59,7 @@ public class AddResponseDecorator extend
      */
     public AddResponse getAddResponse()
     {
-        return ( AddResponse ) getDecorated();
+        return getDecorated();
     }
 
 
@@ -80,6 +80,7 @@ public class AddResponseDecorator extend
      * Length(AddResponse) = Length(0x69) + Length(L1) + L1
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         AddResponse addResponse = getAddResponse();
@@ -97,6 +98,7 @@ public class AddResponseDecorator extend
      * @return The encoded response
      * @throws EncoderException If teh encoding failed
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/BindRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/BindRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/BindRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/BindRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -76,6 +76,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest setMessageId( int messageId )
     {
         super.setMessageId( messageId );
@@ -87,6 +88,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest addControl( Control control )
     {
         return ( BindRequest ) super.addControl( control );
@@ -96,6 +98,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest addAllControls( Control[] controls )
     {
         return ( BindRequest ) super.addAllControls( controls );
@@ -105,6 +108,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest removeControl( Control control )
     {
         return ( BindRequest ) super.removeControl( control );
@@ -118,6 +122,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isSimple()
     {
         return getDecorated().isSimple();
@@ -127,6 +132,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean getSimple()
     {
         return getDecorated().getSimple();
@@ -136,6 +142,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest setSimple( boolean isSimple )
     {
         getDecorated().setSimple( isSimple );
@@ -147,6 +154,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getCredentials()
     {
         return getDecorated().getCredentials();
@@ -156,6 +164,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest setCredentials( String credentials )
     {
         getDecorated().setCredentials( credentials );
@@ -167,6 +176,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest setCredentials( byte[] credentials )
     {
         getDecorated().setCredentials( credentials );
@@ -178,6 +188,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getName()
     {
         return getDecorated().getName();
@@ -187,6 +198,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest setName( String name )
     {
         getDecorated().setName( name );
@@ -198,6 +210,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public Dn getDn()
     {
         return getDecorated().getDn();
@@ -207,6 +220,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest setDn( Dn dn )
     {
         getDecorated().setDn( dn );
@@ -218,6 +232,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isVersion3()
     {
         return getDecorated().isVersion3();
@@ -227,6 +242,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean getVersion3()
     {
         return getDecorated().getVersion3();
@@ -236,6 +252,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest setVersion3( boolean isVersion3 )
     {
         getDecorated().setVersion3( isVersion3 );
@@ -247,6 +264,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getSaslMechanism()
     {
         return getDecorated().getSaslMechanism();
@@ -256,6 +274,7 @@ public class BindRequestDecorator extend
     /**
      * {@inheritDoc}
      */
+    @Override
     public BindRequest setSaslMechanism( String saslMechanism )
     {
         getDecorated().setSaslMechanism( saslMechanism );
@@ -284,6 +303,7 @@ public class BindRequestDecorator extend
      *      Length(0x04) + Length(L2) + L2 + Length(authentication)
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         // Initialized with version
@@ -365,6 +385,7 @@ public class BindRequestDecorator extend
      * @param buffer The buffer where to put the PDU
      * @return The PDU.
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/BindResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/BindResponseDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/BindResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/BindResponseDecorator.java Sat Nov 26 07:48:58 2016
@@ -61,6 +61,7 @@ public class BindResponseDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getServerSaslCreds()
     {
         return getDecorated().getServerSaslCreds();
@@ -70,6 +71,7 @@ public class BindResponseDecorator exten
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setServerSaslCreds( byte[] serverSaslCreds )
     {
         getDecorated().setServerSaslCreds( serverSaslCreds );
@@ -93,6 +95,7 @@ public class BindResponseDecorator exten
      * Length(BindResponse) = Length(0x61) + Length(L1) + L1
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         BindResponse bindResponse = getDecorated();
@@ -124,6 +127,7 @@ public class BindResponseDecorator exten
      * @return The encoded response
      * @throws EncoderException when encoding operations fail
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         BindResponse bindResponse = getDecorated();

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/CompareRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/CompareRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/CompareRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/CompareRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -78,6 +78,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public Dn getName()
     {
         return getDecorated().getName();
@@ -87,6 +88,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public CompareRequest setName( Dn name )
     {
         getDecorated().setName( name );
@@ -98,6 +100,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public Value<?> getAssertionValue()
     {
         return getDecorated().getAssertionValue();
@@ -107,6 +110,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public CompareRequest setAssertionValue( String value )
     {
         getDecorated().setAssertionValue( value );
@@ -118,6 +122,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public CompareRequest setAssertionValue( byte[] value )
     {
         getDecorated().setAssertionValue( value );
@@ -129,6 +134,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getAttributeId()
     {
         return getDecorated().getAttributeId();
@@ -138,6 +144,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public CompareRequest setAttributeId( String attrId )
     {
         getDecorated().setAttributeId( attrId );
@@ -149,6 +156,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public CompareRequest setMessageId( int messageId )
     {
         super.setMessageId( messageId );
@@ -160,6 +168,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public CompareRequest addControl( Control control )
     {
         return ( CompareRequest ) super.addControl( control );
@@ -169,6 +178,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public CompareRequest addAllControls( Control[] controls )
     {
         return ( CompareRequest ) super.addAllControls( controls );
@@ -178,6 +188,7 @@ public class CompareRequestDecorator ext
     /**
      * {@inheritDoc}
      */
+    @Override
     public CompareRequest removeControl( Control control )
     {
         return ( CompareRequest ) super.removeControl( control );
@@ -208,6 +219,7 @@ public class CompareRequestDecorator ext
      * 
      * @return The CompareRequest PDU's length
      */
+    @Override
     public int computeLength()
     {
         // The entry Dn
@@ -250,6 +262,7 @@ public class CompareRequestDecorator ext
      * 
      * @param buffer The buffer where to put the PDU
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/CompareResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/CompareResponseDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/CompareResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/CompareResponseDecorator.java Sat Nov 26 07:48:58 2016
@@ -62,6 +62,7 @@ public class CompareResponseDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isTrue()
     {
         return getDecorated().isTrue();
@@ -86,6 +87,7 @@ public class CompareResponseDecorator ex
      * Length(CompareResponse) = Length(0x6F) + Length(L1) + L1
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         compareResponseLength = ( ( LdapResultDecorator ) getLdapResult() ).computeLength();
@@ -99,8 +101,8 @@ public class CompareResponseDecorator ex
      * 
      * @param buffer The buffer where to put the PDU
      */
-    public ByteBuffer encode( ByteBuffer buffer )
-        throws EncoderException
+    @Override
+    public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try
         {

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/DeleteRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/DeleteRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/DeleteRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/DeleteRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -65,6 +65,7 @@ public class DeleteRequestDecorator exte
     /**
      * {@inheritDoc}
      */
+    @Override
     public Dn getName()
     {
         return getDecorated().getName();
@@ -74,6 +75,7 @@ public class DeleteRequestDecorator exte
     /**
      * {@inheritDoc}
      */
+    @Override
     public DeleteRequest setName( Dn name )
     {
         getDecorated().setName( name );
@@ -85,6 +87,7 @@ public class DeleteRequestDecorator exte
     /**
      * {@inheritDoc}
      */
+    @Override
     public DeleteRequest setMessageId( int messageId )
     {
         super.setMessageId( messageId );
@@ -96,6 +99,7 @@ public class DeleteRequestDecorator exte
     /**
      * {@inheritDoc}
      */
+    @Override
     public DeleteRequest addControl( Control control )
     {
         return ( DeleteRequest ) super.addControl( control );
@@ -105,6 +109,7 @@ public class DeleteRequestDecorator exte
     /**
      * {@inheritDoc}
      */
+    @Override
     public DeleteRequest addAllControls( Control[] controls )
     {
         return ( DeleteRequest ) super.addAllControls( controls );
@@ -114,6 +119,7 @@ public class DeleteRequestDecorator exte
     /**
      * {@inheritDoc}
      */
+    @Override
     public DeleteRequest removeControl( Control control )
     {
         return ( DeleteRequest ) super.removeControl( control );
@@ -134,6 +140,7 @@ public class DeleteRequestDecorator exte
      * Length(DelRequest) = Length(0x4A) + Length(L1) + L1
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         dnBytes = Strings.getBytesUtf8( getName().getName() );
@@ -154,6 +161,7 @@ public class DeleteRequestDecorator exte
      * 
      * @param buffer The buffer where to put the PDU
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/DeleteResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/DeleteResponseDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/DeleteResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/DeleteResponseDecorator.java Sat Nov 26 07:48:58 2016
@@ -73,6 +73,7 @@ public class DeleteResponseDecorator ext
      * Length(DelResponse) = Length(0x6B) + Length(L1) + L1
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         deleteResponseLength = ( ( LdapResultDecorator ) getLdapResult() ).computeLength();
@@ -86,6 +87,7 @@ public class DeleteResponseDecorator ext
      * 
      * @param buffer The buffer where to put the PDU
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/IntermediateResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/IntermediateResponseDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/IntermediateResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/IntermediateResponseDecorator.java Sat Nov 26 07:48:58 2016
@@ -70,6 +70,7 @@ public class IntermediateResponseDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getResponseName()
     {
         return getDecorated().getResponseName();
@@ -79,6 +80,7 @@ public class IntermediateResponseDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setResponseName( String oid )
     {
         getDecorated().setResponseName( oid );
@@ -88,6 +90,7 @@ public class IntermediateResponseDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte[] getResponseValue()
     {
         return getDecorated().getResponseValue();
@@ -97,6 +100,7 @@ public class IntermediateResponseDecorat
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setResponseValue( byte[] value )
     {
         getDecorated().setResponseValue( value );
@@ -124,6 +128,7 @@ public class IntermediateResponseDecorat
      * 
      * @return The IntermediateResponse length
      */
+    @Override
     public int computeLength()
     {
         intermediateResponseLength = 0;
@@ -159,6 +164,7 @@ public class IntermediateResponseDecorat
      * 
      * @param buffer The buffer where to put the PDU
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/LdapResultDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/LdapResultDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/LdapResultDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/LdapResultDecorator.java Sat Nov 26 07:48:58 2016
@@ -80,6 +80,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public ResultCodeEnum getResultCode()
     {
         return decoratedLdapResult.getResultCode();
@@ -89,6 +90,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setResultCode( ResultCodeEnum resultCode )
     {
         decoratedLdapResult.setResultCode( resultCode );
@@ -98,6 +100,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public Dn getMatchedDn()
     {
         return decoratedLdapResult.getMatchedDn();
@@ -107,6 +110,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setMatchedDn( Dn dn )
     {
         decoratedLdapResult.setMatchedDn( dn );
@@ -116,6 +120,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public String getDiagnosticMessage()
     {
         return decoratedLdapResult.getDiagnosticMessage();
@@ -125,6 +130,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setDiagnosticMessage( String diagnosticMessage )
     {
         decoratedLdapResult.setDiagnosticMessage( diagnosticMessage );
@@ -134,6 +140,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isReferral()
     {
         return decoratedLdapResult.isReferral();
@@ -143,6 +150,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public Referral getReferral()
     {
         return decoratedLdapResult.getReferral();
@@ -152,6 +160,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setReferral( Referral referral )
     {
         decoratedLdapResult.setReferral( referral );
@@ -161,6 +170,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public String toString()
     {
         return decoratedLdapResult.toString();
@@ -196,6 +206,7 @@ public class LdapResultDecorator impleme
      *      Length(L2) + L2 + Length(0x83) + Length(L3) + L3
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         if ( decoratedLdapResult.isDefaultSuccess() )
@@ -204,7 +215,7 @@ public class LdapResultDecorator impleme
             return DEFAULT_SUCCESS.length;
         }
 
-        int ldapResultLength = 0;
+        int ldapResultLength;
 
         // The result code
         ldapResultLength = 1 + 1 + BerValue.getNbBytes( getResultCode().getValue() );
@@ -242,6 +253,7 @@ public class LdapResultDecorator impleme
      * @param buffer The buffer where to put the PDU
      * @return The PDU.
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         if ( buffer == null )
@@ -288,6 +300,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public LdapResult getDecorated()
     {
         return decoratedLdapResult;
@@ -297,6 +310,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public LdapApiService getCodecService()
     {
         return codec;
@@ -306,6 +320,7 @@ public class LdapResultDecorator impleme
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isDefaultSuccess()
     {
         return decoratedLdapResult.isDefaultSuccess();

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ModifyDnRequestDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ModifyDnRequestDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ModifyDnRequestDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ModifyDnRequestDecorator.java Sat Nov 26 07:48:58 2016
@@ -67,6 +67,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public Dn getName()
     {
         return getDecorated().getName();
@@ -76,6 +77,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public ModifyDnRequest setName( Dn name )
     {
         getDecorated().setName( name );
@@ -87,6 +89,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public Rdn getNewRdn()
     {
         return getDecorated().getNewRdn();
@@ -96,6 +99,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public ModifyDnRequest setNewRdn( Rdn newRdn )
     {
         getDecorated().setNewRdn( newRdn );
@@ -107,6 +111,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean getDeleteOldRdn()
     {
         return getDecorated().getDeleteOldRdn();
@@ -116,6 +121,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public ModifyDnRequest setDeleteOldRdn( boolean deleteOldRdn )
     {
         getDecorated().setDeleteOldRdn( deleteOldRdn );
@@ -127,6 +133,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public Dn getNewSuperior()
     {
         return getDecorated().getNewSuperior();
@@ -136,6 +143,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public ModifyDnRequest setNewSuperior( Dn newSuperior )
     {
         getDecorated().setNewSuperior( newSuperior );
@@ -147,6 +155,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isMove()
     {
         return getDecorated().isMove();
@@ -156,6 +165,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public ModifyDnRequest setMessageId( int messageId )
     {
         super.setMessageId( messageId );
@@ -167,6 +177,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public ModifyDnRequest addControl( Control control )
     {
         return ( ModifyDnRequest ) super.addControl( control );
@@ -176,6 +187,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public ModifyDnRequest addAllControls( Control[] controls )
     {
         return ( ModifyDnRequest ) super.addAllControls( controls );
@@ -185,6 +197,7 @@ public class ModifyDnRequestDecorator ex
     /**
      * {@inheritDoc}
      */
+    @Override
     public ModifyDnRequest removeControl( Control control )
     {
         return ( ModifyDnRequest ) super.removeControl( control );
@@ -217,6 +230,7 @@ public class ModifyDnRequestDecorator ex
      * 
      * @return The PDU's length of a ModifyDN Request
      */
+    @Override
     public int computeLength()
     {
         int newRdnlength = Strings.getBytesUtf8( getNewRdn().getName() ).length;
@@ -251,6 +265,7 @@ public class ModifyDnRequestDecorator ex
      * @param buffer The buffer where to put the PDU
      * @return The PDU.
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try

Modified: directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ModifyDnResponseDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ModifyDnResponseDecorator.java?rev=1771436&r1=1771435&r2=1771436&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ModifyDnResponseDecorator.java (original)
+++ directory/shared/trunk/ldap/codec/core/src/main/java/org/apache/directory/api/ldap/codec/decorators/ModifyDnResponseDecorator.java Sat Nov 26 07:48:58 2016
@@ -71,6 +71,7 @@ public class ModifyDnResponseDecorator e
      * Length(ModifyDNResponse) = Length(0x6D) + Length(L1) + L1
      * </pre>
      */
+    @Override
     public int computeLength()
     {
         modifyDnResponseLength = ( ( LdapResultDecorator ) getLdapResult() ).computeLength();
@@ -84,6 +85,7 @@ public class ModifyDnResponseDecorator e
      * 
      * @param buffer The buffer where to put the PDU
      */
+    @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {
         try




Mime
View raw message