directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smckin...@apache.org
Subject directory-fortress-commander git commit: FC-191 - sonarqube code cleanup
Date Mon, 10 Oct 2016 16:43:54 GMT
Repository: directory-fortress-commander
Updated Branches:
  refs/heads/master 97007e676 -> b5add2de1


FC-191 - sonarqube code cleanup


Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/commit/b5add2de
Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/tree/b5add2de
Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/diff/b5add2de

Branch: refs/heads/master
Commit: b5add2de19993dfaee0beae76ad90a88448aa8da
Parents: 97007e6
Author: Shawn McKinney <smckinney@apache.org>
Authored: Mon Oct 10 11:22:27 2016 -0500
Committer: Shawn McKinney <smckinney@apache.org>
Committed: Mon Oct 10 11:22:27 2016 -0500

----------------------------------------------------------------------
 .../directory/fortress/web/panel/UserDetailPanel.java | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/blob/b5add2de/src/main/java/org/apache/directory/fortress/web/panel/UserDetailPanel.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/web/panel/UserDetailPanel.java b/src/main/java/org/apache/directory/fortress/web/panel/UserDetailPanel.java
index f812349..1cef0a2 100644
--- a/src/main/java/org/apache/directory/fortress/web/panel/UserDetailPanel.java
+++ b/src/main/java/org/apache/directory/fortress/web/panel/UserDetailPanel.java
@@ -1198,11 +1198,8 @@ public class UserDetailPanel extends FormComponentPanel
                 {
                     roleConstraint = roleSearchModalPanel.getRoleSelection();
                     newUserRole = roleConstraint.getName();
-                    if ( roleConstraint != null )
-                    {
-                        target.add( roleConstraintPanel );
-                        target.add( newUserRoleTF );
-                    }
+                    target.add( roleConstraintPanel );
+                    target.add( newUserRoleTF );
                 }
             } );
 
@@ -1269,11 +1266,8 @@ public class UserDetailPanel extends FormComponentPanel
                 {
                     adminRoleConstraint = adminRoleSearchModalPanel.getAdminRoleSelection();
                     newUserAdminRole = adminRoleConstraint.getName();
-                    if ( adminRoleConstraint != null )
-                    {
-                        target.add( adminRoleConstraintPanel );
-                        target.add( newUserAdminRoleTF );
-                    }
+                    target.add( adminRoleConstraintPanel );
+                    target.add( newUserAdminRoleTF );
                 }
             } );
 


Mime
View raw message