directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smckin...@apache.org
Subject directory-fortress-core git commit: Cleanup (mostly removed) old TODO comments
Date Thu, 25 Feb 2016 04:26:40 GMT
Repository: directory-fortress-core
Updated Branches:
  refs/heads/master 66088251c -> 15ca5b1be


Cleanup (mostly removed) old TODO comments


Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/commit/15ca5b1b
Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/tree/15ca5b1b
Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/diff/15ca5b1b

Branch: refs/heads/master
Commit: 15ca5b1bee946cfd232250ff8fb075f582be24d8
Parents: 6608825
Author: Shawn McKinney <smckinney@apache.org>
Authored: Wed Feb 24 22:22:31 2016 -0600
Committer: Shawn McKinney <smckinney@apache.org>
Committed: Wed Feb 24 22:22:31 2016 -0600

----------------------------------------------------------------------
 .../java/org/apache/directory/fortress/core/ConfigMgr.java  | 2 +-
 .../apache/directory/fortress/core/ConfigMgrFactory.java    | 2 --
 .../apache/directory/fortress/core/impl/AcceleratorDAO.java | 1 -
 .../apache/directory/fortress/core/impl/AdminRoleUtil.java  | 8 --------
 .../org/apache/directory/fortress/core/impl/PermDAO.java    | 1 -
 .../org/apache/directory/fortress/core/impl/PsoUtil.java    | 8 --------
 .../org/apache/directory/fortress/core/impl/RoleUtil.java   | 8 --------
 .../org/apache/directory/fortress/core/impl/UsoUtil.java    | 9 +--------
 .../directory/fortress/core/ldap/ApacheDsDataProvider.java  | 2 +-
 .../org/apache/directory/fortress/core/rest/RestUtils.java  | 1 -
 10 files changed, 3 insertions(+), 39 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/ConfigMgr.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/ConfigMgr.java b/src/main/java/org/apache/directory/fortress/core/ConfigMgr.java
index bebce59..4002d49 100755
--- a/src/main/java/org/apache/directory/fortress/core/ConfigMgr.java
+++ b/src/main/java/org/apache/directory/fortress/core/ConfigMgr.java
@@ -83,7 +83,7 @@ public interface ConfigMgr
      * {@link org.apache.directory.fortress.core.GlobalErrIds#FT_CONFIG_NOT_FOUND} will be
thrown.
      *
      * @param name attribute is required and maps to 'cn' attribute in 'device' object class.
-     * @param inProps TODO
+     * @param inProps contains the properties to remove.
      * @throws org.apache.directory.fortress.core.SecurityException in the event entry not
present or other system error.
      */
     void delete( String name, Properties inProps ) throws SecurityException;

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/ConfigMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/ConfigMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/ConfigMgrFactory.java
index 02f62a6..8eb481d 100755
--- a/src/main/java/org/apache/directory/fortress/core/ConfigMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/ConfigMgrFactory.java
@@ -53,12 +53,10 @@ public final class ConfigMgrFactory
     public static ConfigMgr createInstance()
         throws SecurityException
     {
-        // TODO: Don't reuse {@link VUtil#isNotNullOrEmpty} here until it is determined why
it forces different execution path through GlobalIds.IS_OPENLDAP:
         if (configClassName == null || configClassName.compareTo("") == 0)
         {
             if(IS_REST)
             {
-                // todo: this creates a cycle with rest package:
                 configClassName = ConfigMgrRestImpl.class.getName();
             }
             else

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/impl/AcceleratorDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/AcceleratorDAO.java b/src/main/java/org/apache/directory/fortress/core/impl/AcceleratorDAO.java
index 7e2ea42..15fcc94 100644
--- a/src/main/java/org/apache/directory/fortress/core/impl/AcceleratorDAO.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/AcceleratorDAO.java
@@ -79,7 +79,6 @@ final class AcceleratorDAO extends ApacheDsDataProvider
      *
      * It uses the {@link RbacCreateSessionRequest} and {@link RbacCreateSessionResponse}
accelerator APIs.
      *
-     * todo: this method does not yet, but will soon, return password policy decisions.
      *
      * @param user
      * @return session contains a valid sessionId captured from accelerator createSession
method.

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleUtil.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleUtil.java b/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleUtil.java
index 8deca27..6c71c5a 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleUtil.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleUtil.java
@@ -295,15 +295,7 @@ final class AdminRoleUtil
                 {
                     hierLock.readLock().unlock();
                     hierLock.writeLock().lock();
-
-                    // TODO: determine why this (code that was commented out) creates a deadlock:
-                    //graph = ( SimpleDirectedGraph<String, Relationship> ) adminRoleCache.get(
key );
-
-                    //if ( graph == null )
-                    //{
                     graph = loadGraph( contextId );
-                    //}
-
                     hierLock.readLock().lock();
                 }
                 finally

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/impl/PermDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/PermDAO.java b/src/main/java/org/apache/directory/fortress/core/impl/PermDAO.java
index e62b40e..31b2f3a 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/PermDAO.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/PermDAO.java
@@ -1027,7 +1027,6 @@ final class PermDAO extends ApacheDsDataProvider
         entity.addProperties( PropUtil.getProperties( getAttributes( le, GlobalIds.PROPS
) ) );
         entity.setAdmin( isAdmin );
 
-        // TODO: find out the correct way to do this:
         if ( le != null )
         {
             entity.setDn( le.getDn().getNormName() );

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/impl/PsoUtil.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/PsoUtil.java b/src/main/java/org/apache/directory/fortress/core/impl/PsoUtil.java
index 481e012..6cfa8d0 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/PsoUtil.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/PsoUtil.java
@@ -270,15 +270,7 @@ final class PsoUtil
                 {
                     hierLock.readLock().unlock();
                     hierLock.writeLock().lock();
-
-                    // TODO: determine why this (code that was commented out) creates a deadlock:
-                    //graph = ( SimpleDirectedGraph<String, Relationship> ) psoCache.get(
key );
-
-                    //if ( graph == null )
-                    //{
                     graph = loadGraph( contextId );
-                    //}
-
                     hierLock.readLock().lock();
                 }
                 finally

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/impl/RoleUtil.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/RoleUtil.java b/src/main/java/org/apache/directory/fortress/core/impl/RoleUtil.java
index a79fc59..cec2653 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/RoleUtil.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/RoleUtil.java
@@ -397,15 +397,7 @@ final class RoleUtil implements ParentUtil
                 {
                     hierLock.readLock().unlock();
                     hierLock.writeLock().lock();
-
-                    // TODO: determine why this (code that was commented out) creates a deadlock:
-                    //graph = ( SimpleDirectedGraph<String, Relationship> ) roleCache.get(
key );
-
-                    //if ( graph == null )
-                    //{
                     graph = loadGraph( contextId );
-                    //}
-
                     hierLock.readLock().lock();
                 }
                 finally

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/impl/UsoUtil.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/UsoUtil.java b/src/main/java/org/apache/directory/fortress/core/impl/UsoUtil.java
index d558a88..bc4e4d0 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/UsoUtil.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/UsoUtil.java
@@ -272,14 +272,7 @@ final class UsoUtil
                 {
                     hierLock.readLock().unlock();
                     hierLock.writeLock().lock();
-
-                    // TODO: determine why this (code that was commented out) creates a deadlock:
-                    //graph = ( SimpleDirectedGraph<String, Relationship> ) usoCache.get(
key );
-
-                    //if ( graph == null )
-                    //{
-                        graph = loadGraph( contextId );
-                    //}
+                    graph = loadGraph( contextId );
                     hierLock.readLock().lock();
                 }
                 finally

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/ldap/ApacheDsDataProvider.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/ldap/ApacheDsDataProvider.java
b/src/main/java/org/apache/directory/fortress/core/ldap/ApacheDsDataProvider.java
index 67acb88..45065b9 100644
--- a/src/main/java/org/apache/directory/fortress/core/ldap/ApacheDsDataProvider.java
+++ b/src/main/java/org/apache/directory/fortress/core/ldap/ApacheDsDataProvider.java
@@ -244,7 +244,7 @@ public abstract class ApacheDsDataProvider
         // To enable, set {@code log.admin.user} && {@code log.admin.pw} inside fortress.properties
file:
         if ( StringUtils.isNotEmpty( LDAP_LOG_POOL_UID ) && StringUtils.isNotEmpty(
LDAP_LOG_POOL_PW ) )
         {
-            // TODO: Initializing the log pool in static block requires static props set
within fortress.properties.
+            // Initializing the log pool in static block requires static props set within
fortress.properties.
             // To make this dynamic requires moving this code outside of static block AND
storing the connection metadata inside fortress config node (in ldap).
             LdapConnectionConfig logConfig = new LdapConnectionConfig();
             logConfig.setLdapHost( host );

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/15ca5b1b/src/main/java/org/apache/directory/fortress/core/rest/RestUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/rest/RestUtils.java b/src/main/java/org/apache/directory/fortress/core/rest/RestUtils.java
index 3886f20..af1ed59 100644
--- a/src/main/java/org/apache/directory/fortress/core/rest/RestUtils.java
+++ b/src/main/java/org/apache/directory/fortress/core/rest/RestUtils.java
@@ -78,7 +78,6 @@ public class RestUtils
     private static final String HTTP_PROTOCOL = Config.getProperty( "http.protocol", "http"
);
     private static final String VERSION = System.getProperty( "version" );
     private static final String SERVICE = "fortress-rest-" + VERSION;
-    // TODO: add SSL capability here:
     private static final String URI = HTTP_PROTOCOL + "://" + HTTP_HOST + ":" + HTTP_PORT
+ "/" + SERVICE + "/";
     private static final int HTTP_OK = 200;
     private static final int HTTP_401_UNAUTHORIZED = 401;


Mime
View raw message