directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From plusplusjia...@apache.org
Subject [1/2] directory-kerby git commit: DIRKRB-498 PKINIT branch doesn't build unless -Pnochecks specified.
Date Mon, 14 Dec 2015 08:59:11 GMT
Repository: directory-kerby
Updated Branches:
  refs/heads/pkinit-support ae04916b1 -> dc1e21697


http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/KdcDHKeyInfo.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/KdcDHKeyInfo.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/KdcDHKeyInfo.java
index 9f6e92d..b5ac1c0 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/KdcDHKeyInfo.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/KdcDHKeyInfo.java
@@ -19,14 +19,17 @@
  */
 package org.apache.kerby.kerberos.kerb.type.pa.pkinit;
 
+import org.apache.kerby.asn1.Asn1FieldInfo;
 import org.apache.kerby.asn1.EnumType;
+import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.asn1.type.Asn1BitString;
-import org.apache.kerby.asn1.Asn1FieldInfo;
 import org.apache.kerby.asn1.type.Asn1Integer;
-import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.kerberos.kerb.type.KerberosTime;
 import org.apache.kerby.kerberos.kerb.type.KrbSequenceType;
-import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.KdcDHKeyInfo.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.KdcDHKeyInfo.MyEnum.DH_KEY_EXPIRATION;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.KdcDHKeyInfo.MyEnum.NONCE;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.KdcDHKeyInfo.MyEnum.SUBJECT_PUBLIC_KEY;
 
 /**
  KDCDHKeyInfo ::= SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/Krb5PrincipalName.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/Krb5PrincipalName.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/Krb5PrincipalName.java
index 2868207..257112d 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/Krb5PrincipalName.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/Krb5PrincipalName.java
@@ -25,7 +25,9 @@ import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.kerberos.kerb.type.KrbSequenceType;
 import org.apache.kerby.kerberos.kerb.type.base.PrincipalName;
 import org.apache.kerby.kerberos.kerb.type.base.Realm;
-import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.Krb5PrincipalName.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.Krb5PrincipalName.MyEnum.PRINCIPAL_NAME;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.Krb5PrincipalName.MyEnum.REALM;
 
 /**
  KRB5PrincipalName ::= SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsRep.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsRep.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsRep.java
index b33298d..71078dd 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsRep.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsRep.java
@@ -19,13 +19,15 @@
  */
 package org.apache.kerby.kerberos.kerb.type.pa.pkinit;
 
-import org.apache.kerby.asn1.EnumType;
-import org.apache.kerby.asn1.type.Asn1Choice;
 import org.apache.kerby.asn1.Asn1FieldInfo;
-import org.apache.kerby.asn1.type.Asn1OctetString;
+import org.apache.kerby.asn1.EnumType;
 import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.asn1.ImplicitField;
-import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PaPkAsRep.MyEnum.*;
+import org.apache.kerby.asn1.type.Asn1Choice;
+import org.apache.kerby.asn1.type.Asn1OctetString;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PaPkAsRep.MyEnum.DH_INFO;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PaPkAsRep.MyEnum.ENCKEY_PACK;
 
 /**
  PA-PK-AS-REP ::= CHOICE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsReq.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsReq.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsReq.java
index 060453d..2bd2426 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsReq.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PaPkAsReq.java
@@ -21,11 +21,14 @@ package org.apache.kerby.kerberos.kerb.type.pa.pkinit;
 
 import org.apache.kerby.asn1.Asn1FieldInfo;
 import org.apache.kerby.asn1.EnumType;
-import org.apache.kerby.asn1.type.Asn1OctetString;
 import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.asn1.ImplicitField;
+import org.apache.kerby.asn1.type.Asn1OctetString;
 import org.apache.kerby.kerberos.kerb.type.KrbSequenceType;
-import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PaPkAsReq.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PaPkAsReq.MyEnum.KDC_PKID;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PaPkAsReq.MyEnum.SIGNED_AUTH_PACK;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PaPkAsReq.MyEnum.TRUSTED_CERTIFIERS;
 
 /**
  PA-PK-AS-REQ ::= SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PkAuthenticator.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PkAuthenticator.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PkAuthenticator.java
index 4cd581e..2f48a02 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PkAuthenticator.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/PkAuthenticator.java
@@ -21,12 +21,16 @@ package org.apache.kerby.kerberos.kerb.type.pa.pkinit;
 
 import org.apache.kerby.asn1.Asn1FieldInfo;
 import org.apache.kerby.asn1.EnumType;
+import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.asn1.type.Asn1Integer;
 import org.apache.kerby.asn1.type.Asn1OctetString;
-import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.kerberos.kerb.type.KerberosTime;
 import org.apache.kerby.kerberos.kerb.type.KrbSequenceType;
-import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PkAuthenticator.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PkAuthenticator.MyEnum.CTIME;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PkAuthenticator.MyEnum.CUSEC;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PkAuthenticator.MyEnum.NONCE;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.PkAuthenticator.MyEnum.PA_CHECKSUM;
 
 /**
  PKAuthenticator ::= SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/ReplyKeyPack.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/ReplyKeyPack.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/ReplyKeyPack.java
index 022221e..1c29c51 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/ReplyKeyPack.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/pkinit/ReplyKeyPack.java
@@ -25,7 +25,9 @@ import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.kerberos.kerb.type.KrbSequenceType;
 import org.apache.kerby.kerberos.kerb.type.base.CheckSum;
 import org.apache.kerby.kerberos.kerb.type.base.EncryptionKey;
-import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.ReplyKeyPack.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.ReplyKeyPack.MyEnum.AS_CHECKSUM;
+import static org.apache.kerby.kerberos.kerb.type.pa.pkinit.ReplyKeyPack.MyEnum.REPLY_KEY;
 
 /**
  ReplyKeyPack ::= SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenChallenge.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenChallenge.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenChallenge.java
index 34b6b3e..983e288 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenChallenge.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenChallenge.java
@@ -23,7 +23,8 @@ import org.apache.kerby.asn1.Asn1FieldInfo;
 import org.apache.kerby.asn1.EnumType;
 import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.kerberos.kerb.type.KrbSequenceType;
-import static org.apache.kerby.kerberos.kerb.type.pa.token.PaTokenChallenge.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.token.PaTokenChallenge.MyEnum.TOKENINFOS;
 
 /**
  PA-TOKEN-CHALLENGE ::= SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenRequest.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenRequest.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenRequest.java
index 9ddef33..6db7dd1 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenRequest.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/PaTokenRequest.java
@@ -24,7 +24,9 @@ import org.apache.kerby.asn1.EnumType;
 import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.kerberos.kerb.type.KrbSequenceType;
 import org.apache.kerby.kerberos.kerb.type.base.KrbToken;
-import static org.apache.kerby.kerberos.kerb.type.pa.token.PaTokenRequest.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.token.PaTokenRequest.MyEnum.TOKEN;
+import static org.apache.kerby.kerberos.kerb.type.pa.token.PaTokenRequest.MyEnum.TOKEN_INFO;
 
 /**
  PA-TOKEN-REQUEST ::= SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/TokenInfo.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/TokenInfo.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/TokenInfo.java
index 0c5866f..f28b489 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/TokenInfo.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/pa/token/TokenInfo.java
@@ -21,11 +21,13 @@ package org.apache.kerby.kerberos.kerb.type.pa.token;
 
 import org.apache.kerby.asn1.Asn1FieldInfo;
 import org.apache.kerby.asn1.EnumType;
+import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.asn1.type.Asn1OctetString;
 import org.apache.kerby.asn1.type.Asn1Utf8String;
-import org.apache.kerby.asn1.ExplicitField;
 import org.apache.kerby.kerberos.kerb.type.KrbSequenceType;
-import static org.apache.kerby.kerberos.kerb.type.pa.token.TokenInfo.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.pa.token.TokenInfo.MyEnum.FLAGS;
+import static org.apache.kerby.kerberos.kerb.type.pa.token.TokenInfo.MyEnum.TOKEN_VENDOR;
 
 /**
  TokenInfo ::= SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/EncTicketPart.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/EncTicketPart.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/EncTicketPart.java
index 5199683..4865faa 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/EncTicketPart.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/EncTicketPart.java
@@ -30,7 +30,18 @@ import org.apache.kerby.kerberos.kerb.type.base.EncryptionKey;
 import org.apache.kerby.kerberos.kerb.type.base.HostAddresses;
 import org.apache.kerby.kerberos.kerb.type.base.PrincipalName;
 import org.apache.kerby.kerberos.kerb.type.base.TransitedEncoding;
-import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.AUTHORIZATION_DATA;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.AUTHTIME;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.CADDR;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.CNAME;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.CREALM;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.ENDTIME;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.FLAGS;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.KEY;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.RENEW_TILL;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.STARTTIME;
+import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.TRANSITED;
 
 /**
  -- Encrypted part of ticket
@@ -48,6 +59,7 @@ import static org.apache.kerby.kerberos.kerb.type.ticket.EncTicketPart.MyEnum.*;
  authorization-data      [10] AuthorizationData OPTIONAL
  }
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class EncTicketPart extends KrbAppSequenceType {
     public static final int TAG = 3;
 

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/Ticket.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/Ticket.java
b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/Ticket.java
index 65d8e63..c3f9f61 100644
--- a/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/Ticket.java
+++ b/kerby-kerb/kerb-core/src/main/java/org/apache/kerby/kerberos/kerb/type/ticket/Ticket.java
@@ -21,14 +21,18 @@ package org.apache.kerby.kerberos.kerb.type.ticket;
 
 import org.apache.kerby.asn1.Asn1FieldInfo;
 import org.apache.kerby.asn1.EnumType;
-import org.apache.kerby.asn1.type.Asn1Integer;
 import org.apache.kerby.asn1.ExplicitField;
+import org.apache.kerby.asn1.type.Asn1Integer;
 import org.apache.kerby.kerberos.kerb.KrbConstant;
 import org.apache.kerby.kerberos.kerb.type.KerberosString;
 import org.apache.kerby.kerberos.kerb.type.KrbAppSequenceType;
 import org.apache.kerby.kerberos.kerb.type.base.EncryptedData;
 import org.apache.kerby.kerberos.kerb.type.base.PrincipalName;
-import static org.apache.kerby.kerberos.kerb.type.ticket.Ticket.MyEnum.*;
+
+import static org.apache.kerby.kerberos.kerb.type.ticket.Ticket.MyEnum.ENC_PART;
+import static org.apache.kerby.kerberos.kerb.type.ticket.Ticket.MyEnum.REALM;
+import static org.apache.kerby.kerberos.kerb.type.ticket.Ticket.MyEnum.SNAME;
+import static org.apache.kerby.kerberos.kerb.type.ticket.Ticket.MyEnum.TKT_VNO;
 
 /**
  Ticket          ::= [APPLICATION 1] SEQUENCE {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-server/pom.xml
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-server/pom.xml b/kerby-kerb/kerb-server/pom.xml
index ddea681..edb355c 100644
--- a/kerby-kerb/kerb-server/pom.xml
+++ b/kerby-kerb/kerb-server/pom.xml
@@ -47,10 +47,5 @@
       <artifactId>kerb-identity</artifactId>
       <version>${project.version}</version>
     </dependency>
-    <dependency>
-      <groupId>org.apache.kerby</groupId>
-      <artifactId>not-yet-commons-ssl</artifactId>
-      <version>${project.version}</version>
-    </dependency>
   </dependencies>
 </project>

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/preauth/pkinit/PkinitPreauth.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/preauth/pkinit/PkinitPreauth.java
b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/preauth/pkinit/PkinitPreauth.java
index ae78357..c0a9a10 100644
--- a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/preauth/pkinit/PkinitPreauth.java
+++ b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/preauth/pkinit/PkinitPreauth.java
@@ -1,20 +1,21 @@
 /**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- * <p/>
- * http://www.apache.org/licenses/LICENSE-2.0
- * <p/>
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ *
  */
 package org.apache.kerby.kerberos.kerb.server.preauth.pkinit;
 
@@ -183,7 +184,7 @@ public class PkinitPreauth extends AbstractPreauthPlugin {
                 /**Get REQ_BODY in KDC_REQ for checksum*/
                 Asn1Container container = (Asn1Container) parseResult;
                 List<Asn1ParseResult> parseResults = container.getChildren();
-                Asn1Container parsingItem = (Asn1Container)parseResults.get(0);
+                Asn1Container parsingItem = (Asn1Container) parseResults.get(0);
                 List<Asn1ParseResult> items = parsingItem.getChildren();
                 if (items.size() > 3) { // TO BE FIXED: INDICATE PKINIT CASE!!
                     ByteBuffer bodyBuffer = items.get(3).getBodyBuffer();
@@ -252,6 +253,7 @@ public class PkinitPreauth extends AbstractPreauthPlugin {
                     throw new KrbException(KrbErrorCode.KDC_ERR_PREAUTH_FAILED, errMessage);
                 } else {
                     // rsa
+                    System.out.println("rsa");
                 }
             }
         }
@@ -329,7 +331,7 @@ public class PkinitPreauth extends AbstractPreauthPlugin {
         byte[] signedDataBytes = null;
 
         CertificateSet certificateSet = new CertificateSet();
-        for(X509Certificate x509Certificate : certificates) {
+        for (X509Certificate x509Certificate : certificates) {
             Certificate certificate = PkinitCrypto.changeCertificate(x509Certificate);
             CertificateChoices certificateChoices = new CertificateChoices();
             certificateChoices.setCertificate(certificate);

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/AsRequest.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/AsRequest.java
b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/AsRequest.java
index 5ea03ee..49aa892 100644
--- a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/AsRequest.java
+++ b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/AsRequest.java
@@ -81,7 +81,7 @@ public class AsRequest extends KdcRequest {
         } else {
             clientEntry = getEntry(clientPrincipal.getName());
         }
-        if(isAnonymous()) {
+        if (isAnonymous()) {
             clientEntry.setPrincipal(new PrincipalName(clientPrincipal.getName(), NameType.NT_WELLKNOWN));
         }
 

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java
b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java
index b8ba6d7..2a80845 100644
--- a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java
+++ b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/KdcRequest.java
@@ -700,7 +700,7 @@ public abstract class KdcRequest {
         }
         methodData.add(new PaDataEntry(PaDataType.ETYPE_INFO2, encTypeInfo2));
 
-        if(pkinit) {
+        if (pkinit) {
             methodData.add(new PaDataEntry(PaDataType.PK_AS_REQ, "empty".getBytes()));
             methodData.add(new PaDataEntry(PaDataType.PK_AS_REP, "empty".getBytes()));
         }

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/TicketIssuer.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/TicketIssuer.java
b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/TicketIssuer.java
index 4717e8f..a9bae5b 100644
--- a/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/TicketIssuer.java
+++ b/kerby-kerb/kerb-server/src/main/java/org/apache/kerby/kerberos/kerb/server/request/TicketIssuer.java
@@ -220,7 +220,7 @@ public abstract class TicketIssuer {
             return new PrincipalName(kdcRequest.getToken().getSubject());
         } else {
             PrincipalName principalName = getKdcReq().getReqBody().getCname();
-            if(getKdcRequest().isAnonymous()) {
+            if (getKdcRequest().isAnonymous()) {
                 principalName.setNameType(NameType.NT_WELLKNOWN);
             }
             return principalName;

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/commons/ssl/Certificates.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/commons/ssl/Certificates.java b/kerby-pkix/src/main/java/org/apache/commons/ssl/Certificates.java
index 4c2e3dd..5efc15a 100644
--- a/kerby-pkix/src/main/java/org/apache/commons/ssl/Certificates.java
+++ b/kerby-pkix/src/main/java/org/apache/commons/ssl/Certificates.java
@@ -40,7 +40,6 @@ import javax.naming.directory.Attribute;
 import javax.naming.directory.Attributes;
 import javax.naming.ldap.LdapName;
 import javax.naming.ldap.Rdn;
-import javax.net.ssl.HttpsURLConnection;
 import javax.security.auth.x500.X500Principal;
 import java.io.BufferedInputStream;
 import java.io.BufferedOutputStream;
@@ -88,6 +87,7 @@ import java.util.Set;
  * @author <a href="mailto:juliusdavies@cucbc.com">juliusdavies@cucbc.com</a>
  * @since 19-Aug-2005
  */
+@SuppressWarnings("PMD.AvoidUsingHardCodedIP")
 public class Certificates {
 
     public static final CertificateFactory CF;
@@ -412,14 +412,15 @@ public class Certificates {
                     // to enforce timeouts for CRL-checking (5 seconds).
                     URL url = new URL(urlString);
                     URLConnection urlConn = url.openConnection();
-                    if (urlConn instanceof HttpsURLConnection) {
+                    //if (urlConn instanceof HttpsURLConnection) {
 
                         // HTTPS sites will use special CRLSocket.getInstance() SocketFactory
                         // that is configured to timeout after 5 seconds:
-                        HttpsURLConnection httpsConn = (HttpsURLConnection) urlConn;
+                        //HttpsURLConnection httpsConn = (HttpsURLConnection) urlConn;
                         //httpsConn.setSSLSocketFactory(CRLSocket.getSecureInstance());
 
-                    } else if (urlConn instanceof HttpURLConnection) {
+                    //} else
+                    if (urlConn instanceof HttpURLConnection) {
 
                         // HTTP timeouts can only be set on Java 1.5 and up.  :-(
                         // The code required to set it for Java 1.4 and Java 1.3 is just
too painful.

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/commons/ssl/HostnameVerifier.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/commons/ssl/HostnameVerifier.java b/kerby-pkix/src/main/java/org/apache/commons/ssl/HostnameVerifier.java
index ada875f..86681b4 100644
--- a/kerby-pkix/src/main/java/org/apache/commons/ssl/HostnameVerifier.java
+++ b/kerby-pkix/src/main/java/org/apache/commons/ssl/HostnameVerifier.java
@@ -211,6 +211,7 @@ public interface HostnameVerifier extends javax.net.ssl.HostnameVerifier
{
             }
         };
 
+    @SuppressWarnings("PMD.AvoidUsingHardCodedIP")
     abstract class AbstractVerifier implements HostnameVerifier {
 
         /**
@@ -446,15 +447,14 @@ public interface HostnameVerifier extends javax.net.ssl.HostnameVerifier
{
 
         public static boolean acceptableCountryWildcard(final String cn) {
             int cnLen = cn.length();
-            if (cnLen >= 7 && cnLen <= 9) {
+            if (cnLen >= 7 && cnLen <= 9 && cn.charAt(cnLen - 3) ==
'.') {
                 // Look for the '.' in the 3rd-last position:
-                if (cn.charAt(cnLen - 3) == '.') {
-                    // Trim off the [*.] and the [.XX].
-                    String s = cn.substring(2, cnLen - 3);
-                    // And test against the sorted array of bad 2lds:
-                    int x = Arrays.binarySearch(BAD_COUNTRY_2LDS, s);
-                    return x < 0;
-                }
+                // Trim off the [*.] and the [.XX].
+                String s = cn.substring(2, cnLen - 3);
+                // And test against the sorted array of bad 2lds:
+                int x = Arrays.binarySearch(BAD_COUNTRY_2LDS, s);
+                return x < 0;
+
             }
             return true;
         }

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/commons/ssl/KeyStoreBuilder.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/commons/ssl/KeyStoreBuilder.java b/kerby-pkix/src/main/java/org/apache/commons/ssl/KeyStoreBuilder.java
index 7389e3e..1b3267a 100644
--- a/kerby-pkix/src/main/java/org/apache/commons/ssl/KeyStoreBuilder.java
+++ b/kerby-pkix/src/main/java/org/apache/commons/ssl/KeyStoreBuilder.java
@@ -495,12 +495,10 @@ public class KeyStoreBuilder {
                     System.out.println("what kind of weird pkcs12 file has more than one
alias?");
                 }
             }
-            if (key == null && uke != null) {
+            if (key == null && uke != null && !forTrustMaterial) {
                 // If we're trying to load KeyMaterial, then we *need* that key we spotted.
                 // But if we're trying to load TrustMaterial, then we're fine, and we can
ignore the key.
-                if (!forTrustMaterial) {
-                    throw new ProbablyBadPasswordException("Probably bad JKS-Key password:
" + uke);
-                }
+                throw new ProbablyBadPasswordException("Probably bad JKS-Key password: "
+ uke);
             }
             if (isPKCS12) {
                 // PKCS12 is supposed to be just a key and a chain, anyway.

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/commons/ssl/OpenSSL.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/commons/ssl/OpenSSL.java b/kerby-pkix/src/main/java/org/apache/commons/ssl/OpenSSL.java
index c3f26b5..0eda1db 100644
--- a/kerby-pkix/src/main/java/org/apache/commons/ssl/OpenSSL.java
+++ b/kerby-pkix/src/main/java/org/apache/commons/ssl/OpenSSL.java
@@ -453,6 +453,7 @@ public class OpenSSL {
         return deriveKey(password, salt, keySize, 0, des2);
     }
 
+    @SuppressWarnings("PMD.UselessParentheses")
     public static DerivedKey deriveKey(char[] password, byte[] salt,
                                        int keySize, int ivSize, boolean des2)
         throws NoSuchAlgorithmException {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/commons/ssl/PKCS8Key.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/commons/ssl/PKCS8Key.java b/kerby-pkix/src/main/java/org/apache/commons/ssl/PKCS8Key.java
index b6a47dc..7c4cdaf 100644
--- a/kerby-pkix/src/main/java/org/apache/commons/ssl/PKCS8Key.java
+++ b/kerby-pkix/src/main/java/org/apache/commons/ssl/PKCS8Key.java
@@ -812,6 +812,7 @@ public class PKCS8Key {
      * @param md             The message digest to use
      * @return byte[] the derived key
      */
+    @SuppressWarnings("PMD.UselessParentheses")
     private static byte[] pkcs12(int idByte, int n, byte[] salt,
                                  byte[] password, int iterationCount,
                                  MessageDigest md) {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/commons/ssl/TrustChain.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/commons/ssl/TrustChain.java b/kerby-pkix/src/main/java/org/apache/commons/ssl/TrustChain.java
index 028f3d9..fe54838 100644
--- a/kerby-pkix/src/main/java/org/apache/commons/ssl/TrustChain.java
+++ b/kerby-pkix/src/main/java/org/apache/commons/ssl/TrustChain.java
@@ -135,7 +135,8 @@ public class TrustChain {
         CertificateException {
         KeyStore uks = getUnifiedKeyStore();
         if (uks != null) {
-            return null;//JavaImpl.newTrustManagerFactory(uks);
+            return null;
+            //JavaImpl.newTrustManagerFactory(uks);
         } else {
             return null;
         }
@@ -153,7 +154,7 @@ public class TrustChain {
     public Object[] getTrustManagers()
         throws NoSuchAlgorithmException, KeyStoreException, IOException,
         CertificateException {
-        Object tmf = getTrustManagerFactory();
+//        Object tmf = getTrustManagerFactory();
         //return tmf != null ? JavaImpl.getTrustManagers(tmf) : null;
         return null;
     }

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/cms/type/AttributeCertificateInfoV1.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/cms/type/AttributeCertificateInfoV1.java
b/kerby-pkix/src/main/java/org/apache/kerby/cms/type/AttributeCertificateInfoV1.java
index 5c79fbd..2844ca2 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/cms/type/AttributeCertificateInfoV1.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/cms/type/AttributeCertificateInfoV1.java
@@ -56,6 +56,7 @@ import static org.apache.kerby.cms.type.AttributeCertificateInfoV1.MyEnum.VERSIO
  *
  * AttCertVersionV1 ::= INTEGER { v1(0) }
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class AttributeCertificateInfoV1 extends Asn1SequenceType {
     protected enum MyEnum implements EnumType {
         VERSION,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/cms/type/CertificateChoices.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/cms/type/CertificateChoices.java b/kerby-pkix/src/main/java/org/apache/kerby/cms/type/CertificateChoices.java
index 7c306d7..9d722b2 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/cms/type/CertificateChoices.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/cms/type/CertificateChoices.java
@@ -39,6 +39,7 @@ import static org.apache.kerby.cms.type.CertificateChoices.MyEnum.V2_ATTR_CERT;
  *   v2AttrCert [2] IMPLICIT AttributeCertificateV2,
  *   other [3] IMPLICIT OtherCertificateFormat }
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class CertificateChoices extends Asn1Choice {
     protected enum MyEnum implements EnumType {
         CERTIFICATE,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignedData.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignedData.java b/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignedData.java
index 94e210b..ab761a8 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignedData.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignedData.java
@@ -45,6 +45,7 @@ import static org.apache.kerby.cms.type.SignedData.MyEnum.SIGNER_INFOS;
  * </pre>
  *
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class SignedData extends Asn1SequenceType {
     protected enum MyEnum implements EnumType {
         CMS_VERSION,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignerInfo.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignerInfo.java b/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignerInfo.java
index b55dc4e..518364e 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignerInfo.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/cms/type/SignerInfo.java
@@ -47,6 +47,7 @@ import static org.apache.kerby.cms.type.SignerInfo.MyEnum.UNSIGNED_ATTRS;
  *
  * </pre>
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class SignerInfo extends Asn1SequenceType {
     protected enum MyEnum implements EnumType {
         CMS_VERSION,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/x509/type/AttributeCertificateInfo.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/AttributeCertificateInfo.java
b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/AttributeCertificateInfo.java
index 55fc2f2..fc6e36b 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/AttributeCertificateInfo.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/AttributeCertificateInfo.java
@@ -55,6 +55,7 @@ import static org.apache.kerby.x509.type.AttributeCertificateInfo.MyEnum.VERSION
  *  UniqueIdentifier  ::=  BIT STRING
  * </pre>
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class AttributeCertificateInfo extends Asn1SequenceType {
     protected enum MyEnum implements EnumType {
         VERSION,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/x509/type/DirectoryString.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/DirectoryString.java b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/DirectoryString.java
index c72062a..381ca77 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/DirectoryString.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/DirectoryString.java
@@ -45,6 +45,7 @@ import static org.apache.kerby.x509.type.DirectoryString.MyEnum.UTF8_STRING;
  * }
  * </pre>
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class DirectoryString extends Asn1Choice {
     protected enum MyEnum implements EnumType {
         TELETEX_STRING,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/x509/type/GeneralName.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/GeneralName.java b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/GeneralName.java
index aa6dc55..7c7ec66 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/GeneralName.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/GeneralName.java
@@ -56,6 +56,7 @@ import static org.apache.kerby.x509.type.GeneralName.MyEnum.X400_ADDRESS;
  *  }
  * </pre>
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class GeneralName extends Asn1Choice {
     protected enum MyEnum implements EnumType {
         OTHER_NAME,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/x509/type/IssuingDistributionPoint.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/IssuingDistributionPoint.java
b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/IssuingDistributionPoint.java
index 375369d..3a7108e 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/IssuingDistributionPoint.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/IssuingDistributionPoint.java
@@ -44,6 +44,7 @@ import static org.apache.kerby.x509.type.IssuingDistributionPoint.MyEnum.ONLY_SO
  * }
  * </pre>
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class IssuingDistributionPoint extends Asn1SequenceType {
     protected enum MyEnum implements EnumType {
         DISTRIBUTION_POINT,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertList.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertList.java b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertList.java
index e7aabba..f23bd73 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertList.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertList.java
@@ -55,6 +55,7 @@ import static org.apache.kerby.x509.type.TBSCertList.MyEnum.VERSION;
  *                                }
  * </pre>
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class TBSCertList extends Asn1SequenceType {
     protected enum MyEnum implements EnumType {
         VERSION,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertificate.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertificate.java b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertificate.java
index 60519c3..71deb42 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertificate.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/TBSCertificate.java
@@ -56,6 +56,7 @@ import static org.apache.kerby.x509.type.TBSCertificate.MyEnum.VERSION;
  *  }
  * </pre>
  */
+@SuppressWarnings("PMD.TooManyStaticImports")
 public class TBSCertificate extends Asn1SequenceType {
     protected enum MyEnum implements EnumType {
         VERSION,

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-pkix/src/test/resources/anonymous.txt
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/test/resources/anonymous.txt b/kerby-pkix/src/test/resources/anonymous.txt
index 017a748..bf1466a 100644
--- a/kerby-pkix/src/test/resources/anonymous.txt
+++ b/kerby-pkix/src/test/resources/anonymous.txt
@@ -1,20 +1 @@
-308203DD06092A864886F70D010702A08203CE308203CA0201033100308203BF06072B060105020301A08203B2048203AE30
-8203AAA03C303AA005020306C39CA111180F32303135313231303032353031355AA20602046B22377FA3160414E592C909D3
-20DD4CE1CCAA4708E8BC73D48D03BFA182032A308203263082021906072A8648CE3E02013082020C0282010100FFFFFFFFFF
-FFFFFFC90FDAA22168C234C4C6628B80DC1CD129024E088A67CC74020BBEA63B139B22514A08798E3404DDEF9519B3CD3A43
-1B302B0A6DF25F14374FE1356D6D51C245E485B576625E7EC6F44C42E9A637ED6B0BFF5CB6F406B7EDEE386BFB5A899FA5AE
-9F24117C4B1FE649286651ECE45B3DC2007CB8A163BF0598DA48361C55D39A69163FA8FD24CF5F83655D23DCA3AD961C62F3
-56208552BB9ED529077096966D670C354E4ABC9804F1746C08CA18217C32905E462E36CE3BE39E772C180E86039B2783A2EC
-07A28FB5C55DF06F4C52C9DE2BCBF6955817183995497CEA956AE515D2261898FA051015728E5A8AACAA68FFFFFFFFFFFFFF
-FF020102028201007FFFFFFFFFFFFFFFE487ED5110B4611A62633145C06E0E68948127044533E63A0105DF531D89CD9128A5
-043CC71A026EF7CA8CD9E69D218D98158536F92F8A1BA7F09AB6B6A8E122F242DABB312F3F637A262174D31BF6B585FFAE5B
-7A035BF6F71C35FDAD44CFD2D74F9208BE258FF324943328F6722D9EE1003E5C50B1DF82CC6D241B0E2AE9CD348B1FD47E92
-67AFC1B2AE91EE51D6CB0E3179AB1042A95DCF6A9483B84B4B36B3861AA7255E4C0278BA3604650C10BE19482F23171B671D
-F1CF3B960C074301CD93C1D17603D147DAE2AEF837A62964EF15E5FB4AAC0B8C1CCAA4BE754AB5728AE9130C4C7D02880AB9
-472D455655347FFFFFFFFFFFFFFF0382010500028201006C3C8337692B63F663AB2D953C5ADCE3DBC840339A426408761C1B
-CED206E84C9898B2D44F35A2F0D8604752B1530580DFEB3D7649D9736CA12DCAB7DAFA34A8C1C143A20FF7F9103B3FDEDC62
-08E39330BF0C3FA6BE6C3A6821270D194D9F27A80F0B8E4D6F59A75A0E384A588CFBECF75AC294D85AB8966BA26F49562C56
-F57C450CD1EACAD30F5994DAC89AB11D3229E9D1D6AAA4E80AEAD122115AA2A737DC82A70A99E6F50892135D5D50442B8824
-3C564B6C5B7975DEF3DBC7C541E4C83B55AEE3B44A989CB577B6C7D3B583463D026EB8AAD908BFC8D9E4186AC7A7BA17D4C9
-C591E035FD9AB1325BB21544BB63F18BB499C8AF244CC92EE4497533B1A20E300C300A06082A864886F70D0307A42C302A30
-0CA00A06082B06010502030602300CA00A06082B06010502030601300CA00A06082B060105020306033100
\ No newline at end of file
+308203DD06092A864886F70D010702A08203CE308203CA0201033100308203BF06072B060105020301A08203B2048203AE308203AAA03C303AA005020306C39CA111180F32303135313231303032353031355AA20602046B22377FA3160414E592C909D320DD4CE1CCAA4708E8BC73D48D03BFA182032A308203263082021906072A8648CE3E02013082020C0282010100FFFFFFFFFFFFFFFFC90FDAA22168C234C4C6628B80DC1CD129024E088A67CC74020BBEA63B139B22514A08798E3404DDEF9519B3CD3A431B302B0A6DF25F14374FE1356D6D51C245E485B576625E7EC6F44C42E9A637ED6B0BFF5CB6F406B7EDEE386BFB5A899FA5AE9F24117C4B1FE649286651ECE45B3DC2007CB8A163BF0598DA48361C55D39A69163FA8FD24CF5F83655D23DCA3AD961C62F356208552BB9ED529077096966D670C354E4ABC9804F1746C08CA18217C32905E462E36CE3BE39E772C180E86039B2783A2EC07A28FB5C55DF06F4C52C9DE2BCBF6955817183995497CEA956AE515D2261898FA051015728E5A8AACAA68FFFFFFFFFFFFFFFF020102028201007FFFFFFFFFFFFFFFE487ED5110B4611A62633145C06E0E68948127044533E63A0105DF531D89CD9128A5043CC71A026EF7CA8CD9E69D218D98158536F92F8A1BA7F09AB6B6A8E122F242DABB312F3F637A262174D31BF6B585FFA
 E5B7A035BF6F71C35FDAD44CFD2D74F9208BE258FF324943328F6722D9EE1003E5C50B1DF82CC6D241B0E2AE9CD348B1FD47E9267AFC1B2AE91EE51D6CB0E3179AB1042A95DCF6A9483B84B4B36B3861AA7255E4C0278BA3604650C10BE19482F23171B671DF1CF3B960C074301CD93C1D17603D147DAE2AEF837A62964EF15E5FB4AAC0B8C1CCAA4BE754AB5728AE9130C4C7D02880AB9472D455655347FFFFFFFFFFFFFFF0382010500028201006C3C8337692B63F663AB2D953C5ADCE3DBC840339A426408761C1BCED206E84C9898B2D44F35A2F0D8604752B1530580DFEB3D7649D9736CA12DCAB7DAFA34A8C1C143A20FF7F9103B3FDEDC6208E39330BF0C3FA6BE6C3A6821270D194D9F27A80F0B8E4D6F59A75A0E384A588CFBECF75AC294D85AB8966BA26F49562C56F57C450CD1EACAD30F5994DAC89AB11D3229E9D1D6AAA4E80AEAD122115AA2A737DC82A70A99E6F50892135D5D50442B88243C564B6C5B7975DEF3DBC7C541E4C83B55AEE3B44A989CB577B6C7D3B583463D026EB8AAD908BFC8D9E4186AC7A7BA17D4C9C591E035FD9AB1325BB21544BB63F18BB499C8AF244CC92EE4497533B1A20E300C300A06082A864886F70D0307A42C302A300CA00A06082B06010502030602300CA00A06082B06010502030601300CA00A06082B060105020306033100
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/dc1e2169/kerby-tool/client-tool/pom.xml
----------------------------------------------------------------------
diff --git a/kerby-tool/client-tool/pom.xml b/kerby-tool/client-tool/pom.xml
index ac5bdbc..b6fb6d1 100644
--- a/kerby-tool/client-tool/pom.xml
+++ b/kerby-tool/client-tool/pom.xml
@@ -49,11 +49,6 @@
     </dependency>
     <dependency>
       <groupId>org.apache.kerby</groupId>
-      <artifactId>pki-provider</artifactId>
-      <version>${project.version}</version>
-    </dependency>
-    <dependency>
-      <groupId>org.apache.kerby</groupId>
       <artifactId>kerb-util</artifactId>
       <version>${project.version}</version>
     </dependency>


Mime
View raw message