Return-Path: X-Original-To: apmail-directory-commits-archive@www.apache.org Delivered-To: apmail-directory-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2FFF17268 for ; Tue, 20 Oct 2015 19:33:01 +0000 (UTC) Received: (qmail 61126 invoked by uid 500); 20 Oct 2015 19:33:01 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 61077 invoked by uid 500); 20 Oct 2015 19:33:01 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 61068 invoked by uid 99); 20 Oct 2015 19:33:01 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 19:33:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4E1BE1A2C86 for ; Tue, 20 Oct 2015 19:33:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.79 X-Spam-Level: * X-Spam-Status: No, score=1.79 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id N5jQzz2MfY-E for ; Tue, 20 Oct 2015 19:33:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id E2E4C2303B for ; Tue, 20 Oct 2015 19:32:59 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D10ADE046C for ; Tue, 20 Oct 2015 19:32:57 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 3A92D3A0018 for ; Tue, 20 Oct 2015 19:32:58 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1709668 - in /directory/shared/trunk/ldap: extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/ extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/ model/src/main/java/org/apache/di... Date: Tue, 20 Oct 2015 19:32:57 -0000 To: commits@directory.apache.org From: elecharny@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20151020193258.3A92D3A0018@svn01-us-west.apache.org> Author: elecharny Date: Tue Oct 20 19:32:57 2015 New Revision: 1709668 URL: http://svn.apache.org/viewvc?rev=1709668&view=rev Log: o Removed the useless methods setValues/hasValues o Added some Javadoc @InheritDoc and @Override for completeness Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java?rev=1709668&r1=1709667&r2=1709668&view=diff ============================================================================== --- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java (original) +++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java Tue Oct 20 19:32:57 2015 @@ -47,15 +47,4 @@ public class AdShowDeletedImpl extends A super( OID ); setCritical( isCritical ); } - - - public void setValue( byte[] value ) - { - } - - - public boolean hasValue() - { - return false; - } } \ No newline at end of file Modified: directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java?rev=1709668&r1=1709667&r2=1709668&view=diff ============================================================================== --- directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java (original) +++ directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java Tue Oct 20 19:32:57 2015 @@ -32,7 +32,7 @@ import org.apache.directory.api.ldap.ext /** - * The Active Directory Deleted control decorator. + * The Active Directory Show Deleted control decorator. * * @author Apache Directory Project */ @@ -56,12 +56,19 @@ public class AdShowDeletedDecorator exte } + /** + * {@inheritDoc} + */ + @Override public Asn1Object decode( byte[] controlBytes ) throws DecoderException { return this; } + /** + * {@inheritDoc} + */ @Override public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException { Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java?rev=1709668&r1=1709667&r2=1709668&view=diff ============================================================================== --- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java (original) +++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java Tue Oct 20 19:32:57 2015 @@ -45,15 +45,4 @@ public class CascadeImpl extends Abstrac super( OID ); setCritical( isCritical ); } - - - public void setValue( byte[] value ) - { - } - - - public boolean hasValue() - { - return false; - } } \ No newline at end of file