directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r1709668 - in /directory/shared/trunk/ldap: extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/ extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/ model/src/main/java/org/apache/di...
Date Tue, 20 Oct 2015 19:32:57 GMT
Author: elecharny
Date: Tue Oct 20 19:32:57 2015
New Revision: 1709668

URL: http://svn.apache.org/viewvc?rev=1709668&view=rev
Log:
o Removed the useless methods setValues/hasValues
o Added some Javadoc @InheritDoc and @Override for completeness

Modified:
    directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java
    directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java
    directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java

Modified: directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java?rev=1709668&r1=1709667&r2=1709668&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java
(original)
+++ directory/shared/trunk/ldap/extras/codec-api/src/main/java/org/apache/directory/api/ldap/extras/controls/ad/AdShowDeletedImpl.java
Tue Oct 20 19:32:57 2015
@@ -47,15 +47,4 @@ public class AdShowDeletedImpl extends A
         super( OID );
         setCritical( isCritical );
     }
-
-
-    public void setValue( byte[] value )
-    {
-    }
-
-
-    public boolean hasValue()
-    {
-        return false;
-    }
 }
\ No newline at end of file

Modified: directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java?rev=1709668&r1=1709667&r2=1709668&view=diff
==============================================================================
--- directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java
(original)
+++ directory/shared/trunk/ldap/extras/codec/src/main/java/org/apache/directory/api/ldap/extras/controls/ad_impl/AdShowDeletedDecorator.java
Tue Oct 20 19:32:57 2015
@@ -32,7 +32,7 @@ import org.apache.directory.api.ldap.ext
 
 
 /**
- * The Active Directory Deleted control decorator.
+ * The Active Directory Show Deleted control decorator.
  * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
@@ -56,12 +56,19 @@ public class AdShowDeletedDecorator exte
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
+    @Override
     public Asn1Object decode( byte[] controlBytes ) throws DecoderException
     {
         return this;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     @Override
     public ByteBuffer encode( ByteBuffer buffer ) throws EncoderException
     {

Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java?rev=1709668&r1=1709667&r2=1709668&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java
(original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/CascadeImpl.java
Tue Oct 20 19:32:57 2015
@@ -45,15 +45,4 @@ public class CascadeImpl extends Abstrac
         super( OID );
         setCritical( isCritical );
     }
-
-
-    public void setValue( byte[] value )
-    {
-    }
-
-
-    public boolean hasValue()
-    {
-        return false;
-    }
 }
\ No newline at end of file



Mime
View raw message