directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Seelmann <m...@stefan-seelmann.de>
Subject Re: [1/2] directory-kerby git commit: DIRKRB-321 Removing Page and Sort Search in the backend. Contributed by Yaning
Date Sat, 25 Jul 2015 22:13:12 GMT
Hi,

I just wanted to ask if disabling of checkstyle plugin has been done
accidentally, or on purpose? There are now 27 new checkstyle violations
in code but not detected.

Kind Regards,
Stefan

> http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/8f88bca1/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index a6a3327..f292cc3 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -219,17 +219,8 @@
>              <configLocation>${checkstyle.dir}/kerby-checkstyle.xml</configLocation>
>              <includeTestSourceDirectory>true</includeTestSourceDirectory>
>              <encoding>UTF-8</encoding>
> -            <failOnViolation>true</failOnViolation>
> +            <failOnViolation>false</failOnViolation>
>            </configuration>
> -          <executions>
> -            <execution>
> -              <id>validate</id>
> -              <phase>validate</phase>
> -              <goals>
> -                <goal>check</goal>
> -              </goals>
> -            </execution>
> -          </executions>
>          </plugin>
>  
>        </plugins>
> @@ -284,7 +275,7 @@
>        </properties>
>      </profile>
>      <profile>
> -      <id>activate-checkstyle-in-module</id>
> +      <id>activate-in-module</id>
>        <activation>
>          <file>
>            <exists>${basedir}/../docs/kerby-checkstyle.xml</exists>
> @@ -295,7 +286,7 @@
>        </properties>
>      </profile>
>      <profile>
> -      <id>activate-checkstyle-in-submodule</id>
> +      <id>activate-in-submodule</id>
>        <activation>
>          <file>
>            <exists>${basedir}/../../docs/kerby-checkstyle.xml</exists>
> @@ -305,6 +296,7 @@
>          <checkstyle.dir>${basedir}/../../docs</checkstyle.dir>
>        </properties>
>      </profile>
> +
>      <profile>
>        <id>activate-checkstyle-supression</id>
>        <activation>
> 


Mime
View raw message