directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From seelm...@apache.org
Subject svn commit: r1692018 - in /directory/shared/trunk/ldap/client/api/src: checkstyle/ main/java/org/apache/directory/ldap/client/api/ main/java/org/apache/directory/ldap/client/api/search/ main/java/org/apache/directory/ldap/client/template/
Date Mon, 20 Jul 2015 20:03:18 GMT
Author: seelmann
Date: Mon Jul 20 20:03:17 2015
New Revision: 1692018

URL: http://svn.apache.org/r1692018
Log:
Fix checkstyle violations

Added:
    directory/shared/trunk/ldap/client/api/src/checkstyle/
    directory/shared/trunk/ldap/client/api/src/checkstyle/suppressions.xml   (with props)
Modified:
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultLdapConnectionFactory.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultSchemaLoader.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionPool.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeDescriptionFilter.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeValueAssertionFilter.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/MatchingRuleAssertionFilterBuilder.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SetOfFiltersFilter.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SubstringFilter.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java

Added: directory/shared/trunk/ldap/client/api/src/checkstyle/suppressions.xml
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/checkstyle/suppressions.xml?rev=1692018&view=auto
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/checkstyle/suppressions.xml (added)
+++ directory/shared/trunk/ldap/client/api/src/checkstyle/suppressions.xml Mon Jul 20 20:03:17
2015
@@ -0,0 +1,30 @@
+<?xml version="1.0"?>
+
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+  
+  http://www.apache.org/licenses/LICENSE-2.0
+  
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+<!DOCTYPE suppressions PUBLIC
+    "-//Puppy Crawl//DTD Suppressions 1.1//EN"
+    "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+
+<suppressions>
+
+  <suppress files="org.apache.directory.ldap.client.api.LdapNetworkConnection" checks="FileLength"/>
+
+</suppressions>

Propchange: directory/shared/trunk/ldap/client/api/src/checkstyle/suppressions.xml
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: directory/shared/trunk/ldap/client/api/src/checkstyle/suppressions.xml
------------------------------------------------------------------------------
    svn:mime-type = text/xml

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultLdapConnectionFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultLdapConnectionFactory.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultLdapConnectionFactory.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultLdapConnectionFactory.java
Mon Jul 20 20:03:17 2015
@@ -37,7 +37,7 @@ import org.slf4j.LoggerFactory;
  */
 public class DefaultLdapConnectionFactory implements LdapConnectionFactory
 {
-    private static Logger LOG = LoggerFactory.getLogger( DefaultLdapConnectionFactory.class
);
+    private static final Logger LOG = LoggerFactory.getLogger( DefaultLdapConnectionFactory.class
);
 
     private LdapApiService apiService;
     private LdapConnectionConfig connectionConfig;

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultSchemaLoader.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultSchemaLoader.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultSchemaLoader.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/DefaultSchemaLoader.java
Mon Jul 20 20:03:17 2015
@@ -90,18 +90,18 @@ public class DefaultSchemaLoader extends
     private Dn subschemaSubentryDn;
 
     /** The SubschemaSubentry descriptions parsers */
-    private static AttributeTypeDescriptionSchemaParser AT_DESCR_SCHEMA_PARSER = new AttributeTypeDescriptionSchemaParser();
-    private static DitStructureRuleDescriptionSchemaParser DSR_DESCR_SCHEMA_PARSER = new
DitStructureRuleDescriptionSchemaParser();
-    private static DitContentRuleDescriptionSchemaParser DCR_DESCR_SCHEMA_PARSER = new DitContentRuleDescriptionSchemaParser();
-    private static MatchingRuleDescriptionSchemaParser MR_DESCR_SCHEMA_PARSER = new MatchingRuleDescriptionSchemaParser();
-    private static MatchingRuleUseDescriptionSchemaParser MRU_DESCR_SCHEMA_PARSER = new MatchingRuleUseDescriptionSchemaParser();
-    private static NameFormDescriptionSchemaParser NF_DESCR_SCHEMA_PARSER = new NameFormDescriptionSchemaParser();
-    private static ObjectClassDescriptionSchemaParser OC_DESCR_SCHEMA_PARSER = new ObjectClassDescriptionSchemaParser();
-    private static LdapSyntaxDescriptionSchemaParser LS_DESCR_SCHEMA_PARSER = new LdapSyntaxDescriptionSchemaParser();
+    private static final AttributeTypeDescriptionSchemaParser AT_DESCR_SCHEMA_PARSER = new
AttributeTypeDescriptionSchemaParser();
+    private static final DitStructureRuleDescriptionSchemaParser DSR_DESCR_SCHEMA_PARSER
= new DitStructureRuleDescriptionSchemaParser();
+    private static final DitContentRuleDescriptionSchemaParser DCR_DESCR_SCHEMA_PARSER =
new DitContentRuleDescriptionSchemaParser();
+    private static final MatchingRuleDescriptionSchemaParser MR_DESCR_SCHEMA_PARSER = new
MatchingRuleDescriptionSchemaParser();
+    private static final MatchingRuleUseDescriptionSchemaParser MRU_DESCR_SCHEMA_PARSER =
new MatchingRuleUseDescriptionSchemaParser();
+    private static final NameFormDescriptionSchemaParser NF_DESCR_SCHEMA_PARSER = new NameFormDescriptionSchemaParser();
+    private static final ObjectClassDescriptionSchemaParser OC_DESCR_SCHEMA_PARSER = new
ObjectClassDescriptionSchemaParser();
+    private static final LdapSyntaxDescriptionSchemaParser LS_DESCR_SCHEMA_PARSER = new LdapSyntaxDescriptionSchemaParser();
 
-    private static LdapComparatorDescriptionSchemaParser C_DESCR_SCHEMA_PARSER = new LdapComparatorDescriptionSchemaParser();
-    private static NormalizerDescriptionSchemaParser N_DESCR_SCHEMA_PARSER = new NormalizerDescriptionSchemaParser();
-    private static SyntaxCheckerDescriptionSchemaParser SC_DESCR_SCHEMA_PARSER = new SyntaxCheckerDescriptionSchemaParser();
+    private static final LdapComparatorDescriptionSchemaParser C_DESCR_SCHEMA_PARSER = new
LdapComparatorDescriptionSchemaParser();
+    private static final NormalizerDescriptionSchemaParser N_DESCR_SCHEMA_PARSER = new NormalizerDescriptionSchemaParser();
+    private static final SyntaxCheckerDescriptionSchemaParser SC_DESCR_SCHEMA_PARSER = new
SyntaxCheckerDescriptionSchemaParser();
 
 
     /**

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionConfig.java
Mon Jul 20 20:03:17 2015
@@ -133,7 +133,7 @@ public class LdapConnectionConfig
             TrustManagerFactory tmFactory = TrustManagerFactory.getInstance( trustMgmtAlgo
);
             tmFactory.init( ( KeyStore ) null );
 
-            TrustManager factoryTrustManagers[] = tmFactory.getTrustManagers();
+            TrustManager[] factoryTrustManagers = tmFactory.getTrustManagers();
 
             for ( int i = 0; i < factoryTrustManagers.length; i++ )
             {

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionPool.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionPool.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionPool.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapConnectionPool.java
Mon Jul 20 20:03:17 2015
@@ -39,7 +39,7 @@ import org.slf4j.LoggerFactory;
  */
 public class LdapConnectionPool extends GenericObjectPool<LdapConnection>
 {
-    private static Logger LOG = LoggerFactory.getLogger( LdapConnectionPool.class );
+    private static final Logger LOG = LoggerFactory.getLogger( LdapConnectionPool.class );
 
     private PoolableObjectFactory<LdapConnection> factory;
 

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
Mon Jul 20 20:03:17 2015
@@ -3474,14 +3474,14 @@ public class LdapNetworkConnection exten
 
         Attribute attr = rootDse.get( SchemaConstants.SUPPORTED_CONTROL_AT );
 
-        if (attr == null) 
+        if ( attr == null )
         {
             // Unlikely. Perhaps the server does not respond properly to "+" attribute query
             // (such as 389ds server). So let's try again and let's be more explicit.
             fetchRootDSE( SchemaConstants.ALL_USER_ATTRIBUTES, 
                 SchemaConstants.ALL_OPERATIONAL_ATTRIBUTES, SchemaConstants.SUPPORTED_CONTROL_AT
);
             attr = rootDse.get( SchemaConstants.SUPPORTED_CONTROL_AT );
-            if (attr == null) 
+            if ( attr == null )
             {
                 return supportedControls;
             }
@@ -3622,23 +3622,26 @@ public class LdapNetworkConnection exten
      * fetches the rootDSE from the server
      * @throws LdapException
      */
-    private void fetchRootDSE(String... explicitAttributes) throws LdapException
+    private void fetchRootDSE( String... explicitAttributes ) throws LdapException
     {
         EntryCursor cursor = null;
 
         String[] attributes = explicitAttributes;
-        if (attributes.length == 0) {
-            attributes = new String[] { SchemaConstants.ALL_USER_ATTRIBUTES, SchemaConstants.ALL_OPERATIONAL_ATTRIBUTES
};
+        if ( attributes.length == 0 )
+        {
+            attributes = new String[]
+                { SchemaConstants.ALL_USER_ATTRIBUTES, SchemaConstants.ALL_OPERATIONAL_ATTRIBUTES
};
         }
         
         try
         {
-            cursor = search( "", LdapConstants.OBJECT_CLASS_STAR, SearchScope.OBJECT,
-            		attributes );
-            if ( cursor.next() ) 
+            cursor = search( "", LdapConstants.OBJECT_CLASS_STAR, SearchScope.OBJECT, attributes
);
+            if ( cursor.next() )
             {
                 rootDse = cursor.get();
-            } else {
+            }
+            else
+            {
                 throw new LdapException( "Search for root DSE returned no entry" );
             }
         }

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdifAnonymizer.java
Mon Jul 20 20:03:17 2015
@@ -198,15 +198,6 @@ public class LdifAnonymizer
     }
 
 
-    public LdifAnonymizer( Map<String, Anonymizer> attributeAnonymizers )
-    {
-        for ( String attributeId : attributeAnonymizers.keySet() )
-        {
-
-        }
-    }
-
-
     /**
      * {@inheritDoc}
      */

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeDescriptionFilter.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeDescriptionFilter.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeDescriptionFilter.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeDescriptionFilter.java
Mon Jul 20 20:03:17 2015
@@ -25,7 +25,7 @@ package org.apache.directory.ldap.client
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-/* No qualifier*/class AttributeDescriptionFilter extends AbstractFilter
+/* No qualifier*/final class AttributeDescriptionFilter extends AbstractFilter
 {
     /** The attribute that must be prersent */
     private String attribute;

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeValueAssertionFilter.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeValueAssertionFilter.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeValueAssertionFilter.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/AttributeValueAssertionFilter.java
Mon Jul 20 20:03:17 2015
@@ -28,7 +28,7 @@ import org.apache.directory.api.ldap.mod
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-/* No qualifier*/class AttributeValueAssertionFilter extends AbstractFilter
+/* No qualifier*/final class AttributeValueAssertionFilter extends AbstractFilter
 {
     /** The associated attribute */
     private String attribute;

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/MatchingRuleAssertionFilterBuilder.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/MatchingRuleAssertionFilterBuilder.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/MatchingRuleAssertionFilterBuilder.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/MatchingRuleAssertionFilterBuilder.java
Mon Jul 20 20:03:17 2015
@@ -46,7 +46,7 @@ public class MatchingRuleAssertionFilter
      */
     public MatchingRuleAssertionFilterBuilder setMatchingRule( String matchingRule )
     {
-        ((MatchingRuleAssertionFilter)filter).setMatchingRule( matchingRule );
+        ( ( MatchingRuleAssertionFilter ) filter ).setMatchingRule( matchingRule );
         return this;
     }
     
@@ -58,7 +58,7 @@ public class MatchingRuleAssertionFilter
      */
     public MatchingRuleAssertionFilterBuilder useDnAttributes()
     {
-        ((MatchingRuleAssertionFilter)filter).useDnAttributes();
+        ( ( MatchingRuleAssertionFilter ) filter ).useDnAttributes();
         return this;
     }
 }
\ No newline at end of file

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SetOfFiltersFilter.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SetOfFiltersFilter.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SetOfFiltersFilter.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SetOfFiltersFilter.java
Mon Jul 20 20:03:17 2015
@@ -29,7 +29,7 @@ import java.util.List;
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-/* No qualifier*/class SetOfFiltersFilter extends AbstractFilter
+/* No qualifier*/final class SetOfFiltersFilter extends AbstractFilter
 {
     /** The operator to use with this set (AND or OR) */
     private FilterOperator operator;

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SubstringFilter.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SubstringFilter.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SubstringFilter.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/SubstringFilter.java
Mon Jul 20 20:03:17 2015
@@ -32,7 +32,7 @@ import org.apache.directory.api.util.Str
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-class SubstringFilter extends AbstractFilter
+final class SubstringFilter extends AbstractFilter
 {
     /** The AttributeType for this filter */
     private String attribute;

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/search/UnaryFilter.java
Mon Jul 20 20:03:17 2015
@@ -25,7 +25,7 @@ package org.apache.directory.ldap.client
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-/* No qualifier*/class UnaryFilter extends AbstractFilter
+/* No qualifier*/final class UnaryFilter extends AbstractFilter
 {
     /** The NOT filter */
     private Filter filter;

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/LdapConnectionTemplate.java
Mon Jul 20 20:03:17 2015
@@ -63,7 +63,7 @@ import org.slf4j.LoggerFactory;
  */
 public class LdapConnectionTemplate implements LdapConnectionOperations, ModelFactory
 {
-    private static Logger LOG = LoggerFactory.getLogger( LdapConnectionTemplate.class );
+    private static final Logger LOG = LoggerFactory.getLogger( LdapConnectionTemplate.class
);
     private static final EntryMapper<Dn> DN_ENTRY_MAPPER = new EntryMapper<Dn>()
     {
         @Override

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/MemoryClearingBuffer.java
Mon Jul 20 20:03:17 2015
@@ -34,7 +34,7 @@ import java.util.Arrays;
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-public class MemoryClearingBuffer
+public final class MemoryClearingBuffer
 {
     private static final Charset UTF8 = Charset.forName( "UTF-8" );
     private byte[] computedBytes;
@@ -66,14 +66,18 @@ public class MemoryClearingBuffer
                 for ( ; startIndex < working.length; startIndex++ )
                 {
                     if ( !Character.isWhitespace( working[startIndex] ) )
+                    {
                         break;
+                    }
                 }
 
                 // rtrim
                 for ( endIndex--; endIndex > startIndex; endIndex-- )
                 {
                     if ( !Character.isWhitespace( working[endIndex] ) )
+                    {
                         break;
+                    }
                 }
                 endIndex++;
             }

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java?rev=1692018&r1=1692017&r2=1692018&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/template/PasswordWarningImpl.java
Mon Jul 20 20:03:17 2015
@@ -31,7 +31,7 @@ import org.apache.directory.api.ldap.ext
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-class PasswordWarningImpl implements PasswordWarning
+final class PasswordWarningImpl implements PasswordWarning
 {
     private static final long serialVersionUID = -8952246313604352357L;
 
@@ -53,8 +53,7 @@ class PasswordWarningImpl implements Pas
             PasswordWarningImpl policyWarning = new PasswordWarningImpl();
             policyWarning.timeBeforeExpiration = response.getTimeBeforeExpiration();
             policyWarning.graceAuthNsRemaining = response.getGraceAuthNRemaining();
-            policyWarning.changeAfterReset = response.getPasswordPolicyError() ==
-                PasswordPolicyErrorEnum.CHANGE_AFTER_RESET;
+            policyWarning.changeAfterReset = response.getPasswordPolicyError() == PasswordPolicyErrorEnum.CHANGE_AFTER_RESET;
 
             if ( policyWarning.timeBeforeExpiration >= 0 || policyWarning.graceAuthNsRemaining
>= 0
                 || policyWarning.changeAfterReset )



Mime
View raw message