directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smckin...@apache.org
Subject directory-fortress-core git commit: FC-109 - replace !isNotEmpty with isEmpty
Date Wed, 03 Jun 2015 15:26:43 GMT
Repository: directory-fortress-core
Updated Branches:
  refs/heads/1.0-RC41 ae72bf061 -> 2ba96f0af


FC-109 - replace !isNotEmpty with isEmpty


Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/commit/2ba96f0a
Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/tree/2ba96f0a
Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/diff/2ba96f0a

Branch: refs/heads/1.0-RC41
Commit: 2ba96f0afa6e1a73d62e43fbe54d9cbc1f1a0422
Parents: ae72bf0
Author: Shawn McKinney <smckinney@apache.org>
Authored: Wed Jun 3 10:26:50 2015 -0500
Committer: Shawn McKinney <smckinney@apache.org>
Committed: Wed Jun 3 10:26:50 2015 -0500

----------------------------------------------------------------------
 .../fortress/core/AccelMgrFactory.java          |  2 +-
 .../fortress/core/AccessMgrFactory.java         |  2 +-
 .../fortress/core/AdminMgrFactory.java          |  2 +-
 .../fortress/core/AuditMgrFactory.java          |  2 +-
 .../fortress/core/DelAccessMgrFactory.java      |  2 +-
 .../fortress/core/DelReviewMgrFactory.java      |  2 +-
 .../fortress/core/PwPolicyMgrFactory.java       |  2 +-
 .../fortress/core/ReviewMgrFactory.java         |  2 +-
 .../fortress/core/ant/FortressAntTask.java      |  2 +-
 .../fortress/core/impl/AdminRoleP.java          |  4 +-
 .../directory/fortress/core/impl/ConfigP.java   |  4 +-
 .../fortress/core/impl/OrganizationalUnitP.java |  2 +-
 .../fortress/core/impl/SetAdapter.java          | 77 --------------------
 .../directory/fortress/core/impl/SuffixP.java   |  4 +-
 .../directory/fortress/core/impl/UserDAO.java   |  4 +-
 .../directory/fortress/core/impl/UserP.java     |  6 +-
 .../directory/fortress/core/util/VUtil.java     |  8 +-
 .../fortress/core/jmeter/CheckAccess.java       |  2 +-
 18 files changed, 26 insertions(+), 103 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java
index 1818acf..b85312d 100644
--- a/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/AccelMgrFactory.java
@@ -64,7 +64,7 @@ public final class AccelMgrFactory
     {
         VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
         AccelMgr accelMgr;
-        if (!StringUtils.isNotEmpty( accelClassName ))
+        if ( StringUtils.isEmpty( accelClassName ) )
         {
             accelMgr = new AccelMgrImpl();
         }

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java
index 0bd546e..69c0896 100755
--- a/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/AccessMgrFactory.java
@@ -65,7 +65,7 @@ public final class AccessMgrFactory
         VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
 
         AccessMgr accessMgr;
-        if (!StringUtils.isNotEmpty( accessClassName ))
+        if ( StringUtils.isEmpty( accessClassName ) )
         {
             if(GlobalIds.IS_REST)
             {

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java
index 48b9408..a258289 100755
--- a/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/AdminMgrFactory.java
@@ -68,7 +68,7 @@ public final class AdminMgrFactory
         VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
         AdminMgr adminMgr;
 
-        if (!StringUtils.isNotEmpty( adminClassName ))
+        if ( StringUtils.isEmpty( adminClassName ) )
         {
             if(GlobalIds.IS_REST)
             {

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java
index b6b64b7..a769c33 100755
--- a/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/AuditMgrFactory.java
@@ -66,7 +66,7 @@ public final class AuditMgrFactory
         VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
         AuditMgr auditMgr;
 
-        if (!StringUtils.isNotEmpty( auditClassName ))
+        if ( StringUtils.isEmpty( auditClassName ) )
         {
             if(GlobalIds.IS_REST)
             {

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java
index b896556..d86fb6f 100755
--- a/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/DelAccessMgrFactory.java
@@ -67,7 +67,7 @@ public final class DelAccessMgrFactory
         VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
         DelAccessMgr accessMgr;
 
-        if (!StringUtils.isNotEmpty( accessClassName ))
+        if ( StringUtils.isEmpty( accessClassName ) )
         {
             if(GlobalIds.IS_REST)
             {

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java
index b194640..8401a4d 100755
--- a/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/DelReviewMgrFactory.java
@@ -66,7 +66,7 @@ public final class DelReviewMgrFactory
         VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
         DelReviewMgr delReviewMgr;
 
-        if (!StringUtils.isNotEmpty( dReviewClassName ))
+        if ( StringUtils.isEmpty( dReviewClassName ) )
         {
             if(GlobalIds.IS_REST)
             {

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java
index 78ccc80..9bdd43a 100755
--- a/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/PwPolicyMgrFactory.java
@@ -66,7 +66,7 @@ public final class PwPolicyMgrFactory
         VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
         PwPolicyMgr policyMgr;
 
-        if (!StringUtils.isNotEmpty( policyClassName ))
+        if ( StringUtils.isEmpty( policyClassName ) )
         {
             if(GlobalIds.IS_REST)
             {

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java b/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java
index 6f6f007..1a84a01 100755
--- a/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java
+++ b/src/main/java/org/apache/directory/fortress/core/ReviewMgrFactory.java
@@ -66,7 +66,7 @@ public final class ReviewMgrFactory
         VUtil.assertNotNull(contextId, GlobalErrIds.CONTEXT_NULL, CLS_NM + ".createInstance");
         ReviewMgr reviewMgr;
 
-        if (!StringUtils.isNotEmpty( reviewClassName ))
+        if ( StringUtils.isEmpty( reviewClassName ) )
         {
             if(GlobalIds.IS_REST)
             {

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/ant/FortressAntTask.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/ant/FortressAntTask.java b/src/main/java/org/apache/directory/fortress/core/ant/FortressAntTask.java
index ed896ec..13647d6 100755
--- a/src/main/java/org/apache/directory/fortress/core/ant/FortressAntTask.java
+++ b/src/main/java/org/apache/directory/fortress/core/ant/FortressAntTask.java
@@ -857,7 +857,7 @@ public class FortressAntTask extends Task implements InputHandler
             try
             {
                 String testClassName = Config.getProperty( getTaskName() );
-                if ( !StringUtils.isNotEmpty( testClassName ) )
+                if ( StringUtils.isEmpty( testClassName ) )
                 {
                     testClassName = "org.apache.directory.fortress.core.impl.FortressAntLoadTest";
                 }

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleP.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleP.java b/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleP.java
index 660eccc..610613c 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleP.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/AdminRoleP.java
@@ -335,13 +335,13 @@ public final class AdminRoleP
                 throw new SecurityException( GlobalErrIds.ARLE_INVLD_RANGE, error );
             }
         }
-        else if ( !StringUtils.isNotEmpty( entity.getBeginRange() ) && StringUtils.isNotEmpty(
entity.getEndRange() ) )
+        else if ( StringUtils.isEmpty( entity.getBeginRange() ) && StringUtils.isNotEmpty(
entity.getEndRange() ) )
         {
             String error = "validate role name [" + entity.getName() + "] begin range value
null or empty.";
             LOG.warn( error );
             throw new SecurityException( GlobalErrIds.ARLE_BEGIN_RANGE_NULL, error );
         }
-        else if ( StringUtils.isNotEmpty( entity.getBeginRange() ) && !StringUtils.isNotEmpty(
entity.getEndRange() ) )
+        else if ( StringUtils.isNotEmpty( entity.getBeginRange() ) && StringUtils.isEmpty(
entity.getEndRange() ) )
         {
             String error = "validate role name [" + entity.getName() + "] end range value
null or empty.";
             LOG.warn( error );

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/impl/ConfigP.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/ConfigP.java b/src/main/java/org/apache/directory/fortress/core/impl/ConfigP.java
index c78d5ea..f3a4321 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/ConfigP.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/ConfigP.java
@@ -123,7 +123,7 @@ final class ConfigP
     void delete( String name )
         throws SecurityException
     {
-        if ( !StringUtils.isNotEmpty( name ) )
+        if ( StringUtils.isEmpty( name ) )
         {
             String error = "delete detected null config realm name";
             LOG.warn( error );
@@ -179,7 +179,7 @@ final class ConfigP
     private void validate( String name, Properties entity )
         throws ValidationException
     {
-        if ( !StringUtils.isNotEmpty( name ) )
+        if ( StringUtils.isEmpty( name ) )
         {
             String error = "validate detected null config realm name";
             LOG.warn( error );

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/impl/OrganizationalUnitP.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/OrganizationalUnitP.java
b/src/main/java/org/apache/directory/fortress/core/impl/OrganizationalUnitP.java
index 3dc5f1e..1d5a5c0 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/OrganizationalUnitP.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/OrganizationalUnitP.java
@@ -122,7 +122,7 @@ public class OrganizationalUnitP
             throw new ValidationException( GlobalErrIds.CNTR_NAME_INVLD, error );
         }
         
-        if ( !StringUtils.isNotEmpty( entity.getName() ) )
+        if ( StringUtils.isEmpty( entity.getName() ) )
         {
             String error = "validate name validation failed, null or empty value";
             LOG.warn( error );

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/impl/SetAdapter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/SetAdapter.java b/src/main/java/org/apache/directory/fortress/core/impl/SetAdapter.java
deleted file mode 100755
index 4db75a6..0000000
--- a/src/main/java/org/apache/directory/fortress/core/impl/SetAdapter.java
+++ /dev/null
@@ -1,77 +0,0 @@
-/*
- *   Licensed to the Apache Software Foundation (ASF) under one
- *   or more contributor license agreements.  See the NOTICE file
- *   distributed with this work for additional information
- *   regarding copyright ownership.  The ASF licenses this file
- *   to you under the Apache License, Version 2.0 (the
- *   "License"); you may not use this file except in compliance
- *   with the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- *   Unless required by applicable law or agreed to in writing,
- *   software distributed under the License is distributed on an
- *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- *   KIND, either express or implied.  See the License for the
- *   specific language governing permissions and limitations
- *   under the License.
- *
- */
-package org.apache.directory.fortress.core.impl;
-
-import javax.xml.bind.annotation.adapters.XmlAdapter;
-import java.util.ArrayList;
-import java.util.Set;
-import java.util.TreeSet;
-
-/**
- * Created by IntelliJ IDEA.
- * User: Shawn McKinney
- * Date: 1/21/12
- * Time: 7:59 PM
- * To change this template use File | Settings | File Templates.
- */
-public class SetAdapter extends XmlAdapter<ArrayList<String>, Set<String>>
-{
-    public Set<String> unmarshal(ArrayList<String> val) throws Exception
-    {
-        Set<String> members = null;
-        if(val != null)
-        {
-            members = new TreeSet<>();
-            for(String member : val)
-            {
-                members.add(member);
-            }
-        }
-        return members;
-    }
-
-    public ArrayList<String> marshal(Set<String> val) throws Exception
-    {
-        ArrayList<String> members = null;
-        if(val != null)
-        {
-            members = new ArrayList<>();
-            for(String member : val)
-            {
-                members.add(member);
-            }
-        }
-        return members;
-    }
-}
-
-
-/*
-    public char[] unmarshal(String val) throws Exception
-    {
-        return val.toCharArray();
-    }
-
-    public String marshal(char[] val) throws Exception
-    {
-        return val.toString();
-    }
-
- */

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/impl/SuffixP.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/SuffixP.java b/src/main/java/org/apache/directory/fortress/core/impl/SuffixP.java
index b936480..6bf40e9 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/SuffixP.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/SuffixP.java
@@ -120,7 +120,7 @@ public class SuffixP
             LOG.warn( error );
             throw new ValidationException( GlobalErrIds.SUFX_NAME_INVLD, error );
         }
-        if ( !StringUtils.isNotEmpty( entity.getName() ) )
+        if ( StringUtils.isEmpty( entity.getName() ) )
         {
             String error = "validate name validation failed, null or empty value";
             LOG.warn( error );
@@ -133,7 +133,7 @@ public class SuffixP
             LOG.warn( error );
             throw new ValidationException( GlobalErrIds.SUFX_DCTOP_INVLD, error );
         }
-        if ( !StringUtils.isNotEmpty( entity.getDc() ) )
+        if ( StringUtils.isEmpty( entity.getDc() ) )
         {
             String error = "validate dc validation failed, null or empty value";
             LOG.warn( error );

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/impl/UserDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/UserDAO.java b/src/main/java/org/apache/directory/fortress/core/impl/UserDAO.java
index ba41b37..b17d7d4 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/UserDAO.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/UserDAO.java
@@ -416,7 +416,7 @@ final class UserDAO extends ApacheDsDataProvider
             myEntry.add( SchemaConstants.UID_AT, entity.getUserId() );
 
             // CN is required on inetOrgPerson object class, if caller did not set, use the
userId:
-            if ( !StringUtils.isNotEmpty( entity.getCn() ) )
+            if ( StringUtils.isEmpty( entity.getCn() ) )
             {
                 entity.setCn( entity.getUserId() );
             }
@@ -424,7 +424,7 @@ final class UserDAO extends ApacheDsDataProvider
             myEntry.add( SchemaConstants.CN_AT, entity.getCn() );
 
             // SN is required on inetOrgPerson object class, if caller did not set, use the
userId:
-            if ( !StringUtils.isNotEmpty( entity.getSn() ) )
+            if ( StringUtils.isEmpty( entity.getSn() ) )
             {
                 entity.setSn( entity.getUserId() );
             }

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/impl/UserP.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/impl/UserP.java b/src/main/java/org/apache/directory/fortress/core/impl/UserP.java
index 4141764..efee0b9 100755
--- a/src/main/java/org/apache/directory/fortress/core/impl/UserP.java
+++ b/src/main/java/org/apache/directory/fortress/core/impl/UserP.java
@@ -718,11 +718,11 @@ final class UserP
      */
     private void validate( UserRole uRole ) throws ValidationException
     {
-        if ( !StringUtils.isNotEmpty( uRole.getUserId() ) )
+        if ( StringUtils.isEmpty( uRole.getUserId() ) )
         {
             throw new ValidationException( GlobalErrIds.USER_ID_NULL, CLS_NM + ".validate
userId is NULL" );
         }
-        if ( !StringUtils.isNotEmpty( uRole.getName() ) )
+        if ( StringUtils.isEmpty( uRole.getName() ) )
         {
             throw new ValidationException( GlobalErrIds.ROLE_NM_NULL, CLS_NM + ".validate
name is NULL" );
         }
@@ -764,7 +764,7 @@ final class UserP
                 VUtil.password( entity.getPassword() );
             }
             // the OU attribute is required:
-            if ( !StringUtils.isNotEmpty( entity.getOu() ) )
+            if ( StringUtils.isEmpty( entity.getOu() ) )
             {
                 String error = "OU validation failed, null or empty value";
                 throw new ValidationException( GlobalErrIds.ORG_NULL_USER, error );

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/main/java/org/apache/directory/fortress/core/util/VUtil.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/core/util/VUtil.java b/src/main/java/org/apache/directory/fortress/core/util/VUtil.java
index 849c67e..35d12a3 100755
--- a/src/main/java/org/apache/directory/fortress/core/util/VUtil.java
+++ b/src/main/java/org/apache/directory/fortress/core/util/VUtil.java
@@ -101,7 +101,7 @@ public final class VUtil
      */
     public static void orgUnit( String orgUnitId ) throws ValidationException
     {
-        if ( !StringUtils.isNotEmpty( orgUnitId ) )
+        if ( StringUtils.isEmpty( orgUnitId ) )
         {
             String error = "orgUnit is null";
             throw new ValidationException( GlobalErrIds.ORG_NULL, error );
@@ -163,7 +163,7 @@ public final class VUtil
      */
     public static void safeText( String value, int validLen ) throws ValidationException
     {
-        if ( !StringUtils.isNotEmpty( value ) )
+        if ( StringUtils.isEmpty( value ) )
         {
             String error = "safeText null value";
             throw new ValidationException( GlobalErrIds.CONST_NULL_TEXT, error );
@@ -189,7 +189,7 @@ public final class VUtil
      */
     public static void userId( String userId ) throws ValidationException
     {
-        if ( !StringUtils.isNotEmpty( userId ) )
+        if ( StringUtils.isEmpty( userId ) )
         {
             String error = "userId validation failed, null or empty value";
             throw new ValidationException( GlobalErrIds.USER_ID_NULL, error );
@@ -467,7 +467,7 @@ public final class VUtil
     public static void assertNotNullOrEmpty( String value, int errorCode, String method )
         throws ValidationException
     {
-        if ( !StringUtils.isNotEmpty( value ) )
+        if ( StringUtils.isEmpty( value ) )
         {
             String error = "assertContext detected null entity for method [" + method + "],
error code ["
                 + errorCode + "]";

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/2ba96f0a/src/test/java/org/apache/directory/fortress/core/jmeter/CheckAccess.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/directory/fortress/core/jmeter/CheckAccess.java b/src/test/java/org/apache/directory/fortress/core/jmeter/CheckAccess.java
index 9665857..ba9eaff 100644
--- a/src/test/java/org/apache/directory/fortress/core/jmeter/CheckAccess.java
+++ b/src/test/java/org/apache/directory/fortress/core/jmeter/CheckAccess.java
@@ -161,7 +161,7 @@ public class CheckAccess extends AbstractJavaSamplerClient
     public void setupTest( JavaSamplerContext samplerContext )
     {
         ctr = 0;
-        if(!StringUtils.isNotEmpty( userId ))
+        if(StringUtils.isEmpty( userId ))
         {
             // Load userids are format:  loadtestuserN - where N is a number between 0 and
99.
             // i.e. loadtestuser0,  loadtestuser1,  ... loadtestuser99


Mime
View raw message