directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smckin...@apache.org
Subject directory-fortress-commander git commit: FC-105 - invokes inefficient construction of primitive
Date Sun, 24 May 2015 13:43:12 GMT
Repository: directory-fortress-commander
Updated Branches:
  refs/heads/master cb22ae575 -> ce0ed9c45


FC-105 - invokes inefficient construction of primitive


Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/commit/ce0ed9c4
Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/tree/ce0ed9c4
Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/diff/ce0ed9c4

Branch: refs/heads/master
Commit: ce0ed9c45e34b6a3e9c1f13f849ea233aba216d3
Parents: cb22ae5
Author: Shawn McKinney <smckinney@apache.org>
Authored: Sun May 24 08:42:59 2015 -0500
Committer: Shawn McKinney <smckinney@apache.org>
Committed: Sun May 24 08:42:59 2015 -0500

----------------------------------------------------------------------
 .../directory/fortress/web/panel/ConstraintBasePanel.java      | 6 +++---
 .../apache/directory/fortress/web/panel/GroupListPanel.java    | 4 ++--
 .../apache/directory/fortress/web/panel/ObjectListPanel.java   | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/blob/ce0ed9c4/src/main/java/org/apache/directory/fortress/web/panel/ConstraintBasePanel.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/web/panel/ConstraintBasePanel.java
b/src/main/java/org/apache/directory/fortress/web/panel/ConstraintBasePanel.java
index eb45b6d..61ac7ec 100644
--- a/src/main/java/org/apache/directory/fortress/web/panel/ConstraintBasePanel.java
+++ b/src/main/java/org/apache/directory/fortress/web/panel/ConstraintBasePanel.java
@@ -397,11 +397,11 @@ public class ConstraintBasePanel extends FormComponentPanel
             Calendar calendar = Calendar.getInstance();
             try
             {
-                int years = new Integer( szDate.substring( 0, 4 ) );
-                int months = new Integer( szDate.substring( 4, 6 ) );
+                int years = Integer.valueOf( szDate.substring( 0, 4 ) );
+                int months = Integer.valueOf( szDate.substring( 4, 6 ) );
                 // Convert months because the Calendar uses 0 - 11:
                 months = months - 1;
-                int days = new Integer( szDate.substring( 6, 8 ) );
+                int days = Integer.valueOf( szDate.substring( 6, 8 ) );
                 calendar.set( years, months, days, 0, 0 );
                 date = calendar.getTime();
             }

http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/blob/ce0ed9c4/src/main/java/org/apache/directory/fortress/web/panel/GroupListPanel.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/web/panel/GroupListPanel.java b/src/main/java/org/apache/directory/fortress/web/panel/GroupListPanel.java
index ec79c74..04841f4 100644
--- a/src/main/java/org/apache/directory/fortress/web/panel/GroupListPanel.java
+++ b/src/main/java/org/apache/directory/fortress/web/panel/GroupListPanel.java
@@ -90,9 +90,9 @@ public class GroupListPanel extends FormComponentPanel
         addGrid();
         radioGroup = new RadioGroup( "searchOptions", new PropertyModel( this, "selectedRadioButton"
) );
         add( radioGroup );
-        Radio groupRb = new Radio( "groupRb", new Model( new Character( NAMES ) ) );
+        Radio groupRb = new Radio( "groupRb", new Model( Character.valueOf( NAMES ) ) );
         radioGroup.add( groupRb );
-        Radio memberRb = new Radio( "memberRb", new Model( new Character( MEMBERS ) ) );
+        Radio memberRb = new Radio( "memberRb", new Model( Character.valueOf( MEMBERS ) )
);
         radioGroup.add( memberRb );
         addMemberSearchModal( memberRb );
         radioGroup.setOutputMarkupId( true );

http://git-wip-us.apache.org/repos/asf/directory-fortress-commander/blob/ce0ed9c4/src/main/java/org/apache/directory/fortress/web/panel/ObjectListPanel.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/directory/fortress/web/panel/ObjectListPanel.java b/src/main/java/org/apache/directory/fortress/web/panel/ObjectListPanel.java
index 9c4f0b8..d54fb2e 100644
--- a/src/main/java/org/apache/directory/fortress/web/panel/ObjectListPanel.java
+++ b/src/main/java/org/apache/directory/fortress/web/panel/ObjectListPanel.java
@@ -95,7 +95,7 @@ public class ObjectListPanel extends FormComponentPanel
         add( radioGroup );
         Radio objectRb = new Radio( "objectRb", new Model( Character.valueOf( NAMES ) ) );
         radioGroup.add( objectRb );
-        Radio ouRb = new Radio( "ouRb", new Model( new Character( OUS ) ) );
+        Radio ouRb = new Radio( "ouRb", new Model( Character.valueOf( OUS ) ) );
         radioGroup.add( ouRb );
         addOUSearchModal( ouRb );
         radioGroup.setOutputMarkupId( true );


Mime
View raw message