Return-Path: X-Original-To: apmail-directory-commits-archive@www.apache.org Delivered-To: apmail-directory-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 084DD174E7 for ; Tue, 7 Apr 2015 08:26:51 +0000 (UTC) Received: (qmail 37554 invoked by uid 500); 7 Apr 2015 08:26:50 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 37508 invoked by uid 500); 7 Apr 2015 08:26:50 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 37499 invoked by uid 99); 7 Apr 2015 08:26:50 -0000 Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2015 08:26:50 +0000 Received: from hades.apache.org (localhost [127.0.0.1]) by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id B5BC9AC0163 for ; Tue, 7 Apr 2015 08:26:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1671759 - in /directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model: OlcConfig.java OlcDbSocketConfig.java OlcSchemaConfig.java Date: Tue, 07 Apr 2015 08:26:50 -0000 To: commits@directory.apache.org From: elecharny@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20150407082650.B5BC9AC0163@hades.apache.org> Author: elecharny Date: Tue Apr 7 08:26:50 2015 New Revision: 1671759 URL: http://svn.apache.org/r1671759 Log: Used the copyListString method to avoid a modification by the caller Modified: directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcConfig.java directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcDbSocketConfig.java directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcSchemaConfig.java Modified: directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcConfig.java URL: http://svn.apache.org/viewvc/directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcConfig.java?rev=1671759&r1=1671758&r2=1671759&view=diff ============================================================================== --- directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcConfig.java (original) +++ directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcConfig.java Tue Apr 7 08:26:50 2015 @@ -59,7 +59,10 @@ public class OlcConfig */ public List getAuxiliaryObjectClasses() { - return auxiliaryObjectClasses; + List copy = new ArrayList( auxiliaryObjectClasses.size() ); + copy.addAll( auxiliaryObjectClasses ); + + return copy; } Modified: directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcDbSocketConfig.java URL: http://svn.apache.org/viewvc/directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcDbSocketConfig.java?rev=1671759&r1=1671758&r2=1671759&view=diff ============================================================================== --- directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcDbSocketConfig.java (original) +++ directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcDbSocketConfig.java Tue Apr 7 08:26:50 2015 @@ -67,7 +67,7 @@ public class OlcDbSocketConfig extends O */ public List getOlcDbSocketExtensions() { - return olcDbSocketExtensions; + return copyListString( olcDbSocketExtensions ); } @@ -85,7 +85,7 @@ public class OlcDbSocketConfig extends O */ public void setOlcDbSocketExtensions( List olcDbSocketExtensions ) { - this.olcDbSocketExtensions = olcDbSocketExtensions; + this.olcDbSocketExtensions = copyListString( olcDbSocketExtensions ); } Modified: directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcSchemaConfig.java URL: http://svn.apache.org/viewvc/directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcSchemaConfig.java?rev=1671759&r1=1671758&r2=1671759&view=diff ============================================================================== --- directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcSchemaConfig.java (original) +++ directory/studio/trunk/plugins/openldap.config.editor/src/main/java/org/apache/directory/studio/openldap/config/model/OlcSchemaConfig.java Tue Apr 7 08:26:50 2015 @@ -181,7 +181,7 @@ public class OlcSchemaConfig extends Olc */ public List getCn() { - return cn; + return copyListString( cn ); } @@ -190,7 +190,7 @@ public class OlcSchemaConfig extends Olc */ public List getOlcAttributeTypes() { - return olcAttributeTypes; + return copyListString( olcAttributeTypes ); } @@ -199,7 +199,7 @@ public class OlcSchemaConfig extends Olc */ public List getOlcDitContentRules() { - return olcDitContentRules; + return copyListString( olcDitContentRules ); } @@ -208,7 +208,7 @@ public class OlcSchemaConfig extends Olc */ public List getOlcLdapSyntaxes() { - return olcLdapSyntaxes; + return copyListString( olcLdapSyntaxes ); } @@ -217,7 +217,7 @@ public class OlcSchemaConfig extends Olc */ public List getOlcObjectClasses() { - return olcObjectClasses; + return copyListString( olcObjectClasses ); } @@ -226,7 +226,7 @@ public class OlcSchemaConfig extends Olc */ public List getOlcObjectIdentifier() { - return olcObjectIdentifier; + return copyListString( olcObjectIdentifier ); } @@ -235,7 +235,7 @@ public class OlcSchemaConfig extends Olc */ public void setCn( List cn ) { - this.cn = cn; + this.cn = copyListString( cn ); } @@ -244,7 +244,7 @@ public class OlcSchemaConfig extends Olc */ public void setOlcAttributeTypes( List olcAttributeTypes ) { - this.olcAttributeTypes = olcAttributeTypes; + this.olcAttributeTypes = copyListString( olcAttributeTypes ); } @@ -253,7 +253,7 @@ public class OlcSchemaConfig extends Olc */ public void setOlcDitContentRules( List olcDitContentRules ) { - this.olcDitContentRules = olcDitContentRules; + this.olcDitContentRules = copyListString( olcDitContentRules ); } @@ -262,7 +262,7 @@ public class OlcSchemaConfig extends Olc */ public void setOlcLdapSyntaxes( List olcLdapSyntaxes ) { - this.olcLdapSyntaxes = olcLdapSyntaxes; + this.olcLdapSyntaxes = copyListString( olcLdapSyntaxes ); } @@ -271,7 +271,7 @@ public class OlcSchemaConfig extends Olc */ public void setOlcObjectClasses( List olcObjectClasses ) { - this.olcObjectClasses = olcObjectClasses; + this.olcObjectClasses = copyListString( olcObjectClasses ); } @@ -280,6 +280,6 @@ public class OlcSchemaConfig extends Olc */ public void setOlcObjectIdentifier( List olcObjectIdentifier ) { - this.olcObjectIdentifier = olcObjectIdentifier; + this.olcObjectIdentifier = copyListString( olcObjectIdentifier ); } }