directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cohei...@apache.org
Subject directory-kerby git commit: More Kerby PMD work
Date Wed, 29 Apr 2015 09:21:46 GMT
Repository: directory-kerby
Updated Branches:
  refs/heads/master d7bf961d6 -> e452f1854


More Kerby PMD work


Project: http://git-wip-us.apache.org/repos/asf/directory-kerby/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-kerby/commit/e452f185
Tree: http://git-wip-us.apache.org/repos/asf/directory-kerby/tree/e452f185
Diff: http://git-wip-us.apache.org/repos/asf/directory-kerby/diff/e452f185

Branch: refs/heads/master
Commit: e452f1854e9728abb1ac0fe602b684b4aae5863b
Parents: d7bf961
Author: Colm O hEigeartaigh <coheigea@apache.org>
Authored: Wed Apr 29 10:21:16 2015 +0100
Committer: Colm O hEigeartaigh <coheigea@apache.org>
Committed: Wed Apr 29 10:21:35 2015 +0100

----------------------------------------------------------------------
 .../org/apache/kerby/kerberos/kdc/impl/NettyKdcNetwork.java  | 7 ++++---
 .../java/org/apache/kerby/kerberos/tool/klist/Klist.java     | 8 ++++----
 .../org/apache/kerby/kerberos/tool/token/TokenCache.java     | 8 ++++----
 3 files changed, 12 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/e452f185/kerby-kdc/src/main/java/org/apache/kerby/kerberos/kdc/impl/NettyKdcNetwork.java
----------------------------------------------------------------------
diff --git a/kerby-kdc/src/main/java/org/apache/kerby/kerberos/kdc/impl/NettyKdcNetwork.java
b/kerby-kdc/src/main/java/org/apache/kerby/kerberos/kdc/impl/NettyKdcNetwork.java
index 119e089..5c7d5f8 100644
--- a/kerby-kdc/src/main/java/org/apache/kerby/kerberos/kdc/impl/NettyKdcNetwork.java
+++ b/kerby-kdc/src/main/java/org/apache/kerby/kerberos/kdc/impl/NettyKdcNetwork.java
@@ -39,7 +39,6 @@ import java.net.InetSocketAddress;
 public class NettyKdcNetwork {
     private KdcContext kdcContext;
     private InetSocketAddress tcpAddress;
-    private InetSocketAddress udpAddress;
     private EventLoopGroup bossGroup;
     private EventLoopGroup workerGroup;
 
@@ -53,12 +52,14 @@ public class NettyKdcNetwork {
     public void listen(InetSocketAddress tcpAddress,
                        InetSocketAddress udpAddress) throws IOException {
         this.tcpAddress = tcpAddress;
-        this.udpAddress = udpAddress;
+        
+        /*this.udpAddress = udpAddress;
 
 
         if (udpAddress != null) {
 
         }
+        */
     }
 
     public void start() {
@@ -87,7 +88,7 @@ public class NettyKdcNetwork {
         }
     }
 
-    private ChannelInitializer createChannelInitializer() {
+    private ChannelInitializer<SocketChannel> createChannelInitializer() {
         return new ChannelInitializer<SocketChannel>() {
             @Override
             public void initChannel(SocketChannel ch) throws Exception {

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/e452f185/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/klist/Klist.java
----------------------------------------------------------------------
diff --git a/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/klist/Klist.java
b/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/klist/Klist.java
index 88e8700..c499442 100644
--- a/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/klist/Klist.java
+++ b/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/klist/Klist.java
@@ -65,7 +65,7 @@ public class Klist {
         System.exit(-1);
     }
 
-    private static int printInfo(String name, KOptions klOptions) {
+    private static int printInfo(KOptions klOptions) {
         CredentialCache cc = new CredentialCache();
         List<Credential> credentials;
         InputStream cis = null ;
@@ -115,7 +115,7 @@ public class Klist {
     public static void main(String[] args) throws Exception {
         KOptions klOptions = new KOptions();
         KlistOption klopt;
-        String name = null;
+        // String name = null;
 
         int i = 0;
         String opt, value, error;
@@ -130,7 +130,7 @@ public class Klist {
                     break;
                 }
             } else {
-                name = opt;
+                // name = opt;
                 break;
             }
 
@@ -153,7 +153,7 @@ public class Klist {
             klOptions.add(klopt);
         }
 
-        int errNo = Klist.printInfo(name, klOptions);
+        int errNo = Klist.printInfo(klOptions);
         System.exit(errNo);
     }
 }

http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/e452f185/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/token/TokenCache.java
----------------------------------------------------------------------
diff --git a/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/token/TokenCache.java
b/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/token/TokenCache.java
index d737085..7583121 100644
--- a/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/token/TokenCache.java
+++ b/kerby-tool/client-tool/src/main/java/org/apache/kerby/kerberos/tool/token/TokenCache.java
@@ -32,12 +32,12 @@ public class TokenCache {
             cacheFile = new File(tokenCacheFile);
             if (!cacheFile.exists()) {
                 throw new RuntimeException("Invalid token cache specified: " + tokenCacheFile);
-            };
+            }
         } else {
             cacheFile = getDefaultTokenCache();
             if (!cacheFile.exists()) {
                 throw new RuntimeException("No token cache available by default");
-            };
+            }
         }
 
         String token = null;
@@ -48,8 +48,8 @@ public class TokenCache {
             if (line != null) {
                 token = line;
             }
-        } catch (IOException ex) {
-            //NOP
+        } catch (IOException ex) { //NOPMD
+            //
         }
 
         return token;


Mime
View raw message