directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayyag...@apache.org
Subject svn commit: r1572459 - in /directory: apacheds/trunk/core-api/src/test/java/org/apache/directory/server/core/api/entry/ shared/trunk/integ/src/test/java/org/apache/directory/api/ldap/entry/ shared/trunk/ldap/model/src/main/java/org/apache/directory/api...
Date Thu, 27 Feb 2014 07:45:29 GMT
Author: kayyagari
Date: Thu Feb 27 07:45:28 2014
New Revision: 1572459

URL: http://svn.apache.org/r1572459
Log:
removed single quotes around a non-null binary value (DIRAPI-171)

Modified:
    directory/apacheds/trunk/core-api/src/test/java/org/apache/directory/server/core/api/entry/SchemaAwareEntryTest.java
    directory/shared/trunk/integ/src/test/java/org/apache/directory/api/ldap/entry/SchemaAwareEntryTest.java
    directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/entry/BinaryValue.java
    directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java
    directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/BinaryValueTest.java

Modified: directory/apacheds/trunk/core-api/src/test/java/org/apache/directory/server/core/api/entry/SchemaAwareEntryTest.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/test/java/org/apache/directory/server/core/api/entry/SchemaAwareEntryTest.java?rev=1572459&r1=1572458&r2=1572459&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/test/java/org/apache/directory/server/core/api/entry/SchemaAwareEntryTest.java
(original)
+++ directory/apacheds/trunk/core-api/src/test/java/org/apache/directory/server/core/api/entry/SchemaAwareEntryTest.java
Thu Feb 27 07:45:28 2014
@@ -3638,8 +3638,8 @@ public class SchemaAwareEntryTest
                 "    dn[n]: dc=example,dc=com\n" +
                 "    ObjectClass: top\n" +
                 "    ObjectClass: person\n\n" +
-                "    UserPassword: '0x61 0x62 '\n" +
-                "    UserPassword: '0x62 '\n" +
+                "    UserPassword: 0x61 0x62 \n" +
+                "    UserPassword: 0x62 \n" +
                 "    UserPassword: ''";
 
         assertEquals( expected, entry.toString() );

Modified: directory/shared/trunk/integ/src/test/java/org/apache/directory/api/ldap/entry/SchemaAwareEntryTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/integ/src/test/java/org/apache/directory/api/ldap/entry/SchemaAwareEntryTest.java?rev=1572459&r1=1572458&r2=1572459&view=diff
==============================================================================
--- directory/shared/trunk/integ/src/test/java/org/apache/directory/api/ldap/entry/SchemaAwareEntryTest.java
(original)
+++ directory/shared/trunk/integ/src/test/java/org/apache/directory/api/ldap/entry/SchemaAwareEntryTest.java
Thu Feb 27 07:45:28 2014
@@ -1161,8 +1161,8 @@ public class SchemaAwareEntryTest
                 "    ObjectClass: top\n" +
                 "    ObjectClass: person\n" +
                 "    ObjectClass: ''\n" +
-                "    UserPassword: '0x61 0x62 '\n" +
-                "    UserPassword: '0x62 '\n" +
+                "    UserPassword: 0x61 0x62 \n" +
+                "    UserPassword: 0x62 \n" +
                 "    UserPassword: ''\n";
 
         assertEquals( expected, entry.toString() );

Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/entry/BinaryValue.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/entry/BinaryValue.java?rev=1572459&r1=1572458&r2=1572459&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/entry/BinaryValue.java
(original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/entry/BinaryValue.java
Thu Feb 27 07:45:28 2014
@@ -689,11 +689,11 @@ public class BinaryValue extends Abstrac
 
             System.arraycopy( wrappedValue, 0, copy, 0, 16 );
 
-            return "'" + Strings.dumpBytes( copy ) + "...'";
+            return Strings.dumpBytes( copy ) + "...";
         }
         else
         {
-            return "'" + Strings.dumpBytes( wrappedValue ) + "'";
+            return Strings.dumpBytes( wrappedValue );
         }
     }
 }
\ No newline at end of file

Modified: directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java?rev=1572459&r1=1572458&r2=1572459&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java
(original)
+++ directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/AttributeTest.java
Thu Feb 27 07:45:28 2014
@@ -1302,10 +1302,10 @@ public class AttributeTest
         Attribute attr2 = new DefaultAttribute( "test" );
 
         attr2.add( BYTES1 );
-        assertEquals( "test: '0x61 0x62 '", attr2.toString() );
+        assertEquals( "test: 0x61 0x62 ", attr2.toString() );
 
         attr2.add( BYTES3 );
-        assertEquals( "test: '0x61 0x62 '\ntest: '0x63 '", attr2.toString() );
+        assertEquals( "test: 0x61 0x62 \ntest: 0x63 ", attr2.toString() );
     }
 
 

Modified: directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/BinaryValueTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/BinaryValueTest.java?rev=1572459&r1=1572458&r2=1572459&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/BinaryValueTest.java
(original)
+++ directory/shared/trunk/ldap/model/src/test/java/org/apache/directory/api/ldap/model/entry/BinaryValueTest.java
Thu Feb 27 07:45:28 2014
@@ -477,10 +477,10 @@ public class BinaryValueTest
         assertEquals( "null", bv.toString() );
 
         bv = new BinaryValue( StringConstants.EMPTY_BYTES );
-        assertEquals( "''", bv.toString() );
+        assertEquals( "", bv.toString() );
 
         bv = new BinaryValue( BYTES1 );
-        assertEquals( "'0x01 0x02 0x03 0x04 '", bv.toString() );
+        assertEquals( "0x01 0x02 0x03 0x04 ", bv.toString() );
     }
 
 



Mime
View raw message