Return-Path: X-Original-To: apmail-directory-commits-archive@www.apache.org Delivered-To: apmail-directory-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4A7510E6E for ; Mon, 17 Jun 2013 14:44:38 +0000 (UTC) Received: (qmail 37892 invoked by uid 500); 17 Jun 2013 14:44:37 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 37794 invoked by uid 500); 17 Jun 2013 14:44:37 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 37785 invoked by uid 99); 17 Jun 2013 14:44:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jun 2013 14:44:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jun 2013 14:44:34 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 4391E2388A3D; Mon, 17 Jun 2013 14:44:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1493788 - /directory/studio/trunk/plugins/ldapbrowser.common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/ModWidget.java Date: Mon, 17 Jun 2013 14:44:14 -0000 To: commits@directory.apache.org From: pamarcelot@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130617144414.4391E2388A3D@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: pamarcelot Date: Mon Jun 17 14:44:13 2013 New Revision: 1493788 URL: http://svn.apache.org/r1493788 Log: Fix for DIRSTUDIO-792 (Batch operation Next button inactive) Modified: directory/studio/trunk/plugins/ldapbrowser.common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/ModWidget.java Modified: directory/studio/trunk/plugins/ldapbrowser.common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/ModWidget.java URL: http://svn.apache.org/viewvc/directory/studio/trunk/plugins/ldapbrowser.common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/ModWidget.java?rev=1493788&r1=1493787&r2=1493788&view=diff ============================================================================== --- directory/studio/trunk/plugins/ldapbrowser.common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/ModWidget.java (original) +++ directory/studio/trunk/plugins/ldapbrowser.common/src/main/java/org/apache/directory/studio/ldapbrowser/common/widgets/ModWidget.java Mon Jun 17 14:44:13 2013 @@ -51,7 +51,7 @@ import org.eclipse.swt.widgets.Text; * * @author Apache Directory Project */ -public class ModWidget extends BrowserWidget implements ModifyListener +public class ModWidget extends BrowserWidget { /** The scrolled composite */ private ScrolledComposite scrolledComposite; @@ -68,6 +68,15 @@ public class ModWidget extends BrowserWi /** The resulting LDIF */ private String ldif; + // Listeners + private ModifyListener modifyListener = new ModifyListener() + { + public void modifyText( ModifyEvent e ) + { + validate( true ); + } + }; + /** * Creates a new instance of ModWidget. @@ -130,15 +139,6 @@ public class ModWidget extends BrowserWi /** - * {@inheritDoc} - */ - public void modifyText( ModifyEvent e ) - { - validate( true ); - } - - - /** * Validates the input elements. */ public void validate( boolean notifyListeners ) @@ -240,12 +240,13 @@ public class ModWidget extends BrowserWi modSpec.modType = BaseWidgetUtils.createReadonlyCombo( modSpecComposite, new String[] { "add", "replace", "delete" }, 0, 1 ); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ modSpec.modType.setLayoutData( new GridData() ); - modSpec.modType.addModifyListener( this ); + modSpec.modType.addModifyListener( modifyListener ); // attribute combo with field decoration and content proposal modSpec.modAttributeCombo = BaseWidgetUtils.createCombo( modSpecComposite, new String[0], -1, 1 ); new ExtendedContentAssistCommandAdapter( modSpec.modAttributeCombo, new ComboContentAdapter(), listContentProposalProvider, null, null, true ); + modSpec.modAttributeCombo.addModifyListener( modifyListener ); // add button with listener modSpec.modAddButton = new Button( composite, SWT.PUSH ); @@ -374,7 +375,7 @@ public class ModWidget extends BrowserWi // text field valueLine.valueComposite = BaseWidgetUtils.createColumnContainer( modSpec.modGroup, 3, 1 ); valueLine.valueText = BaseWidgetUtils.createText( valueLine.valueComposite, "", 1 ); //$NON-NLS-1$ - valueLine.valueText.addModifyListener( this ); + valueLine.valueText.addModifyListener( modifyListener ); // add button with listener valueLine.valueAddButton = new Button( valueLine.valueComposite, SWT.PUSH );