directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r1398737 - /directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/DefaultOptimizer.java
Date Tue, 16 Oct 2012 11:23:33 GMT
Author: elecharny
Date: Tue Oct 16 11:23:32 2012
New Revision: 1398737

URL: http://svn.apache.org/viewvc?rev=1398737&view=rev
Log:
Fix for DIRSERVER-1751 : a substring filter now uses the index to speed up a search

Modified:
    directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/DefaultOptimizer.java

Modified: directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/DefaultOptimizer.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/DefaultOptimizer.java?rev=1398737&r1=1398736&r2=1398737&view=diff
==============================================================================
--- directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/DefaultOptimizer.java
(original)
+++ directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/search/impl/DefaultOptimizer.java
Tue Oct 16 11:23:32 2012
@@ -45,6 +45,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.filter.ScopeNode;
 import org.apache.directory.shared.ldap.model.filter.SimpleNode;
 import org.apache.directory.shared.ldap.model.filter.SubstringNode;
+import org.apache.directory.shared.util.Strings;
 
 
 /**
@@ -157,7 +158,7 @@ public class DefaultOptimizer<E> impleme
             else if ( node instanceof SubstringNode )
             {
                 /** Cannot really say so we presume the total index count */
-                count = getFullScan( leaf );
+                count = getSubstringScan( ( SubstringNode ) leaf );
             }
             else if ( node instanceof ExtensibleNode )
             {
@@ -305,6 +306,7 @@ public class DefaultOptimizer<E> impleme
         if ( db.hasIndexOn( node.getAttributeType() ) )
         {
             Index<V, E, String> idx = ( Index<V, E, String> ) db.getIndex( node.getAttributeType()
);
+            
             if ( isGreaterThan )
             {
                 return idx.greaterThanCount( node.getValue().getValue() );
@@ -318,6 +320,42 @@ public class DefaultOptimizer<E> impleme
         // count for non-indexed attribute is unknown so we presume da worst
         return Long.MAX_VALUE;
     }
+    
+    
+    /**
+     * Get a scan count based on a Substring node : we will count the entries that are greater
+     * than ABC where the filter is (attr=ABC*). Any other filter won't be evaluated (for
instance,
+     * a filter like (attr=*ABC) will resolve to a full scan atm - we could have created
a reverted
+     * index for such a case -, and filters like (attr=*ABC*) also esolve to a full scan).
+     * 
+     * @param node The substring node
+     * @return The number of candidates
+     * @throws Exception If there is an error accessing an index
+     */
+    private long getSubstringScan( SubstringNode node ) throws Exception
+    {
+        if ( db.hasIndexOn( node.getAttributeType() ) )
+        {
+            Index<String, E, String> idx = ( Index<String, E, String> ) db.getIndex(
node.getAttributeType() );
+            
+            String initial = node.getInitial();
+            
+            if ( Strings.isEmpty( initial ) )
+            {
+            	// Not a (attr=ABC*) filter : full scan
+                return Long.MAX_VALUE;
+            }
+            else
+            {
+            	return idx.greaterThanCount( initial );
+            }
+        }
+        else
+        {
+            // count for non-indexed attribute is unknown so we presume da worst
+        	return Long.MAX_VALUE;
+        }
+    }
 
 
     /**



Mime
View raw message