directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pamarce...@apache.org
Subject svn commit: r1333525 - /directory/studio/trunk/plugins/ldapservers/src/main/java/org/apache/directory/studio/ldapservers/views/ServersTableViewer.java
Date Thu, 03 May 2012 16:13:33 GMT
Author: pamarcelot
Date: Thu May  3 16:13:33 2012
New Revision: 1333525

URL: http://svn.apache.org/viewvc?rev=1333525&view=rev
Log:
Removed useless 'try catch'.

Modified:
    directory/studio/trunk/plugins/ldapservers/src/main/java/org/apache/directory/studio/ldapservers/views/ServersTableViewer.java

Modified: directory/studio/trunk/plugins/ldapservers/src/main/java/org/apache/directory/studio/ldapservers/views/ServersTableViewer.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/plugins/ldapservers/src/main/java/org/apache/directory/studio/ldapservers/views/ServersTableViewer.java?rev=1333525&r1=1333524&r2=1333525&view=diff
==============================================================================
--- directory/studio/trunk/plugins/ldapservers/src/main/java/org/apache/directory/studio/ldapservers/views/ServersTableViewer.java
(original)
+++ directory/studio/trunk/plugins/ldapservers/src/main/java/org/apache/directory/studio/ldapservers/views/ServersTableViewer.java
Thu May  3 16:13:33 2012
@@ -132,7 +132,7 @@ public class ServersTableViewer extends 
                 LdapServer server = event.getServer();
                 switch ( kind )
                 {
-                    // The server status has changed
+                // The server status has changed
                     case STATUS_CHANGED:
                         // First, we refresh the server
                         refreshServer( server );
@@ -236,16 +236,9 @@ public class ServersTableViewer extends 
         {
             public void run()
             {
-                try
-                {
-                    refresh( server );
-                    ISelection sel = ServersTableViewer.this.getSelection();
-                    ServersTableViewer.this.setSelection( sel );
-                }
-                catch ( Exception e )
-                {
-                    // ignore
-                }
+                refresh( server );
+                ISelection sel = ServersTableViewer.this.getSelection();
+                ServersTableViewer.this.setSelection( sel );
             }
         } );
     }
@@ -286,24 +279,17 @@ public class ServersTableViewer extends 
                 // Checking if we need to stop the animation
                 if ( !stopAnimation )
                 {
-                    try
-                    {
-                        // Changing the animation state on the label provider
-                        labelProvider.animate();
+                    // Changing the animation state on the label provider
+                    labelProvider.animate();
 
-                        // Looping on the currently starting servers
-                        for ( LdapServer server : serversNeedingAnimation.toArray( new LdapServer[0]
) )
+                    // Looping on the currently starting servers
+                    for ( LdapServer server : serversNeedingAnimation.toArray( new LdapServer[0]
) )
+                    {
+                        if ( server != null && getTree() != null && !getTree().isDisposed()
)
                         {
-                            if ( server != null && getTree() != null && !getTree().isDisposed()
)
-                            {
-                                updateAnimation( server );
-                            }
+                            updateAnimation( server );
                         }
                     }
-                    catch ( Exception e )
-                    {
-                        // Trace.trace( Trace.FINEST, "Error in Servers view animation",
e ); TODO
-                    }
 
                     // Re-launching the animation
                     display.timerExec( SLEEP, animatorThread[0] );
@@ -339,16 +325,9 @@ public class ServersTableViewer extends 
      */
     private void updateAnimation( LdapServer server )
     {
-        try
-        {
-            Widget widget = doFindItem( server );
-            TreeItem item = ( TreeItem ) widget;
-            item.setText( 1, labelProvider.getColumnText( server, 1 ) );
-            item.setImage( 1, labelProvider.getColumnImage( server, 1 ) );
-        }
-        catch ( Exception e )
-        {
-            // Trace.trace( Trace.WARNING, "Error in optimized animation", e ); TODO
-        }
+        Widget widget = doFindItem( server );
+        TreeItem item = ( TreeItem ) widget;
+        item.setText( 1, labelProvider.getColumnText( server, 1 ) );
+        item.setImage( 1, labelProvider.getColumnImage( server, 1 ) );
     }
 }
\ No newline at end of file



Mime
View raw message