directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pamarce...@apache.org
Subject svn commit: r1245617 - /directory/studio/trunk/plugins/connection.core/src/main/java/org/apache/directory/studio/connection/core/io/api/DirectoryApiConnectionWrapper.java
Date Fri, 17 Feb 2012 15:37:57 GMT
Author: pamarcelot
Date: Fri Feb 17 15:37:57 2012
New Revision: 1245617

URL: http://svn.apache.org/viewvc?rev=1245617&view=rev
Log:
Better handling of the exception which will be caught by the method caller.

Modified:
    directory/studio/trunk/plugins/connection.core/src/main/java/org/apache/directory/studio/connection/core/io/api/DirectoryApiConnectionWrapper.java

Modified: directory/studio/trunk/plugins/connection.core/src/main/java/org/apache/directory/studio/connection/core/io/api/DirectoryApiConnectionWrapper.java
URL: http://svn.apache.org/viewvc/directory/studio/trunk/plugins/connection.core/src/main/java/org/apache/directory/studio/connection/core/io/api/DirectoryApiConnectionWrapper.java?rev=1245617&r1=1245616&r2=1245617&view=diff
==============================================================================
--- directory/studio/trunk/plugins/connection.core/src/main/java/org/apache/directory/studio/connection/core/io/api/DirectoryApiConnectionWrapper.java
(original)
+++ directory/studio/trunk/plugins/connection.core/src/main/java/org/apache/directory/studio/connection/core/io/api/DirectoryApiConnectionWrapper.java
Fri Feb 17 15:37:57 2012
@@ -770,8 +770,9 @@ public class DirectoryApiConnectionWrapp
      *      an array of modification items
      * @return
      *      an array of converted modifications
+     * @throws LdapInvalidAttributeValueException 
      */
-    private Modification[] convertModificationItems( ModificationItem[] modificationItems
)
+    private Modification[] convertModificationItems( ModificationItem[] modificationItems
) throws LdapInvalidAttributeValueException
     {
         if ( modificationItems != null )
         {
@@ -781,15 +782,7 @@ public class DirectoryApiConnectionWrapp
             {
                 Modification modification = new DefaultModification();
 
-                try
-                {
-                    modification.setAttribute( AttributeUtils.toApiAttribute( modificationItem.getAttribute()
) );
-                }
-                catch ( LdapInvalidAttributeValueException liave )
-                {
-                    // TODO : handle the exception
-                }
-
+                modification.setAttribute( AttributeUtils.toApiAttribute( modificationItem.getAttribute()
) );
                 modification.setOperation( convertModificationOperation( modificationItem.getModificationOp()
) );
                 modifications.add( modification );
             }



Mime
View raw message