directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fel...@apache.org
Subject svn commit: r1083573 - /directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java
Date Sun, 20 Mar 2011 21:21:42 GMT
Author: felixk
Date: Sun Mar 20 21:21:42 2011
New Revision: 1083573

URL: http://svn.apache.org/viewvc?rev=1083573&view=rev
Log:
Thanks Emmanuel for hint of false positiv

Modified:
    directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java

Modified: directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java?rev=1083573&r1=1083572&r2=1083573&view=diff
==============================================================================
--- directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java
(original)
+++ directory/shared/trunk/asn1/ber/src/main/java/org/apache/directory/shared/asn1/ber/tlv/Value.java
Sun Mar 20 21:21:42 2011
@@ -151,9 +151,11 @@ public class Value
      *
      * @return Returns the data.
      */
+    @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="EI_EXPOSE_REP",
+    		justification="The return of the direct value (without cloning) was intended. Even
if we modify the interned value, it won't have any impact")
     public byte[] getData()
     {
-        return data.clone();
+        return data;
     }
 
 



Mime
View raw message