directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pamarce...@apache.org
Subject svn commit: r1079731 - /directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
Date Wed, 09 Mar 2011 10:29:41 GMT
Author: pamarcelot
Date: Wed Mar  9 10:29:41 2011
New Revision: 1079731

URL: http://svn.apache.org/viewvc?rev=1079731&view=rev
Log:
Fixed PMD error.
Avoid unused private methods such as 'bindSasl(String,byte,String,String,String,Control...)'.

Modified:
    directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java

Modified: directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java?rev=1079731&r1=1079730&r2=1079731&view=diff
==============================================================================
--- directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
(original)
+++ directory/shared/trunk/ldap/client/api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java
Wed Mar  9 10:29:41 2011
@@ -1389,7 +1389,7 @@ public class LdapNetworkConnection exten
         System.setProperty( "java.security.krb5.conf", krbConfPath );
 
         Configuration.setConfiguration( new Krb5LoginConfiguration() );
-	System.setProperty( "javax.security.auth.useSubjectCredsOnly", "true" );
+        System.setProperty( "javax.security.auth.useSubjectCredsOnly", "true" );
 
         try
         {
@@ -2925,7 +2925,7 @@ public class LdapNetworkConnection exten
      */
     public ExtendedResponse extended( OID oid, byte[] value ) throws LdapException
     {
-        ExtendedRequest<?> extendedRequest = 
+        ExtendedRequest<?> extendedRequest =
             LdapCodecServiceFactory.getSingleton().newExtendedRequest( oid.toString(), value
);
         return extended( extendedRequest );
     }
@@ -3461,10 +3461,10 @@ public class LdapNetworkConnection exten
     public void sessionCreated( IoSession session ) throws Exception
     {
         // Last, store the message container
-        LdapMessageContainer<? extends MessageDecorator<Message>> ldapMessageContainer
= 
-            new LdapMessageContainer<MessageDecorator<Message>>( 
-            codec,
-            new BinaryAttributeDetector()
+        LdapMessageContainer<? extends MessageDecorator<Message>> ldapMessageContainer
=
+            new LdapMessageContainer<MessageDecorator<Message>>(
+                codec,
+                new BinaryAttributeDetector()
             {
                 public boolean isBinary( String id )
                 {
@@ -3475,7 +3475,7 @@ public class LdapNetworkConnection exten
                     }
                     catch ( Exception e )
                     {
-                        return !Strings.isEmpty(id) && id.endsWith(";binary");
+                        return !Strings.isEmpty( id ) && id.endsWith( ";binary" );
                     }
                 }
             } );
@@ -3590,24 +3590,6 @@ public class LdapNetworkConnection exten
 
 
     /**
-     * perform SASL based bind operation @see {@link #bindSasl(SaslRequest)} 
-     */
-    private BindFuture bindSasl( String name, byte[] credentials, String saslMech, String
authzId, String realmName,
-        Control... ctrls )
-        throws LdapException, IOException
-    {
-        SaslRequest saslRequest = new SaslRequest( saslMech ); // TODO fix this
-        saslRequest.setUsername( name );
-        saslRequest.setCredentials( credentials );
-        saslRequest.setAuthorizationId( authzId );
-        saslRequest.setRealmName( realmName );
-        saslRequest.addAllControls( ctrls );
-
-        return bindSasl( saslRequest );
-    }
-
-
-    /**
      * Process the SASL Bind. It's a dialog with the server, we will send a first BindRequest,
receive
      * a response and the, if this response is a challenge, continue by sending a new BindRequest
with
      * the requested informations.



Mime
View raw message