directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r1074170 - in /directory/shared/trunk/ldap-model/src: main/java/org/apache/directory/shared/ldap/model/entry/ test/java/org/apache/directory/shared/ldap/model/entry/
Date Thu, 24 Feb 2011 14:41:46 GMT
Author: elecharny
Date: Thu Feb 24 14:41:45 2011
New Revision: 1074170

URL: http://svn.apache.org/viewvc?rev=1074170&view=rev
Log:
o Removed the serialVersionUid from many helper classes

Modified:
    directory/shared/trunk/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java
    directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueAttributeTypeTest.java
    directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java
    directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/StringValueAttributeTypeTest.java

Modified: directory/shared/trunk/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java?rev=1074170&r1=1074169&r2=1074170&view=diff
==============================================================================
--- directory/shared/trunk/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java
(original)
+++ directory/shared/trunk/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java
Thu Feb 24 14:41:45 2011
@@ -62,8 +62,6 @@ public class EntryUtils
      */
     static class MR extends MatchingRule
     {
-        private static final long serialVersionUID = 0L;
-
         protected MR( String oid )
         {
             super( oid );
@@ -85,8 +83,6 @@ public class EntryUtils
     }
     static class S extends LdapSyntax
     {
-        private static final long serialVersionUID = 0L;
-
         public S( String oid, boolean humanReadible )
         {
             super( oid, "", humanReadible );
@@ -100,8 +96,6 @@ public class EntryUtils
 
         syntax.setSyntaxChecker( new SyntaxChecker( "1.1.2.1" )
         {
-            private static final long serialVersionUID = 0L;
-
             public boolean isValidSyntax( Object value )
             {
                 if ( !( value instanceof String ) )
@@ -128,8 +122,6 @@ public class EntryUtils
 
         matchingRule.setLdapComparator( new LdapComparator<String>( matchingRule.getOid()
)
         {
-            private static final long serialVersionUID = 0L;
-
             public int compare( String o1, String o2 )
             {
                 return ( o1 == null ? 
@@ -140,8 +132,6 @@ public class EntryUtils
         
         Normalizer normalizer = new Normalizer( "1.1.1" )
         {
-            private static final long serialVersionUID = 0L;
-
             public Value<?> normalize( Value<?> value ) throws LdapException
             {
                 if ( !value.isBinary() )
@@ -176,8 +166,6 @@ public class EntryUtils
 
         syntax.setSyntaxChecker( new SyntaxChecker( "1.1.2" )
         {
-            private static final long serialVersionUID = 0L;
-
             public boolean isValidSyntax( Object value )
             {
                 return ((String)value == null) || (((String)value).length() < 7) ;
@@ -190,8 +178,6 @@ public class EntryUtils
 
         matchingRule.setLdapComparator( new LdapComparator<String>( matchingRule.getOid()
)
         {
-            private static final long serialVersionUID = 0L;
-
             public int compare( String o1, String o2 )
             {
                 return ( ( o1 == null ) ? 
@@ -216,8 +202,6 @@ public class EntryUtils
 
         syntax.setSyntaxChecker( new SyntaxChecker( "1.2.1" )
         {
-            private static final long serialVersionUID = 0L;
-
             public boolean isValidSyntax( Object value )
             {
                 return ( value == null ) || ( ((byte[])value).length < 5 );
@@ -231,9 +215,6 @@ public class EntryUtils
         
         matchingRule.setNormalizer( new Normalizer( "1.1.1" )
         {
-            // The serial UID
-            private static final long serialVersionUID = 1L;
-            
             public Value<?> normalize( Value<?> value ) throws LdapException
             {
                 if ( value.isBinary() )

Modified: directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueAttributeTypeTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueAttributeTypeTest.java?rev=1074170&r1=1074169&r2=1074170&view=diff
==============================================================================
--- directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueAttributeTypeTest.java
(original)
+++ directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueAttributeTypeTest.java
Thu Feb 24 14:41:45 2011
@@ -34,8 +34,6 @@ import java.io.ObjectInputStream;
 import java.io.ObjectOutputStream;
 import java.util.Arrays;
 
-import com.mycila.junit.concurrent.Concurrency;
-import com.mycila.junit.concurrent.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.schema.AttributeType;
 import org.apache.directory.shared.ldap.model.schema.LdapSyntax;
@@ -49,6 +47,9 @@ import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+import com.mycila.junit.concurrent.Concurrency;
+import com.mycila.junit.concurrent.ConcurrentJunitRunner;
+
 
 /**
  * Tests that the BinaryValue class works properly as expected.
@@ -87,8 +88,6 @@ public class BinaryValueAttributeTypeTes
         mr.setLdapComparator( new ByteArrayComparator( "1.1.1" ) );
         mr.setNormalizer( new Normalizer( "1.1.1" )
         {
-            private static final long serialVersionUID = 1L;
-            
             public Value<?> normalize( Value<?> value ) throws LdapException
             {
                 if ( value.isBinary() )

Modified: directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java?rev=1074170&r1=1074169&r2=1074170&view=diff
==============================================================================
--- directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java
(original)
+++ directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java
Thu Feb 24 14:41:45 2011
@@ -20,11 +20,11 @@ package org.apache.directory.shared.ldap
 
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.assertFalse;
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
@@ -33,8 +33,6 @@ import java.io.ObjectInputStream;
 import java.io.ObjectOutputStream;
 import java.util.Arrays;
 
-import com.mycila.junit.concurrent.Concurrency;
-import com.mycila.junit.concurrent.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.schema.Normalizer;
 import org.apache.directory.shared.ldap.model.schema.SyntaxChecker;
@@ -43,6 +41,9 @@ import org.apache.directory.shared.util.
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+import com.mycila.junit.concurrent.Concurrency;
+import com.mycila.junit.concurrent.ConcurrentJunitRunner;
+
 
 /**
  * 
@@ -61,8 +62,6 @@ public class BinaryValueTest
     
     private static final Normalizer BINARY_NORMALIZER = new Normalizer( "1.1.1" )
     {
-        private static final long serialVersionUID = 1L;
-        
         public Value<?> normalize( Value<?> value ) throws LdapException
         {
             if ( value.isBinary() )
@@ -95,8 +94,6 @@ public class BinaryValueTest
      */
     private static final Normalizer BINARY_NORMALIZER_EMPTY = new Normalizer( "1.1.1" )
     {
-        private static final long serialVersionUID = 1L;
-        
         public Value<?> normalize( Value<?> value ) throws LdapException
         {
             if ( value.isBinary() )
@@ -116,8 +113,6 @@ public class BinaryValueTest
     
     private static final SyntaxChecker BINARY_CHECKER = new SyntaxChecker( "1.1.1" )
     {
-        private static final long serialVersionUID = 6721114025331041937L;
-
         public boolean isValidSyntax( Object value )
         {
             if ( value == null )

Modified: directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/StringValueAttributeTypeTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/StringValueAttributeTypeTest.java?rev=1074170&r1=1074169&r2=1074170&view=diff
==============================================================================
--- directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/StringValueAttributeTypeTest.java
(original)
+++ directory/shared/trunk/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/StringValueAttributeTypeTest.java
Thu Feb 24 14:41:45 2011
@@ -38,20 +38,21 @@ import java.util.Comparator;
 import java.util.HashSet;
 import java.util.List;
 
-import com.mycila.junit.concurrent.Concurrency;
-import com.mycila.junit.concurrent.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.schema.AttributeType;
 import org.apache.directory.shared.ldap.model.schema.LdapComparator;
 import org.apache.directory.shared.ldap.model.schema.SyntaxChecker;
 import org.apache.directory.shared.ldap.model.schema.comparators.StringComparator;
-import org.apache.directory.shared.ldap.model.schema.normalizers.NoOpNormalizer;
 import org.apache.directory.shared.ldap.model.schema.normalizers.DeepTrimToLowerNormalizer;
+import org.apache.directory.shared.ldap.model.schema.normalizers.NoOpNormalizer;
 import org.apache.directory.shared.ldap.model.schema.syntaxCheckers.OctetStringSyntaxChecker;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+import com.mycila.junit.concurrent.Concurrency;
+import com.mycila.junit.concurrent.ConcurrentJunitRunner;
+
 
 /**
  * Tests that the StringValue class works properly as expected.
@@ -444,8 +445,6 @@ public class StringValueAttributeTypeTes
     @Test public void testConstrainedString()
     {
         s.setSyntaxChecker( new SyntaxChecker( "1.1.1.1" ) {
-            private static final long serialVersionUID = 0L;
-
             public boolean isValidSyntax( Object value )
             {
                 if ( value instanceof String )
@@ -460,8 +459,6 @@ public class StringValueAttributeTypeTes
         mr.setSyntax( s );
         mr.setLdapComparator( new LdapComparator<String>( mr.getOid() )
         {
-            private static final long serialVersionUID = 0L;
-
             public int compare( String o1, String o2 )
             {
                 if ( o1 == null )



Mime
View raw message