directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akaras...@apache.org
Subject svn commit: r1072825 - in /directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras: ./ extended/ extended/ads_impl/
Date Mon, 21 Feb 2011 02:27:24 GMT
Author: akarasulu
Date: Mon Feb 21 02:27:23 2011
New Revision: 1072825

URL: http://svn.apache.org/viewvc?rev=1072825&view=rev
Log:
DISHARED-86: after extracting interfaces follow naming conventions for Cancel extOp

Added:
    directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java
      - copied, changed from r1072824, directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelRequest.java
    directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequestImpl.java
      - copied, changed from r1072824, directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java
    directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java
      - copied, changed from r1072824, directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelResponse.java
    directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponseImpl.java
      - copied, changed from r1072824, directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java
Removed:
    directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelRequest.java
    directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelResponse.java
Modified:
    directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/ExtrasBundleActivator.java
    directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ads_impl/CancelFactory.java

Modified: directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/ExtrasBundleActivator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/ExtrasBundleActivator.java?rev=1072825&r1=1072824&r2=1072825&view=diff
==============================================================================
--- directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/ExtrasBundleActivator.java
(original)
+++ directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/ExtrasBundleActivator.java
Mon Feb 21 02:27:23 2011
@@ -39,7 +39,7 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.extras.extended.CertGenerationRequest;
 import org.apache.directory.shared.ldap.extras.extended.GracefulDisconnect;
 import org.apache.directory.shared.ldap.extras.extended.GracefulShutdownRequest;
-import org.apache.directory.shared.ldap.extras.extended.ICancelRequest;
+import org.apache.directory.shared.ldap.extras.extended.CancelRequest;
 import org.apache.directory.shared.ldap.extras.extended.StoredProcedureRequest;
 import org.apache.directory.shared.ldap.extras.extended.ads_impl.CancelFactory;
 import org.apache.directory.shared.ldap.extras.extended.ads_impl.CertGenerationFactory;
@@ -150,7 +150,7 @@ public class ExtrasBundleActivator imple
         codec.unregisterControl( SyncStateValue.OID );
         codec.unregisterControl( PasswordPolicy.OID );
         
-        codec.unregisterExtendedRequest( ICancelRequest.EXTENSION_OID );
+        codec.unregisterExtendedRequest( CancelRequest.EXTENSION_OID );
         codec.unregisterExtendedRequest( CertGenerationRequest.EXTENSION_OID );
         codec.unregisterExtendedRequest( GracefulShutdownRequest.EXTENSION_OID );
         codec.unregisterExtendedRequest( StoredProcedureRequest.EXTENSION_OID );

Copied: directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java
(from r1072824, directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelRequest.java)
URL: http://svn.apache.org/viewvc/directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java?p2=directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java&p1=directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelRequest.java&r1=1072824&r2=1072825&rev=1072825&view=diff
==============================================================================
--- directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelRequest.java
(original)
+++ directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java
Mon Feb 21 02:27:23 2011
@@ -27,7 +27,7 @@ import org.apache.directory.shared.ldap.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-public interface ICancelRequest extends ExtendedRequest<ICancelResponse>
+public interface CancelRequest extends ExtendedRequest<CancelResponse>
 {
 
     /** The requestName for this extended request */

Copied: directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequestImpl.java
(from r1072824, directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java)
URL: http://svn.apache.org/viewvc/directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequestImpl.java?p2=directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequestImpl.java&p1=directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java&r1=1072824&r2=1072825&rev=1072825&view=diff
==============================================================================
--- directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequest.java
(original)
+++ directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelRequestImpl.java
Mon Feb 21 02:27:23 2011
@@ -35,7 +35,7 @@ import org.apache.directory.shared.ldap.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-public class CancelRequest extends AbstractExtendedRequest<ICancelResponse> implements
ICancelRequest
+public class CancelRequestImpl extends AbstractExtendedRequest<CancelResponse> implements
CancelRequest
 {
     /** The serial version UUID */
     private static final long serialVersionUID = 1L;
@@ -49,7 +49,7 @@ public class CancelRequest extends Abstr
      * @param messageId the message id
      * @param cancelId the message id of the request to cancel
      */
-    public CancelRequest( int messageId, int cancelId )
+    public CancelRequestImpl( int messageId, int cancelId )
     {
         super( messageId );
         setRequestName( EXTENSION_OID );
@@ -61,7 +61,7 @@ public class CancelRequest extends Abstr
     /**
      * Creates a new instance of CancelRequest.
      */
-    public CancelRequest()
+    public CancelRequestImpl()
     {
         setRequestName( EXTENSION_OID );
     }
@@ -79,11 +79,11 @@ public class CancelRequest extends Abstr
     }
     
 
-    public ICancelResponse getResultResponse()
+    public CancelResponse getResultResponse()
     {
         if ( response == null )
         {
-            response = new CancelResponse( cancelId );
+            response = new CancelResponseImpl( cancelId );
         }
 
         return response;

Copied: directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java
(from r1072824, directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelResponse.java)
URL: http://svn.apache.org/viewvc/directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java?p2=directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java&p1=directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelResponse.java&r1=1072824&r2=1072825&rev=1072825&view=diff
==============================================================================
--- directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ICancelResponse.java
(original)
+++ directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java
Mon Feb 21 02:27:23 2011
@@ -28,7 +28,7 @@ import org.apache.directory.shared.ldap.
  * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-public interface ICancelResponse extends ExtendedResponse
+public interface CancelResponse extends ExtendedResponse
 {
 
 }
\ No newline at end of file

Copied: directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponseImpl.java
(from r1072824, directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java)
URL: http://svn.apache.org/viewvc/directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponseImpl.java?p2=directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponseImpl.java&p1=directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java&r1=1072824&r2=1072825&rev=1072825&view=diff
==============================================================================
--- directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponse.java
(original)
+++ directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/CancelResponseImpl.java
Mon Feb 21 02:27:23 2011
@@ -23,7 +23,6 @@ package org.apache.directory.shared.ldap
 import org.apache.directory.shared.i18n.I18n;
 import org.apache.directory.shared.ldap.model.message.ExtendedResponseImpl;
 import org.apache.directory.shared.ldap.model.message.ResultCodeEnum;
-import org.apache.directory.shared.util.StringConstants;
 
 
 /**
@@ -32,7 +31,7 @@ import org.apache.directory.shared.util.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-public class CancelResponse extends ExtendedResponseImpl implements ICancelResponse
+public class CancelResponseImpl extends ExtendedResponseImpl implements CancelResponse
 {
     /** The serial version UUID */
     private static final long serialVersionUID = 1L;
@@ -43,7 +42,7 @@ public class CancelResponse extends Exte
      * @param messageId The messageId
      * @param rcode the result code
      */
-    public CancelResponse( int messageId, ResultCodeEnum rcode )
+    public CancelResponseImpl( int messageId, ResultCodeEnum rcode )
     {
         super( messageId );
 
@@ -66,7 +65,7 @@ public class CancelResponse extends Exte
     }
 
 
-    public CancelResponse( int messageId )
+    public CancelResponseImpl( int messageId )
     {
         super( messageId );
         super.getLdapResult().setMatchedDn( null );
@@ -74,29 +73,14 @@ public class CancelResponse extends Exte
     }
 
 
-    public CancelResponse()
+    public CancelResponseImpl()
     {
-        super( ICancelRequest.EXTENSION_OID );
+        super( CancelRequest.EXTENSION_OID );
         super.getLdapResult().setMatchedDn( null );
         super.getLdapResult().setResultCode( ResultCodeEnum.SUCCESS );
     }
 
 
-    // ------------------------------------------------------------------------
-    // ExtendedResponse Interface Method Implementations
-    // ------------------------------------------------------------------------
-    /**
-     * Gets the response OID specific encoded response values. It's a null
-     * value for a CancelResponse
-     * 
-     * @return the response specific encoded response values.
-     */
-    public byte[] getResponse()
-    {
-        return StringConstants.EMPTY_BYTES;
-    }
-
-
     /**
      * Gets the OID uniquely identifying this extended response (a.k.a. its
      * name). It's a null value for the Cancel response
@@ -134,6 +118,6 @@ public class CancelResponse extends Exte
             return true;
         }
 
-        return ( obj instanceof CancelResponse );
+        return ( obj instanceof CancelResponseImpl );
     }
 }

Modified: directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ads_impl/CancelFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ads_impl/CancelFactory.java?rev=1072825&r1=1072824&r2=1072825&view=diff
==============================================================================
--- directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ads_impl/CancelFactory.java
(original)
+++ directory/shared/branches/akarasulu/ldap-extras/codec/src/main/java/org/apache/directory/shared/ldap/extras/extended/ads_impl/CancelFactory.java
Mon Feb 21 02:27:23 2011
@@ -22,10 +22,10 @@ package org.apache.directory.shared.ldap
 
 import org.apache.directory.shared.asn1.DecoderException;
 import org.apache.directory.shared.ldap.codec.api.ExtendedRequestFactory;
+import org.apache.directory.shared.ldap.extras.extended.CancelRequestImpl;
+import org.apache.directory.shared.ldap.extras.extended.CancelResponseImpl;
 import org.apache.directory.shared.ldap.extras.extended.CancelRequest;
 import org.apache.directory.shared.ldap.extras.extended.CancelResponse;
-import org.apache.directory.shared.ldap.extras.extended.ICancelRequest;
-import org.apache.directory.shared.ldap.extras.extended.ICancelResponse;
 
 
 /**
@@ -34,32 +34,32 @@ import org.apache.directory.shared.ldap.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-public class CancelFactory implements ExtendedRequestFactory<CancelRequest, CancelResponse>
+public class CancelFactory implements ExtendedRequestFactory<CancelRequestImpl, CancelResponseImpl>
 {
     /**
      * {@inheritDoc}
      */
     public String getOid()
     {
-        return ICancelRequest.EXTENSION_OID;
+        return CancelRequest.EXTENSION_OID;
     }
 
     
     /**
      * {@inheritDoc}
      */
-    public ICancelRequest newRequest()
+    public CancelRequest newRequest()
     {
-        return new CancelRequest();
+        return new CancelRequestImpl();
     }
 
 
     /**
      * {@inheritDoc}
      */
-    public ICancelResponse newResponse( byte[] encodedValue ) throws DecoderException
+    public CancelResponse newResponse( byte[] encodedValue ) throws DecoderException
     {
-        ICancelResponse response = new CancelResponse();
+        CancelResponse response = new CancelResponseImpl();
         response.setResponseValue( encodedValue );
         return response;
     }



Mime
View raw message