directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akaras...@apache.org
Subject svn commit: r1067801 [1/2] - in /directory/shared/branches/m1: ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/ ldap-model/src/main/java/org/apache/directory/shared/ldap/model/exception/ ldap-model/src/main/java/org/apache/directo...
Date Sun, 06 Feb 2011 23:05:34 GMT
Author: akarasulu
Date: Sun Feb  6 23:05:33 2011
New Revision: 1067801

URL: http://svn.apache.org/viewvc?rev=1067801&view=rev
Log:
formatting, spelling, cleaning up warnings

Modified:
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/exception/LdapURLEncodingException.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/FilterParser.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/SimpleNode.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Rdn.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITContentRule.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITStructureRule.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRule.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRuleUse.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NameForm.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NormalizerMappingResolver.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaManager.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaUtils.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/ComparableComparator.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimCachingNormalizingComparator.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DnComparator.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/SerializableComparator.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/DefaultSchemaObjectRegistry.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/Registries.java
    directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/subtree/SubtreeSpecificationParser.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/AttributeUtilsTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterCloneTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterNodeEqualityTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterParserTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/UndefinedNodeTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/AddRequestImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/BindRequestImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/CompareRequestImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/DeleteRequestImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedRequestImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedResponseImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/LdapResultImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyDnRequestImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyRequestImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ReferralImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseDoneImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseReferenceImplTest.java
    directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/name/DnTest.java
    directory/shared/branches/m1/ldap-schema/src/main/java/org/apache/directory/shared/ldap/schemamanager/impl/DefaultSchemaManager.java
    directory/shared/branches/m1/ldap-schema/src/test/java/org/apache/directory/shared/ldap/schemaloader/SchemaManagerEnableDisableLoadTest.java
    directory/shared/branches/m1/util/src/main/java/org/apache/directory/shared/util/ArrayEnumeration.java
    directory/shared/branches/m1/util/src/main/java/org/apache/directory/shared/util/JoinIterator.java
    directory/shared/branches/m1/util/src/main/java/org/apache/directory/shared/util/NoDuplicateKeysMap.java
    directory/shared/branches/m1/util/src/main/java/org/apache/directory/shared/util/SequencedHashMap.java
    directory/shared/branches/m1/util/src/main/java/org/apache/directory/shared/util/UnixCrypt.java
    directory/shared/branches/m1/util/src/test/java/org/apache/directory/shared/util/MethodUtilsTest.java

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/entry/EntryUtils.java Sun Feb  6 23:05:33 2011
@@ -136,24 +136,6 @@ public class EntryUtils
                     ( o2 == null ? 0 : -1 ) :
                     ( o2 == null ? 1 : o1.compareTo( o2 ) ) );
             }
-
-            int getValue( String val )
-            {
-                if ( val.equals( "LOW" ) ) 
-                {
-                    return 0;
-                }
-                else if ( val.equals( "MEDIUM" ) ) 
-                {
-                    return 1;
-                }
-                else if ( val.equals( "HIGH" ) ) 
-                {
-                    return 2;
-                }
-                
-                throw new IllegalArgumentException( I18n.err( I18n.ERR_04473 ) );
-            }
         } );
         
         Normalizer normalizer = new Normalizer( "1.1.1" )

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/exception/LdapURLEncodingException.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/exception/LdapURLEncodingException.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/exception/LdapURLEncodingException.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/exception/LdapURLEncodingException.java Sun Feb  6 23:05:33 2011
@@ -28,6 +28,9 @@ package org.apache.directory.shared.ldap
  */
 public class LdapURLEncodingException extends LdapException
 {
+    private static final long serialVersionUID = 193461058160901616L;
+
+
     /**
      * Creates a LdapStringEncodingException
      * 
@@ -37,5 +40,4 @@ public class LdapURLEncodingException ex
     {
         super( pMessage );
     }
-
 }

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/FilterParser.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/FilterParser.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/FilterParser.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/FilterParser.java Sun Feb  6 23:05:33 2011
@@ -402,6 +402,7 @@ public class FilterParser
      * @param pos
      * @return
      */
+    @SuppressWarnings({ "rawtypes", "unchecked" })
     private static ExprNode parsePresenceEqOrSubstring( SchemaManager schemaManager, String attribute, String filter, Position pos )
         throws ParseException, LdapException
     {
@@ -507,6 +508,7 @@ public class FilterParser
      *                  
      * An item starts with an attribute or a colon.
      */
+    @SuppressWarnings({ "rawtypes", "unchecked" })
     private static ExprNode parseItem( SchemaManager schemaManager, String filter, Position pos, char c ) 
         throws ParseException, LdapException
     {

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/SimpleNode.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/SimpleNode.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/SimpleNode.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/filter/SimpleNode.java Sun Feb  6 23:05:33 2011
@@ -36,11 +36,9 @@ public abstract class SimpleNode<T> exte
     /** the value */
     protected Value<T> value;
 
-    /* TODO - why are these here if not used? */
     /** Constants for comparisons : > */
     public static final boolean EVAL_GREATER = true;
 
-    /* TODO - why are these here if not used? */
     /** Constants for comparisons : < */
     public static final boolean EVAL_LESSER = false;
 
@@ -76,6 +74,7 @@ public abstract class SimpleNode<T> exte
     /**
      * Makes a full clone in new memory space of the current node and children
      */
+    @SuppressWarnings("unchecked")
     @Override
     public ExprNode clone()
     {

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Dn.java Sun Feb  6 23:05:33 2011
@@ -996,6 +996,7 @@ public class Dn implements Cloneable, Se
      *
      * @return All the components
      */
+    @SuppressWarnings("unchecked")
     public List<Rdn> getRdns()
     {
         return UnmodifiableList.decorate( rdns );

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Rdn.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Rdn.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Rdn.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/name/Rdn.java Sun Feb  6 23:05:33 2011
@@ -714,6 +714,7 @@ public class Rdn implements Cloneable, C
             default:
                 if ( atavTypes.containsKey( normalizedType ) )
                 {
+                    @SuppressWarnings("unchecked")
                     Collection<Ava> atavList = ( Collection<Ava> ) atavTypes.get( normalizedType );
                     StringBuffer sb = new StringBuffer();
                     boolean isFirst = true;
@@ -792,6 +793,7 @@ public class Rdn implements Cloneable, C
             default:
                 if ( atavTypes.containsKey( normalizedType ) )
                 {
+                    @SuppressWarnings("unchecked")
                     Collection<Ava> atavList = ( Collection<Ava> ) atavTypes.get( normalizedType );
                     return atavList.iterator().next();
                 }

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITContentRule.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITContentRule.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITContentRule.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITContentRule.java Sun Feb  6 23:05:33 2011
@@ -711,6 +711,7 @@ public class DITContentRule extends Abst
             return false;
         }
 
+        @SuppressWarnings("unused")
         DITContentRule that = ( DITContentRule ) o;
 
         // TODO : complete the check

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITStructureRule.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITStructureRule.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITStructureRule.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/DITStructureRule.java Sun Feb  6 23:05:33 2011
@@ -274,6 +274,7 @@ public class DITStructureRule extends Ab
             return false;
         }
 
+        @SuppressWarnings("unused")
         DITStructureRule that = ( DITStructureRule ) o;
 
         // TODO : complete the test

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRule.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRule.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRule.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRule.java Sun Feb  6 23:05:33 2011
@@ -126,6 +126,7 @@ public class MatchingRule extends Abstra
      * @param registries The Registries
      * @exception If the addition failed
      */
+    @SuppressWarnings({ "unchecked", "rawtypes" })
     public void addToRegistries( List<Throwable> errors, Registries registries ) throws LdapException
     {
         if ( registries != null )
@@ -330,6 +331,7 @@ public class MatchingRule extends Abstra
      *
      * @param ldapComparator The LdapComparator
      */
+    @SuppressWarnings("unchecked")
     public void setLdapComparator( LdapComparator<?> ldapComparator )
     {
         if ( locked )
@@ -349,6 +351,7 @@ public class MatchingRule extends Abstra
      *
      * @param ldapComparator The LdapComparator
      */
+    @SuppressWarnings("unchecked")
     public void updateLdapComparator( LdapComparator<?> ldapComparator )
     {
         if ( locked )

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRuleUse.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRuleUse.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRuleUse.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/MatchingRuleUse.java Sun Feb  6 23:05:33 2011
@@ -297,6 +297,7 @@ public class MatchingRuleUse extends Abs
             return false;
         }
 
+        @SuppressWarnings("unused")
         MatchingRuleUse that = ( MatchingRuleUse ) o;
 
         // TODO : complete the checks

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NameForm.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NameForm.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NameForm.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NameForm.java Sun Feb  6 23:05:33 2011
@@ -531,6 +531,7 @@ public class NameForm extends AbstractSc
             return false;
         }
 
+        @SuppressWarnings("unused")
         NameForm that = ( NameForm ) o;
 
         // TODO : complete the checks

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NormalizerMappingResolver.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NormalizerMappingResolver.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NormalizerMappingResolver.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/NormalizerMappingResolver.java Sun Feb  6 23:05:33 2011
@@ -39,7 +39,7 @@ import java.util.Map;
  * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
-public interface NormalizerMappingResolver
+public interface NormalizerMappingResolver<E extends Normalizer>
 {
-    Map getNormalizerMapping() throws Exception;
+    Map<String, E> getNormalizerMapping() throws Exception;
 }

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaManager.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaManager.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaManager.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaManager.java Sun Feb  6 23:05:33 2011
@@ -783,6 +783,7 @@ public interface SchemaManager
      *
      * @return The the global OidRegistry
      */
+    @SuppressWarnings("rawtypes")
     OidRegistry getGlobalOidRegistry();
 
 

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaUtils.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaUtils.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaUtils.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/SchemaUtils.java Sun Feb  6 23:05:33 2011
@@ -1000,6 +1000,7 @@ public final class SchemaUtils
 
         buf.append( " FORM " ).append( dsr.getForm() );
 
+        @SuppressWarnings("unused")
         List<Integer> ruleIds = dsr.getSuperRules();
         // TODO : Add the rendering
 

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/ComparableComparator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/ComparableComparator.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/ComparableComparator.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/ComparableComparator.java Sun Feb  6 23:05:33 2011
@@ -64,6 +64,7 @@ public class ComparableComparator<T> ext
      * @param o2 the second comparable
      * @return {@inheritDoc}
      */
+    @SuppressWarnings("unchecked")
     public int compare( Comparable<T> o1, Comparable<T> o2 )
     {
         LOG.debug( "comparing objects '{}' with '{}'", o1, o2 );

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimCachingNormalizingComparator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimCachingNormalizingComparator.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimCachingNormalizingComparator.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimCachingNormalizingComparator.java Sun Feb  6 23:05:33 2011
@@ -34,6 +34,7 @@ public class DeepTrimCachingNormalizingC
     private static final long serialVersionUID = -3462901701103045845L;
 
     
+    @SuppressWarnings({ "rawtypes", "unchecked" })
     public DeepTrimCachingNormalizingComparator( String oid )
     {
         super( oid, new CachingNormalizer( new DeepTrimNormalizer( oid ), 10 ),

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DeepTrimToLowerCachingNormalizingComparator.java Sun Feb  6 23:05:33 2011
@@ -34,6 +34,7 @@ public class DeepTrimToLowerCachingNorma
     private static final long serialVersionUID = -3462901701103045845L;
 
     
+    @SuppressWarnings({ "rawtypes", "unchecked" })
     public DeepTrimToLowerCachingNormalizingComparator( String oid )
     {
         super( oid, new CachingNormalizer( new DeepTrimToLowerNormalizer( oid ), 10 ),

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DnComparator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DnComparator.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DnComparator.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/DnComparator.java Sun Feb  6 23:05:33 2011
@@ -34,6 +34,7 @@ import org.apache.directory.shared.ldap.
  * 
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  */
+@SuppressWarnings("serial")
 public class DnComparator extends LdapComparator<Object>
 {
     /** A reference to the schema manager */ 

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/SerializableComparator.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/SerializableComparator.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/SerializableComparator.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/comparators/SerializableComparator.java Sun Feb  6 23:05:33 2011
@@ -87,18 +87,21 @@ public class SerializableComparator<E> e
     /**
      * @param schemaManager the schemaManager to set
      */
+    @SuppressWarnings("unchecked")
     public void setSchemaManager( SchemaManager schemaManager )
     {
         if ( wrapped == null )
         {
             try
             {
-                wrapped = (Comparator<E>)schemaManager.lookupComparatorRegistry( matchingRuleOid );
+                wrapped = ( Comparator<E> ) 
+                    schemaManager.lookupComparatorRegistry( matchingRuleOid );
             }
             catch ( LdapException ne )
             {
                 // Not found : get the default comparator
-                wrapped = (Comparator<E>)new ComparableComparator<Comparable<E>>( matchingRuleOid );
+                wrapped = ( Comparator<E> ) 
+                    new ComparableComparator<Comparable<E>>( matchingRuleOid );
             }
         }
 

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/DefaultSchemaObjectRegistry.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/DefaultSchemaObjectRegistry.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/DefaultSchemaObjectRegistry.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/DefaultSchemaObjectRegistry.java Sun Feb  6 23:05:33 2011
@@ -359,7 +359,7 @@ public abstract class DefaultSchemaObjec
      * {@inheritDoc}
      */
     // This will suppress PMD.EmptyCatchBlock warnings in this method
-    @SuppressWarnings("PMD.EmptyCatchBlock")
+    @SuppressWarnings({ "PMD.EmptyCatchBlock", "unchecked" })
     public SchemaObjectRegistry<T> copy( SchemaObjectRegistry<T> original )
     {
         // Fill the byName and OidRegistry maps, the type has already be copied
@@ -396,7 +396,7 @@ public abstract class DefaultSchemaObjec
                 }
                 else
                 {
-                    copiedValue = (T) value.copy();
+                    copiedValue = ( T ) value.copy();
                 }
 
                 // Update the data structure. 

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/Registries.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/Registries.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/Registries.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/schema/registries/Registries.java Sun Feb  6 23:05:33 2011
@@ -135,7 +135,7 @@ public class Registries implements Schem
     protected Map<SchemaObjectWrapper, Set<SchemaObjectWrapper>> using;
 
     /** A reference on the schema Manager */
-    @SuppressWarnings("PMD.UnusedPrivateField")
+    @SuppressWarnings({ "PMD.UnusedPrivateField", "unused" })
     // False positive 
     private SchemaManager schemaManager;
 
@@ -673,7 +673,7 @@ public class Registries implements Schem
     @SuppressWarnings("PMD.UnusedFormalParameter")
     private void buildDitContentRuleReferences( List<Throwable> errors )
     {
-        for ( DITContentRule ditContentRule : ditContentRuleRegistry )
+        for ( @SuppressWarnings("unused") DITContentRule ditContentRule : ditContentRuleRegistry )
         {
             // TODO
         }
@@ -687,7 +687,7 @@ public class Registries implements Schem
     @SuppressWarnings("PMD.UnusedFormalParameter")
     private void buildDitStructureRuleReferences( List<Throwable> errors )
     {
-        for ( DITStructureRule ditStructureRule : ditStructureRuleRegistry )
+        for ( @SuppressWarnings("unused") DITStructureRule ditStructureRule : ditStructureRuleRegistry )
         {
             // TODO
         }
@@ -792,7 +792,7 @@ public class Registries implements Schem
     @SuppressWarnings("PMD.UnusedFormalParameter")
     private void buildNameFormReferences( List<Throwable> errors )
     {
-        for ( NameForm nameFormRule : nameFormRegistry )
+        for ( @SuppressWarnings("unused") NameForm nameFormRule : nameFormRegistry )
         {
             // TODO
         }

Modified: directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/subtree/SubtreeSpecificationParser.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/subtree/SubtreeSpecificationParser.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/subtree/SubtreeSpecificationParser.java (original)
+++ directory/shared/branches/m1/ldap-model/src/main/java/org/apache/directory/shared/ldap/model/subtree/SubtreeSpecificationParser.java Sun Feb  6 23:05:33 2011
@@ -70,7 +70,8 @@ public class SubtreeSpecificationParser
     /**
      * Creates a normalizing subtree specification parser.
      */
-    public SubtreeSpecificationParser( NormalizerMappingResolver resolver, SchemaManager schemaManager )
+    public SubtreeSpecificationParser( @SuppressWarnings("rawtypes") 
+        NormalizerMappingResolver resolver, SchemaManager schemaManager )
     {
         StringReader in = new StringReader( "" ); // place holder for the
                                                     // first input

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/AttributeUtilsTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/AttributeUtilsTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/AttributeUtilsTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/AttributeUtilsTest.java Sun Feb  6 23:05:33 2011
@@ -19,6 +19,7 @@
  */
 package org.apache.directory.shared.ldap.model.entry;
 
+
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
@@ -30,12 +31,12 @@ import java.util.Set;
 
 import org.apache.directory.junit.tools.Concurrent;
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
-import org.apache.directory.shared.ldap.model.entry.*;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+
 /**
  * A test case for the AttributeUtils methods 
  *

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/entry/BinaryValueTest.java Sun Feb  6 23:05:33 2011
@@ -18,6 +18,7 @@
  */
 package org.apache.directory.shared.ldap.model.entry;
 
+
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertNotNull;
@@ -42,6 +43,7 @@ import org.apache.directory.shared.util.
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+
 /**
  * 
  * Test the BinaryValue class
@@ -114,6 +116,8 @@ public class BinaryValueTest
     
     private static final SyntaxChecker BINARY_CHECKER = new SyntaxChecker( "1.1.1" )
     {
+        private static final long serialVersionUID = 6721114025331041937L;
+
         public boolean isValidSyntax( Object value )
         {
             if ( value == null )

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterCloneTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterCloneTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterCloneTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterCloneTest.java Sun Feb  6 23:05:33 2011
@@ -29,7 +29,6 @@ import java.text.ParseException;
 
 import org.apache.directory.junit.tools.Concurrent;
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
-import org.apache.directory.shared.ldap.model.filter.*;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -43,13 +42,12 @@ import org.junit.runner.RunWith;
 @Concurrent()
 public class FilterCloneTest
 {
-    @SuppressWarnings("unchecked")
     @Test
     public void testItemFilter() throws ParseException
     {
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( null, "(ou~=people)" );
-        // just check that it doesnt throw for now
-        node = (SimpleNode)node.clone();
+        SimpleNode<?> node= ( SimpleNode<?> ) FilterParser.parse( null, "(ou~=people)" );
+        // just check that it doesn't throw for now
+        node = ( SimpleNode<?> )node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertEquals( "people", node.getValue().getString() );
         assertTrue( node instanceof ApproximateNode );
@@ -60,8 +58,8 @@ public class FilterCloneTest
     public void testAndFilter() throws ParseException
     {
         BranchNode node = ( BranchNode ) FilterParser.parse( null, "(&(ou~=people)(age>=30))" );
-        // just check that it doesnt throw for now
-        node = (BranchNode) node.clone();
+        // just check that it doesn't throw for now
+        node = ( BranchNode ) node.clone();
         assertEquals( 2, node.getChildren().size() );
         assertTrue( node instanceof AndNode );
     }
@@ -71,8 +69,8 @@ public class FilterCloneTest
     public void testAndFilterOneChildOnly() throws ParseException
     {
         BranchNode node = ( BranchNode ) FilterParser.parse( null, "(&(ou~=people))" );
-        // just check that it doesnt throw for now
-        node = (BranchNode)node.clone();
+        // just check that it doesn't throw for now
+        node = ( BranchNode ) node.clone();
         assertEquals( 1, node.getChildren().size() );
         assertTrue( node instanceof AndNode);
     }
@@ -82,8 +80,8 @@ public class FilterCloneTest
     public void testOrFilter() throws ParseException
     {
         BranchNode node = ( BranchNode ) FilterParser.parse( null, "(|(ou~=people)(age>=30))" );
-        // just check that it doesnt throw for now
-        node = (BranchNode)node.clone();
+        // just check that it doesn't throw for now
+        node = ( BranchNode ) node.clone();
         assertEquals( 2, node.getChildren().size() );
         assertTrue( node instanceof OrNode );
     }
@@ -93,8 +91,8 @@ public class FilterCloneTest
     public void testOrFilterOneChildOnly() throws ParseException
     {
         BranchNode node = ( BranchNode ) FilterParser.parse( null, "(|(age>=30))" );
-        // just check that it doesnt throw for now
-        node = (BranchNode) node.clone();
+        // just check that it doesn't throw for now
+        node = ( BranchNode )  node.clone();
         assertEquals( 1, node.getChildren().size() );
         assertTrue( node instanceof OrNode );
     }
@@ -104,44 +102,41 @@ public class FilterCloneTest
     public void testNotFilter() throws ParseException
     {
         BranchNode node = ( BranchNode ) FilterParser.parse( null, "(!(&(ou~= people)(age>=30)))" );
-        // just check that it doesnt throw for now
-        node = (BranchNode)node.clone();
+        // just check that it doesn't throw for now
+        node = ( BranchNode ) node.clone();
         assertEquals( 1, node.getChildren().size() );
         assertTrue( node instanceof NotNode );
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testOptionAndEscapesFilter() throws ParseException
     {
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( null, "(ou;lang-de>=\\23\\42asdl fkajsd)" );
-        // just check that it doesnt throw for now
-        node = (SimpleNode)node.clone();
+        SimpleNode<?> node = ( SimpleNode<?> ) FilterParser.parse( null, "(ou;lang-de>=\\23\\42asdl fkajsd)" );
+        // just check that it doesn't throw for now
+        node = (SimpleNode<?>)node.clone();
         assertEquals( "ou;lang-de", node.getAttribute() );
         assertEquals( "#Basdl fkajsd", node.getValue().getString() );
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testOptionsAndEscapesFilter() throws ParseException
     {
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( null, "(ou;lang-de;version-124>=\\23\\42asdl fkajsd)" );
-        // just check that it doesnt throw for now
-        node = (SimpleNode)node.clone();
+        SimpleNode<?> node = ( SimpleNode<?> ) FilterParser.parse( null, "(ou;lang-de;version-124>=\\23\\42asdl fkajsd)" );
+        // just check that it doesn't throw for now
+        node = ( SimpleNode<?> )node.clone();
         assertEquals( "ou;lang-de;version-124", node.getAttribute() );
         assertEquals( "#Basdl fkajsd", node.getValue().getString() );
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testNumericoidOptionsAndEscapesFilter() throws ParseException
     {
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( null, "(1.3.4.2;lang-de;version-124>=\\23\\42asdl fkajsd)" );
-        // just check that it doesnt throw for now
-        node = (SimpleNode)node.clone();
+        SimpleNode<?> node= ( SimpleNode<?> ) FilterParser.parse( null, "(1.3.4.2;lang-de;version-124>=\\23\\42asdl fkajsd)" );
+        // just check that it doesn't throw for now
+        node = ( SimpleNode<?> ) node.clone();
         assertEquals( "1.3.4.2;lang-de;version-124", node.getAttribute() );
         assertEquals( "#Basdl fkajsd", node.getValue().getString() );
     }
@@ -151,7 +146,7 @@ public class FilterCloneTest
     public void testPresentFilter() throws ParseException
     {
         PresenceNode node = ( PresenceNode ) FilterParser.parse( null, "(ou=*)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = (PresenceNode) node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertTrue( node instanceof PresenceNode );
@@ -162,33 +157,31 @@ public class FilterCloneTest
     public void testNumericoidPresentFilter() throws ParseException
     {
         PresenceNode node = (PresenceNode) FilterParser.parse( null, "(1.2.3.4=*)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( PresenceNode )node.clone();
         assertEquals( "1.2.3.4", node.getAttribute() );
         assertTrue( node instanceof PresenceNode );
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testEqualsFilter() throws ParseException
     {
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( null, "(ou=people)" );
-        // just check that it doesnt throw for now
-        node = ( SimpleNode) node.clone();
+        SimpleNode<?> node= ( SimpleNode<?> ) FilterParser.parse( null, "(ou=people)" );
+        // just check that it doesn't throw for now
+        node = ( SimpleNode<?> ) node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertEquals( "people", node.getValue().getString() );
         assertTrue( node instanceof EqualityNode );
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testEqualsWithForwardSlashFilter() throws ParseException
     {
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( null, "(ou=people/in/my/company)" );
-        // just check that it doesnt throw for now
-        node = (SimpleNode) node.clone();
+        SimpleNode<?> node= ( SimpleNode<?> ) FilterParser.parse( null, "(ou=people/in/my/company)" );
+        // just check that it doesn't throw for now
+        node = ( SimpleNode<?> ) node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertEquals( "people/in/my/company", node.getValue().getString() );
         assertTrue( node instanceof EqualityNode );
@@ -199,7 +192,7 @@ public class FilterCloneTest
     public void testExtensibleFilterForm1() throws ParseException
     {
         ExtensibleNode node = ( ExtensibleNode ) FilterParser.parse( null, "(ou:dn:stupidMatch:=dummyAssertion\\23\\2A)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( ExtensibleNode ) node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertEquals( "dummyAssertion#*", node.getValue().getString() );
@@ -213,7 +206,7 @@ public class FilterCloneTest
     public void testExtensibleFilterForm1WithNumericOid() throws ParseException
     {
         ExtensibleNode node = ( ExtensibleNode ) FilterParser.parse( null, "(1.2.3.4:dn:1.3434.23.2:=dummyAssertion\\23\\2A)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( ExtensibleNode )node.clone();
         assertEquals( "1.2.3.4", node.getAttribute() );
         assertEquals( "dummyAssertion#*", node.getValue().getString() );
@@ -227,7 +220,7 @@ public class FilterCloneTest
     public void testExtensibleFilterForm1NoDnAttr() throws ParseException
     {
         ExtensibleNode node = ( ExtensibleNode ) FilterParser.parse( null, "(ou:stupidMatch:=dummyAssertion\\23\\2A)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( ExtensibleNode ) node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertEquals( "dummyAssertion#*", node.getValue().getString() );
@@ -242,7 +235,7 @@ public class FilterCloneTest
     public void testExtensibleFilterForm1NoAttrNoMatchingRule() throws ParseException
     {
         ExtensibleNode node = ( ExtensibleNode ) FilterParser.parse( null, "(ou:=dummyAssertion\\23\\2A)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = (ExtensibleNode) node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertEquals( "dummyAssertion#*", node.getValue().getString() );
@@ -256,7 +249,7 @@ public class FilterCloneTest
     public void testExtensibleFilterForm2() throws ParseException
     {
         ExtensibleNode node = ( ExtensibleNode ) FilterParser.parse( null, "(:dn:stupidMatch:=dummyAssertion\\23\\2A)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( ExtensibleNode ) node.clone();
         assertEquals( null, node.getAttribute() );
         assertEquals( "dummyAssertion#*", node.getValue().getString() );
@@ -282,7 +275,7 @@ public class FilterCloneTest
     public void testExtensibleFilterForm2NoDnAttr() throws ParseException
     {
         ExtensibleNode node1 = ( ExtensibleNode ) FilterParser.parse( null, "(:stupidMatch:=dummyAssertion\\23\\2A)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         ExtensibleNode node = ( ExtensibleNode )node1.clone();
         assertEquals( null, node.getAttribute() );
         assertEquals( "dummyAssertion#*", node.getValue().getString() );
@@ -296,7 +289,7 @@ public class FilterCloneTest
     public void testExtensibleFilterForm2NoDnAttrWithNumericOidNoAttr() throws ParseException
     {
         ExtensibleNode node = ( ExtensibleNode ) FilterParser.parse( null, "(:1.3434.23.2:=dummyAssertion\\23\\2A)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( ExtensibleNode) node.clone();
         assertEquals( null, node.getAttribute() );
         assertEquals( "dummyAssertion#*", node.getValue().getString() );
@@ -310,7 +303,7 @@ public class FilterCloneTest
     public void testSubstringNoAnyNoFinal() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=foo*)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode ) node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertTrue( node instanceof SubstringNode );
@@ -325,7 +318,7 @@ public class FilterCloneTest
     public void testSubstringNoAny() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=foo*bar)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode ) node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertTrue( node instanceof SubstringNode );
@@ -340,7 +333,7 @@ public class FilterCloneTest
     public void testSubstringNoAnyNoIni() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=*bar)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode )node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertTrue( node instanceof SubstringNode );
@@ -355,7 +348,7 @@ public class FilterCloneTest
     public void testSubstringOneAny() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=foo*guy*bar)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode )node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertTrue( node instanceof SubstringNode );
@@ -371,7 +364,7 @@ public class FilterCloneTest
     public void testSubstringManyAny() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=a*b*c*d*e*f)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode )node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertTrue( node instanceof SubstringNode );
@@ -390,7 +383,7 @@ public class FilterCloneTest
     public void testSubstringNoIniManyAny() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=*b*c*d*e*f)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode )node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertTrue( node instanceof SubstringNode );
@@ -409,7 +402,7 @@ public class FilterCloneTest
     public void testSubstringManyAnyNoFinal() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=a*b*c*d*e*)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode )node.clone();
         assertEquals( "ou", node.getAttribute() );
         assertTrue( node instanceof SubstringNode );
@@ -428,7 +421,7 @@ public class FilterCloneTest
     public void testSubstringNoIniManyAnyNoFinal() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=*b*c*d*e*)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode ) node.clone();
         
         assertEquals( "ou", node.getAttribute() );
@@ -448,7 +441,7 @@ public class FilterCloneTest
     public void testSubstringNoAnyDoubleSpaceStar() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=foo* *bar)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode )node.clone();
         
         assertEquals( "ou", node.getAttribute() );
@@ -465,7 +458,7 @@ public class FilterCloneTest
     public void testSubstringAnyDoubleSpaceStar() throws ParseException
     {
         SubstringNode node = (SubstringNode) FilterParser.parse( null, "(ou=foo* a *bar)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode ) node.clone();
         
         assertEquals( "ou", node.getAttribute() );
@@ -487,7 +480,7 @@ public class FilterCloneTest
     public void testSubstringStarAnyStar() throws ParseException
     {
         SubstringNode node = ( SubstringNode ) FilterParser.parse( null, "(ou=*foo*)" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         node = ( SubstringNode )node.clone();
         
         assertEquals( "ou", node.getAttribute() );
@@ -499,13 +492,12 @@ public class FilterCloneTest
     }
     
     
-    @SuppressWarnings("unchecked")
     @Test
     public void testEqualsFilterNullValue() throws ParseException
     {
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( null, "(ou=)" );
-        // just check that it doesnt throw for now
-        node = ( SimpleNode )node.clone();
+        SimpleNode<?> node= ( SimpleNode<?> ) FilterParser.parse( null, "(ou=)" );
+        // just check that it doesn't throw for now
+        node = ( SimpleNode<?> )node.clone();
         
         assertEquals( "ou", node.getAttribute() );
         assertEquals( "", node.getValue().getString() );
@@ -516,13 +508,12 @@ public class FilterCloneTest
     /**
      * test a filter with a # in value
      */
-    @SuppressWarnings("unchecked")
     @Test
     public void testEqualsFilterWithPoundInValue() throws ParseException
     {
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( null, "(uid=#f1)" );
-        // just check that it doesnt throw for now
-        node = ( SimpleNode ) node.clone();
+        SimpleNode<?> node= ( SimpleNode<?> ) FilterParser.parse( null, "(uid=#f1)" );
+        // just check that it doesn't throw for now
+        node = ( SimpleNode<?> ) node.clone();
         assertEquals( "uid", node.getAttribute() );
         assertEquals( "#f1", node.getValue().getString() );
         assertTrue( node instanceof EqualityNode );
@@ -533,7 +524,7 @@ public class FilterCloneTest
     public void testLargeBusyFilter() throws ParseException
     {
         ExprNode node1 = FilterParser.parse( null, "(&(|(2.5.4.3=h*)(2.5.4.4=h*)(2.16.840.1.113730.3.1.241=h*)(2.5.4.42=h*))(!(objectClass=computer))(|(objectClass=person)(objectClass=group)(objectClass=organizationalUnit)(objectClass=domain))(!(&(userAccountControl:1.2.840.113556.1.4.803:=2))))" );
-        // just check that it doesnt throw for now
+        // just check that it doesn't throw for now
         ExprNode node = node1.clone();
         assertTrue(node instanceof AndNode);
         //TODO test full structure

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterNodeEqualityTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterNodeEqualityTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterNodeEqualityTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterNodeEqualityTest.java Sun Feb  6 23:05:33 2011
@@ -23,7 +23,6 @@ package org.apache.directory.shared.ldap
 import org.apache.directory.junit.tools.Concurrent;
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.entry.StringValue;
-import org.apache.directory.shared.ldap.model.filter.*;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterParserTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterParserTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterParserTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/FilterParserTest.java Sun Feb  6 23:05:33 2011
@@ -33,7 +33,6 @@ import java.util.List;
 import org.apache.directory.junit.tools.Concurrent;
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.entry.StringValue;
-import org.apache.directory.shared.ldap.model.filter.*;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -81,7 +80,7 @@ public class FilterParserTest
         assertTrue( checkWrongFilter( "(&(cn=abc)" ) );
     }
 
-    @SuppressWarnings("unchecked")
+
     @Test
     public void testItemFilter() throws ParseException
     {
@@ -156,12 +155,11 @@ public class FilterParserTest
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testOptionAndEscapesFilter() throws ParseException
     {
         String str = "(ou;lang-de>=\\23\\42asdl fkajsd)";     // \23 = '#'
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( str );
+        SimpleNode<?> node = ( SimpleNode<?> ) FilterParser.parse( str );
         assertEquals( "ou;lang-de", node.getAttribute() );
         assertEquals( "#Basdl fkajsd", node.getValue().getString() );
         String  str2 = node.toString();
@@ -169,12 +167,11 @@ public class FilterParserTest
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testOptionsAndEscapesFilter() throws ParseException
     {
         String str = "(ou;lang-de;version-124>=\\23\\42asdl fkajsd)";
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( str );
+        SimpleNode<?> node = ( SimpleNode<?> ) FilterParser.parse( str );
         assertEquals( "ou;lang-de;version-124", node.getAttribute() );
         assertEquals( "#Basdl fkajsd", node.getValue().getString() );
         String  str2 = node.toString();
@@ -182,12 +179,11 @@ public class FilterParserTest
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testNumericoidOptionsAndEscapesFilter() throws ParseException
     {
         String str = "(1.3.4.2;lang-de;version-124>=\\23\\42afdl fkajsd)";
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( str );
+        SimpleNode<?> node = ( SimpleNode<?> ) FilterParser.parse( str );
         assertEquals( "1.3.4.2;lang-de;version-124", node.getAttribute() );
         assertEquals( "#Bafdl fkajsd", node.getValue().getString() );
         String  str2 = node.toString();
@@ -219,12 +215,11 @@ public class FilterParserTest
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testEqualsFilter() throws ParseException
     {
         String str = "(ou=people)";
-        SimpleNode node = ( SimpleNode ) FilterParser.parse( str );
+        SimpleNode<?> node = ( SimpleNode<?> ) FilterParser.parse( str );
         assertEquals( "ou", node.getAttribute() );
         assertEquals( "people", node.getValue().getString() );
         assertTrue( node instanceof EqualityNode );
@@ -250,7 +245,6 @@ public class FilterParserTest
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testEqualsWithForwardSlashFilter() throws ParseException
     {
@@ -878,7 +872,6 @@ public class FilterParserTest
     /**
      * test a filter with a # in value
      */
-    @SuppressWarnings("unchecked")
     @Test
     public void testEqualsFilterWithPoundInValue() throws ParseException
     {
@@ -972,7 +965,6 @@ public class FilterParserTest
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testQuotedChars() throws ParseException
     {
@@ -985,7 +977,6 @@ public class FilterParserTest
     }
 
 
-    @SuppressWarnings("unchecked")
     @Test
     public void testQuotedCharsCase() throws ParseException
     {
@@ -1091,8 +1082,8 @@ public class FilterParserTest
         // First child : (jagplayUserGroup=Active)
         ExprNode child1 = children1.get( 0 );
         assertTrue( child1 instanceof EqualityNode );
-        assertEquals( "jagplayUserGroup", ( ( EqualityNode ) child1 ).getAttribute() );
-        assertEquals( "Active", ( ( EqualityNode ) child1 ).getValue().getString() );
+        assertEquals( "jagplayUserGroup", ( ( EqualityNode<?> ) child1 ).getAttribute() );
+        assertEquals( "Active", ( ( EqualityNode<?> ) child1 ).getValue().getString() );
 
         // Second child : (!(jagplayUserGroup=Banned))
         ExprNode child2 = children1.get( 1 );
@@ -1101,14 +1092,14 @@ public class FilterParserTest
 
         ExprNode notNodeChild1 = notNode1.getFirstChild();
         assertTrue( notNodeChild1 instanceof EqualityNode );
-        assertEquals( "jagplayUserGroup", ( ( EqualityNode ) notNodeChild1 ).getAttribute() );
-        assertEquals( "Banned", ( ( EqualityNode ) notNodeChild1 ).getValue().getString() );
+        assertEquals( "jagplayUserGroup", ( ( EqualityNode<?> ) notNodeChild1 ).getAttribute() );
+        assertEquals( "Banned", ( ( EqualityNode<?> ) notNodeChild1 ).getValue().getString() );
 
         // Third child : (jagplayUserNickname=admin)
         ExprNode child3 = children1.get( 2 );
         assertTrue( child3 instanceof EqualityNode );
-        assertEquals( "jagplayUserNickname", ( ( EqualityNode ) child3 ).getAttribute() );
-        assertEquals( "admin", ( ( EqualityNode ) child3 ).getValue().getString() );
+        assertEquals( "jagplayUserNickname", ( ( EqualityNode<?> ) child3 ).getAttribute() );
+        assertEquals( "admin", ( ( EqualityNode<?> ) child3 ).getValue().getString() );
 
         // Check Node 2 : (&(jagplayUserNickname=admin)(&(jagplayUserGroup=Active)(!(jagplayUserGroup=Banned))))
         assertEquals( 2, node2.getChildren().size() );
@@ -1116,8 +1107,8 @@ public class FilterParserTest
 
         child1 = node2.getChildren().get( 0 );
         assertTrue( child1 instanceof EqualityNode );
-        assertEquals( "jagplayUserNickname", ( ( EqualityNode ) child1 ).getAttribute() );
-        assertEquals( "admin", ( ( EqualityNode ) child1 ).getValue().getString() );
+        assertEquals( "jagplayUserNickname", ( ( EqualityNode<?> ) child1 ).getAttribute() );
+        assertEquals( "admin", ( ( EqualityNode<?> ) child1 ).getValue().getString() );
 
         child2 = node2.getChildren().get( 1 );
         assertTrue( child2 instanceof AndNode );
@@ -1127,8 +1118,8 @@ public class FilterParserTest
         // First child : (jagplayUserGroup=Active)
         child1 = andNode2.getChildren().get( 0 );
         assertTrue( child1 instanceof EqualityNode );
-        assertEquals( "jagplayUserGroup", ( ( EqualityNode ) child1 ).getAttribute() );
-        assertEquals( "Active", ( ( EqualityNode ) child1 ).getValue().getString() );
+        assertEquals( "jagplayUserGroup", ( ( EqualityNode<?> ) child1 ).getAttribute() );
+        assertEquals( "Active", ( ( EqualityNode<?> ) child1 ).getValue().getString() );
 
         // second child : (!(jagplayUserGroup=Banned))
         child2 = andNode2.getChildren().get( 1 );
@@ -1137,7 +1128,7 @@ public class FilterParserTest
 
         notNodeChild1 = notNode1.getFirstChild();
         assertTrue( notNodeChild1 instanceof EqualityNode );
-        assertEquals( "jagplayUserGroup", ( ( EqualityNode ) notNodeChild1 ).getAttribute() );
-        assertEquals( "Banned", ( ( EqualityNode ) notNodeChild1 ).getValue().getString() );
+        assertEquals( "jagplayUserGroup", ( ( EqualityNode<?> ) notNodeChild1 ).getAttribute() );
+        assertEquals( "Banned", ( ( EqualityNode<?> ) notNodeChild1 ).getValue().getString() );
     }
 }

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/UndefinedNodeTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/UndefinedNodeTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/UndefinedNodeTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/filter/UndefinedNodeTest.java Sun Feb  6 23:05:33 2011
@@ -29,7 +29,6 @@ import java.util.List;
 
 import org.apache.directory.junit.tools.Concurrent;
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
-import org.apache.directory.shared.ldap.model.filter.*;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/AddRequestImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/AddRequestImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/AddRequestImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/AddRequestImplTest.java Sun Feb  6 23:05:33 2011
@@ -34,7 +34,6 @@ import org.apache.directory.shared.ldap.
 import org.apache.directory.shared.ldap.model.entry.EntryAttribute;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.exception.MessageException;
-import org.apache.directory.shared.ldap.model.entry.Value;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -303,61 +302,7 @@ public class AddRequestImplTest
                 return false;
             }
 
-
-            public void addAttributeType( String type ) throws LdapException
-            {
-            }
-
-
-            public void addAttributeValue( String value )
-            {
-            }
-
-
-            public void addAttributeValue( Value<?> value )
-            {
-            }
-
-
-            public void addAttributeValue( byte[] value )
-            {
-            }
-
-
-            public String getCurrentAttributeType()
-            {
-                return null;
-            }
-
-
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
+            
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/BindRequestImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/BindRequestImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/BindRequestImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/BindRequestImplTest.java Sun Feb  6 23:05:33 2011
@@ -30,7 +30,6 @@ import org.apache.directory.junit.tools.
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.exception.MessageException;
-import org.apache.directory.shared.ldap.model.message.*;
 import org.apache.directory.shared.ldap.model.message.Control;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.Test;
@@ -358,34 +357,6 @@ public class BindRequestImplTest
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/CompareRequestImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/CompareRequestImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/CompareRequestImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/CompareRequestImplTest.java Sun Feb  6 23:05:33 2011
@@ -31,7 +31,6 @@ import org.apache.directory.junit.tools.
 import org.apache.directory.shared.ldap.model.entry.Value;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.exception.MessageException;
-import org.apache.directory.shared.ldap.model.message.*;
 import org.apache.directory.shared.ldap.model.message.Control;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.Test;
@@ -307,34 +306,6 @@ public class CompareRequestImplTest
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/DeleteRequestImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/DeleteRequestImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/DeleteRequestImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/DeleteRequestImplTest.java Sun Feb  6 23:05:33 2011
@@ -30,7 +30,6 @@ import org.apache.directory.junit.tools.
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.exception.MessageException;
-import org.apache.directory.shared.ldap.model.message.*;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -239,34 +238,6 @@ public class DeleteRequestImplTest
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedRequestImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedRequestImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedRequestImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedRequestImplTest.java Sun Feb  6 23:05:33 2011
@@ -26,13 +26,9 @@ import static org.junit.Assert.assertTru
 import java.util.HashMap;
 import java.util.Map;
 
-import javax.naming.NamingException;
-import javax.naming.ldap.ExtendedResponse;
-
 import org.apache.directory.junit.tools.Concurrent;
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.MessageException;
-import org.apache.directory.shared.ldap.model.message.*;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -252,13 +248,6 @@ public class ExtendedRequestImplTest
             }
 
 
-            public ExtendedResponse createExtendedResponse( String id, byte[] berValue, int offset, int length )
-                throws NamingException
-            {
-                return null;
-            }
-
-
             public void addAllControls( Control[] controls ) throws MessageException
             {
             }
@@ -270,34 +259,6 @@ public class ExtendedRequestImplTest
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedResponseImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedResponseImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedResponseImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ExtendedResponseImplTest.java Sun Feb  6 23:05:33 2011
@@ -224,34 +224,6 @@ public class ExtendedResponseImplTest
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/LdapResultImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/LdapResultImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/LdapResultImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/LdapResultImplTest.java Sun Feb  6 23:05:33 2011
@@ -26,7 +26,6 @@ import static org.junit.Assert.assertTru
 import org.apache.directory.junit.tools.Concurrent;
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
-import org.apache.directory.shared.ldap.model.message.*;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.junit.Test;
 import org.junit.runner.RunWith;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyDnRequestImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyDnRequestImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyDnRequestImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyDnRequestImplTest.java Sun Feb  6 23:05:33 2011
@@ -30,7 +30,6 @@ import org.apache.directory.junit.tools.
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.LdapException;
 import org.apache.directory.shared.ldap.model.exception.MessageException;
-import org.apache.directory.shared.ldap.model.message.*;
 import org.apache.directory.shared.ldap.model.message.Control;
 import org.apache.directory.shared.ldap.model.name.Dn;
 import org.apache.directory.shared.ldap.model.name.Rdn;
@@ -399,34 +398,6 @@ public class ModifyDnRequestImplTest
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyRequestImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyRequestImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyRequestImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ModifyRequestImplTest.java Sun Feb  6 23:05:33 2011
@@ -32,7 +32,6 @@ import java.util.Map;
 import org.apache.directory.junit.tools.Concurrent;
 import org.apache.directory.junit.tools.ConcurrentJunitRunner;
 import org.apache.directory.shared.ldap.model.exception.MessageException;
-import org.apache.directory.shared.ldap.model.message.*;
 import org.apache.directory.shared.ldap.model.entry.DefaultEntryAttribute;
 import org.apache.directory.shared.ldap.model.entry.DefaultModification;
 import org.apache.directory.shared.ldap.model.entry.EntryAttribute;
@@ -428,34 +427,6 @@ public class ModifyRequestImplTest
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;
@@ -494,43 +465,31 @@ public class ModifyRequestImplTest
 
             public void add( String attributeName, String... attributeValue )
             {
-                // TODO Auto-generated method stub
-
             }
 
 
             public void add( String attributeName, byte[]... attributeValue )
             {
-                // TODO Auto-generated method stub
-
             }
 
 
             public void add( EntryAttribute attr )
             {
-                // TODO Auto-generated method stub
-
             }
 
 
             public void remove( String attributeName, String... attributeValue )
             {
-                // TODO Auto-generated method stub
-
             }
 
 
             public void remove( String attributeName, byte[]... attributeValue )
             {
-                // TODO Auto-generated method stub
-
             }
 
 
             public void remove( EntryAttribute attr )
             {
-                // TODO Auto-generated method stub
-
             }
         };
 

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ReferralImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ReferralImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ReferralImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/ReferralImplTest.java Sun Feb  6 23:05:33 2011
@@ -198,7 +198,7 @@ public class ReferralImplTest
         {
             public Collection<String> getLdapUrls()
             {
-                return Collections.EMPTY_LIST;
+                return Collections.emptyList();
             }
 
 

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseDoneImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseDoneImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseDoneImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseDoneImplTest.java Sun Feb  6 23:05:33 2011
@@ -185,34 +185,6 @@ public class SearchResponseDoneImplTest
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseReferenceImplTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseReferenceImplTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseReferenceImplTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/message/SearchResponseReferenceImplTest.java Sun Feb  6 23:05:33 2011
@@ -162,34 +162,6 @@ public class SearchResponseReferenceImpl
             }
 
 
-            public Control getCurrentControl()
-            {
-                return null;
-            }
-
-
-            public int getControlsLength()
-            {
-                return 0;
-            }
-
-
-            public void setControlsLength( int controlsLength )
-            {
-            }
-
-
-            public int getMessageLength()
-            {
-                return 0;
-            }
-
-
-            public void setMessageLength( int messageLength )
-            {
-            }
-
-
             public Control getControl( String oid )
             {
                 return null;

Modified: directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/name/DnTest.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/name/DnTest.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/name/DnTest.java (original)
+++ directory/shared/branches/m1/ldap-model/src/test/java/org/apache/directory/shared/ldap/model/name/DnTest.java Sun Feb  6 23:05:33 2011
@@ -3650,7 +3650,7 @@ public class DnTest
 
         for ( Rdn rdn : dn )
         {
-            fail( "Should not be there" );
+            fail( "Should not be there: rdn = " + rdn );
         }
 
         assertTrue( true );

Modified: directory/shared/branches/m1/ldap-schema/src/main/java/org/apache/directory/shared/ldap/schemamanager/impl/DefaultSchemaManager.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/m1/ldap-schema/src/main/java/org/apache/directory/shared/ldap/schemamanager/impl/DefaultSchemaManager.java?rev=1067801&r1=1067800&r2=1067801&view=diff
==============================================================================
--- directory/shared/branches/m1/ldap-schema/src/main/java/org/apache/directory/shared/ldap/schemamanager/impl/DefaultSchemaManager.java (original)
+++ directory/shared/branches/m1/ldap-schema/src/main/java/org/apache/directory/shared/ldap/schemamanager/impl/DefaultSchemaManager.java Sun Feb  6 23:05:33 2011
@@ -1922,6 +1922,7 @@ public class DefaultSchemaManager implem
     /**
      * {@inheritDoc}
      */
+    @SuppressWarnings("rawtypes")
     public OidRegistry getGlobalOidRegistry()
     {
         return registries.getGlobalOidRegistry();



Mime
View raw message