Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchRequestImpl.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchRequestImpl.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchRequestImpl.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchRequestImpl.java Mon Dec 20 14:15:55 2010 @@ -32,7 +32,6 @@ import org.apache.directory.shared.asn1. import org.apache.directory.shared.ldap.codec.AttributeValueAssertion; import org.apache.directory.shared.ldap.codec.LdapConstants; import org.apache.directory.shared.ldap.codec.LdapMessageContainer; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.codec.search.AndFilter; import org.apache.directory.shared.ldap.codec.search.AttributeValueAssertionFilter; import org.apache.directory.shared.ldap.codec.search.ConnectorFilter; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultDone.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultDone.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultDone.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultDone.java Mon Dec 20 14:15:55 2010 @@ -20,9 +20,6 @@ package org.apache.directory.shared.ldap.message; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; - - /** * Search done protocol response message used to indicate the completion of a * search request message. Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultEntry.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultEntry.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultEntry.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultEntry.java Mon Dec 20 14:15:55 2010 @@ -21,7 +21,6 @@ package org.apache.directory.shared.ldap.message; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.entry.Entry; import org.apache.directory.shared.ldap.entry.EntryAttribute; import org.apache.directory.shared.ldap.exception.LdapException; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultReference.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultReference.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultReference.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SearchResultReference.java Mon Dec 20 14:15:55 2010 @@ -21,9 +21,6 @@ package org.apache.directory.shared.ldap.message; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; - - /** * Search reference protocol response message used to return referrals to the * client in response to a search request message. Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SingleReplyRequest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SingleReplyRequest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SingleReplyRequest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/SingleReplyRequest.java Mon Dec 20 14:15:55 2010 @@ -19,8 +19,6 @@ */ package org.apache.directory.shared.ldap.message; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; - /** * Super interface for all request messages returning only one type of response. Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/UnbindRequest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/UnbindRequest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/UnbindRequest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/message/UnbindRequest.java Mon Dec 20 14:15:55 2010 @@ -19,8 +19,6 @@ */ package org.apache.directory.shared.ldap.message; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; - /** * Unbind protocol request message used to end a client session. Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/IntegerSyntaxChecker.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/IntegerSyntaxChecker.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/IntegerSyntaxChecker.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/IntegerSyntaxChecker.java Mon Dec 20 14:15:55 2010 @@ -23,6 +23,7 @@ package org.apache.directory.shared.ldap import org.apache.directory.shared.ldap.constants.SchemaConstants; import org.apache.directory.shared.ldap.schema.SyntaxChecker; import org.apache.directory.shared.ldap.util.StringTools; +import org.apache.directory.shared.util.Strings; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -101,7 +102,7 @@ public class IntegerSyntaxChecker extend { pos = 1; } - else if ( !StringTools.isDigit( c ) ) + else if ( !Strings.isDigit(c) ) { LOG.debug( "Syntax invalid for '{}'", value ); return false; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaByteSyntaxChecker.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaByteSyntaxChecker.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaByteSyntaxChecker.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaByteSyntaxChecker.java Mon Dec 20 14:15:55 2010 @@ -22,6 +22,7 @@ package org.apache.directory.shared.ldap import org.apache.directory.shared.ldap.constants.SchemaConstants; import org.apache.directory.shared.ldap.schema.SyntaxChecker; import org.apache.directory.shared.ldap.util.StringTools; +import org.apache.directory.shared.util.Strings; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -101,7 +102,7 @@ public class JavaByteSyntaxChecker exten { pos = 1; } - else if ( !StringTools.isDigit( c ) ) + else if ( !Strings.isDigit(c) ) { LOG.debug( "Syntax invalid for '{}'", value ); return false; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaIntegerSyntaxChecker.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaIntegerSyntaxChecker.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaIntegerSyntaxChecker.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaIntegerSyntaxChecker.java Mon Dec 20 14:15:55 2010 @@ -22,6 +22,7 @@ package org.apache.directory.shared.ldap import org.apache.directory.shared.ldap.constants.SchemaConstants; import org.apache.directory.shared.ldap.schema.SyntaxChecker; import org.apache.directory.shared.ldap.util.StringTools; +import org.apache.directory.shared.util.Strings; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -102,7 +103,7 @@ public class JavaIntegerSyntaxChecker ex { pos = 1; } - else if ( !StringTools.isDigit( c ) ) + else if ( !Strings.isDigit(c) ) { LOG.debug( "Syntax invalid for '{}'", value ); return false; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaLongSyntaxChecker.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaLongSyntaxChecker.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaLongSyntaxChecker.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaLongSyntaxChecker.java Mon Dec 20 14:15:55 2010 @@ -22,6 +22,7 @@ package org.apache.directory.shared.ldap import org.apache.directory.shared.ldap.constants.SchemaConstants; import org.apache.directory.shared.ldap.schema.SyntaxChecker; import org.apache.directory.shared.ldap.util.StringTools; +import org.apache.directory.shared.util.Strings; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -101,7 +102,7 @@ public class JavaLongSyntaxChecker exten { pos = 1; } - else if ( !StringTools.isDigit( c ) ) + else if ( !Strings.isDigit(c) ) { LOG.debug( "Syntax invalid for '{}'", value ); return false; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaShortSyntaxChecker.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaShortSyntaxChecker.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaShortSyntaxChecker.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/JavaShortSyntaxChecker.java Mon Dec 20 14:15:55 2010 @@ -22,6 +22,7 @@ package org.apache.directory.shared.ldap import org.apache.directory.shared.ldap.constants.SchemaConstants; import org.apache.directory.shared.ldap.schema.SyntaxChecker; import org.apache.directory.shared.ldap.util.StringTools; +import org.apache.directory.shared.util.Strings; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -101,7 +102,7 @@ public class JavaShortSyntaxChecker exte { pos = 1; } - else if ( !StringTools.isDigit( c ) ) + else if ( !Strings.isDigit(c) ) { LOG.debug( "Syntax invalid for '{}'", value ); return false; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OidSyntaxChecker.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OidSyntaxChecker.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OidSyntaxChecker.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OidSyntaxChecker.java Mon Dec 20 14:15:55 2010 @@ -24,6 +24,7 @@ import org.apache.directory.shared.asn1. import org.apache.directory.shared.ldap.constants.SchemaConstants; import org.apache.directory.shared.ldap.schema.SyntaxChecker; import org.apache.directory.shared.ldap.util.StringTools; +import org.apache.directory.shared.util.Strings; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -100,7 +101,7 @@ public class OidSyntaxChecker extends Sy // if the first character is a digit it's an attempt at an OID and must be // checked to make sure there are no other chars except '.' and digits. - if ( StringTools.isDigit( strValue.charAt( 0 ) ) ) + if ( Strings.isDigit(strValue.charAt(0)) ) { if ( ! OID.isOID( strValue ) ) { Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/AttributeUtils.java Mon Dec 20 14:15:55 2010 @@ -921,7 +921,7 @@ public final class AttributeUtils int start = pos.start; - if ( StringTools.isAlpha( c ) ) + if ( Strings.isAlpha(c) ) { // A DESCR pos.start++; @@ -939,7 +939,7 @@ public final class AttributeUtils return str.substring( start, pos.start ); } - else if ( StringTools.isDigit( c ) ) + else if ( Strings.isDigit(c) ) { // An OID pos.start++; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/DNUtils.java Mon Dec 20 14:15:55 2010 @@ -20,6 +20,8 @@ package org.apache.directory.shared.ldap.util; +import org.apache.directory.shared.util.Strings; + /** * Utility class used by the DN Parser. * @@ -323,7 +325,7 @@ public final class DNUtils { byte b = bytes[index++]; - if ( StringTools.isAlpha( b ) ) + if ( Strings.isAlpha(b) ) { return index-1; } Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/JndiUtils.java Mon Dec 20 14:15:55 2010 @@ -50,7 +50,7 @@ import javax.naming.ldap.ExtendedRequest import javax.naming.ldap.ExtendedResponse; import javax.naming.ldap.LdapName; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; +import org.apache.directory.shared.ldap.message.MessageTypeEnum; import org.apache.directory.shared.ldap.codec.controls.ControlImpl; import org.apache.directory.shared.ldap.exception.LdapAffectMultipleDsaException; import org.apache.directory.shared.ldap.exception.LdapAliasDereferencingException; @@ -77,10 +77,7 @@ import org.apache.directory.shared.ldap. import org.apache.directory.shared.ldap.exception.LdapServiceUnavailableException; import org.apache.directory.shared.ldap.exception.LdapTimeLimitExceededException; import org.apache.directory.shared.ldap.exception.LdapUnwillingToPerformException; -import org.apache.directory.shared.ldap.message.ExtendedResponseImpl; -import org.apache.directory.shared.ldap.message.LdapResult; -import org.apache.directory.shared.ldap.message.MessageException; -import org.apache.directory.shared.ldap.message.ResultResponse; +import org.apache.directory.shared.ldap.message.*; import org.apache.directory.shared.ldap.message.control.Control; import org.apache.directory.shared.ldap.name.DN; Modified: directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/main/java/org/apache/directory/shared/ldap/util/StringTools.java Mon Dec 20 14:15:55 2010 @@ -1347,7 +1347,7 @@ public final class StringTools /** * Test if the current character is equal to a specific character. * - * @param string The String which contains the data + * @param bytes The String which contains the data * @param index Current position in the string * @param car The character we want to compare with the current string * position @@ -1491,7 +1491,7 @@ public final class StringTools * Check if the current byte is an Hex Char * <hex> ::= [0x30-0x39] | [0x41-0x46] | [0x61-0x66] * - * @param byte The byte we want to check + * @param b The byte we want to check * @return true if the current byte is a Hex byte */ public static boolean isHex( byte b ) @@ -1615,50 +1615,6 @@ public final class StringTools } } - - /** - * Test if the current character is a digit <digit> ::= '0' | '1' | '2' | - * '3' | '4' | '5' | '6' | '7' | '8' | '9' - * - * @param car the character to test - * - * @return true if the character is a Digit - */ - public static boolean isDigit( char car ) - { - return ( car >= '0' ) && ( car <= '9' ); - } - - - /** - * Test if the current byte is an Alpha character : - * <alpha> ::= [0x41-0x5A] | [0x61-0x7A] - * - * @param c The byte to test - * - * @return true if the byte is an Alpha - * character - */ - public static boolean isAlpha( byte c ) - { - return ( ( c > 0 ) && ( c <= 127 ) && CharConstants.ALPHA[c] ); - } - - - /** - * Test if the current character is an Alpha character : - * <alpha> ::= [0x41-0x5A] | [0x61-0x7A] - * - * @param c The char to test - * - * @return true if the character is an Alpha - * character - */ - public static boolean isAlpha( char c ) - { - return ( ( c > 0 ) && ( c <= 127 ) && CharConstants.ALPHA[c] ); - } - /** * Test if the current character is an Alpha character : <alpha> ::= @@ -3252,19 +3208,6 @@ public final class StringTools return ( ( c > 127 ) || CharConstants.UNICODE_SUBSET[c] ); } - - /** - * Check if the current char is in the unicodeSubset : all chars but - * '\0', '(', ')', '*' and '\' - * - * @param c The char to check - * @return True if the current char is in the unicode subset - */ - public static boolean isUnicodeSubset( char c ) - { - return ( ( c > 127 ) || CharConstants.UNICODE_SUBSET[c] ); - } - /** * converts the bytes of a UUID to string Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AbstractMessageTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AbstractMessageTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AbstractMessageTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AbstractMessageTest.java Mon Dec 20 14:15:55 2010 @@ -25,7 +25,6 @@ import static org.junit.Assert.assertTru import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.codec.controls.ControlImpl; import org.junit.Test; import org.junit.runner.RunWith; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AbstractResultResponseTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AbstractResultResponseTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AbstractResultResponseTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AbstractResultResponseTest.java Mon Dec 20 14:15:55 2010 @@ -25,7 +25,6 @@ import static org.junit.Assert.assertTru import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.codec.controls.ControlImpl; import org.apache.directory.shared.ldap.exception.LdapException; import org.apache.directory.shared.ldap.name.DN; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AddRequestImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AddRequestImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AddRequestImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/AddRequestImplTest.java Mon Dec 20 14:15:55 2010 @@ -28,7 +28,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.entry.DefaultEntry; import org.apache.directory.shared.ldap.entry.DefaultEntryAttribute; import org.apache.directory.shared.ldap.entry.Entry; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/BindRequestImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/BindRequestImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/BindRequestImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/BindRequestImplTest.java Mon Dec 20 14:15:55 2010 @@ -28,7 +28,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.exception.LdapException; import org.apache.directory.shared.ldap.message.control.Control; import org.apache.directory.shared.ldap.name.DN; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/CompareRequestImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/CompareRequestImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/CompareRequestImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/CompareRequestImplTest.java Mon Dec 20 14:15:55 2010 @@ -28,7 +28,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.entry.Value; import org.apache.directory.shared.ldap.exception.LdapException; import org.apache.directory.shared.ldap.message.control.Control; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/DeleteRequestImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/DeleteRequestImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/DeleteRequestImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/DeleteRequestImplTest.java Mon Dec 20 14:15:55 2010 @@ -28,7 +28,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.exception.LdapException; import org.apache.directory.shared.ldap.message.control.Control; import org.apache.directory.shared.ldap.name.DN; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ExtendedRequestImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ExtendedRequestImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ExtendedRequestImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ExtendedRequestImplTest.java Mon Dec 20 14:15:55 2010 @@ -31,7 +31,6 @@ import javax.naming.ldap.ExtendedRespons import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.message.control.Control; import org.junit.Test; import org.junit.runner.RunWith; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ExtendedResponseImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ExtendedResponseImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ExtendedResponseImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ExtendedResponseImplTest.java Mon Dec 20 14:15:55 2010 @@ -28,7 +28,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.exception.LdapException; import org.apache.directory.shared.ldap.message.control.Control; import org.apache.directory.shared.ldap.name.DN; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ModifyDnRequestImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ModifyDnRequestImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ModifyDnRequestImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ModifyDnRequestImplTest.java Mon Dec 20 14:15:55 2010 @@ -28,7 +28,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.exception.LdapException; import org.apache.directory.shared.ldap.message.control.Control; import org.apache.directory.shared.ldap.name.DN; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ModifyRequestImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ModifyRequestImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ModifyRequestImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/ModifyRequestImplTest.java Mon Dec 20 14:15:55 2010 @@ -31,7 +31,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.entry.DefaultEntryAttribute; import org.apache.directory.shared.ldap.entry.DefaultModification; import org.apache.directory.shared.ldap.entry.EntryAttribute; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/SearchResponseDoneImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/SearchResponseDoneImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/SearchResponseDoneImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/SearchResponseDoneImplTest.java Mon Dec 20 14:15:55 2010 @@ -28,7 +28,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.exception.LdapException; import org.apache.directory.shared.ldap.message.control.Control; import org.apache.directory.shared.ldap.name.DN; Modified: directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/SearchResponseReferenceImplTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/SearchResponseReferenceImplTest.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/SearchResponseReferenceImplTest.java (original) +++ directory/shared/branches/alex_refactoring/ldap/src/test/java/org/apache/directory/shared/ldap/message/SearchResponseReferenceImplTest.java Mon Dec 20 14:15:55 2010 @@ -28,7 +28,6 @@ import java.util.Map; import org.apache.directory.junit.tools.Concurrent; import org.apache.directory.junit.tools.ConcurrentJunitRunner; -import org.apache.directory.shared.ldap.codec.MessageTypeEnum; import org.apache.directory.shared.ldap.message.control.Control; import org.junit.Test; import org.junit.runner.RunWith; Modified: directory/shared/branches/alex_refactoring/util/src/main/java/org/apache/directory/shared/util/Strings.java URL: http://svn.apache.org/viewvc/directory/shared/branches/alex_refactoring/util/src/main/java/org/apache/directory/shared/util/Strings.java?rev=1051118&r1=1051117&r2=1051118&view=diff ============================================================================== --- directory/shared/branches/alex_refactoring/util/src/main/java/org/apache/directory/shared/util/Strings.java (original) +++ directory/shared/branches/alex_refactoring/util/src/main/java/org/apache/directory/shared/util/Strings.java Mon Dec 20 14:15:55 2010 @@ -53,4 +53,57 @@ public class Strings return sb.toString(); } + + /** + * Test if the current character is a digit <digit> ::= '0' | '1' | '2' | + * '3' | '4' | '5' | '6' | '7' | '8' | '9' + * + * @param car the character to test + * + * @return true if the character is a Digit + */ + public static boolean isDigit( char car ) + { + return ( car >= '0' ) && ( car <= '9' ); + } + + /** + * Test if the current byte is an Alpha character : + * <alpha> ::= [0x41-0x5A] | [0x61-0x7A] + * + * @param c The byte to test + * + * @return true if the byte is an Alpha + * character + */ + public static boolean isAlpha( byte c ) + { + return ( ( c > 0 ) && ( c <= 127 ) && CharConstants.ALPHA[c] ); + } + + /** + * Test if the current character is an Alpha character : + * <alpha> ::= [0x41-0x5A] | [0x61-0x7A] + * + * @param c The char to test + * + * @return true if the character is an Alpha + * character + */ + public static boolean isAlpha( char c ) + { + return ( ( c > 0 ) && ( c <= 127 ) && CharConstants.ALPHA[c] ); + } + + /** + * Check if the current char is in the unicodeSubset : all chars but + * '\0', '(', ')', '*' and '\' + * + * @param c The char to check + * @return True if the current char is in the unicode subset + */ + public static boolean isUnicodeSubset( char c ) + { + return ( ( c > 127 ) || CharConstants.UNICODE_SUBSET[c] ); + } }