Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 56661 invoked from network); 13 Sep 2010 20:44:45 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Sep 2010 20:44:45 -0000 Received: (qmail 79943 invoked by uid 500); 13 Sep 2010 20:44:45 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 79681 invoked by uid 500); 13 Sep 2010 20:44:45 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 79315 invoked by uid 99); 13 Sep 2010 20:44:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Sep 2010 20:44:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Sep 2010 20:44:42 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 671BB23889EA; Mon, 13 Sep 2010 20:44:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r996683 - /directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java Date: Mon, 13 Sep 2010 20:44:21 -0000 To: commits@directory.apache.org From: kayyagari@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100913204421.671BB23889EA@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: kayyagari Date: Mon Sep 13 20:44:21 2010 New Revision: 996683 URL: http://svn.apache.org/viewvc?rev=996683&view=rev Log: o removed some unused code (the if conditions will never be executed cause the corresponding XXXFuture can never be null inside the switch block) Modified: directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java Modified: directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java?rev=996683&r1=996682&r2=996683&view=diff ============================================================================== --- directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java (original) +++ directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/LdapNetworkConnection.java Mon Sep 13 20:44:21 2010 @@ -1466,12 +1466,6 @@ public class LdapNetworkConnection exten AddFuture addFuture = ( AddFuture ) responseFuture; - if ( addFuture == null ) - { - LOG.error( "AddFuture is null" ); - throw new LdapException( "AddFuture is null" ); - } - // remove the listener from the listener map if ( LOG.isDebugEnabled() ) { @@ -1501,12 +1495,6 @@ public class LdapNetworkConnection exten BindFuture bindFuture = ( BindFuture ) responseFuture; - if ( bindFuture == null ) - { - LOG.error( "BindFuture is null" ); - throw new LdapException( "BindFuture is null" ); - } - // remove the listener from the listener map if ( bindResponse.getLdapResult().getResultCode() == ResultCodeEnum.SUCCESS ) { @@ -1535,12 +1523,6 @@ public class LdapNetworkConnection exten CompareFuture compareFuture = ( CompareFuture ) responseFuture; - if ( compareFuture == null ) - { - LOG.error( "CompareFuture is null" ); - throw new LdapException( "CompareFuture is null" ); - } - // remove the listener from the listener map if ( LOG.isDebugEnabled() ) { @@ -1570,12 +1552,6 @@ public class LdapNetworkConnection exten DeleteFuture deleteFuture = ( DeleteFuture ) responseFuture; - if ( deleteFuture == null ) - { - LOG.error( "DeleteFuture is null" ); - throw new LdapException( "DeleteFuture is null" ); - } - if ( LOG.isDebugEnabled() ) { if ( deleteResponse.getLdapResult().getResultCode() == ResultCodeEnum.SUCCESS ) @@ -1604,12 +1580,6 @@ public class LdapNetworkConnection exten ExtendedFuture extendedFuture = ( ExtendedFuture ) responseFuture; - if ( extendedFuture == null ) - { - LOG.error( "ExtendedFuture is null" ); - throw new LdapException( "extendedFuture is null" ); - } - // remove the listener from the listener map if ( LOG.isDebugEnabled() ) { @@ -1666,12 +1636,6 @@ public class LdapNetworkConnection exten ModifyFuture modifyFuture = ( ModifyFuture ) responseFuture; - if ( modifyFuture == null ) - { - LOG.error( "ModifyFuture is null" ); - throw new LdapException( "ModifyFuture is null" ); - } - if ( LOG.isDebugEnabled() ) { if ( modifyResponse.getLdapResult().getResultCode() == ResultCodeEnum.SUCCESS ) @@ -1700,12 +1664,6 @@ public class LdapNetworkConnection exten ModifyDnFuture modifyDnFuture = ( ModifyDnFuture ) responseFuture; - if ( modifyDnFuture == null ) - { - LOG.error( "ModifyDNFuture is null" ); - throw new LdapException( "ModifyDNFuture is null" ); - } - if ( LOG.isDebugEnabled() ) { if ( modifyDnResponse.getLdapResult().getResultCode() == ResultCodeEnum.SUCCESS ) @@ -1734,12 +1692,6 @@ public class LdapNetworkConnection exten SearchFuture searchFuture = ( SearchFuture ) responseFuture; - if ( searchFuture == null ) - { - LOG.error( "SearchFuture is null" ); - throw new LdapException( "SearchFuture is null" ); - } - if ( LOG.isDebugEnabled() ) { if ( searchResultDone.getLdapResult().getResultCode() == ResultCodeEnum.SUCCESS ) @@ -1773,12 +1725,6 @@ public class LdapNetworkConnection exten searchFuture = ( SearchFuture ) responseFuture; - if ( searchFuture == null ) - { - LOG.error( "SearchFuture is null" ); - throw new LdapException( "SearchFuture is null" ); - } - if ( LOG.isDebugEnabled() ) { LOG.debug( "Search entry found : {}", searchResultEntry ); @@ -1795,12 +1741,6 @@ public class LdapNetworkConnection exten searchFuture = ( SearchFuture ) responseFuture; - if ( searchFuture == null ) - { - LOG.error( "SearchFuture is null" ); - throw new LdapException( "SearchFuture is null" ); - } - if ( LOG.isDebugEnabled() ) { LOG.debug( "Search reference found : {}", searchResultReference );