From commits-return-27309-apmail-directory-commits-archive=directory.apache.org@directory.apache.org Sun Sep 05 17:00:34 2010 Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 91074 invoked from network); 5 Sep 2010 17:00:34 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 5 Sep 2010 17:00:34 -0000 Received: (qmail 49745 invoked by uid 500); 5 Sep 2010 17:00:34 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 49683 invoked by uid 500); 5 Sep 2010 17:00:34 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 49676 invoked by uid 99); 5 Sep 2010 17:00:34 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Sep 2010 17:00:34 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Sep 2010 17:00:12 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id DC01023889E9; Sun, 5 Sep 2010 16:59:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r992822 - /directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/ Date: Sun, 05 Sep 2010 16:59:50 -0000 To: commits@directory.apache.org From: elecharny@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100905165950.DC01023889E9@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: elecharny Date: Sun Sep 5 16:59:50 2010 New Revision: 992822 URL: http://svn.apache.org/viewvc?rev=992822&view=rev Log: Finished the asn1 classes review : o removed useless classes Removed: directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/CallbackHistory.java directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/DecoderFactory.java directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/DecoderMonitor.java directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/DecoderMonitorAdapter.java directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/DecoderStack.java directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/EncoderFactory.java directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/EncoderMonitor.java directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/EncoderMonitorAdapter.java Modified: directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/AbstractStatefulDecoder.java directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/EncoderCallback.java Modified: directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/AbstractStatefulDecoder.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/AbstractStatefulDecoder.java?rev=992822&r1=992821&r2=992822&view=diff ============================================================================== --- directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/AbstractStatefulDecoder.java (original) +++ directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/AbstractStatefulDecoder.java Sun Sep 5 16:59:50 2010 @@ -21,7 +21,7 @@ package org.apache.directory.shared.asn1 /** - * Convenience class to not have to reimplement the two setter methods everytime + * Convenience class to not have to re-implement the two setter methods every time * one starts a new decoder. * * @author Apache Directory Project @@ -31,13 +31,6 @@ public abstract class AbstractStatefulDe /** this decoder's callback */ private DecoderCallback cb = null; - /** this decoder's monitor */ - private DecoderMonitor monitor = null; - - - // ------------------------------------------------------------------------ - // constructors - // ------------------------------------------------------------------------ /** * Creates a stateful decoder where the callback and monitor must be set. @@ -59,44 +52,11 @@ public abstract class AbstractStatefulDe /** - * Creates a stateful decoder with a monitor but no callback. - * - * @param monitor the monitor to use for this decoder - */ - public AbstractStatefulDecoder( DecoderMonitor monitor ) - { - this.monitor = monitor; - } - - - /** - * Creates a stateful decoder. - * - * @param cb the callback to use for this decoder - * @param monitor the monitor to use for this decoder - */ - public AbstractStatefulDecoder( DecoderCallback cb, DecoderMonitor monitor ) - { - this.monitor = monitor; - setCallback( cb ); - } - - - // ------------------------------------------------------------------------ - // StatefulDecoder methods - // ------------------------------------------------------------------------ - /** * {@inheritDoc} */ public void setCallback( DecoderCallback cb ) { - DecoderCallback old = this.cb; this.cb = cb; - - if ( this.monitor != null ) - { - this.monitor.callbackSet( this, old, cb ); - } } @@ -110,24 +70,10 @@ public abstract class AbstractStatefulDe /** - * {@inheritDoc} - */ - public void setDecoderMonitor( DecoderMonitor monitor ) - { - this.monitor = monitor; - } - - - // ------------------------------------------------------------------------ - // protected methods - // ------------------------------------------------------------------------ - - /** * Notifies via the callback if one has been set that this decoder has * decoded a unit of encoded data. * - * @param decoded - * the decoded byproduct. + * @param decoded the decoded byproduct. */ protected void decodeOccurred( Object decoded ) { @@ -136,15 +82,4 @@ public abstract class AbstractStatefulDe cb.decodeOccurred( this, decoded ); } } - - - /** - * Gets the decoder's monitor. - * - * @return the monitor for this StatefulDecoder - */ - protected DecoderMonitor getDecoderMonitor() - { - return monitor; - } } Modified: directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/EncoderCallback.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/EncoderCallback.java?rev=992822&r1=992821&r2=992822&view=diff ============================================================================== --- directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/EncoderCallback.java (original) +++ directory/shared/trunk/asn1/src/main/java/org/apache/directory/shared/asn1/codec/stateful/EncoderCallback.java Sun Sep 5 16:59:50 2010 @@ -21,7 +21,7 @@ package org.apache.directory.shared.asn1 /** - * Document me. + * Callback interface for stateful encoder callbacks. * * @author Apache Directory Project */ @@ -30,10 +30,8 @@ public interface EncoderCallback /** * Callback to deliver a fully encoded object. * - * @param encoder - * the stateful encoder driving the callback - * @param encoded - * the object that was encoded + * @param encoder the stateful encoder driving the callback + * @param encoded the object that was encoded */ void encodeOccurred( StatefulEncoder encoder, Object encoded ); }