directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From seelm...@apache.org
Subject svn commit: r1001621 [2/2] - in /directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api: ./ callback/ exception/ future/ listener/ protocol/
Date Mon, 27 Sep 2010 08:29:27 GMT
Modified: directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/listener/ModifyListener.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/listener/ModifyListener.java?rev=1001621&r1=1001620&r2=1001621&view=diff
==============================================================================
--- directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/listener/ModifyListener.java
(original)
+++ directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/listener/ModifyListener.java
Mon Sep 27 08:29:26 2010
@@ -41,5 +41,5 @@ public interface ModifyListener extends 
      * @param response the modify operation's response
      * @throws LdapException
      */
-    public void modifyCompleted( LdapAsyncConnection connection, ModifyResponse response
) throws LdapException;
+    void modifyCompleted( LdapAsyncConnection connection, ModifyResponse response ) throws
LdapException;
 }

Modified: directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolCodecFactory.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolCodecFactory.java?rev=1001621&r1=1001620&r2=1001621&view=diff
==============================================================================
--- directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolCodecFactory.java
(original)
+++ directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolCodecFactory.java
Mon Sep 27 08:29:26 2010
@@ -27,7 +27,6 @@ import org.apache.mina.filter.codec.Prot
 
 
 /**
- * 
  * The factory used to create the LDAP encoder and decoder.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
@@ -42,10 +41,8 @@ public class LdapProtocolCodecFactory im
 
 
     /**
-     * 
      * Creates a new instance of LdapProtocolCodecFactory. It
      * creates the encoded an decoder instances.
-     *
      */
     public LdapProtocolCodecFactory()
     {
@@ -53,18 +50,24 @@ public class LdapProtocolCodecFactory im
 
 
     /**
-     * Get the Ldap decoder. 
+     * Get the LDAP decoder.
+     *
+     * @param session the IO session
+     * @return the decoder
      */
-    public ProtocolDecoder getDecoder( IoSession session ) throws Exception
+    public ProtocolDecoder getDecoder( IoSession session )
     {
         return new LdapProtocolDecoder();
     }
 
 
     /**
-     * Get the Ldap encoder.
+     * Get the LDAP encoder.
+     *
+     * @param session the IO session
+     * @return the encoder
      */
-    public ProtocolEncoder getEncoder( IoSession session ) throws Exception
+    public ProtocolEncoder getEncoder( IoSession session )
     {
         return new LdapProtocolEncoder();
     }

Modified: directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolDecoder.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolDecoder.java?rev=1001621&r1=1001620&r2=1001621&view=diff
==============================================================================
--- directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolDecoder.java
(original)
+++ directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolDecoder.java
Mon Sep 27 08:29:26 2010
@@ -58,7 +58,8 @@ public class LdapProtocolDecoder impleme
      * @param session The session containing the LdapMessageContainer
      * @param buffer The ByteBuffer containing the incoming bytes to decode
      * to a LDAP message
-     * @param out The callback we have to invoke when the message has been decoded 
+     * @param out The callback we have to invoke when the message has been decoded
+     * @throws Exception if the read data violated protocol specification
      */
     public void decode( IoSession session, IoBuffer buffer, ProtocolDecoderOutput out ) throws
Exception
     {

Modified: directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolEncoder.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolEncoder.java?rev=1001621&r1=1001620&r2=1001621&view=diff
==============================================================================
--- directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolEncoder.java
(original)
+++ directory/shared/trunk/ldap-client-api/src/main/java/org/apache/directory/ldap/client/api/protocol/LdapProtocolEncoder.java
Mon Sep 27 08:29:26 2010
@@ -33,7 +33,6 @@ import org.slf4j.LoggerFactory;
 
 
 /**
- * 
  * A LDAP message decoder. It is based on shared-ldap decoder.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
@@ -47,12 +46,15 @@ public class LdapProtocolEncoder impleme
     private static final boolean IS_DEBUG = LOG.isDebugEnabled();
 
     /** The stateful encoder */
-    private static final LdapEncoder encoder = new LdapEncoder();
+    private static final LdapEncoder ENCODER = new LdapEncoder();
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void encode( IoSession session, Object message, ProtocolEncoderOutput out ) throws
Exception
     {
-        ByteBuffer buffer = encoder.encodeMessage( ( Message ) message );
+        ByteBuffer buffer = ENCODER.encodeMessage( ( Message ) message );
 
         IoBuffer ioBuffer = IoBuffer.wrap( buffer );
 
@@ -60,6 +62,9 @@ public class LdapProtocolEncoder impleme
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void dispose( IoSession session ) throws Exception
     {
         // Nothing to do



Mime
View raw message