Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 9026 invoked from network); 4 Jun 2010 15:33:12 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 4 Jun 2010 15:33:12 -0000 Received: (qmail 47856 invoked by uid 500); 4 Jun 2010 15:33:12 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 47813 invoked by uid 500); 4 Jun 2010 15:33:12 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 47806 invoked by uid 99); 4 Jun 2010 15:33:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Jun 2010 15:33:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Jun 2010 15:33:10 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 1539923889B6; Fri, 4 Jun 2010 15:32:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r951443 - /directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.java Date: Fri, 04 Jun 2010 15:32:49 -0000 To: commits@directory.apache.org From: felixk@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100604153249.1539923889B6@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: felixk Date: Fri Jun 4 15:32:48 2010 New Revision: 951443 URL: http://svn.apache.org/viewvc?rev=951443&view=rev Log: Remove dead code Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.java Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.java?rev=951443&r1=951442&r2=951443&view=diff ============================================================================== --- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.java (original) +++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/entry/DefaultEntryAttribute.java Fri Jun 4 15:32:48 2010 @@ -1472,36 +1472,12 @@ public class DefaultEntryAttribute imple { if ( isHR ) { - // Iterate through all the values, and quit if we - // don't find one in the values - if ( attributeType != null ) - { - for ( String val:vals ) - { - Value value = createStringValue( attributeType, val ); - - if ( value == null ) - { - // The value can't be normalized : we don't add it. - LOG.error( I18n.err( I18n.ERR_04449, val ) ); - return false; - } - - if ( !contains( value ) ) - { - return false; - } - } - } - else + for ( String val:vals ) { - for ( String val:vals ) + + if ( !contains( new StringValue( val ) ) ) { - - if ( !contains( new StringValue( val ) ) ) - { - return false; - } + return false; } } }