directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fel...@apache.org
Subject svn commit: r947249 - in /directory/apacheds/trunk: core-api/src/main/java/org/apache/directory/server/core/schema/SchemaPartition.java jdbm/src/main/java/jdbm/btree/BPage.java
Date Sat, 22 May 2010 06:38:33 GMT
Author: felixk
Date: Sat May 22 06:38:33 2010
New Revision: 947249

URL: http://svn.apache.org/viewvc?rev=947249&view=rev
Log:
Remove unnecessary final modifiers.
When a class has the final modifier, all the methods are automatically final. 

Modified:
    directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/schema/SchemaPartition.java
    directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java

Modified: directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/schema/SchemaPartition.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/schema/SchemaPartition.java?rev=947249&r1=947248&r2=947249&view=diff
==============================================================================
--- directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/schema/SchemaPartition.java
(original)
+++ directory/apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/schema/SchemaPartition.java
Sat May 22 06:38:33 2010
@@ -154,7 +154,7 @@ public final class SchemaPartition exten
     /**
      * Get's the ID which is fixed: 'schema'.
      */
-    public final String getId()
+    public String getId()
     {
         return ID;
     }
@@ -164,7 +164,7 @@ public final class SchemaPartition exten
      * Has no affect: the id is fixed at {@link SchemaPartition#ID}: 'schema'.
      * A warning is logged.
      */
-    public final void setId( String id )
+    public void setId( String id )
     {
         LOG.warn( "This partition's ID is fixed: {}", ID );
     }
@@ -173,7 +173,7 @@ public final class SchemaPartition exten
     /**
      * Always returns {@link ServerDNConstants#OU_SCHEMA_DN_NORMALIZED}: '2.5.4.11=schema'.
      */
-    public final DN getSuffixDn()
+    public DN getSuffixDn()
     {
         return wrapped.getSuffixDn();
     }
@@ -182,7 +182,7 @@ public final class SchemaPartition exten
     /**
      * Always returns {@link ServerDNConstants#OU_SCHEMA_DN}: 'ou=schema'.
      */
-    public final String getSuffix()
+    public String getSuffix()
     {
         return SchemaConstants.OU_SCHEMA;
     }
@@ -191,7 +191,7 @@ public final class SchemaPartition exten
     /**
      * Has no affect: just logs a warning.
      */
-    public final void setSuffix( String suffix )
+    public void setSuffix( String suffix )
     {
         LOG.warn( "This partition's suffix is fixed: {}", SchemaConstants.OU_SCHEMA );
     }

Modified: directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java?rev=947249&r1=947248&r2=947249&view=diff
==============================================================================
--- directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java (original)
+++ directory/apacheds/trunk/jdbm/src/main/java/jdbm/btree/BPage.java Sat May 22 06:38:33
2010
@@ -888,6 +888,8 @@ public class BPage<K, V> implements Seri
     /**
      * Return the child BPage at given index.
      */
+    // False positive
+    @SuppressWarnings("PMD.UnnecessaryFinalModifier")
     BPage<K, V> childBPage( int index ) throws IOException
     {
         return loadBPage( children[index] );



Mime
View raw message