directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r946592 - /directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java
Date Thu, 20 May 2010 11:19:29 GMT
Author: elecharny
Date: Thu May 20 11:19:29 2010
New Revision: 946592

URL: http://svn.apache.org/viewvc?rev=946592&view=rev
Log:
Fixed the inconsistency in the equals() method (no need to check for entry being null when
it can't)

Modified:
    directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java

Modified: directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java?rev=946592&r1=946591&r2=946592&view=diff
==============================================================================
--- directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java
(original)
+++ directory/shared/trunk/ldap-ldif/src/main/java/org/apache/directory/shared/ldap/ldif/LdifEntry.java
Thu May 20 11:19:29 2010
@@ -693,23 +693,6 @@ public class LdifEntry implements Clonea
         {
             case Add :
                 // Checks the attributes
-                if ( entry == null )
-                {
-                    if ( otherEntry.entry != null )
-                    {
-                        return false;
-                    }
-                    else
-                    {
-                        break;
-                    }
-                }
-                
-                if ( otherEntry.entry == null )
-                {
-                    return false;
-                }
-                
                 if ( entry.size() != otherEntry.entry.size() )
                 {
                     return false;



Mime
View raw message