Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 94216 invoked from network); 28 Apr 2010 17:12:53 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Apr 2010 17:12:53 -0000 Received: (qmail 65974 invoked by uid 500); 28 Apr 2010 17:12:53 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 65942 invoked by uid 500); 28 Apr 2010 17:12:53 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 65935 invoked by uid 99); 28 Apr 2010 17:12:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Apr 2010 17:12:52 +0000 X-ASF-Spam-Status: No, hits=-1353.9 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Apr 2010 17:12:51 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id B71692388980; Wed, 28 Apr 2010 17:12:01 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r939010 - in /directory/shared/trunk/ldap/src: main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java Date: Wed, 28 Apr 2010 17:12:01 -0000 To: commits@directory.apache.org From: elecharny@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100428171201.B71692388980@eris.apache.org> Author: elecharny Date: Wed Apr 28 17:12:01 2010 New Revision: 939010 URL: http://svn.apache.org/viewvc?rev=939010&view=rev Log: OctetString SyntaxChecker should accept null values Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java?rev=939010&r1=939009&r2=939010&view=diff ============================================================================== --- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java (original) +++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java Wed Apr 28 17:12:01 2010 @@ -65,6 +65,7 @@ public class OctetStringSyntaxChecker ex */ public boolean isValidSyntax( Object value ) { - return ( value != null ); + // Always true. + return true; } } Modified: directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java?rev=939010&r1=939009&r2=939010&view=diff ============================================================================== --- directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java (original) +++ directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java Wed Apr 28 17:12:01 2010 @@ -20,7 +20,6 @@ package org.apache.directory.shared.ldap.schema.syntax; -import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import org.apache.directory.shared.ldap.schema.syntaxCheckers.OctetStringSyntaxChecker; @@ -41,7 +40,7 @@ public class OctetStringSyntaxCheckerTes @Test public void testNullString() { - assertFalse( checker.isValidSyntax( null ) ); + assertTrue( checker.isValidSyntax( null ) ); }