directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r939010 - in /directory/shared/trunk/ldap/src: main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java
Date Wed, 28 Apr 2010 17:12:01 GMT
Author: elecharny
Date: Wed Apr 28 17:12:01 2010
New Revision: 939010

URL: http://svn.apache.org/viewvc?rev=939010&view=rev
Log:
OctetString SyntaxChecker should accept null values

Modified:
    directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java
    directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java

Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java?rev=939010&r1=939009&r2=939010&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java
(original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/schema/syntaxCheckers/OctetStringSyntaxChecker.java
Wed Apr 28 17:12:01 2010
@@ -65,6 +65,7 @@ public class OctetStringSyntaxChecker ex
      */
     public boolean isValidSyntax( Object value )
     {
-        return ( value != null );
+        // Always true.
+        return true;
     }
 }

Modified: directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java?rev=939010&r1=939009&r2=939010&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java
(original)
+++ directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OctetStringSyntaxCheckerTest.java
Wed Apr 28 17:12:01 2010
@@ -20,7 +20,6 @@
 package org.apache.directory.shared.ldap.schema.syntax;
 
 
-import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertTrue;
 
 import org.apache.directory.shared.ldap.schema.syntaxCheckers.OctetStringSyntaxChecker;
@@ -41,7 +40,7 @@ public class OctetStringSyntaxCheckerTes
     @Test
     public void testNullString()
     {
-        assertFalse( checker.isValidSyntax( null ) );
+        assertTrue( checker.isValidSyntax( null ) );
     }
 
 



Mime
View raw message