directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r915260 - /directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/BindRequestImpl.java
Date Tue, 23 Feb 2010 09:49:17 GMT
Author: elecharny
Date: Tue Feb 23 09:49:16 2010
New Revision: 915260

URL: http://svn.apache.org/viewvc?rev=915260&view=rev
Log:
o Minor refactoring

Modified:
    directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/BindRequestImpl.java

Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/BindRequestImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/BindRequestImpl.java?rev=915260&r1=915259&r2=915260&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/BindRequestImpl.java
(original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/message/BindRequestImpl.java
Tue Feb 23 09:49:16 2010
@@ -51,7 +51,7 @@
     /** The passwords, keys or tickets used to verify user identity */
     private byte[] credentials;
     
-    /** A storage for credential hashCode */
+    /** A storage for credentials hashCode */
     private int hCredentials;
 
     /** The mechanism used to decode user identity */
@@ -60,9 +60,10 @@
     /** Simple vs. SASL authentication mode flag */
     private boolean isSimple = true;
 
-    /** Bind behavoir exhibity by protocol version */
+    /** Bind behavior exhibited by protocol version */
     private boolean isVersion3 = true;
 
+    /** The associated response */
     public InternalBindResponse response;
 
 
@@ -73,10 +74,9 @@
     /**
      * Creates an BindRequest implementation to bind to an LDAP server.
      * 
-     * @param id
-     *            the sequence identifier of the BindRequest message.
+     * @param id the sequence identifier of the BindRequest message.
      */
-    public BindRequestImpl(final int id)
+    public BindRequestImpl( final int id )
     {
         super( id, TYPE );
         hCredentials = 0;
@@ -149,10 +149,13 @@
         {
             this.credentials = new byte[ credentials.length ];
             System.arraycopy( credentials, 0, this.credentials, 0, credentials.length );
-        } else {
+        } 
+        else 
+        {
             this.credentials = null;
         }
         
+        // Compute the hashcode
         if ( credentials != null )
         {
             hCredentials = 0;
@@ -280,7 +283,6 @@
     // -----------------------------------------------------------------------
     // BindRequest Interface Method Implementations
     // -----------------------------------------------------------------------
-
     /**
      * Gets the protocol response message type for this request which produces
      * at least one response.
@@ -307,6 +309,18 @@
 
         return response;
     }
+    
+
+
+    /**
+     * RFC 2251/4511 [Section 4.11]: Abandon, Bind, Unbind, and StartTLS operations
+     * cannot be abandoned.
+     */
+    public void abandon()
+    {
+        throw new UnsupportedOperationException( I18n.err( I18n.ERR_04185 ) );
+    }
+
 
     /**
      * @see Object#equals(Object)
@@ -371,6 +385,7 @@
         return true;
     }
     
+    
     /**
      * @see Object#hashCode()
      * @return the instance's hash code 
@@ -389,6 +404,7 @@
         return hash;
     }
 
+    
     /**
      * Get a String representation of a BindRequest
      * 
@@ -435,14 +451,4 @@
 
         return sb.toString();
     }
-
-
-    /**
-     * RFC 2251 [Section 4.11]: Abandon, Bind, Unbind, and StartTLS operations
-     * cannot be abandoned.
-     */
-    public void abandon()
-    {
-        throw new UnsupportedOperationException( I18n.err( I18n.ERR_04185 ) );
-    }
 }



Mime
View raw message