directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayyag...@apache.org
Subject svn commit: r749040 - in /directory/shared/trunk/ldap/src: main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncDoneValue/ test/java/org/apache/directory/shared/ldap/codec/controls/replication/
Date Sun, 01 Mar 2009 14:22:28 GMT
Author: kayyagari
Date: Sun Mar  1 14:22:28 2009
New Revision: 749040

URL: http://svn.apache.org/viewvc?rev=749040&view=rev
Log:
o fixed a bug related to grammar end without the refreshdeletes flag and cookie

Modified:
    directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncDoneValue/SyncDoneValueControlGrammar.java
    directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/codec/controls/replication/SyncDoneValueControlTest.java

Modified: directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncDoneValue/SyncDoneValueControlGrammar.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncDoneValue/SyncDoneValueControlGrammar.java?rev=749040&r1=749039&r2=749040&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncDoneValue/SyncDoneValueControlGrammar.java
(original)
+++ directory/shared/trunk/ldap/src/main/java/org/apache/directory/shared/ldap/codec/controls/replication/syncDoneValue/SyncDoneValueControlGrammar.java
Sun Mar  1 14:22:28 2009
@@ -93,6 +93,8 @@
                     SyncDoneValueControlContainer syncDoneValueContainer = ( SyncDoneValueControlContainer
) container;
                     SyncDoneValueControlCodec control = new SyncDoneValueControlCodec();
                     syncDoneValueContainer.setSyncDoneValueControl( control );
+                    
+                    syncDoneValueContainer.grammarEndAllowed( true );
                 }
             } );
 
@@ -121,8 +123,7 @@
 
                     syncDoneValueContainer.getSyncDoneValueControl().setCookie( cookie );
 
-                    // there is still a boolean flag left in the sequence
-                    syncDoneValueContainer.grammarEndAllowed( false );
+                    syncDoneValueContainer.grammarEndAllowed( true );
                 }
             } );
 

Modified: directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/codec/controls/replication/SyncDoneValueControlTest.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/codec/controls/replication/SyncDoneValueControlTest.java?rev=749040&r1=749039&r2=749040&view=diff
==============================================================================
--- directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/codec/controls/replication/SyncDoneValueControlTest.java
(original)
+++ directory/shared/trunk/ldap/src/test/java/org/apache/directory/shared/ldap/codec/controls/replication/SyncDoneValueControlTest.java
Sun Mar  1 14:22:28 2009
@@ -158,13 +158,15 @@
         try
         {
             decoder.decode( bb, container );
-            fail( "shouldn't reach this" );
         }
         catch ( Exception e )
         {
-            assertTrue( true );
+            fail( "shouldn't reach this" );
         }
 
+        SyncDoneValueControlCodec control = container.getSyncDoneValueControl();
+        assertNull( control.getCookie() );
+        assertFalse( control.isRefreshDeletes() );
     }
 
     



Mime
View raw message