directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From akaras...@apache.org
Subject svn commit: r682585 - /directory/apacheds/branches/bigbang/core/src/main/java/org/apache/directory/server/core/changelog/ChangeLogInterceptor.java
Date Tue, 05 Aug 2008 05:36:59 GMT
Author: akarasulu
Date: Mon Aug  4 22:36:58 2008
New Revision: 682585

URL: http://svn.apache.org/viewvc?rev=682585&view=rev
Log:
sometimes modify requests will contain all non-existent (bogus not defined by schema) attribute
modifications. In this case the modification items will be empty by the time it reaches this
interceptor.  To prevent it from causing errors in processing we simply ignore the request
as far as the changelog is concerned.  The request has no effect so it is ok to ignore it.

Modified:
    directory/apacheds/branches/bigbang/core/src/main/java/org/apache/directory/server/core/changelog/ChangeLogInterceptor.java

Modified: directory/apacheds/branches/bigbang/core/src/main/java/org/apache/directory/server/core/changelog/ChangeLogInterceptor.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/bigbang/core/src/main/java/org/apache/directory/server/core/changelog/ChangeLogInterceptor.java?rev=682585&r1=682584&r2=682585&view=diff
==============================================================================
--- directory/apacheds/branches/bigbang/core/src/main/java/org/apache/directory/server/core/changelog/ChangeLogInterceptor.java
(original)
+++ directory/apacheds/branches/bigbang/core/src/main/java/org/apache/directory/server/core/changelog/ChangeLogInterceptor.java
Mon Aug  4 22:36:58 2008
@@ -202,7 +202,16 @@
 
         // @TODO: needs big consideration!!!
         // NOTE: perhaps we need to log this as a system operation that cannot and should
not be reapplied?
-        if ( isDelete || ! changeLog.isEnabled() || ! opContext.isFirstOperation() )
+        if ( 
+            isDelete ||   
+            ! changeLog.isEnabled() || 
+            ! opContext.isFirstOperation() ||
+            
+         // if there are no modifications due to stripping out bogus non-
+         // existing attributes then we will have no modification items and
+         // should ignore not this without registerring it with the changelog
+         
+            opContext.getModItems().size() == 0 )  
         {
             if ( isDelete )
             {



Mime
View raw message