Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 14916 invoked from network); 10 Feb 2008 13:15:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Feb 2008 13:15:37 -0000 Received: (qmail 65735 invoked by uid 500); 10 Feb 2008 13:15:31 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 65690 invoked by uid 500); 10 Feb 2008 13:15:31 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 65679 invoked by uid 99); 10 Feb 2008 13:15:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Feb 2008 05:15:30 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Feb 2008 13:14:54 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6E8DA1A983A; Sun, 10 Feb 2008 05:15:14 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r620282 - in /directory/shared/branches/0.9.8/ldap/src: main/java/org/apache/directory/shared/ldap/name/RdnParser.java test/java/org/apache/directory/shared/ldap/name/LdapDNTest.java test/java/org/apache/directory/shared/ldap/name/RdnTest.java Date: Sun, 10 Feb 2008 13:15:13 -0000 To: commits@directory.apache.org From: seelmann@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080210131514.6E8DA1A983A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: seelmann Date: Sun Feb 10 05:15:11 2008 New Revision: 620282 URL: http://svn.apache.org/viewvc?rev=620282&view=rev Log: Fix for DIRSTUDIO-161. RDN with empty value is valid, e.g. 'dc=' Modified: directory/shared/branches/0.9.8/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/LdapDNTest.java directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/RdnTest.java Modified: directory/shared/branches/0.9.8/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java URL: http://svn.apache.org/viewvc/directory/shared/branches/0.9.8/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java?rev=620282&r1=620281&r2=620282&view=diff ============================================================================== --- directory/shared/branches/0.9.8/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java (original) +++ directory/shared/branches/0.9.8/ldap/src/main/java/org/apache/directory/shared/ldap/name/RdnParser.java Sun Feb 10 05:15:11 2008 @@ -595,7 +595,7 @@ if( bytes.length <= pos.start ) { // no attribute value - return false; + return true; } byte c = bytes[pos.start]; Modified: directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/LdapDNTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/LdapDNTest.java?rev=620282&r1=620281&r2=620282&view=diff ============================================================================== --- directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/LdapDNTest.java (original) +++ directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/LdapDNTest.java Sun Feb 10 05:15:11 2008 @@ -2831,8 +2831,8 @@ assertFalse( LdapDN.isValid( "a" ) ); assertFalse( LdapDN.isValid( "a " ) ); - assertFalse( LdapDN.isValid( "a=" ) ); - assertFalse( LdapDN.isValid( "a= " ) ); + assertTrue( LdapDN.isValid( "a=" ) ); + assertTrue( LdapDN.isValid( "a= " ) ); assertFalse( LdapDN.isValid( "=" ) ); assertFalse( LdapDN.isValid( " = " ) ); Modified: directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/RdnTest.java URL: http://svn.apache.org/viewvc/directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/RdnTest.java?rev=620282&r1=620281&r2=620282&view=diff ============================================================================== --- directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/RdnTest.java (original) +++ directory/shared/branches/0.9.8/ldap/src/test/java/org/apache/directory/shared/ldap/name/RdnTest.java Sun Feb 10 05:15:11 2008 @@ -612,4 +612,17 @@ assertEquals( "\\#a#b", Rdn.escapeValue( "#a#b" ) ); assertEquals( "\\##a#b", Rdn.escapeValue( "##a#b" ) ); } + + + /** + * test an RDN with empty value + */ + public void testRdnWithEmptyValue() throws InvalidNameException + { + assertTrue( RdnParser.isValid( "a=" ) ); + assertTrue( RdnParser.isValid( "a=\"\"" ) ); + assertEquals( "a=", new Rdn( "a=\"\"" ).toString() ); + assertEquals( "a=", new Rdn( "a=" ).toString() ); + } + }