directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r584156 - in /directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common: ServerAttribute.java ServerEntry.java
Date Fri, 12 Oct 2007 13:08:10 GMT
Author: elecharny
Date: Fri Oct 12 06:08:01 2007
New Revision: 584156

URL: http://svn.apache.org/viewvc?rev=584156&view=rev
Log:
Added some comment to alex' comments

Modified:
    directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerAttribute.java
    directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerEntry.java

Modified: directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerAttribute.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerAttribute.java?rev=584156&r1=584155&r2=584156&view=diff
==============================================================================
--- directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerAttribute.java
(original)
+++ directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerAttribute.java
Fri Oct 12 06:08:01 2007
@@ -64,13 +64,33 @@
  * Why not track the AttributeType associated with the ServerAttribute as we
  * discussed a while back at LDAPCon?  It makes sense to access the attributeType
  * directly from the ServerAttribute instead of having to fish for it in the
- * registries.  Perhaps the attributeType can be dynamically looked up from within
+ * registries.  
+ * 
+ * @todo ELE - Yeah, it seems to be a good idea, if we can get this informtion.
+ * The main pb is that this object is created during the decoding phase, so
+ * we have to see how we can provide access to the registry in codec.
+ *
+ * 
+ * @todo ALEX -
+ * Perhaps the attributeType can be dynamically looked up from within
  * implementors of this interface (to respond to schema changes) to dynamically
  * resolve their respective type information.  Internally checks should be performed
  * while adding values.
+ * 
+ * @todo ELE :
+ * I would rather prefer to be sure that we push correct values into a ServerAttribute
+ * instead of checking the correctness of those values in ServerAttribute.
+ * 
  * @todo ALEX - Remove after resolution:
  * Also I thought we would use polymorphism for the different kinds of attributes:
  * Binary verses NonBinary.  Is there value in this?
+ * 
+ * @todo ELE -
+ * yes, value are either Binary or String, but now, I'm not sure this is a good choice,
+ * because we need more types : AttributeType for ObjectClass (if we store "top", or 
+ * "person" as String into a value, we will need to convert them to OID in order to
+ * do some schema check later in the SchemaInterceptor: not really good. The pb 
+ * is the same for DistinguishedName : do we need a DNValue?
  *
  * @author <a href="mailto:dev@directory.apache.org"> Apache Directory Project</a>
  * @version $Rev: 499013 $

Modified: directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerEntry.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerEntry.java?rev=584156&r1=584155&r2=584156&view=diff
==============================================================================
--- directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerEntry.java
(original)
+++ directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/common/ServerEntry.java
Fri Oct 12 06:08:01 2007
@@ -53,6 +53,10 @@
  * may need two kinds of put, remove and add methods where one performs schema checks
  * and the other does not.  I don't know if this is mixing concerns but I'd like to
  * explore the idea somewhat. 
+ * 
+ * @todo ELE -
+ * Make sense. It will spare some access to the registry everywhere, as the instance will

+ * be selfaware of its MAY and MUST 
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$



Mime
View raw message