directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r574834 - in /directory/apacheds/trunk: protocol-changepw/src/main/java/org/apache/directory/server/changepw/ protocol-changepw/src/test/java/org/apache/directory/server/changepw/protocol/ protocol-kerberos/src/main/java/org/apache/director...
Date Wed, 12 Sep 2007 08:18:47 GMT
Author: elecharny
Date: Wed Sep 12 01:18:46 2007
New Revision: 574834

URL: http://svn.apache.org/viewvc?rev=574834&view=rev
Log:
Removed warnings using generics and commenting useless code

Modified:
    directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
    directory/apacheds/trunk/protocol-changepw/src/test/java/org/apache/directory/server/changepw/protocol/ChangepwProtocolHandlerTest.java
    directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/directory/server/kerberos/kdc/KerberosServer.java
    directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/NtpServer.java

Modified: directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java?rev=574834&r1=574833&r2=574834&view=diff
==============================================================================
--- directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
(original)
+++ directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
Wed Sep 12 01:18:46 2007
@@ -92,7 +92,7 @@
      * @param newConfig
      * @return Whether configuration being proposed as new is really different.
      */
-    public boolean isDifferent( Dictionary newConfig )
+    public boolean isDifferent( Dictionary<String, Object> newConfig )
     {
         return config.isDifferent( newConfig );
     }

Modified: directory/apacheds/trunk/protocol-changepw/src/test/java/org/apache/directory/server/changepw/protocol/ChangepwProtocolHandlerTest.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-changepw/src/test/java/org/apache/directory/server/changepw/protocol/ChangepwProtocolHandlerTest.java?rev=574834&r1=574833&r2=574834&view=diff
==============================================================================
--- directory/apacheds/trunk/protocol-changepw/src/test/java/org/apache/directory/server/changepw/protocol/ChangepwProtocolHandlerTest.java
(original)
+++ directory/apacheds/trunk/protocol-changepw/src/test/java/org/apache/directory/server/changepw/protocol/ChangepwProtocolHandlerTest.java
Wed Sep 12 01:18:46 2007
@@ -26,7 +26,6 @@
 import java.net.InetSocketAddress;
 import java.net.SocketAddress;
 import java.net.UnknownHostException;
-import java.util.Arrays;
 
 import javax.security.auth.kerberos.KerberosPrincipal;
 
@@ -35,7 +34,6 @@
 import org.apache.directory.server.changepw.ChangePasswordConfiguration;
 import org.apache.directory.server.changepw.io.ChangePasswordDataEncoder;
 import org.apache.directory.server.changepw.messages.ChangePasswordError;
-import org.apache.directory.server.changepw.messages.ChangePasswordReply;
 import org.apache.directory.server.changepw.messages.ChangePasswordRequest;
 import org.apache.directory.server.changepw.value.ChangePasswordData;
 import org.apache.directory.server.changepw.value.ChangePasswordDataModifier;
@@ -81,8 +79,9 @@
 public class ChangepwProtocolHandlerTest extends TestCase
 {
     /** The Change Password SUCCESS result code. */
-    private static final byte[] SUCCESS = new byte[]
-        { ( byte ) 0x00, ( byte ) 0x00 };
+	// Never used...
+    //private static final byte[] SUCCESS = new byte[]
+    //    { ( byte ) 0x00, ( byte ) 0x00 };
 
     private ChangePasswordConfiguration config;
     private PrincipalStore store;
@@ -187,7 +186,9 @@
         //processChangePasswordReply( reply, serviceTicket.getSessionKey(), subSessionKey
);
     }
 
-
+    /**
+     * TODO : Check if this method is important or not. It was called in
+     * the testInitialFlagRequired() method above, but this call has been commented
     private void processChangePasswordReply( ChangePasswordReply reply, EncryptionKey sessionKey,
         EncryptionKey subSessionKey ) throws Exception
     {
@@ -212,6 +213,7 @@
 
         assertTrue( "Password change returned SUCCESS (0x00 0x00).", Arrays.equals( SUCCESS,
resultCode ) );
     }
+     */
 
 
     public void testSetPassword() throws Exception

Modified: directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/directory/server/kerberos/kdc/KerberosServer.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/directory/server/kerberos/kdc/KerberosServer.java?rev=574834&r1=574833&r2=574834&view=diff
==============================================================================
--- directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/directory/server/kerberos/kdc/KerberosServer.java
(original)
+++ directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/directory/server/kerberos/kdc/KerberosServer.java
Wed Sep 12 01:18:46 2007
@@ -92,7 +92,7 @@
      * @param newConfig
      * @return <code>True</true> if the configuration is different.
      */
-    public boolean isDifferent( Dictionary newConfig )
+    public boolean isDifferent( Dictionary<String, Object> newConfig )
     {
         return config.isDifferent( newConfig );
     }

Modified: directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/NtpServer.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/NtpServer.java?rev=574834&r1=574833&r2=574834&view=diff
==============================================================================
--- directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/NtpServer.java
(original)
+++ directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/NtpServer.java
Wed Sep 12 01:18:46 2007
@@ -84,7 +84,7 @@
      * @param newConfig
      * @return Whether configuration being proposed as new is really different.
      */
-    public boolean isDifferent( Dictionary newConfig )
+    public boolean isDifferent( Dictionary<String, Object> newConfig )
     {
         return config.isDifferent( newConfig );
     }



Mime
View raw message