directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elecha...@apache.org
Subject svn commit: r568064 - /directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java
Date Tue, 21 Aug 2007 11:23:43 GMT
Author: elecharny
Date: Tue Aug 21 04:23:42 2007
New Revision: 568064

URL: http://svn.apache.org/viewvc?rev=568064&view=rev
Log:
Added an assertObjectClass() private methode to check that the current entry ObjectClasses
contain a STRUCTURAL OC

Modified:
    directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java

Modified: directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java?rev=568064&r1=568063&r2=568064&view=diff
==============================================================================
--- directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java
(original)
+++ directory/apacheds/trunk/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java
Tue Aug 21 04:23:42 2007
@@ -1701,12 +1701,17 @@
         List<ObjectClass> ocs = new ArrayList<ObjectClass>();
 
         alterObjectClasses( objectClassAttr );
-
+        
+        // Now we can process the MUST and MAY attributes
         Set<String> must = getAllMust( objectClassAttr.getAll() );
         Set<String> allowed = getAllAllowed( objectClassAttr.getAll(), must );
 
         boolean hasExtensibleObject = getObjectClasses( objectClassAttr, ocs );
 
+        // As we now have all the ObjectClasses updated, we have
+        // to check that we don't have conflicting ObjectClasses
+        assertObjectClasses( ocs );
+
         assertRequiredAttributesPresent( dn, entry, must );
         assertNumberOfAttributeValuesValid( entry );
 
@@ -1851,6 +1856,51 @@
         }
     }
     
+    /**
+     * Checck that OC does not conflict :
+     * - we can't have more than one STRUCTURAL OC unless they are in the same
+     * inheritance tree
+     * - we must have at least one STRUCTURAL OC
+     */
+    private void assertObjectClasses( List<ObjectClass> ocs )  throws LdapSchemaViolationException
+    {
+    	boolean hasStructural = false;
+    	boolean hasExtensibleObject = false;
+    	
+    	// Loop on all the entry objectClasses 
+    	for ( ObjectClass oc:ocs )
+    	{
+    		if ( oc.isStructural() )
+    		{
+    			// We have a STRUCTURAL OC. Do we already found one ?
+    			if ( hasStructural )
+    			{
+    				// Yes, then there must be an inheritence relationship
+    				// between those two OC, otherwise this is an error.
+    				// TODO check that the inheritence tree is correct
+    			}
+    			else
+    			{
+    				hasStructural = true;
+    			}
+    		}
+    		
+    		if ( oc.getOid().equals( SchemaConstants.EXTENSIBLE_OBJECT_OC_OID ) )
+    		{
+    			hasExtensibleObject = true;
+    		}
+    	}
+    	
+    	// Throw an error if no STRUCTURAL objectClass is found.
+    	// Right now, if the extensibleObject OC is present, we relax
+    	// the previous constraint to avoid failing tests.
+    	if ( !hasStructural && !hasExtensibleObject )
+    	{
+    		String message = "An entry must have at least one STRUCTURAL ObjectClass";
+    		log.error( message );
+    		throw new LdapSchemaViolationException( message, ResultCodeEnum.OBJECT_CLASS_VIOLATION
);
+    	}
+    }
 
     /**
      * Check the entry attributes syntax, using the syntaxCheckers



Mime
View raw message