directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ccust...@apache.org
Subject svn commit: r556238 [5/8] - in /directory: apacheds/trunk-with-dependencies/ sandbox/ccustine/new_installers/apacheds/ sandbox/ccustine/new_installers/apacheds/benchmarks/ sandbox/ccustine/new_installers/apacheds/bootstrap-extract/ sandbox/ccustine/new...
Date Sat, 14 Jul 2007 07:55:59 GMT
Modified: directory/sandbox/ccustine/new_installers/apacheds/pom.xml
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/pom.xml?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/pom.xml (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/pom.xml Sat Jul 14 00:55:44 2007
@@ -9,7 +9,7 @@
   </parent>
 
   <groupId>org.apache.directory.server</groupId>
-  <artifactId>build</artifactId>
+  <artifactId>apacheds-parent</artifactId>
   <version>1.5.1-SNAPSHOT</version>
   <name>ApacheDS</name>
   <packaging>pom</packaging>
@@ -20,6 +20,12 @@
     <dependencies>
       <dependency>
         <groupId>org.apache.directory.server</groupId>
+        <artifactId>apacheds-server-xml</artifactId>
+        <version>${pom.version}</version>
+      </dependency>
+
+      <dependency>
+        <groupId>org.apache.directory.server</groupId>
         <artifactId>apacheds-core</artifactId>
         <version>${pom.version}</version>
       </dependency>
@@ -109,9 +115,15 @@
       </dependency>
 
       <dependency>
-        <groupId>commons-logging</groupId>
-        <artifactId>commons-logging</artifactId>
-        <version>1.1</version>
+        <groupId>org.slf4j</groupId>
+        <artifactId>jcl104-over-slf4j</artifactId>
+        <version>1.4.0</version>
+      </dependency>
+
+      <dependency>
+        <groupId>org.slf4j</groupId>
+        <artifactId>slf4j-api</artifactId>
+        <version>1.4.0</version>
       </dependency>
 
       <dependency>
@@ -249,9 +261,30 @@
     </dependency>
 
     <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+      <version>1.4.0</version>
+    </dependency>
+
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>jcl104-over-slf4j</artifactId>
+      <version>1.4.0</version>
+      <scope>test</scope>
+    </dependency>
+
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>nlog4j</artifactId>
+      <version>1.2.25</version>
+      <scope>test</scope>
+    </dependency>
+
+    <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
       <version>3.8.1</version>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 
@@ -284,6 +317,7 @@
       <module>server-sar</module>
     -->
 
+    <module>server-xml</module>
     <module>server-unit</module>
     <module>server-main</module>
     <module>server-jndi</module>
@@ -384,6 +418,11 @@
   <build>
     <pluginManagement>
       <plugins>
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>dependency-maven-plugin</artifactId>
+          <version>1.0</version>
+        </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-surefire-plugin</artifactId>

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/pom.xml
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/pom.xml?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/pom.xml (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/pom.xml Sat Jul 14 00:55:44 2007
@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <parent>
     <groupId>org.apache.directory.server</groupId>
-    <artifactId>build</artifactId>
+    <artifactId>apacheds-parent</artifactId>
     <version>1.5.1-SNAPSHOT</version>
   </parent>
   <artifactId>apacheds-protocol-changepw</artifactId>
@@ -16,12 +16,6 @@
   <packaging>jar</packaging>  
 
   <dependencies>
-    <dependency>
-      <groupId>org.slf4j</groupId>
-      <artifactId>nlog4j</artifactId>
-      <scope>provided</scope>
-    </dependency>
-
     <dependency>
       <groupId>org.apache.directory.server</groupId>
       <artifactId>apacheds-kerberos-shared</artifactId>

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordConfiguration.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordConfiguration.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordConfiguration.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordConfiguration.java Sat Jul 14 00:55:44 2007
@@ -127,6 +127,15 @@
 
 
     /**
+     * @param primaryRealm The primaryRealm to set.
+     */
+    public void setPrimaryRealm( String primaryRealm )
+    {
+        this.primaryRealm = primaryRealm;
+    }
+
+
+    /**
      * Returns the encryption types.
      *
      * @return The encryption types.
@@ -138,6 +147,15 @@
 
 
     /**
+     * @param encryptionTypes The encryptionTypes to set.
+     */
+    public void setEncryptionTypes( EncryptionType[] encryptionTypes )
+    {
+        this.encryptionTypes = encryptionTypes;
+    }
+
+
+    /**
      * Returns the allowable clock skew.
      *
      * @return The allowable clock skew.
@@ -149,6 +167,15 @@
 
 
     /**
+     * @param allowableClockSkew The allowableClockSkew to set.
+     */
+    public void setAllowableClockSkew( long allowableClockSkew )
+    {
+        this.allowableClockSkew = allowableClockSkew;
+    }
+
+
+    /**
      * Returns the Change Password service principal.
      *
      * @return The Change Password service principal.
@@ -160,6 +187,15 @@
 
 
     /**
+     * @param servicePrincipal The Change Password service principal to set.
+     */
+    public void setServicePrincipal( String servicePrincipal )
+    {
+        this.servicePrincipal = servicePrincipal;
+    }
+
+
+    /**
      * Returns whether empty addresses are allowed.
      *
      * @return Whether empty addresses are allowed.
@@ -167,6 +203,15 @@
     public boolean isEmptyAddressesAllowed()
     {
         return isEmptyAddressesAllowed;
+    }
+
+
+    /**
+     * @param isEmptyAddressesAllowed The isEmptyAddressesAllowed to set.
+     */
+    public void setEmptyAddressesAllowed( boolean isEmptyAddressesAllowed )
+    {
+        this.isEmptyAddressesAllowed = isEmptyAddressesAllowed;
     }
 
 

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java Sat Jul 14 00:55:44 2007
@@ -77,7 +77,7 @@
 
             acceptor.bind( new InetSocketAddress( port ), handler, serviceConfig );
 
-            log.debug( "{} listening on port {}", name, new Integer( port ) );
+            log.debug( "{} listening on port {}.", name, new Integer( port ) );
         }
         catch ( IOException ioe )
         {
@@ -108,6 +108,6 @@
         acceptor = null;
         handler = null;
 
-        log.debug( "{} has stopped listening on port {}", config.getServiceName(), new Integer( config.getIpPort() ) );
+        log.debug( "{} has stopped listening on port {}.", config.getServiceName(), new Integer( config.getIpPort() ) );
     }
 }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorDecoder.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorDecoder.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorDecoder.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorDecoder.java Sat Jul 14 00:55:44 2007
@@ -54,19 +54,18 @@
 
         modifier.setProtocolVersionNumber( buf.getShort() );
 
-        /*
-         * TODO - No condition to set on modifier.
-         */
-        buf.getShort();
+        // AP_REQ length will be 0 for error messages
+        modifier.setAuthHeaderLength( buf.getShort() );
 
         int errorLength = messageLength - HEADER_LENGTH;
 
         byte[] errorBytes = new byte[errorLength];
 
         buf.get( errorBytes );
+        ByteBuffer errorBuffer = ByteBuffer.wrap( errorBytes );
 
         ErrorMessageDecoder errorDecoder = new ErrorMessageDecoder();
-        ErrorMessage errorMessage = errorDecoder.decode( buf );
+        ErrorMessage errorMessage = errorDecoder.decode( errorBuffer );
 
         modifier.setErrorMessage( errorMessage );
 

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java Sat Jul 14 00:55:44 2007
@@ -43,6 +43,7 @@
 import org.apache.mina.common.IdleStatus;
 import org.apache.mina.common.IoHandler;
 import org.apache.mina.common.IoSession;
+import org.apache.mina.common.TransportType;
 import org.apache.mina.filter.codec.ProtocolCodecFilter;
 import org.apache.mina.handler.chain.IoHandlerCommand;
 import org.slf4j.Logger;
@@ -80,10 +81,21 @@
 
     public void sessionCreated( IoSession session ) throws Exception
     {
-        log.debug( "{} CREATED", session.getRemoteAddress() );
+        if ( log.isDebugEnabled() )
+        {
+            log.debug( "{} CREATED:  {}", session.getRemoteAddress(), session.getTransportType() );
+        }
 
-        session.getFilterChain().addFirst( "codec",
-            new ProtocolCodecFilter( ChangePasswordProtocolCodecFactory.getInstance() ) );
+        if ( session.getTransportType() == TransportType.DATAGRAM )
+        {
+            session.getFilterChain().addFirst( "codec",
+                new ProtocolCodecFilter( ChangePasswordUdpProtocolCodecFactory.getInstance() ) );
+        }
+        else
+        {
+            session.getFilterChain().addFirst( "codec",
+                new ProtocolCodecFilter( ChangePasswordTcpProtocolCodecFactory.getInstance() ) );
+        }
     }
 
 
@@ -101,7 +113,7 @@
 
     public void sessionIdle( IoSession session, IdleStatus status )
     {
-        log.debug( "{} IDLE({})", session.getRemoteAddress(), status );
+        log.debug( "{} IDLE ({})", session.getRemoteAddress(), status );
     }
 
 
@@ -114,7 +126,7 @@
 
     public void messageReceived( IoSession session, Object message )
     {
-        log.debug( "{} RCVD: {}", session.getRemoteAddress(), message );
+        log.debug( "{} RCVD:  {}", session.getRemoteAddress(), message );
 
         InetAddress clientAddress = ( ( InetSocketAddress ) session.getRemoteAddress() ).getAddress();
         ChangePasswordRequest request = ( ChangePasswordRequest ) message;
@@ -164,7 +176,7 @@
     {
         if ( log.isDebugEnabled() )
         {
-            log.debug( "{} SENT: {}", session.getRemoteAddress(), message );
+            log.debug( "{} SENT:  {}", session.getRemoteAddress(), message );
         }
     }
 

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/service/ProcessPasswordChange.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/service/ProcessPasswordChange.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/service/ProcessPasswordChange.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-changepw/src/main/java/org/apache/directory/server/changepw/service/ProcessPasswordChange.java Sat Jul 14 00:55:44 2007
@@ -63,7 +63,7 @@
         try
         {
             String principalName = store.changePassword( clientPrincipal, newPassword );
-            log.debug( "Successfully modified principal {}", principalName );
+            log.debug( "Successfully modified principal {}.", principalName );
         }
         catch ( NamingException ne )
         {

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/pom.xml
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/pom.xml?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/pom.xml (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/pom.xml Sat Jul 14 00:55:44 2007
@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <parent>
     <groupId>org.apache.directory.server</groupId>
-    <artifactId>build</artifactId>
+    <artifactId>apacheds-parent</artifactId>
     <version>1.5.1-SNAPSHOT</version>
   </parent>
   <artifactId>apacheds-protocol-dhcp</artifactId>
@@ -20,12 +20,6 @@
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
       <scope>test</scope>
-    </dependency>
-
-    <dependency>
-      <groupId>org.slf4j</groupId>
-      <artifactId>nlog4j</artifactId>
-      <scope>provided</scope>
     </dependency>
 
     <dependency>

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/DhcpService.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/DhcpService.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/DhcpService.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/DhcpService.java Sat Jul 14 00:55:44 2007
@@ -32,5 +32,11 @@
  */
 public interface DhcpService
 {
+    /**
+     * Returns a reply for a given request.
+     *
+     * @param request
+     * @return The {@link DhcpMessage} reply.
+     */
     public DhcpMessage getReplyFor( DhcpMessage request );
 }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpMessageDecoder.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpMessageDecoder.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpMessageDecoder.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpMessageDecoder.java Sat Jul 14 00:55:44 2007
@@ -40,6 +40,7 @@
      * 
      * @return a DhcpMessage.
      * @param buffer ByteBuffer to convert to a DhcpMessage object
+     * @throws DhcpException 
      */
     public DhcpMessage decode( ByteBuffer buffer ) throws DhcpException
     {

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpOptionsDecoder.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpOptionsDecoder.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpOptionsDecoder.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpOptionsDecoder.java Sat Jul 14 00:55:44 2007
@@ -50,6 +50,13 @@
         { ( byte ) 99, ( byte ) 130, ( byte ) 83, ( byte ) 99 };
 
 
+    /**
+     * Decodes the {@link ByteBuffer} into an {@link OptionsField}.
+     *
+     * @param message
+     * @return The decoded {@link OptionsField}.
+     * @throws DhcpException
+     */
     public OptionsField decode( ByteBuffer message ) throws DhcpException
     {
         byte[] magicCookie = new byte[4];

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpOptionsEncoder.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpOptionsEncoder.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpOptionsEncoder.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/io/DhcpOptionsEncoder.java Sat Jul 14 00:55:44 2007
@@ -38,6 +38,12 @@
         { ( byte ) 99, ( byte ) 130, ( byte ) 83, ( byte ) 99 };
 
 
+    /**
+     * Encodes the {@link OptionsField} into the provided {@link ByteBuffer}.
+     *
+     * @param options
+     * @param message
+     */
     public void encode( OptionsField options, ByteBuffer message )
     {
         message.put( VENDOR_MAGIC_COOKIE );

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/DhcpMessage.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/DhcpMessage.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/DhcpMessage.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/DhcpMessage.java Sat Jul 14 00:55:44 2007
@@ -50,10 +50,30 @@
     private OptionsField options = new OptionsField();
 
 
-    public DhcpMessage(MessageType messageType, byte opCode, byte hardwareAddressType, byte hardwareAddressLength,
+    /**
+     * Creates a new instance of DhcpMessage.
+     *
+     * @param messageType
+     * @param opCode
+     * @param hardwareAddressType
+     * @param hardwareAddressLength
+     * @param hardwareOptions
+     * @param transactionId
+     * @param seconds
+     * @param flags
+     * @param actualClientAddress
+     * @param assignedClientAddress
+     * @param nextServerAddress
+     * @param relayAgentAddress
+     * @param clientHardwareAddress
+     * @param serverHostname
+     * @param bootFileName
+     * @param options
+     */
+    public DhcpMessage( MessageType messageType, byte opCode, byte hardwareAddressType, byte hardwareAddressLength,
         byte hardwareOptions, int transactionId, short seconds, short flags, byte[] actualClientAddress,
         byte[] assignedClientAddress, byte[] nextServerAddress, byte[] relayAgentAddress, byte[] clientHardwareAddress,
-        byte[] serverHostname, byte[] bootFileName, OptionsField options)
+        byte[] serverHostname, byte[] bootFileName, OptionsField options )
     {
         this.messageType = messageType;
         this.opCode = opCode;
@@ -76,6 +96,8 @@
 
     /**
      * Message type.
+     * 
+     * @return The {@link MessageType}.
      */
     public MessageType getMessageType()
     {
@@ -86,6 +108,8 @@
     /**
      * Message op code / message type.
      * 1 = BOOTREQUEST, 2 = BOOTREPLY
+     * 
+     * @return The message op code (type).
      */
     public byte getOpCode()
     {
@@ -96,6 +120,8 @@
     /**
      * Hardware address type, see ARP section in
      * "Assigned Numbers" RFC; e.g., '1' = 10mb ethernet.
+     * 
+     * @return The hardware address type.
      */
     public byte getHardwareAddressType()
     {
@@ -105,6 +131,8 @@
 
     /**
      * Hardware address length (e.g.  '6' for 10mb ethernet).
+     * 
+     * @return The hardware address length.
      */
     public byte getHardwareAddressLength()
     {
@@ -115,6 +143,8 @@
     /**
      * Client sets to zero, optionally used by relay agents
      * when booting via a relay agent.
+     * 
+     * @return The hardware options.
      */
     public byte getHardwareOptions()
     {
@@ -126,6 +156,8 @@
      * Transaction ID, a random number chosen by the client,
      * used by the client and server to associate messages
      * and responses between a client and a server.
+     * 
+     * @return The transaction ID.
      */
     public int getTransactionId()
     {
@@ -136,6 +168,8 @@
     /**
      * Filled in by client, seconds elapsed since client
      * began address acquisition or renewal process.
+     * 
+     * @return The seconds.
      */
     public short getSeconds()
     {
@@ -145,6 +179,8 @@
 
     /**
      * Flags.
+     * 
+     * @return The flags.
      */
     public short getFlags()
     {
@@ -155,6 +191,8 @@
     /**
      * Client IP address; only filled in if client is in BOUND,
      * RENEW or REBINDING state and can respond to ARP requests.
+     * 
+     * @return The actual client addresses.
      */
     public byte[] getActualClientAddress()
     {
@@ -164,6 +202,8 @@
 
     /**
      * Get 'your' (client) IP address.
+     * 
+     * @return The assigned client addresses.
      */
     public byte[] getAssignedClientAddress()
     {
@@ -174,6 +214,8 @@
     /**
      * IP address of next server to use in bootstrap;
      * returned in DHCPOFFER, DHCPACK by server.
+     * 
+     * @return The next server address.
      */
     public byte[] getNextServerAddress()
     {
@@ -183,6 +225,8 @@
 
     /**
      * Relay agent IP address, used in booting via a relay agent.
+     * 
+     * @return The relay agent address.
      */
     public byte[] getRelayAgentAddress()
     {
@@ -192,6 +236,8 @@
 
     /**
      * Client hardware address.
+     * 
+     * @return The client hardware address.
      */
     public byte[] getClientHardwareAddress()
     {
@@ -201,6 +247,8 @@
 
     /**
      * Optional server host name, null terminated string.
+     * 
+     * @return The server hostname.
      */
     public byte[] getServerHostname()
     {
@@ -211,6 +259,8 @@
     /**
      * Boot file name, null terminated string; "generic" name or null
      * in DHCPDISCOVER, fully qualified directory-path name in DHCPOFFER.
+     * 
+     * @return The boot file name.
      */
     public byte[] getBootFileName()
     {
@@ -221,6 +271,8 @@
     /**
      * Optional parameters field.  See the options
      * documents for a list of defined options.
+     * 
+     * @return The options.
      */
     public OptionsField getOptions()
     {

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/DhcpMessageModifier.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/DhcpMessageModifier.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/DhcpMessageModifier.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/DhcpMessageModifier.java Sat Jul 14 00:55:44 2007
@@ -49,6 +49,11 @@
     private OptionsField options = new OptionsField();
 
 
+    /**
+     * Get a new {@link DhcpMessage}.
+     *
+     * @return The new {@link DhcpMessage}.
+     */
     public DhcpMessage getDhcpMessage()
     {
         return new DhcpMessage( messageType, opCode, hardwareAddressType, hardwareAddressLength, hardwareOptions,
@@ -59,6 +64,8 @@
 
     /**
      * Message type.
+     * 
+     * @param messageType 
      */
     public void setMessageType( MessageType messageType )
     {
@@ -69,6 +76,8 @@
     /**
      * Message op code / message type.
      * 1 = BOOTREQUEST, 2 = BOOTREPLY
+     * 
+     * @param opCode 
      */
     public void setOpCode( byte opCode )
     {
@@ -79,6 +88,8 @@
     /**
      * Hardware address type, see ARP section in
      * "Assigned Numbers" RFC; e.g., '1' = 10mb ethernet.
+     * 
+     * @param hardwareAddressType 
      */
     public void setHardwareAddressType( byte hardwareAddressType )
     {
@@ -88,6 +99,8 @@
 
     /**
      * Hardware address length (e.g.  '6' for 10mb ethernet).
+     * 
+     * @param hardwareAddressLength 
      */
     public void setHardwareAddressLength( byte hardwareAddressLength )
     {
@@ -110,6 +123,8 @@
      * Transaction ID, a random number chosen by the client,
      * used by the client and server to associate messages
      * and responses between a client and a server.
+     * 
+     * @param transactionId 
      */
     public void setTransactionId( int transactionId )
     {
@@ -120,6 +135,8 @@
     /**
      * Filled in by client, seconds elapsed since client
      * began address acquisition or renewal process.
+     * 
+     * @param seconds 
      */
     public void setSeconds( short seconds )
     {
@@ -129,6 +146,8 @@
 
     /**
      * Flags.
+     * 
+     * @param flags 
      */
     public void setFlags( short flags )
     {
@@ -139,6 +158,8 @@
     /**
      * Client IP address; only filled in if client is in BOUND,
      * RENEW or REBINDING state and can respond to ARP requests.
+     * 
+     * @param actualClientAddress 
      */
     public void setActualClientAddress( byte[] actualClientAddress )
     {
@@ -148,6 +169,8 @@
 
     /**
      * Get 'your' (client) IP address.
+     * 
+     * @param assignedClientAddress 
      */
     public void setAssignedClientAddress( byte[] assignedClientAddress )
     {
@@ -158,6 +181,8 @@
     /**
      * IP address of next server to use in bootstrap;
      * returned in DHCPOFFER, DHCPACK by server.
+     * 
+     * @param nextServerAddress 
      */
     public void setNextServerAddress( byte[] nextServerAddress )
     {
@@ -167,6 +192,8 @@
 
     /**
      * Relay agent IP address, used in booting via a relay agent.
+     * 
+     * @param relayAgentAddress 
      */
     public void setRelayAgentAddress( byte[] relayAgentAddress )
     {
@@ -176,6 +203,8 @@
 
     /**
      * Client hardware address.
+     * 
+     * @param clientHardwareAddress 
      */
     public void setClientHardwareAddress( byte[] clientHardwareAddress )
     {
@@ -185,6 +214,8 @@
 
     /**
      * Optional server host name, null terminated string.
+     * 
+     * @param serverHostname 
      */
     public void setServerHostname( byte[] serverHostname )
     {
@@ -195,6 +226,8 @@
     /**
      * Boot file name, null terminated string; "generic" name or null
      * in DHCPDISCOVER, fully qualified directory-path name in DHCPOFFER.
+     * 
+     * @param bootFileName 
      */
     public void setBootFileName( byte[] bootFileName )
     {
@@ -205,6 +238,8 @@
     /**
      * Optional parameters field.  See the options
      * documents for a list of defined options.
+     * 
+     * @param options 
      */
     public void setOptions( OptionsField options )
     {

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/MessageType.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/MessageType.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/MessageType.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/messages/MessageType.java Sat Jul 14 00:55:44 2007
@@ -33,32 +33,88 @@
 public final class MessageType implements Comparable
 {
     /**
-     * Enumeration elements are constructed once upon class loading.
-     * Order of appearance here determines the order of compareTo.
+     * Constant for the "Null" message type.
      */
     public static final MessageType NULL = new MessageType( 0, "Null" );
+
+    /**
+     * Constant for the "DHCP Discover" message type.
+     */
     public static final MessageType DHCPDISCOVER = new MessageType( 1, "DHCP Discover" );
+
+    /**
+     * Constant for the "DHCP Offer" message type.
+     */
     public static final MessageType DHCPOFFER = new MessageType( 2, "DHCP Offer" );
+
+    /**
+     * Constant for the "DHCP Request" message type.
+     */
     public static final MessageType DHCPREQUEST = new MessageType( 3, "DHCP Request" );
+
+    /**
+     * Constant for the "DHCP Decline" message type.
+     */
     public static final MessageType DHCPDECLINE = new MessageType( 4, "DHCP Decline" );
+
+    /**
+     * Constant for the "DHCP Acknowledge" message type.
+     */
     public static final MessageType DHCPACK = new MessageType( 5, "DHCP Acknowledge" );
+
+    /**
+     * Constant for the "DHCP Not Acknowledge" message type.
+     */
     public static final MessageType DHCPNAK = new MessageType( 6, "DHCP Not Acknowledge" );
+
+    /**
+     * Constant for the "DHCP Release" message type.
+     */
     public static final MessageType DHCPRELEASE = new MessageType( 7, "DHCP Release" );
+
+    /**
+     * Constant for the "DHCP Inform" message type.
+     */
     public static final MessageType DHCPINFORM = new MessageType( 8, "DHCP Inform" );
 
+    /**
+     * Array for building a List of VALUES.
+     */
+    private static final MessageType[] values =
+        { NULL, DHCPDISCOVER, DHCPOFFER, DHCPREQUEST, DHCPDECLINE, DHCPACK, DHCPNAK, DHCPRELEASE, DHCPINFORM };
+
+    /**
+     * A list of all the message type constants.
+     */
+    public static final List VALUES = Collections.unmodifiableList( Arrays.asList( values ) );
 
-    public String toString()
-    {
-        return name;
-    }
+    /**
+     * The name of the message type.
+     */
+    private final String name;
+
+    /**
+     * The value/code for the message type.
+     */
+    private final int ordinal;
 
 
-    public int compareTo( Object that )
+    /**
+     * Private constructor prevents construction outside of this class.
+     */
+    private MessageType( int ordinal, String name )
     {
-        return ordinal - ( ( MessageType ) that ).ordinal;
+        this.ordinal = ordinal;
+        this.name = name;
     }
 
 
+    /**
+     * Returns the message type when specified by its ordinal.
+     *
+     * @param type
+     * @return The message type.
+     */
     public static MessageType getTypeByOrdinal( int type )
     {
         for ( int ii = 0; ii < values.length; ii++ )
@@ -68,30 +124,25 @@
     }
 
 
+    /**
+     * Returns the number associated with this message type.
+     *
+     * @return The message type ordinal.
+     */
     public int getOrdinal()
     {
         return ordinal;
     }
 
-    /// PRIVATE /////
-    private final String name;
-    private final int ordinal;
 
-
-    /**
-     * Private constructor prevents construction outside of this class.
-     */
-    private MessageType(int ordinal, String name)
+    public int compareTo( Object that )
     {
-        this.ordinal = ordinal;
-        this.name = name;
+        return ordinal - ( ( MessageType ) that ).ordinal;
     }
 
-    /**
-     * These two lines are all that's necessary to export a List of VALUES.
-     */
-    private static final MessageType[] values =
-        { NULL, DHCPDISCOVER, DHCPOFFER, DHCPREQUEST, DHCPDECLINE, DHCPACK, DHCPNAK, DHCPRELEASE, DHCPINFORM };
-    // VALUES needs to be located here, otherwise illegal forward reference
-    public static final List VALUES = Collections.unmodifiableList( Arrays.asList( values ) );
+
+    public String toString()
+    {
+        return name;
+    }
 }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/AddressListOption.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/AddressListOption.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/AddressListOption.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/AddressListOption.java Sat Jul 14 00:55:44 2007
@@ -41,7 +41,13 @@
     private byte[] value;
 
 
-    public AddressListOption(int tag, byte[] value)
+    /**
+     * Creates a new instance of AddressListOption.
+     *
+     * @param tag
+     * @param value
+     */
+    public AddressListOption( int tag, byte[] value )
     {
         super( tag, value.length );
         this.value = value;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/AddressOption.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/AddressOption.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/AddressOption.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/AddressOption.java Sat Jul 14 00:55:44 2007
@@ -43,7 +43,13 @@
     private byte[] value;
 
 
-    public AddressOption(int tag, byte[] value)
+    /**
+     * Creates a new instance of AddressOption.
+     *
+     * @param tag
+     * @param value
+     */
+    public AddressOption( int tag, byte[] value )
     {
         super( tag, length );
         this.value = value;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/DhcpOption.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/DhcpOption.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/DhcpOption.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/DhcpOption.java Sat Jul 14 00:55:44 2007
@@ -40,7 +40,13 @@
     private int length;
 
 
-    public DhcpOption(int tag, int length)
+    /**
+     * Creates a new instance of DhcpOption.
+     *
+     * @param tag
+     * @param length
+     */
+    public DhcpOption( int tag, int length )
     {
         this.tag = tag;
         this.length = length;
@@ -50,6 +56,11 @@
     abstract protected void valueToByteBuffer( ByteBuffer out );
 
 
+    /**
+     * Writes this {@link DhcpOption} to the provided {@link ByteBuffer}.
+     *
+     * @param out
+     */
     public void writeTo( ByteBuffer out )
     {
         out.put( ( byte ) tag );

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/OptionsField.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/OptionsField.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/OptionsField.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/OptionsField.java Sat Jul 14 00:55:44 2007
@@ -40,18 +40,33 @@
     private Set<DhcpOption> options = new HashSet<DhcpOption>();
 
 
+    /**
+     * Adds the provided {@link DhcpOption} to this {@link OptionsField}.
+     *
+     * @param option
+     */
     public void add( DhcpOption option )
     {
         options.add( option );
     }
 
 
+    /**
+     * Returns whether this {@link OptionsField} is empty.
+     *
+     * @return true if this {@link OptionsField} is empty.
+     */
     public boolean isEmpty()
     {
         return options.isEmpty();
     }
 
 
+    /**
+     * Returns this {@link OptionsField} as an array of {@link DhcpOption}s.
+     *
+     * @return The array of {@link DhcpOption}s.
+     */
     public DhcpOption[] toArray()
     {
         return options.toArray( new DhcpOption[options.size()] );

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/BootfileName.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/BootfileName.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/BootfileName.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/BootfileName.java Sat Jul 14 00:55:44 2007
@@ -40,7 +40,12 @@
     private byte[] bootFileName;
 
 
-    public BootfileName(byte[] bootFileName)
+    /**
+     * Creates a new instance of BootfileName.
+     *
+     * @param bootFileName
+     */
+    public BootfileName( byte[] bootFileName )
     {
         super( 67, 1 );
         this.bootFileName = bootFileName;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ClientIdentifier.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ClientIdentifier.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ClientIdentifier.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ClientIdentifier.java Sat Jul 14 00:55:44 2007
@@ -58,7 +58,12 @@
     private byte[] clientIdentifier;
 
 
-    public ClientIdentifier(byte[] clientIdentifier)
+    /**
+     * Creates a new instance of ClientIdentifier.
+     *
+     * @param clientIdentifier
+     */
+    public ClientIdentifier( byte[] clientIdentifier )
     {
         super( 61, 2 );
         this.clientIdentifier = clientIdentifier;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/DhcpMessageType.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/DhcpMessageType.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/DhcpMessageType.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/DhcpMessageType.java Sat Jul 14 00:55:44 2007
@@ -50,7 +50,12 @@
     private byte[] messageType;
 
 
-    public DhcpMessageType(byte[] messageType)
+    /**
+     * Creates a new instance of DhcpMessageType.
+     *
+     * @param messageType
+     */
+    public DhcpMessageType( byte[] messageType )
     {
         super( 53, 1 );
         this.messageType = messageType;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/IpAddressLeaseTime.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/IpAddressLeaseTime.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/IpAddressLeaseTime.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/IpAddressLeaseTime.java Sat Jul 14 00:55:44 2007
@@ -45,7 +45,12 @@
     private byte[] ipAddressLeaseTime;
 
 
-    public IpAddressLeaseTime(byte[] ipAddressLeaseTime)
+    /**
+     * Creates a new instance of IpAddressLeaseTime.
+     *
+     * @param ipAddressLeaseTime
+     */
+    public IpAddressLeaseTime( byte[] ipAddressLeaseTime )
     {
         super( 51, 4 );
         this.ipAddressLeaseTime = ipAddressLeaseTime;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/MaximumDhcpMessageSize.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/MaximumDhcpMessageSize.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/MaximumDhcpMessageSize.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/MaximumDhcpMessageSize.java Sat Jul 14 00:55:44 2007
@@ -44,7 +44,12 @@
     private byte[] maximumDhcpMessageSize;
 
 
-    public MaximumDhcpMessageSize(byte[] maximumDhcpMessageSize)
+    /**
+     * Creates a new instance of MaximumDhcpMessageSize.
+     *
+     * @param maximumDhcpMessageSize
+     */
+    public MaximumDhcpMessageSize( byte[] maximumDhcpMessageSize )
     {
         super( 57, 2 );
         this.maximumDhcpMessageSize = maximumDhcpMessageSize;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/Message.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/Message.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/Message.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/Message.java Sat Jul 14 00:55:44 2007
@@ -44,7 +44,12 @@
     private byte[] message;
 
 
-    public Message(byte[] message)
+    /**
+     * Creates a new instance of Message.
+     *
+     * @param message
+     */
+    public Message( byte[] message )
     {
         super( 56, 1 );
         this.message = message;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/OptionOverload.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/OptionOverload.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/OptionOverload.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/OptionOverload.java Sat Jul 14 00:55:44 2007
@@ -53,7 +53,12 @@
     private byte[] optionOverload;
 
 
-    public OptionOverload(byte[] optionOverload)
+    /**
+     * Creates a new instance of OptionOverload.
+     *
+     * @param optionOverload
+     */
+    public OptionOverload( byte[] optionOverload )
     {
         super( 52, 1 );
         this.optionOverload = optionOverload;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ParameterRequestList.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ParameterRequestList.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ParameterRequestList.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ParameterRequestList.java Sat Jul 14 00:55:44 2007
@@ -47,7 +47,12 @@
     private byte[] parameterRequestList;
 
 
-    public ParameterRequestList(byte[] parameterRequestList)
+    /**
+     * Creates a new instance of ParameterRequestList.
+     *
+     * @param parameterRequestList
+     */
+    public ParameterRequestList( byte[] parameterRequestList )
     {
         super( 55, 1 );
         this.parameterRequestList = parameterRequestList;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RebindingTimeValue.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RebindingTimeValue.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RebindingTimeValue.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RebindingTimeValue.java Sat Jul 14 00:55:44 2007
@@ -43,7 +43,12 @@
     private int rebindingTimeValue;
 
 
-    public RebindingTimeValue(int rebindingTimeValue)
+    /**
+     * Creates a new instance of RebindingTimeValue.
+     *
+     * @param rebindingTimeValue
+     */
+    public RebindingTimeValue( int rebindingTimeValue )
     {
         super( 59, 4 );
         this.rebindingTimeValue = rebindingTimeValue;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RenewalTimeValue.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RenewalTimeValue.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RenewalTimeValue.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RenewalTimeValue.java Sat Jul 14 00:55:44 2007
@@ -43,7 +43,12 @@
     private int renewalTimeValue;
 
 
-    public RenewalTimeValue(int renewalTimeValue)
+    /**
+     * Creates a new instance of RenewalTimeValue.
+     *
+     * @param renewalTimeValue
+     */
+    public RenewalTimeValue( int renewalTimeValue )
     {
         super( 58, 4 );
         this.renewalTimeValue = renewalTimeValue;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RequestedIpAddress.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RequestedIpAddress.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RequestedIpAddress.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/RequestedIpAddress.java Sat Jul 14 00:55:44 2007
@@ -35,7 +35,12 @@
  */
 public class RequestedIpAddress extends AddressOption
 {
-    public RequestedIpAddress(byte[] requestedIpAddress)
+    /**
+     * Creates a new instance of RequestedIpAddress.
+     *
+     * @param requestedIpAddress
+     */
+    public RequestedIpAddress( byte[] requestedIpAddress )
     {
         super( 50, requestedIpAddress );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ServerIdentifier.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ServerIdentifier.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ServerIdentifier.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/ServerIdentifier.java Sat Jul 14 00:55:44 2007
@@ -43,7 +43,12 @@
  */
 public class ServerIdentifier extends AddressOption
 {
-    public ServerIdentifier(byte[] serverIdentifier)
+    /**
+     * Creates a new instance of ServerIdentifier.
+     *
+     * @param serverIdentifier
+     */
+    public ServerIdentifier( byte[] serverIdentifier )
     {
         super( 54, serverIdentifier );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/TftpServerName.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/TftpServerName.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/TftpServerName.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/TftpServerName.java Sat Jul 14 00:55:44 2007
@@ -40,7 +40,12 @@
     private byte[] tftpServerName;
 
 
-    public TftpServerName(byte[] tftpServerName)
+    /**
+     * Creates a new instance of TftpServerName.
+     *
+     * @param tftpServerName
+     */
+    public TftpServerName( byte[] tftpServerName )
     {
         super( 66, 1 );
         this.tftpServerName = tftpServerName;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/VendorClassIdentifier.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/VendorClassIdentifier.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/VendorClassIdentifier.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/dhcp/VendorClassIdentifier.java Sat Jul 14 00:55:44 2007
@@ -49,7 +49,12 @@
     private byte[] vendorClassIdentifier;
 
 
-    public VendorClassIdentifier(byte[] vendorClassIdentifier)
+    /**
+     * Creates a new instance of VendorClassIdentifier.
+     *
+     * @param vendorClassIdentifier
+     */
+    public VendorClassIdentifier( byte[] vendorClassIdentifier )
     {
         super( 60, 1 );
         this.vendorClassIdentifier = vendorClassIdentifier;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/ArpCacheTimeout.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/ArpCacheTimeout.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/ArpCacheTimeout.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/ArpCacheTimeout.java Sat Jul 14 00:55:44 2007
@@ -40,7 +40,12 @@
     private byte[] arpCacheTimeout;
 
 
-    public ArpCacheTimeout(byte[] arpCacheTimeout)
+    /**
+     * Creates a new instance of ArpCacheTimeout.
+     *
+     * @param arpCacheTimeout
+     */
+    public ArpCacheTimeout( byte[] arpCacheTimeout )
     {
         super( 35, 4 );
         this.arpCacheTimeout = arpCacheTimeout;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/EthernetEncapsulation.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/EthernetEncapsulation.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/EthernetEncapsulation.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/EthernetEncapsulation.java Sat Jul 14 00:55:44 2007
@@ -43,7 +43,12 @@
     private byte[] ethernetEncapsulation;
 
 
-    public EthernetEncapsulation(byte[] ethernetEncapsulation)
+    /**
+     * Creates a new instance of EthernetEncapsulation.
+     *
+     * @param ethernetEncapsulation
+     */
+    public EthernetEncapsulation( byte[] ethernetEncapsulation )
     {
         super( 36, 1 );
         this.ethernetEncapsulation = ethernetEncapsulation;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/TrailerEncapsulation.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/TrailerEncapsulation.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/TrailerEncapsulation.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/linklayer/TrailerEncapsulation.java Sat Jul 14 00:55:44 2007
@@ -42,7 +42,12 @@
     private byte[] trailerEncapsulation;
 
 
-    public TrailerEncapsulation(byte[] trailerEncapsulation)
+    /**
+     * Creates a new instance of TrailerEncapsulation.
+     *
+     * @param trailerEncapsulation
+     */
+    public TrailerEncapsulation( byte[] trailerEncapsulation )
     {
         super( 34, 1 );
         this.trailerEncapsulation = trailerEncapsulation;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultFingerServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultFingerServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultFingerServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultFingerServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class DefaultFingerServers extends AddressListOption
 {
-    public DefaultFingerServers(byte[] defaultFingerServer)
+    /**
+     * Creates a new instance of DefaultFingerServers.
+     *
+     * @param defaultFingerServer
+     */
+    public DefaultFingerServers( byte[] defaultFingerServer )
     {
         super( 73, defaultFingerServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultIrcServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultIrcServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultIrcServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultIrcServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class DefaultIrcServers extends AddressListOption
 {
-    public DefaultIrcServers(byte[] defaultIrcServer)
+    /**
+     * Creates a new instance of DefaultIrcServers.
+     *
+     * @param defaultIrcServer
+     */
+    public DefaultIrcServers( byte[] defaultIrcServer )
     {
         super( 74, defaultIrcServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultWwwServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultWwwServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultWwwServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/DefaultWwwServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class DefaultWwwServers extends AddressListOption
 {
-    public DefaultWwwServers(byte[] defaultWwwServer)
+    /**
+     * Creates a new instance of DefaultWwwServers.
+     *
+     * @param defaultWwwServer
+     */
+    public DefaultWwwServers( byte[] defaultWwwServer )
     {
         super( 72, defaultWwwServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/MobileIpHomeAgents.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/MobileIpHomeAgents.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/MobileIpHomeAgents.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/MobileIpHomeAgents.java Sat Jul 14 00:55:44 2007
@@ -39,7 +39,12 @@
  */
 public class MobileIpHomeAgents extends AddressListOption
 {
-    public MobileIpHomeAgents(byte[] mobileIpHomeAgent)
+    /**
+     * Creates a new instance of MobileIpHomeAgents.
+     *
+     * @param mobileIpHomeAgent
+     */
+    public MobileIpHomeAgents( byte[] mobileIpHomeAgent )
     {
         super( 68, mobileIpHomeAgent );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NbddServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NbddServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NbddServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NbddServers.java Sat Jul 14 00:55:44 2007
@@ -35,7 +35,12 @@
  */
 public class NbddServers extends AddressListOption
 {
-    public NbddServers(byte[] netbiosDatagramDistributionServer)
+    /**
+     * Creates a new instance of NbddServers.
+     *
+     * @param netbiosDatagramDistributionServer
+     */
+    public NbddServers( byte[] netbiosDatagramDistributionServer )
     {
         super( 45, netbiosDatagramDistributionServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosNameServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosNameServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosNameServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosNameServers.java Sat Jul 14 00:55:44 2007
@@ -36,7 +36,12 @@
  */
 public class NetbiosNameServers extends AddressListOption
 {
-    public NetbiosNameServers(byte[] netbiosNameServer)
+    /**
+     * Creates a new instance of NetbiosNameServers.
+     *
+     * @param netbiosNameServer
+     */
+    public NetbiosNameServers( byte[] netbiosNameServer )
     {
         super( 44, netbiosNameServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosNodeType.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosNodeType.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosNodeType.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosNodeType.java Sat Jul 14 00:55:44 2007
@@ -53,7 +53,12 @@
     private byte[] netbiosNodeType;
 
 
-    public NetbiosNodeType(byte[] netbiosNodeType)
+    /**
+     * Creates a new instance of NetbiosNodeType.
+     *
+     * @param netbiosNodeType
+     */
+    public NetbiosNodeType( byte[] netbiosNodeType )
     {
         super( 46, 1 );
         this.netbiosNodeType = netbiosNodeType;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosScope.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosScope.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosScope.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NetbiosScope.java Sat Jul 14 00:55:44 2007
@@ -41,7 +41,12 @@
     private byte[] netbiosScope;
 
 
-    public NetbiosScope(byte[] netbiosScope)
+    /**
+     * Creates a new instance of NetbiosScope.
+     *
+     * @param netbiosScope
+     */
+    public NetbiosScope( byte[] netbiosScope )
     {
         super( 47, 1 );
         this.netbiosScope = netbiosScope;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisDomain.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisDomain.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisDomain.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisDomain.java Sat Jul 14 00:55:44 2007
@@ -41,7 +41,12 @@
     private byte[] nisDomain;
 
 
-    public NisDomain(byte[] nisDomain)
+    /**
+     * Creates a new instance of NisDomain.
+     *
+     * @param nisDomain
+     */
+    public NisDomain( byte[] nisDomain )
     {
         super( 40, 1 );
         this.nisDomain = nisDomain;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisPlusDomain.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisPlusDomain.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisPlusDomain.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisPlusDomain.java Sat Jul 14 00:55:44 2007
@@ -41,7 +41,12 @@
     private byte[] nisPlusDomain;
 
 
-    public NisPlusDomain(byte[] nisPlusDomain)
+    /**
+     * Creates a new instance of NisPlusDomain.
+     *
+     * @param nisPlusDomain
+     */
+    public NisPlusDomain( byte[] nisPlusDomain )
     {
         super( 64, 1 );
         this.nisPlusDomain = nisPlusDomain;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisPlusServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisPlusServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisPlusServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisPlusServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class NisPlusServers extends AddressListOption
 {
-    public NisPlusServers(byte[] nisPlusServers)
+    /**
+     * Creates a new instance of NisPlusServers.
+     *
+     * @param nisPlusServers
+     */
+    public NisPlusServers( byte[] nisPlusServers )
     {
         super( 65, nisPlusServers );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NisServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class NisServers extends AddressListOption
 {
-    public NisServers(byte[] nisServers)
+    /**
+     * Creates a new instance of NisServers.
+     *
+     * @param nisServers
+     */
+    public NisServers( byte[] nisServers )
     {
         super( 41, nisServers );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NntpServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NntpServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NntpServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NntpServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class NntpServers extends AddressListOption
 {
-    public NntpServers(byte[] nntpServer)
+    /**
+     * Creates a new instance of NntpServers.
+     *
+     * @param nntpServer
+     */
+    public NntpServers( byte[] nntpServer )
     {
         super( 71, nntpServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NtpServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NtpServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NtpServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/NtpServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class NtpServers extends AddressListOption
 {
-    public NtpServers(byte[] ntpServers)
+    /**
+     * Creates a new instance of NtpServers.
+     *
+     * @param ntpServers
+     */
+    public NtpServers( byte[] ntpServers )
     {
         super( 42, ntpServers );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/Pop3Servers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/Pop3Servers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/Pop3Servers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/Pop3Servers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class Pop3Servers extends AddressListOption
 {
-    public Pop3Servers(byte[] pop3Server)
+    /**
+     * Creates a new instance of Pop3Servers.
+     *
+     * @param pop3Server
+     */
+    public Pop3Servers( byte[] pop3Server )
     {
         super( 70, pop3Server );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/SmtpServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/SmtpServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/SmtpServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/SmtpServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class SmtpServers extends AddressListOption
 {
-    public SmtpServers(byte[] smtpServer)
+    /**
+     * Creates a new instance of SmtpServers.
+     *
+     * @param smtpServer
+     */
+    public SmtpServers( byte[] smtpServer )
     {
         super( 69, smtpServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/StdaServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/StdaServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/StdaServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/StdaServers.java Sat Jul 14 00:55:44 2007
@@ -38,7 +38,12 @@
  */
 public class StdaServers extends AddressListOption
 {
-    public StdaServers(byte[] stdaServer)
+    /**
+     * Creates a new instance of StdaServers.
+     *
+     * @param stdaServer
+     */
+    public StdaServers( byte[] stdaServer )
     {
         super( 76, stdaServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/StreetTalkServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/StreetTalkServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/StreetTalkServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/StreetTalkServers.java Sat Jul 14 00:55:44 2007
@@ -38,7 +38,12 @@
  */
 public class StreetTalkServers extends AddressListOption
 {
-    public StreetTalkServers(byte[] streetTalkServer)
+    /**
+     * Creates a new instance of StreetTalkServers.
+     *
+     * @param streetTalkServer
+     */
+    public StreetTalkServers( byte[] streetTalkServer )
     {
         super( 75, streetTalkServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/VendorSpecificInformation.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/VendorSpecificInformation.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/VendorSpecificInformation.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/VendorSpecificInformation.java Sat Jul 14 00:55:44 2007
@@ -68,7 +68,12 @@
     private byte[] vendorSpecificInformation;
 
 
-    public VendorSpecificInformation(byte[] vendorSpecificInformation)
+    /**
+     * Creates a new instance of VendorSpecificInformation.
+     *
+     * @param vendorSpecificInformation
+     */
+    public VendorSpecificInformation( byte[] vendorSpecificInformation )
     {
         super( 43, 1 );
         this.vendorSpecificInformation = vendorSpecificInformation;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/XWindowDisplayManagers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/XWindowDisplayManagers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/XWindowDisplayManagers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/XWindowDisplayManagers.java Sat Jul 14 00:55:44 2007
@@ -39,7 +39,12 @@
  */
 public class XWindowDisplayManagers extends AddressListOption
 {
-    public XWindowDisplayManagers(byte[] xWindowDisplayManager)
+    /**
+     * Creates a new instance of XWindowDisplayManagers.
+     *
+     * @param xWindowDisplayManager
+     */
+    public XWindowDisplayManagers( byte[] xWindowDisplayManager )
     {
         super( 49, xWindowDisplayManager );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/XWindowFontServers.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/XWindowFontServers.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/XWindowFontServers.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/misc/XWindowFontServers.java Sat Jul 14 00:55:44 2007
@@ -37,7 +37,12 @@
  */
 public class XWindowFontServers extends AddressListOption
 {
-    public XWindowFontServers(byte[] xWindowFontServer)
+    /**
+     * Creates a new instance of XWindowFontServers.
+     *
+     * @param xWindowFontServer
+     */
+    public XWindowFontServers( byte[] xWindowFontServer )
     {
         super( 48, xWindowFontServer );
     }

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/DefaultIpTimeToLive.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/DefaultIpTimeToLive.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/DefaultIpTimeToLive.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/DefaultIpTimeToLive.java Sat Jul 14 00:55:44 2007
@@ -42,7 +42,12 @@
     private byte[] defaultIpTimeToLive;
 
 
-    public DefaultIpTimeToLive(byte[] defaultIpTimeToLive)
+    /**
+     * Creates a new instance of DefaultIpTimeToLive.
+     *
+     * @param defaultIpTimeToLive
+     */
+    public DefaultIpTimeToLive( byte[] defaultIpTimeToLive )
     {
         super( 23, 1 );
         this.defaultIpTimeToLive = defaultIpTimeToLive;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/IpForwarding.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/IpForwarding.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/IpForwarding.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/IpForwarding.java Sat Jul 14 00:55:44 2007
@@ -42,7 +42,12 @@
     private byte[] ipForwarding;
 
 
-    public IpForwarding(byte[] ipForwarding)
+    /**
+     * Creates a new instance of IpForwarding.
+     *
+     * @param ipForwarding
+     */
+    public IpForwarding( byte[] ipForwarding )
     {
         super( 19, 1 );
         this.ipForwarding = ipForwarding;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/MaximumDatagramSize.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/MaximumDatagramSize.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/MaximumDatagramSize.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/MaximumDatagramSize.java Sat Jul 14 00:55:44 2007
@@ -42,7 +42,12 @@
     private byte[] maximumDatagramSize;
 
 
-    public MaximumDatagramSize(byte[] maximumDatagramSize)
+    /**
+     * Creates a new instance of MaximumDatagramSize.
+     *
+     * @param maximumDatagramSize
+     */
+    public MaximumDatagramSize( byte[] maximumDatagramSize )
     {
         super( 22, 2 );
         this.maximumDatagramSize = maximumDatagramSize;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/NonLocalSourceRouting.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/NonLocalSourceRouting.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/NonLocalSourceRouting.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/NonLocalSourceRouting.java Sat Jul 14 00:55:44 2007
@@ -43,7 +43,12 @@
     private byte[] nonLocalSourceRouting;
 
 
-    public NonLocalSourceRouting(byte[] nonLocalSourceRouting)
+    /**
+     * Creates a new instance of NonLocalSourceRouting.
+     *
+     * @param nonLocalSourceRouting
+     */
+    public NonLocalSourceRouting( byte[] nonLocalSourceRouting )
     {
         super( 20, 1 );
         this.nonLocalSourceRouting = nonLocalSourceRouting;

Modified: directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/PathMtuAgingTimeout.java
URL: http://svn.apache.org/viewvc/directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/PathMtuAgingTimeout.java?view=diff&rev=556238&r1=556237&r2=556238
==============================================================================
--- directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/PathMtuAgingTimeout.java (original)
+++ directory/sandbox/ccustine/new_installers/apacheds/protocol-dhcp/src/main/java/org/apache/directory/server/dhcp/options/perhost/PathMtuAgingTimeout.java Sat Jul 14 00:55:44 2007
@@ -42,7 +42,12 @@
     private byte[] pathMtuAgingTimeout;
 
 
-    public PathMtuAgingTimeout(byte[] pathMtuAgingTimeout)
+    /**
+     * Creates a new instance of PathMtuAgingTimeout.
+     *
+     * @param pathMtuAgingTimeout
+     */
+    public PathMtuAgingTimeout( byte[] pathMtuAgingTimeout )
     {
         super( 24, 4 );
         this.pathMtuAgingTimeout = pathMtuAgingTimeout;



Mime
View raw message