Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 70988 invoked from network); 7 Jun 2007 03:33:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Jun 2007 03:33:09 -0000 Received: (qmail 83953 invoked by uid 500); 7 Jun 2007 03:33:13 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 83926 invoked by uid 500); 7 Jun 2007 03:33:13 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 83908 invoked by uid 99); 7 Jun 2007 03:33:13 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2007 20:33:13 -0700 X-ASF-Spam-Status: No, hits=-99.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2007 20:33:09 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id E54131A981D; Wed, 6 Jun 2007 20:32:48 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r545044 - in /directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol: NtpDecoder.java NtpEncoder.java NtpProtocolCodecFactory.java Date: Thu, 07 Jun 2007 03:32:48 -0000 To: commits@directory.apache.org From: erodriguez@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070607033248.E54131A981D@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: erodriguez Date: Wed Jun 6 20:32:48 2007 New Revision: 545044 URL: http://svn.apache.org/viewvc?view=rev&rev=545044 Log: Warnings clean-up in protocol-ntp. Modified: directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpDecoder.java directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpEncoder.java directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpProtocolCodecFactory.java Modified: directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpDecoder.java URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpDecoder.java?view=diff&rev=545044&r1=545043&r2=545044 ============================================================================== --- directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpDecoder.java (original) +++ directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpDecoder.java Wed Jun 6 20:32:48 2007 @@ -24,7 +24,7 @@ import org.apache.directory.server.ntp.io.NtpMessageDecoder; import org.apache.mina.common.ByteBuffer; import org.apache.mina.common.IoSession; -import org.apache.mina.filter.codec.ProtocolDecoder; +import org.apache.mina.filter.codec.ProtocolDecoderAdapter; import org.apache.mina.filter.codec.ProtocolDecoderOutput; @@ -32,22 +32,11 @@ * @author Apache Directory Project * @version $Rev$, $Date$ */ -public class NtpDecoder implements ProtocolDecoder +public class NtpDecoder extends ProtocolDecoderAdapter { public void decode( IoSession session, ByteBuffer in, ProtocolDecoderOutput out ) { NtpMessageDecoder decoder = new NtpMessageDecoder(); out.write( decoder.decode( in.buf() ) ); - } - - - public void dispose( IoSession arg0 ) throws Exception - { - } - - - public void finishDecode( IoSession session, ProtocolDecoderOutput out ) throws Exception - { - // TODO Auto-generated method stub } } Modified: directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpEncoder.java URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpEncoder.java?view=diff&rev=545044&r1=545043&r2=545044 ============================================================================== --- directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpEncoder.java (original) +++ directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpEncoder.java Wed Jun 6 20:32:48 2007 @@ -25,7 +25,7 @@ import org.apache.directory.server.ntp.messages.NtpMessage; import org.apache.mina.common.ByteBuffer; import org.apache.mina.common.IoSession; -import org.apache.mina.filter.codec.ProtocolEncoder; +import org.apache.mina.filter.codec.ProtocolEncoderAdapter; import org.apache.mina.filter.codec.ProtocolEncoderOutput; @@ -33,7 +33,7 @@ * @author Apache Directory Project * @version $Rev$, $Date$ */ -public class NtpEncoder implements ProtocolEncoder +public class NtpEncoder extends ProtocolEncoderAdapter { public void encode( IoSession session, Object message, ProtocolEncoderOutput out ) { @@ -45,10 +45,5 @@ buf.flip(); out.write( buf ); - } - - - public void dispose( IoSession arg0 ) throws Exception - { } } Modified: directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpProtocolCodecFactory.java URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpProtocolCodecFactory.java?view=diff&rev=545044&r1=545043&r2=545044 ============================================================================== --- directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpProtocolCodecFactory.java (original) +++ directory/apacheds/trunk/protocol-ntp/src/main/java/org/apache/directory/server/ntp/protocol/NtpProtocolCodecFactory.java Wed Jun 6 20:32:48 2007 @@ -35,6 +35,11 @@ private static final NtpProtocolCodecFactory INSTANCE = new NtpProtocolCodecFactory(); + /** + * Returns the singleton instance of {@link NtpProtocolCodecFactory}. + * + * @return The singleton instance of {@link NtpProtocolCodecFactory}. + */ public static NtpProtocolCodecFactory getInstance() { return INSTANCE; @@ -43,6 +48,7 @@ private NtpProtocolCodecFactory() { + // Private constructor prevents instantiation outside this class. }