directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erodrig...@apache.org
Subject svn commit: r547132 - in /directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns: io/decoder/ messages/ service/ store/
Date Thu, 14 Jun 2007 05:43:04 GMT
Author: erodriguez
Date: Wed Jun 13 22:43:03 2007
New Revision: 547132

URL: http://svn.apache.org/viewvc?view=rev&rev=547132
Log:
Warnings clean-up in protocol-dns, mostly Javadocs and generics.

Modified:
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/io/decoder/NameServerRecordDecoder.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/DnsMessage.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecord.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecordImpl.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/BuildReply.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/DomainNameServiceChain.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/GetResourceRecords.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorContext.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorReply.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/DnsCatalog.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/JndiRecordStoreImpl.java

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/io/decoder/NameServerRecordDecoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/io/decoder/NameServerRecordDecoder.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/io/decoder/NameServerRecordDecoder.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/io/decoder/NameServerRecordDecoder.java
Wed Jun 13 22:43:03 2007
@@ -55,9 +55,8 @@
 
     public Map decode( ByteBuffer byteBuffer, short length ) throws IOException
     {
-        Map map = new HashMap();
+        Map<String, String> map = new HashMap<String, String>();
         map.put( DnsAttribute.DOMAIN_NAME, DnsMessageDecoder.getDomainName( byteBuffer )
);
         return map;
     }
-
 }

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/DnsMessage.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/DnsMessage.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/DnsMessage.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/DnsMessage.java
Wed Jun 13 22:43:03 2007
@@ -74,6 +74,24 @@
     private List<ResourceRecord> additionalRecords;
 
 
+    /**
+     * Creates a new instance of DnsMessage.
+     *
+     * @param transactionId
+     * @param messageType
+     * @param opCode
+     * @param authoritativeAnswer
+     * @param truncated
+     * @param recursionDesired
+     * @param recursionAvailable
+     * @param reserved
+     * @param acceptNonAuthenticatedData
+     * @param responseCode
+     * @param question
+     * @param answer
+     * @param authority
+     * @param additional
+     */
     public DnsMessage( int transactionId, MessageType messageType, OpCode opCode, boolean
authoritativeAnswer,
         boolean truncated, boolean recursionDesired, boolean recursionAvailable, boolean
reserved,
         boolean acceptNonAuthenticatedData, ResponseCode responseCode, List<QuestionRecord>
question,

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecord.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecord.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecord.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecord.java
Wed Jun 13 22:43:03 2007
@@ -52,6 +52,7 @@
 
 
     /**
+     * @param id 
      * @return Returns the value for an id.
      */
     public String get( String id );

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecordImpl.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecordImpl.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecordImpl.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/messages/ResourceRecordImpl.java
Wed Jun 13 22:43:03 2007
@@ -92,6 +92,15 @@
     private Map attributes;
 
 
+    /**
+     * Creates a new instance of ResourceRecordImpl.
+     *
+     * @param domainName
+     * @param recordType
+     * @param recordClass
+     * @param timeToLive
+     * @param attributes
+     */
     public ResourceRecordImpl( String domainName, RecordType recordType, RecordClass recordClass,
int timeToLive,
         Map attributes )
     {

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/BuildReply.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/BuildReply.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/BuildReply.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/BuildReply.java
Wed Jun 13 22:43:03 2007
@@ -72,7 +72,7 @@
     }
 
 
-    public String getContextKey()
+    protected String getContextKey()
     {
         return ( this.contextKey );
     }

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/DomainNameServiceChain.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/DomainNameServiceChain.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/DomainNameServiceChain.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/DomainNameServiceChain.java
Wed Jun 13 22:43:03 2007
@@ -37,6 +37,9 @@
     private static final Logger log = LoggerFactory.getLogger( DomainNameServiceChain.class
);
 
 
+    /**
+     * Creates a new instance of DomainNameServiceChain.
+     */
     public DomainNameServiceChain()
     {
         if ( log.isDebugEnabled() )

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/GetResourceRecords.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/GetResourceRecords.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/GetResourceRecords.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/GetResourceRecords.java
Wed Jun 13 22:43:03 2007
@@ -27,6 +27,7 @@
 import org.apache.directory.server.dns.DnsException;
 import org.apache.directory.server.dns.messages.DnsMessage;
 import org.apache.directory.server.dns.messages.QuestionRecord;
+import org.apache.directory.server.dns.messages.ResourceRecord;
 import org.apache.directory.server.dns.messages.ResponseCode;
 import org.apache.directory.server.dns.store.RecordStore;
 import org.apache.directory.shared.ldap.exception.LdapNameNotFoundException;
@@ -67,9 +68,17 @@
     }
 
 
-    public Set getEntry( RecordStore store, QuestionRecord question ) throws Exception
+    /**
+     * Returns a set of {@link ResourceRecord}s from a {@link RecordStore}, given a DNS {@link
QuestionRecord}.
+     *
+     * @param store
+     * @param question
+     * @return The set of {@link ResourceRecord}s.
+     * @throws Exception
+     */
+    public Set<ResourceRecord> getEntry( RecordStore store, QuestionRecord question
) throws Exception
     {
-        Set records = null;
+        Set<ResourceRecord> records = null;
 
         try
         {
@@ -99,7 +108,7 @@
     }
 
 
-    public String getContextKey()
+    protected String getContextKey()
     {
         return ( this.contextKey );
     }

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorContext.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorContext.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorContext.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorContext.java
Wed Jun 13 22:43:03 2007
@@ -70,7 +70,7 @@
     }
 
 
-    public String getContextKey()
+    protected String getContextKey()
     {
         return ( this.contextKey );
     }

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorReply.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorReply.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorReply.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/service/MonitorReply.java
Wed Jun 13 22:43:03 2007
@@ -58,7 +58,7 @@
         next.execute( session, message );
     }
 
-    public String getContextKey()
+    protected String getContextKey()
     {
         return ( this.contextKey );
     }

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/DnsCatalog.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/DnsCatalog.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/DnsCatalog.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/DnsCatalog.java
Wed Jun 13 22:43:03 2007
@@ -37,7 +37,12 @@
     private Map map;
 
 
-    public DnsCatalog(Map map)
+    /**
+     * Creates a new instance of DnsCatalog.
+     *
+     * @param map
+     */
+    public DnsCatalog( Map map )
     {
         this.map = map;
     }

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/JndiRecordStoreImpl.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/JndiRecordStoreImpl.java?view=diff&rev=547132&r1=547131&r2=547132
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/JndiRecordStoreImpl.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/store/JndiRecordStoreImpl.java
Wed Jun 13 22:43:03 2007
@@ -46,7 +46,13 @@
     private SearchStrategy strategy;
 
 
-    public JndiRecordStoreImpl(DnsConfiguration config, InitialContextFactory factory)
+    /**
+     * Creates a new instance of JndiRecordStoreImpl.
+     *
+     * @param config
+     * @param factory
+     */
+    public JndiRecordStoreImpl( DnsConfiguration config, InitialContextFactory factory )
     {
         this.config = config;
         this.factory = factory;



Mime
View raw message