directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erodrig...@apache.org
Subject svn commit: r545041 - in /directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol: DnsDecoder.java DnsEncoder.java DnsProtocolCodecFactory.java DnsProtocolHandler.java
Date Thu, 07 Jun 2007 03:31:35 GMT
Author: erodriguez
Date: Wed Jun  6 20:31:34 2007
New Revision: 545041

URL: http://svn.apache.org/viewvc?view=rev&rev=545041
Log:
Warnings clean-up in protocol-dns.

Modified:
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsDecoder.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsEncoder.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolCodecFactory.java
    directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolHandler.java

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsDecoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsDecoder.java?view=diff&rev=545041&r1=545040&r2=545041
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsDecoder.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsDecoder.java
Wed Jun  6 20:31:34 2007
@@ -26,7 +26,7 @@
 import org.apache.directory.server.dns.io.decoder.DnsMessageDecoder;
 import org.apache.mina.common.ByteBuffer;
 import org.apache.mina.common.IoSession;
-import org.apache.mina.filter.codec.ProtocolDecoder;
+import org.apache.mina.filter.codec.ProtocolDecoderAdapter;
 import org.apache.mina.filter.codec.ProtocolDecoderOutput;
 
 
@@ -37,7 +37,7 @@
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
  */
-public class DnsDecoder implements ProtocolDecoder
+public class DnsDecoder extends ProtocolDecoderAdapter
 {
     private DnsMessageDecoder decoder = new DnsMessageDecoder();
 
@@ -45,15 +45,5 @@
     public void decode( IoSession session, ByteBuffer in, ProtocolDecoderOutput out ) throws
IOException
     {
         out.write( decoder.decode( in ) );
-    }
-
-
-    public void dispose( IoSession arg0 ) throws Exception
-    {
-    }
-
-
-    public void finishDecode( IoSession session, ProtocolDecoderOutput out ) throws Exception
-    {
     }
 }

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsEncoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsEncoder.java?view=diff&rev=545041&r1=545040&r2=545041
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsEncoder.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsEncoder.java
Wed Jun  6 20:31:34 2007
@@ -25,7 +25,7 @@
 import org.apache.directory.server.dns.messages.DnsMessage;
 import org.apache.mina.common.ByteBuffer;
 import org.apache.mina.common.IoSession;
-import org.apache.mina.filter.codec.ProtocolEncoder;
+import org.apache.mina.filter.codec.ProtocolEncoderAdapter;
 import org.apache.mina.filter.codec.ProtocolEncoderOutput;
 
 
@@ -36,7 +36,7 @@
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
  */
-public class DnsEncoder implements ProtocolEncoder
+public class DnsEncoder extends ProtocolEncoderAdapter
 {
     private DnsMessageEncoder encoder = new DnsMessageEncoder();
 
@@ -49,10 +49,5 @@
         buf.flip();
 
         out.write( buf );
-    }
-
-
-    public void dispose( IoSession arg0 ) throws Exception
-    {
     }
 }

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolCodecFactory.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolCodecFactory.java?view=diff&rev=545041&r1=545040&r2=545041
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolCodecFactory.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolCodecFactory.java
Wed Jun  6 20:31:34 2007
@@ -35,6 +35,11 @@
     private static final DnsProtocolCodecFactory INSTANCE = new DnsProtocolCodecFactory();
 
 
+    /**
+     * Returns the singleton instance of {@link DnsProtocolCodecFactory}.
+     *
+     * @return The singleton instance of {@link DnsProtocolCodecFactory}.
+     */
     public static DnsProtocolCodecFactory getInstance()
     {
         return INSTANCE;
@@ -43,6 +48,7 @@
 
     private DnsProtocolCodecFactory()
     {
+        // Private constructor prevents instantiation outside this class.
     }
 
 

Modified: directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolHandler.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolHandler.java?view=diff&rev=545041&r1=545040&r2=545041
==============================================================================
--- directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolHandler.java
(original)
+++ directory/apacheds/trunk/protocol-dns/src/main/java/org/apache/directory/server/dns/protocol/DnsProtocolHandler.java
Wed Jun  6 20:31:34 2007
@@ -57,6 +57,12 @@
     private String contextKey = "context";
 
 
+    /**
+     * Creates a new instance of DnsProtocolHandler.
+     *
+     * @param config
+     * @param store
+     */
     public DnsProtocolHandler( DnsConfiguration config, RecordStore store )
     {
         this.config = config;
@@ -151,7 +157,7 @@
     }
 
 
-    public String getContextKey()
+    protected String getContextKey()
     {
         return ( this.contextKey );
     }



Mime
View raw message