directory-commits mailing list archives

Author: erodriguez
Date: Fri Jun  1 20:12:11 2007
New Revision: 543699

URL: http://svn.apache.org/viewvc?view=rev&rev=543699
Log:
Enhancements to changepw-protocol:
o  Removed some empty methods by using MINA codec adapters.
o  Warnings clean-up.

Modified:
    directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordDecoder.java
    directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordEncoder.java
    directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java

Modified: directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordDecoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordDecoder.java?view=diff&rev=543699&r1=543698&r2=543699
==============================================================================
--- directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordDecoder.java
(original)
+++ directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordDecoder.java
Fri Jun  1 20:12:11 2007
@@ -26,7 +26,7 @@
 import org.apache.directory.server.changepw.io.ChangePasswordRequestDecoder;
 import org.apache.mina.common.ByteBuffer;
 import org.apache.mina.common.IoSession;
-import org.apache.mina.filter.codec.ProtocolDecoder;
+import org.apache.mina.filter.codec.ProtocolDecoderAdapter;
 import org.apache.mina.filter.codec.ProtocolDecoderOutput;
 
 
@@ -34,22 +34,11 @@
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
  */
-public class ChangePasswordDecoder implements ProtocolDecoder
+public class ChangePasswordDecoder extends ProtocolDecoderAdapter
 {
     public void decode( IoSession session, ByteBuffer in, ProtocolDecoderOutput out ) throws
IOException
     {
         ChangePasswordRequestDecoder decoder = new ChangePasswordRequestDecoder();
         out.write( decoder.decode( in.buf() ) );
-    }
-
-
-    public void dispose( IoSession session ) throws Exception
-    {
-    }
-
-
-    public void finishDecode( IoSession session, ProtocolDecoderOutput out ) throws Exception
-    {
-        // TODO Auto-generated method stub
     }
 }

Modified: directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordEncoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordEncoder.java?view=diff&rev=543699&r1=543698&r2=543699
==============================================================================
--- directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordEncoder.java
(original)
+++ directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordEncoder.java
Fri Jun  1 20:12:11 2007
@@ -29,7 +29,7 @@
 import org.apache.directory.server.changepw.messages.ChangePasswordReply;
 import org.apache.mina.common.ByteBuffer;
 import org.apache.mina.common.IoSession;
-import org.apache.mina.filter.codec.ProtocolEncoder;
+import org.apache.mina.filter.codec.ProtocolEncoderAdapter;
 import org.apache.mina.filter.codec.ProtocolEncoderOutput;
 
 
@@ -37,7 +37,7 @@
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
  */
-public class ChangePasswordEncoder implements ProtocolEncoder
+public class ChangePasswordEncoder extends ProtocolEncoderAdapter
 {
     public void encode( IoSession session, Object message, ProtocolEncoderOutput out ) throws
IOException
     {
@@ -74,10 +74,5 @@
         ChangePasswordErrorEncoder encoder = new ChangePasswordErrorEncoder();
 
         encoder.encode( buf.buf(), error );
-    }
-
-
-    public void dispose( IoSession arg0 ) throws Exception
-    {
     }
 }

Modified: directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java?view=diff&rev=543699&r1=543698&r2=543699
==============================================================================
--- directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java
(original)
+++ directory/apacheds/trunk/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java
Fri Jun  1 20:12:11 2007
@@ -48,6 +48,7 @@
 
     private ChangePasswordProtocolCodecFactory()
     {
+        // Private constructor prevents instantiation outside this class.
     }