Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 82722 invoked from network); 11 May 2007 03:07:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 May 2007 03:07:40 -0000 Received: (qmail 28363 invoked by uid 500); 11 May 2007 03:07:46 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 28329 invoked by uid 500); 11 May 2007 03:07:46 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 28317 invoked by uid 99); 11 May 2007 03:07:46 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 May 2007 20:07:46 -0700 X-ASF-Spam-Status: No, hits=-99.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 May 2007 20:07:39 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 4E49E1A9838; Thu, 10 May 2007 20:07:19 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r537072 - in /directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service: GetPrincipalStoreEntry.java VerifyAuthHeader.java VerifyTicket.java Date: Fri, 11 May 2007 03:07:19 -0000 To: commits@directory.apache.org From: erodriguez@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070511030719.4E49E1A9838@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: erodriguez Date: Thu May 10 20:07:18 2007 New Revision: 537072 URL: http://svn.apache.org/viewvc?view=rev&rev=537072 Log: Minor warning clean-up, some javadocs. Modified: directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/GetPrincipalStoreEntry.java directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyAuthHeader.java directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyTicket.java Modified: directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/GetPrincipalStoreEntry.java URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/GetPrincipalStoreEntry.java?view=diff&rev=537072&r1=537071&r2=537072 ============================================================================== --- directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/GetPrincipalStoreEntry.java (original) +++ directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/GetPrincipalStoreEntry.java Thu May 10 20:07:18 2007 @@ -38,6 +38,16 @@ private String contextKey = "context"; + /** + * Get a PrincipalStoreEntry given a principal. The ErrorType is used to indicate + * whether any resulting error pertains to a server or client. + * + * @param principal + * @param store + * @param errorType + * @return The PrincipalStoreEntry + * @throws Exception + */ public PrincipalStoreEntry getEntry( KerberosPrincipal principal, PrincipalStore store, ErrorType errorType ) throws Exception { @@ -61,7 +71,7 @@ } - public String getContextKey() + protected String getContextKey() { return ( this.contextKey ); } Modified: directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyAuthHeader.java URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyAuthHeader.java?view=diff&rev=537072&r1=537071&r2=537072 ============================================================================== --- directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyAuthHeader.java (original) +++ directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyAuthHeader.java Thu May 10 20:07:18 2007 @@ -51,7 +51,20 @@ private String contextKey = "context"; - // RFC 1510 A.10. KRB_AP_REQ verification + /** + * Verifies an AuthHeader using guidelines from RFC 1510 section A.10., "KRB_AP_REQ verification." + * + * @param authHeader + * @param ticket + * @param serverKey + * @param clockSkew + * @param replayCache + * @param emptyAddressesAllowed + * @param clientAddress + * @param lockBox + * @return The authenticator. + * @throws KerberosException + */ public Authenticator verifyAuthHeader( ApplicationRequest authHeader, Ticket ticket, EncryptionKey serverKey, long clockSkew, ReplayCache replayCache, boolean emptyAddressesAllowed, InetAddress clientAddress, CipherTextHandler lockBox ) throws KerberosException @@ -151,7 +164,7 @@ } - public String getContextKey() + protected String getContextKey() { return ( this.contextKey ); } Modified: directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyTicket.java URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyTicket.java?view=diff&rev=537072&r1=537071&r2=537072 ============================================================================== --- directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyTicket.java (original) +++ directory/apacheds/branches/kerberos-encryption-types/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared/service/VerifyTicket.java Thu May 10 20:07:18 2007 @@ -38,6 +38,15 @@ { private String contextKey = "context"; + + /** + * Verifies a Ticket given a realm and the server principal. + * + * @param ticket + * @param primaryRealm + * @param serverPrincipal + * @throws Exception + */ public void verifyTicket( Ticket ticket, String primaryRealm, KerberosPrincipal serverPrincipal ) throws Exception { if ( !ticket.getRealm().equals( primaryRealm ) && !ticket.getServerPrincipal().equals( serverPrincipal ) ) @@ -47,7 +56,7 @@ } - public String getContextKey() + protected String getContextKey() { return ( this.contextKey ); }