directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erodrig...@apache.org
Subject svn commit: r539677 - in /directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src: main/java/org/apache/directory/server/changepw/ main/java/org/apache/directory/server/changepw/exceptions/ main/java/org/apache/directory/server/chan...
Date Sat, 19 May 2007 02:34:30 GMT
Author: erodriguez
Date: Fri May 18 19:34:29 2007
New Revision: 539677

URL: http://svn.apache.org/viewvc?view=rev&rev=539677
Log:
Javadocs and minor warning clean-up.

Modified:
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/exceptions/ErrorType.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordDataDecoder.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorEncoder.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordReplyEncoder.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordRequestDecoder.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessage.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessageModifier.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordError.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordErrorModifier.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReply.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReplyModifier.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequest.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequestModifier.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordData.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordDataModifier.java
    directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/test/java/org/apache/directory/server/changepw/service/CheckPasswordPolicyTest.java

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/ChangePasswordServer.java
Fri May 18 19:34:29 2007
@@ -52,8 +52,17 @@
 
     private IoHandler handler;
 
-    public ChangePasswordServer(ChangePasswordConfiguration config, IoAcceptor acceptor,
IoServiceConfig serviceConfig, 
-        PrincipalStore store)
+
+    /**
+     * Creates a new instance of ChangePasswordServer.
+     *
+     * @param config
+     * @param acceptor
+     * @param serviceConfig
+     * @param store
+     */
+    public ChangePasswordServer( ChangePasswordConfiguration config, IoAcceptor acceptor,
+        IoServiceConfig serviceConfig, PrincipalStore store )
     {
         this.config = config;
         this.acceptor = acceptor;
@@ -77,12 +86,21 @@
     }
 
 
+    /**
+     * Returns whether configuration being proposed as new is really different.
+     *
+     * @param newConfig
+     * @return Whether configuration being proposed as new is really different.
+     */
     public boolean isDifferent( Dictionary newConfig )
     {
         return config.isDifferent( newConfig );
     }
 
 
+    /**
+     * Destroys this instance of {@link ChangePasswordServer}.
+     */
     public void destroy()
     {
         acceptor.unbind( new InetSocketAddress( config.getPort() ) );

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/exceptions/ErrorType.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/exceptions/ErrorType.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/exceptions/ErrorType.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/exceptions/ErrorType.java
Fri May 18 19:34:29 2007
@@ -34,43 +34,78 @@
  */
 public final class ErrorType implements Comparable
 {
-    /*
-     * Enumeration elements are constructed once upon class loading.
-     * Order of appearance here determines the order of compareTo.
+    /**
+     * Constant for the "Request failed due to being malformed" error type.
      */
     public static final ErrorType KRB5_KPASSWD_MALFORMED = new ErrorType( 1, "Request failed
due to being malformed." );
+
+    /**
+     * Constant for the "Request failed due to a hard error in processing the request" error
type.
+     */
     public static final ErrorType KRB5_KPASSWD_HARDERROR = new ErrorType( 2,
         "Request failed due to a hard error in processing the request." );
+
+    /**
+     * Constant for the "Request failed due to an error in authentication processing" error
type.
+     */
     public static final ErrorType KRB5_KPASSWD_AUTHERROR = new ErrorType( 3,
         "Request failed due to an error in authentication processing." );
+
+    /**
+     * Constant for the "Request failed due to a soft error in processing the request" error
type.
+     */
     public static final ErrorType KRB5_KPASSWD_SOFTERROR = new ErrorType( 4,
         "Request failed due to a soft error in processing the request." );
+
+    /**
+     * Constant for the "Requestor not authorized" error type.
+     */
     public static final ErrorType KRB5_KPASSWD_ACCESSDENIED = new ErrorType( 5, "Requestor
not authorized." );
+
+    /**
+     * Constant for the "Protocol version unsupported" error type.
+     */
     public static final ErrorType KRB5_KPASSWD_BAD_VERSION = new ErrorType( 6, "Protocol
version unsupported." );
+
+    /**
+     * Constant for the "Initial flag required" error type.
+     */
     public static final ErrorType KRB5_KPASSWD_INITIAL_FLAG_NEEDED = new ErrorType( 7, "Initial
flag required." );
+
+    /**
+     * Constant for the "Request failed for an unknown reason" error type.
+     */
     public static final ErrorType KRB5_KPASSWD_UNKNOWN_ERROR = new ErrorType( 8,
         "Request failed for an unknown reason." );
 
-    /** Array for building a List of VALUES. */
+    /**
+     * Array for building a List of VALUES.
+     */
     private static final ErrorType[] values =
         { KRB5_KPASSWD_MALFORMED, KRB5_KPASSWD_HARDERROR, KRB5_KPASSWD_AUTHERROR, KRB5_KPASSWD_SOFTERROR,
             KRB5_KPASSWD_ACCESSDENIED, KRB5_KPASSWD_BAD_VERSION, KRB5_KPASSWD_INITIAL_FLAG_NEEDED,
             KRB5_KPASSWD_UNKNOWN_ERROR };
 
-    /** a list of all the error type constants */
+    /**
+     * A list of all the error type constants.
+     */
     public static final List VALUES = Collections.unmodifiableList( Arrays.asList( values
) );
 
-    /** the name of the error type */
+    /**
+     * The name of the error type.
+     */
     private final String name;
 
-    /** the value/code for the error type */
+    /**
+     * The value/code for the error type.
+     */
     private final int ordinal;
 
 
     /**
      * Private constructor prevents construction outside of this class.
      */
-    private ErrorType(int ordinal, String name)
+    private ErrorType( int ordinal, String name )
     {
         this.ordinal = ordinal;
         this.name = name;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordDataDecoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordDataDecoder.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordDataDecoder.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordDataDecoder.java
Fri May 18 19:34:29 2007
@@ -41,6 +41,13 @@
  */
 public class ChangePasswordDataDecoder
 {
+    /**
+     * Decodes bytes into a ChangePasswordData.
+     *
+     * @param encodedChangePasswdData
+     * @return The {@link ChangePasswordData}.
+     * @throws IOException
+     */
     public ChangePasswordData decodeChangePasswordData( byte[] encodedChangePasswdData )
throws IOException
     {
         ASN1InputStream ais = new ASN1InputStream( encodedChangePasswdData );

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorEncoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorEncoder.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorEncoder.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordErrorEncoder.java
Fri May 18 19:34:29 2007
@@ -35,6 +35,13 @@
  */
 public class ChangePasswordErrorEncoder
 {
+    /**
+     * Encodes a {@link ChangePasswordError} into a {@link ByteBuffer}.
+     *
+     * @param buf
+     * @param message
+     * @throws IOException
+     */
     public void encode( ByteBuffer buf, ChangePasswordError message ) throws IOException
     {
         // Build error message bytes

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordReplyEncoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordReplyEncoder.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordReplyEncoder.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordReplyEncoder.java
Fri May 18 19:34:29 2007
@@ -37,6 +37,13 @@
  */
 public class ChangePasswordReplyEncoder
 {
+    /**
+     * Encodes a {@link ChangePasswordReply} into a {@link ByteBuffer}.
+     *
+     * @param buf
+     * @param message
+     * @throws IOException
+     */
     public void encode( ByteBuffer buf, ChangePasswordReply message ) throws IOException
     {
         // Build application reply bytes

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordRequestDecoder.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordRequestDecoder.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordRequestDecoder.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/io/ChangePasswordRequestDecoder.java
Fri May 18 19:34:29 2007
@@ -37,6 +37,13 @@
  */
 public class ChangePasswordRequestDecoder
 {
+    /**
+     * Decodes a {@link ByteBuffer} into a {@link ChangePasswordRequest}.
+     *
+     * @param buf
+     * @return The {@link ChangePasswordRequest}.
+     * @throws IOException
+     */
     public ChangePasswordRequest decode( ByteBuffer buf ) throws IOException
     {
         ChangePasswordRequestModifier modifier = new ChangePasswordRequestModifier();

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessage.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessage.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessage.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessage.java
Fri May 18 19:34:29 2007
@@ -26,7 +26,9 @@
  */
 abstract public class AbstractPasswordMessage
 {
-    // ChangePassword protocol version number
+    /**
+     * ChangePassword protocol version number.
+     */
     public static final int PVNO = 1;
 
     private short messageLength;
@@ -34,7 +36,7 @@
     private short authHeaderLength;
 
 
-    protected AbstractPasswordMessage(short messageLength, short versionNumber, short authHeaderLength)
+    protected AbstractPasswordMessage( short messageLength, short versionNumber, short authHeaderLength
)
     {
         this.messageLength = messageLength;
         this.versionNumber = versionNumber;
@@ -42,18 +44,33 @@
     }
 
 
+    /**
+     * Returns the message length.
+     *
+     * @return The message length.
+     */
     public short getMessageLength()
     {
         return messageLength;
     }
 
 
+    /**
+     * Returns the version number.
+     *
+     * @return The version number.
+     */
     public short getVersionNumber()
     {
         return versionNumber;
     }
 
 
+    /**
+     * Returns the length of the AuthHeader.
+     *
+     * @return The length of the AuthHeader.
+     */
     public short getAuthHeaderLength()
     {
         return authHeaderLength;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessageModifier.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessageModifier.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessageModifier.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/AbstractPasswordMessageModifier.java
Fri May 18 19:34:29 2007
@@ -31,18 +31,33 @@
     protected short authHeaderLength;
 
 
+    /**
+     * Sets the message length.
+     *
+     * @param messageLength
+     */
     public void setMessageLength( short messageLength )
     {
         this.messageLength = messageLength;
     }
 
 
+    /**
+     * Sets the protocol version number.
+     *
+     * @param versionNumber
+     */
     public void setProtocolVersionNumber( short versionNumber )
     {
         this.versionNumber = versionNumber;
     }
 
 
+    /**
+     * Sets the AuthHeader length.
+     *
+     * @param authHeaderLength
+     */
     public void setAuthHeaderLength( short authHeaderLength )
     {
         this.authHeaderLength = authHeaderLength;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordError.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordError.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordError.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordError.java
Fri May 18 19:34:29 2007
@@ -32,8 +32,16 @@
     private ErrorMessage errorMessage;
 
 
-    public ChangePasswordError(short messageLength, short versionNumber, short authHeaderLength,
-        ErrorMessage errorMessage)
+    /**
+     * Creates a new instance of ChangePasswordError.
+     *
+     * @param messageLength
+     * @param versionNumber
+     * @param authHeaderLength
+     * @param errorMessage
+     */
+    public ChangePasswordError( short messageLength, short versionNumber, short authHeaderLength,
+        ErrorMessage errorMessage )
     {
         super( messageLength, versionNumber, authHeaderLength );
 
@@ -41,6 +49,11 @@
     }
 
 
+    /**
+     * Returns the {@link ErrorMessage}.
+     *
+     * @return The {@link ErrorMessage}.
+     */
     public ErrorMessage getErrorMessage()
     {
         return errorMessage;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordErrorModifier.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordErrorModifier.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordErrorModifier.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordErrorModifier.java
Fri May 18 19:34:29 2007
@@ -32,12 +32,22 @@
     private ErrorMessage errorMessage;
 
 
+    /**
+     * Returns the {@link ChangePasswordError}.
+     *
+     * @return The {@link ChangePasswordError}.
+     */
     public ChangePasswordError getChangePasswordError()
     {
         return new ChangePasswordError( messageLength, versionNumber, authHeaderLength, errorMessage
);
     }
 
 
+    /**
+     * Sets the {@link ErrorMessage}.
+     *
+     * @param errorMessage
+     */
     public void setErrorMessage( ErrorMessage errorMessage )
     {
         this.errorMessage = errorMessage;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReply.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReply.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReply.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReply.java
Fri May 18 19:34:29 2007
@@ -34,8 +34,17 @@
     private PrivateMessage privateMessage;
 
 
-    public ChangePasswordReply(short messageLength, short versionNumber, short authHeaderLength,
-        ApplicationReply applicationReply, PrivateMessage privateMessage)
+    /**
+     * Creates a new instance of ChangePasswordReply.
+     *
+     * @param messageLength
+     * @param versionNumber
+     * @param authHeaderLength
+     * @param applicationReply
+     * @param privateMessage
+     */
+    public ChangePasswordReply( short messageLength, short versionNumber, short authHeaderLength,
+        ApplicationReply applicationReply, PrivateMessage privateMessage )
     {
         super( messageLength, versionNumber, authHeaderLength );
 
@@ -44,12 +53,22 @@
     }
 
 
+    /**
+     * Returns the {@link ApplicationReply}.
+     *
+     * @return The {@link ApplicationReply}.
+     */
     public ApplicationReply getApplicationReply()
     {
         return applicationReply;
     }
 
 
+    /**
+     * Returns the {@link PrivateMessage}.
+     *
+     * @return The {@link PrivateMessage}.
+     */
     public PrivateMessage getPrivateMessage()
     {
         return privateMessage;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReplyModifier.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReplyModifier.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReplyModifier.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordReplyModifier.java
Fri May 18 19:34:29 2007
@@ -34,6 +34,11 @@
     private PrivateMessage privateMessage;
 
 
+    /**
+     * Returns the {@link ChangePasswordReply}.
+     *
+     * @return The {@link ChangePasswordReply}.
+     */
     public ChangePasswordReply getChangePasswordReply()
     {
         return new ChangePasswordReply( messageLength, versionNumber, authHeaderLength, applicationReply,
@@ -41,12 +46,22 @@
     }
 
 
+    /**
+     * Sets the {@link ApplicationReply}.
+     *
+     * @param applicationReply
+     */
     public void setApplicationReply( ApplicationReply applicationReply )
     {
         this.applicationReply = applicationReply;
     }
 
 
+    /**
+     * Sets the {@link PrivateMessage}.
+     *
+     * @param privateMessage
+     */
     public void setPrivateMessage( PrivateMessage privateMessage )
     {
         this.privateMessage = privateMessage;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequest.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequest.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequest.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequest.java
Fri May 18 19:34:29 2007
@@ -34,8 +34,17 @@
     private PrivateMessage privateMessage;
 
 
-    public ChangePasswordRequest(short messageLength, short versionNumber, short authHeaderLength,
-        ApplicationRequest authHeader, PrivateMessage privateMessage)
+    /**
+     * Creates a new instance of ChangePasswordRequest.
+     *
+     * @param messageLength
+     * @param versionNumber
+     * @param authHeaderLength
+     * @param authHeader
+     * @param privateMessage
+     */
+    public ChangePasswordRequest( short messageLength, short versionNumber, short authHeaderLength,
+        ApplicationRequest authHeader, PrivateMessage privateMessage )
     {
         super( messageLength, versionNumber, authHeaderLength );
 
@@ -44,12 +53,22 @@
     }
 
 
+    /**
+     * Returns the {@link ApplicationRequest}.
+     *
+     * @return The {@link ApplicationRequest}.
+     */
     public ApplicationRequest getAuthHeader()
     {
         return authHeader;
     }
 
 
+    /**
+     * Returns the {@link PrivateMessage}.
+     *
+     * @return The {@link PrivateMessage}.
+     */
     public PrivateMessage getPrivateMessage()
     {
         return privateMessage;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequestModifier.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequestModifier.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequestModifier.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/messages/ChangePasswordRequestModifier.java
Fri May 18 19:34:29 2007
@@ -34,18 +34,33 @@
     private PrivateMessage privateMessage;
 
 
+    /**
+     * Returns the {@link ChangePasswordRequest}.
+     *
+     * @return The {@link ChangePasswordRequest}.
+     */
     public ChangePasswordRequest getChangePasswordMessage()
     {
         return new ChangePasswordRequest( messageLength, versionNumber, authHeaderLength,
authHeader, privateMessage );
     }
 
 
+    /**
+     * Sets the AuthHeader.
+     *
+     * @param authHeader
+     */
     public void setAuthHeader( ApplicationRequest authHeader )
     {
         this.authHeader = authHeader;
     }
 
 
+    /**
+     * Sets the {@link PrivateMessage}.
+     *
+     * @param privateMessage
+     */
     public void setPrivateMessage( PrivateMessage privateMessage )
     {
         this.privateMessage = privateMessage;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolCodecFactory.java
Fri May 18 19:34:29 2007
@@ -35,6 +35,11 @@
     private static final ChangePasswordProtocolCodecFactory INSTANCE = new ChangePasswordProtocolCodecFactory();
 
 
+    /**
+     * Returns the singleton instance of {@link ChangePasswordProtocolCodecFactory}.
+     *
+     * @return The singleton instance of {@link ChangePasswordProtocolCodecFactory}.
+     */
     public static ChangePasswordProtocolCodecFactory getInstance()
     {
         return INSTANCE;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/protocol/ChangePasswordProtocolHandler.java
Fri May 18 19:34:29 2007
@@ -63,6 +63,12 @@
     private String contextKey = "context";
 
 
+    /**
+     * Creates a new instance of ChangePasswordProtocolHandler.
+     *
+     * @param config
+     * @param store
+     */
     public ChangePasswordProtocolHandler( ChangePasswordConfiguration config, PrincipalStore
store )
     {
         this.config = config;
@@ -163,7 +169,7 @@
     }
 
 
-    public String getContextKey()
+    protected String getContextKey()
     {
         return ( this.contextKey );
     }

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordData.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordData.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordData.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordData.java
Fri May 18 19:34:29 2007
@@ -34,7 +34,14 @@
     private String realm;
 
 
-    public ChangePasswordData(byte[] password, PrincipalName principalName, String realm)
+    /**
+     * Creates a new instance of ChangePasswordData.
+     *
+     * @param password
+     * @param principalName
+     * @param realm
+     */
+    public ChangePasswordData( byte[] password, PrincipalName principalName, String realm
)
     {
         this.password = password;
         this.principalName = principalName;
@@ -42,18 +49,33 @@
     }
 
 
+    /**
+     * Returns the password as bytes.
+     *
+     * @return The password as bytes.
+     */
     public byte[] getPassword()
     {
         return password;
     }
 
 
+    /**
+     * Returns the principal name.
+     *
+     * @return The principal name.
+     */
     public PrincipalName getPrincipalName()
     {
         return principalName;
     }
 
 
+    /**
+     * Returns the realm.
+     *
+     * @return The realm.
+     */
     public String getRealm()
     {
         return realm;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordDataModifier.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordDataModifier.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordDataModifier.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/main/java/org/apache/directory/server/changepw/value/ChangePasswordDataModifier.java
Fri May 18 19:34:29 2007
@@ -34,24 +34,44 @@
     private String realm;
 
 
+    /**
+     * Returns the {@link ChangePasswordData}.
+     *
+     * @return The {@link ChangePasswordData}.
+     */
     public ChangePasswordData getChangePasswdData()
     {
         return new ChangePasswordData( password, principalName, realm );
     }
 
 
+    /**
+     * Sets the bytes of the new password.
+     *
+     * @param password
+     */
     public void setNewPassword( byte[] password )
     {
         this.password = password;
     }
 
 
+    /**
+     * Sets the target principal name whose password is to be changed.
+     *
+     * @param principalName
+     */
     public void setTargetName( PrincipalName principalName )
     {
         this.principalName = principalName;
     }
 
 
+    /**
+     * Sets the target realm of the principal whose password is to be changed.
+     *
+     * @param realm
+     */
     public void setTargetRealm( String realm )
     {
         this.realm = realm;

Modified: directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/test/java/org/apache/directory/server/changepw/service/CheckPasswordPolicyTest.java
URL: http://svn.apache.org/viewvc/directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/test/java/org/apache/directory/server/changepw/service/CheckPasswordPolicyTest.java?view=diff&rev=539677&r1=539676&r2=539677
==============================================================================
--- directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/test/java/org/apache/directory/server/changepw/service/CheckPasswordPolicyTest.java
(original)
+++ directory/apacheds/branches/kerberos-encryption-types/protocol-changepw/src/test/java/org/apache/directory/server/changepw/service/CheckPasswordPolicyTest.java
Fri May 18 19:34:29 2007
@@ -22,8 +22,6 @@
 
 import javax.security.auth.kerberos.KerberosPrincipal;
 
-import org.apache.directory.server.changepw.service.CheckPasswordPolicy;
-
 import junit.framework.TestCase;
 
 
@@ -42,6 +40,9 @@
     private CheckPasswordPolicy policy = new CheckPasswordPolicy();
 
 
+    /**
+     * Tests that a good password is valid according to all policy checks.
+     */
     public void testGoodPassword()
     {
         String username = "Enrique Rodriguez";
@@ -53,6 +54,9 @@
     }
 
 
+    /**
+     * Tests that a bad password fails all validity checks.
+     */
     public void testBadPassword()
     {
         String username = "Erin Randall";
@@ -64,6 +68,9 @@
     }
 
 
+    /**
+     * Tests variations of a password where the password includes tokens of the username.
+     */
     public void testPrincipalAsUsername()
     {
         String username = new KerberosPrincipal( "erodriguez@EXAMPLE.COM" ).getName();



Mime
View raw message