directory-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From seelm...@apache.org
Subject svn commit: r519442 - in /directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui: editors/entry/ widgets/entryeditor/ wizards/
Date Sat, 17 Mar 2007 21:09:55 GMT
Author: seelmann
Date: Sat Mar 17 14:09:54 2007
New Revision: 519442

URL: http://svn.apache.org/viewvc?view=rev&rev=519442
Log:
Small refactorings, code cleaning, Javadocs.

Removed:
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorContentProvider.java
Modified:
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditor.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorActionGroup.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorConfiguration.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorFilter.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/OpenEntryEditorPreferencePageAction.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowOperationalAttributesAction.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowQuickFilterAction.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetActionGroup.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetConfiguration.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/wizards/NewEntryAttributesWizardPageActionGroup.java

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditor.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditor.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditor.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditor.java Sat Mar 17 14:09:54 2007
@@ -46,36 +46,58 @@
 import org.eclipse.ui.views.contentoutline.IContentOutlinePage;
 
 
+/**
+ * The EntryEditor is an {@link IEditorPart} is used to display and edit the attributes of an entry.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryEditor extends EditorPart implements INavigationLocationProvider, IReusableEditor
 {
 
+    /** The editor configuration. */
     private EntryEditorConfiguration configuration;
 
+    /** The action group. */
     private EntryEditorActionGroup actionGroup;
 
+    /** The main widget. */
     private EntryEditorWidget mainWidget;
 
+    /** The universal listener. */
     private EntryEditorUniversalListener universalListener;
 
+    /** The outline page. */
     private LdifOutlinePage outlinePage;
 
 
+    /**
+     * Gets the ID of the EntryEditor.
+     * 
+     * @return the id of the EntryEditor
+     */
     public static String getId()
     {
         return EntryEditor.class.getName();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void setInput( IEditorInput input )
     {
         super.setInput( input );
 
-        if ( input instanceof EntryEditorInput && this.universalListener != null )
+        if ( input instanceof EntryEditorInput && universalListener != null )
         {
             EntryEditorInput eei = ( EntryEditorInput ) input;
             IEntry entry = eei.getResolvedEntry();
-            this.universalListener.setInput( entry );
 
+            // inform listener
+            universalListener.setInput( entry );
+
+            // mark location for back/forward history navigation
             if ( entry != null )
             {
                 // enable one instance hack before fireing the input change event 
@@ -88,9 +110,10 @@
                 getSite().getPage().getNavigationHistory().markLocation( this );
             }
 
-            if ( this.outlinePage != null )
+            // refresh outline
+            if ( outlinePage != null )
             {
-                this.outlinePage.refresh();
+                outlinePage.refresh();
             }
 
             // finally enable the one instance hack 
@@ -99,28 +122,32 @@
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void init( IEditorSite site, IEditorInput input ) throws PartInitException
     {
         super.setSite( site );
 
         // mark dummy location, necessary because the first marked
         // location doesn't appear in history
-        this.setInput( new EntryEditorInput( ( IEntry ) null ) );
+        setInput( new EntryEditorInput( ( IEntry ) null ) );
         getSite().getPage().getNavigationHistory().markLocation( this );
 
-        this.setInput( input );
+        setInput( input );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void createPartControl( Composite parent )
     {
-
         Composite composite = new Composite( parent, SWT.NONE );
         composite.setLayoutData( new GridData( GridData.FILL_BOTH ) );
         GridLayout layout = new GridLayout();
         layout.marginWidth = 0;
         layout.marginHeight = 0;
-        // layout.horizontalSpacing = 0;
         layout.verticalSpacing = 0;
         composite.setLayout( layout );
 
@@ -128,32 +155,38 @@
             BrowserUIPlugin.PLUGIN_ID + "." + "tools_entry_editor" );
 
         // create configuration
-        this.configuration = new EntryEditorConfiguration();
+        configuration = new EntryEditorConfiguration();
 
         // create main widget
-        this.mainWidget = new EntryEditorWidget( this.configuration );
-        this.mainWidget.createWidget( composite );
+        mainWidget = new EntryEditorWidget( this.configuration );
+        mainWidget.createWidget( composite );
 
         // create actions and context menu and register global actions
-        this.actionGroup = new EntryEditorActionGroup( this );
-        this.actionGroup.fillToolBar( this.mainWidget.getToolBarManager() );
-        this.actionGroup.fillMenu( this.mainWidget.getMenuManager() );
-        this.actionGroup.enableGlobalActionHandlers( getEditorSite().getActionBars() );
-        this.actionGroup.fillContextMenu( this.mainWidget.getContextMenuManager() );
+        actionGroup = new EntryEditorActionGroup( this );
+        actionGroup.fillToolBar( mainWidget.getToolBarManager() );
+        actionGroup.fillMenu( mainWidget.getMenuManager() );
+        actionGroup.enableGlobalActionHandlers( getEditorSite().getActionBars() );
+        actionGroup.fillContextMenu( mainWidget.getContextMenuManager() );
 
         // create the listener
-        getSite().setSelectionProvider( this.mainWidget.getViewer() );
-        this.universalListener = new EntryEditorUniversalListener( this );
-        this.setInput( getEditorInput() );
+        getSite().setSelectionProvider( mainWidget.getViewer() );
+        universalListener = new EntryEditorUniversalListener( this );
+        setInput( getEditorInput() );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void setFocus()
     {
-        this.mainWidget.setFocus();
+        mainWidget.setFocus();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public Object getAdapter( Class required )
     {
         if ( IContentOutlinePage.class.equals( required ) )
@@ -193,18 +226,21 @@
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void dispose()
     {
-        if ( this.configuration != null )
+        if ( configuration != null )
         {
-            this.universalListener.dispose();
-            this.universalListener = null;
-            this.mainWidget.dispose();
-            this.mainWidget = null;
-            this.actionGroup.dispose();
-            this.actionGroup = null;
-            this.configuration.dispose();
-            this.configuration = null;
+            universalListener.dispose();
+            universalListener = null;
+            mainWidget.dispose();
+            mainWidget = null;
+            actionGroup.dispose();
+            actionGroup = null;
+            configuration.dispose();
+            configuration = null;
             getSite().setSelectionProvider( null );
         }
 
@@ -212,64 +248,107 @@
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void doSave( IProgressMonitor monitor )
     {
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void doSaveAs()
     {
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public boolean isDirty()
     {
         return false;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public boolean isSaveAsAllowed()
     {
         return false;
     }
 
 
+    /**
+     * Gets the action group.
+     * 
+     * @return the action group
+     */
     public EntryEditorActionGroup getActionGroup()
     {
         return actionGroup;
     }
 
 
+    /**
+     * Gets the configuration.
+     * 
+     * @return the configuration
+     */
     public EntryEditorConfiguration getConfiguration()
     {
         return configuration;
     }
 
 
+    /**
+     * Gets the main widget.
+     * 
+     * @return the main widget
+     */
     public EntryEditorWidget getMainWidget()
     {
         return mainWidget;
     }
 
 
+    /**
+     * Gets the outline page.
+     * 
+     * @return the outline page
+     */
     public LdifOutlinePage getOutlinePage()
     {
         return outlinePage;
     }
 
 
+    /**
+     * Gets the universal listener.
+     * 
+     * @return the universal listener
+     */
     public EntryEditorUniversalListener getUniversalListener()
     {
         return universalListener;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public INavigationLocation createEmptyNavigationLocation()
     {
         return null;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public INavigationLocation createNavigationLocation()
     {
         return new EntryEditorNavigationLocation( this );

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorActionGroup.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorActionGroup.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorActionGroup.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorActionGroup.java Sat Mar 17 14:09:54 2007
@@ -44,7 +44,6 @@
 import org.apache.directory.ldapstudio.browser.ui.widgets.entryeditor.EditAttributeDescriptionAction;
 import org.apache.directory.ldapstudio.browser.ui.widgets.entryeditor.EntryEditorWidgetActionGroup;
 import org.apache.directory.ldapstudio.browser.ui.widgets.entryeditor.OpenDefaultEditorAction;
-
 import org.eclipse.jface.action.IAction;
 import org.eclipse.jface.action.IMenuListener;
 import org.eclipse.jface.action.IMenuManager;
@@ -60,181 +59,226 @@
 import org.eclipse.ui.commands.ICommandService;
 
 
+/**
+ * The EntryEditorWidgetActionGroup manages all actions of the entry editor.
+ * 
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryEditorActionGroup extends EntryEditorWidgetActionGroup
 {
 
+    /** The show operational attributes action. */
     private ShowOperationalAttributesAction showOperationalAttributesAction;
 
+    /** The open entry editor preference page. */
     private OpenEntryEditorPreferencePageAction openEntryEditorPreferencePage;
 
+    /** The collapse all action. */
     private CollapseAllAction collapseAllAction;
 
+    /** The expand all action. */
     private ExpandAllAction expandAllAction;
 
+    /** The Constant editAttributeDescriptionAction. */
     private static final String editAttributeDescriptionAction = "editAttributeDescriptionAction";
-    
+
+    /** The Constant refreshAttributesAction. */
     private static final String refreshAttributesAction = "refreshAttributesAction";
 
+    /** The Constant newAttributeAction. */
     private static final String newAttributeAction = "newAttributeAction";
 
+    /** The Constant newSearchAction. */
     private static final String newSearchAction = "newSearchDialogAction";
 
+    /** The Constant newBatchOperationAction. */
     private static final String newBatchOperationAction = "newBatchOperationAction";
 
+    /** The Constant copyDnAction. */
     private static final String copyDnAction = "copyDnAction";
 
+    /** The Constant copyUrlAction. */
     private static final String copyUrlAction = "copyUrlAction";
 
+    /** The Constant copyAttriuteDescriptionAction. */
     private static final String copyAttriuteDescriptionAction = "copyAttriuteDescriptionAction";
 
+    /** The Constant copyValueUtf8Action. */
     private static final String copyValueUtf8Action = "copyValueUtf8Action";
 
+    /** The Constant copyValueBase64Action. */
     private static final String copyValueBase64Action = "copyValueBase64Action";
 
+    /** The Constant copyValueHexAction. */
     private static final String copyValueHexAction = "copyValueHexAction";
 
+    /** The Constant copyValueAsLdifAction. */
     private static final String copyValueAsLdifAction = "copyValueAsLdifAction";
 
+    /** The Constant copySearchFilterAction. */
     private static final String copySearchFilterAction = "copySearchFilterAction";
 
+    /** The Constant copyNotSearchFilterAction. */
     private static final String copyNotSearchFilterAction = "copyNotSearchFilterAction";
 
+    /** The Constant copyAndSearchFilterAction. */
     private static final String copyAndSearchFilterAction = "copyAndSearchFilterAction";
 
+    /** The Constant copyOrSearchFilterAction. */
     private static final String copyOrSearchFilterAction = "copyOrSearchFilterAction";
 
+    /** The Constant deleteAllValuesAction. */
     private static final String deleteAllValuesAction = "deleteAllValuesAction";
 
+    /** The Constant locateDnInDitAction. */
     private static final String locateDnInDitAction = "locateDnInDitAction";
 
+    /** The Constant showOcdAction. */
     private static final String showOcdAction = "showOcdAction";
 
+    /** The Constant showAtdAction. */
     private static final String showAtdAction = "showAtdAction";
 
+    /** The Constant showEqualityMrdAction. */
     private static final String showEqualityMrdAction = "showEqualityMrdAction";
 
+    /** The Constant showSubstringMrdAction. */
     private static final String showSubstringMrdAction = "showSubstringMrdAction";
 
+    /** The Constant showOrderingMrdAction. */
     private static final String showOrderingMrdAction = "showOrderingMrdAction";
 
+    /** The Constant showLsdAction. */
     private static final String showLsdAction = "showLsdAction";
 
 
+    /**
+     * Creates a new instance of EntryEditorActionGroup.
+     * 
+     * @param entryEditor the entry editor
+     */
     public EntryEditorActionGroup( EntryEditor entryEditor )
     {
         super( entryEditor.getMainWidget(), entryEditor.getConfiguration() );
         TreeViewer viewer = entryEditor.getMainWidget().getViewer();
 
+        // create OpenDefaultEditorAction with enabled rename action flag
         openDefaultValueEditorActionProxy.dispose();
-        openDefaultValueEditorActionProxy = new EntryEditorActionProxy( viewer , new OpenDefaultEditorAction( viewer, openBestValueEditorActionProxy, true ) );
+        openDefaultValueEditorActionProxy = new EntryEditorActionProxy( viewer, new OpenDefaultEditorAction( viewer,
+            openBestValueEditorActionProxy, true ) );
 
-        this.showOperationalAttributesAction = new ShowOperationalAttributesAction();
-        this.openEntryEditorPreferencePage = new OpenEntryEditorPreferencePageAction();
-        this.collapseAllAction = new CollapseAllAction( viewer );
-        this.expandAllAction = new ExpandAllAction( viewer );
-        
-        this.entryEditorActionMap.put( editAttributeDescriptionAction,
-            new EntryEditorActionProxy( viewer, new EditAttributeDescriptionAction( viewer ) ) );
-        
-        this.entryEditorActionMap.put( refreshAttributesAction,
-            new EntryEditorActionProxy( viewer, new RefreshAction() ) );
-
-        this.entryEditorActionMap.put( newAttributeAction,
-            new EntryEditorActionProxy( viewer, new NewAttributeAction() ) );
-        this.entryEditorActionMap.put( newSearchAction, new EntryEditorActionProxy( viewer, new NewSearchAction() ) );
-        this.entryEditorActionMap.put( newBatchOperationAction, new EntryEditorActionProxy( viewer,
+        showOperationalAttributesAction = new ShowOperationalAttributesAction();
+        openEntryEditorPreferencePage = new OpenEntryEditorPreferencePageAction();
+        collapseAllAction = new CollapseAllAction( viewer );
+        expandAllAction = new ExpandAllAction( viewer );
+
+        entryEditorActionMap.put( editAttributeDescriptionAction, new EntryEditorActionProxy( viewer,
+            new EditAttributeDescriptionAction( viewer ) ) );
+
+        entryEditorActionMap.put( refreshAttributesAction, new EntryEditorActionProxy( viewer, new RefreshAction() ) );
+
+        entryEditorActionMap.put( newAttributeAction, new EntryEditorActionProxy( viewer, new NewAttributeAction() ) );
+        entryEditorActionMap.put( newSearchAction, new EntryEditorActionProxy( viewer, new NewSearchAction() ) );
+        entryEditorActionMap.put( newBatchOperationAction, new EntryEditorActionProxy( viewer,
             new NewBatchOperationAction() ) );
 
-        this.entryEditorActionMap.put( locateDnInDitAction, new EntryEditorActionProxy( viewer,
-            new LocateDnInDitAction() ) );
-        this.entryEditorActionMap.put( showOcdAction, new EntryEditorActionProxy( viewer, new OpenSchemaBrowserAction(
+        entryEditorActionMap.put( locateDnInDitAction, new EntryEditorActionProxy( viewer, new LocateDnInDitAction() ) );
+        entryEditorActionMap.put( showOcdAction, new EntryEditorActionProxy( viewer, new OpenSchemaBrowserAction(
             OpenSchemaBrowserAction.MODE_OBJECTCLASS ) ) );
-        this.entryEditorActionMap.put( showAtdAction, new EntryEditorActionProxy( viewer, new OpenSchemaBrowserAction(
+        entryEditorActionMap.put( showAtdAction, new EntryEditorActionProxy( viewer, new OpenSchemaBrowserAction(
             OpenSchemaBrowserAction.MODE_ATTRIBUTETYPE ) ) );
-        this.entryEditorActionMap.put( showEqualityMrdAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( showEqualityMrdAction, new EntryEditorActionProxy( viewer,
             new OpenSchemaBrowserAction( OpenSchemaBrowserAction.MODE_EQUALITYMATCHINGRULE ) ) );
-        this.entryEditorActionMap.put( showSubstringMrdAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( showSubstringMrdAction, new EntryEditorActionProxy( viewer,
             new OpenSchemaBrowserAction( OpenSchemaBrowserAction.MODE_SUBSTRINGMATCHINGRULE ) ) );
-        this.entryEditorActionMap.put( showOrderingMrdAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( showOrderingMrdAction, new EntryEditorActionProxy( viewer,
             new OpenSchemaBrowserAction( OpenSchemaBrowserAction.MODE_ORDERINGMATCHINGRULE ) ) );
-        this.entryEditorActionMap.put( showLsdAction, new EntryEditorActionProxy( viewer, new OpenSchemaBrowserAction(
+        entryEditorActionMap.put( showLsdAction, new EntryEditorActionProxy( viewer, new OpenSchemaBrowserAction(
             OpenSchemaBrowserAction.MODE_SYNTAX ) ) );
 
-        this.entryEditorActionMap.put( copyDnAction, new EntryEditorActionProxy( viewer, new CopyDnAction() ) );
-        this.entryEditorActionMap.put( copyUrlAction, new EntryEditorActionProxy( viewer, new CopyUrlAction() ) );
-        this.entryEditorActionMap.put( copyAttriuteDescriptionAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( copyDnAction, new EntryEditorActionProxy( viewer, new CopyDnAction() ) );
+        entryEditorActionMap.put( copyUrlAction, new EntryEditorActionProxy( viewer, new CopyUrlAction() ) );
+        entryEditorActionMap.put( copyAttriuteDescriptionAction, new EntryEditorActionProxy( viewer,
             new CopyAttributeDescriptionAction() ) );
-        this.entryEditorActionMap.put( copyValueUtf8Action, new EntryEditorActionProxy( viewer, new CopyValueAction(
+        entryEditorActionMap.put( copyValueUtf8Action, new EntryEditorActionProxy( viewer, new CopyValueAction(
             CopyValueAction.MODE_UTF8 ) ) );
-        this.entryEditorActionMap.put( copyValueBase64Action, new EntryEditorActionProxy( viewer, new CopyValueAction(
+        entryEditorActionMap.put( copyValueBase64Action, new EntryEditorActionProxy( viewer, new CopyValueAction(
             CopyValueAction.MODE_BASE64 ) ) );
-        this.entryEditorActionMap.put( copyValueHexAction, new EntryEditorActionProxy( viewer, new CopyValueAction(
+        entryEditorActionMap.put( copyValueHexAction, new EntryEditorActionProxy( viewer, new CopyValueAction(
             CopyValueAction.MODE_HEX ) ) );
-        this.entryEditorActionMap.put( copyValueAsLdifAction, new EntryEditorActionProxy( viewer, new CopyValueAction(
+        entryEditorActionMap.put( copyValueAsLdifAction, new EntryEditorActionProxy( viewer, new CopyValueAction(
             CopyValueAction.MODE_LDIF ) ) );
 
-        this.entryEditorActionMap.put( copySearchFilterAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( copySearchFilterAction, new EntryEditorActionProxy( viewer,
             new CopySearchFilterAction( CopySearchFilterAction.MODE_EQUALS ) ) );
-        this.entryEditorActionMap.put( copyNotSearchFilterAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( copyNotSearchFilterAction, new EntryEditorActionProxy( viewer,
             new CopySearchFilterAction( CopySearchFilterAction.MODE_NOT ) ) );
-        this.entryEditorActionMap.put( copyAndSearchFilterAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( copyAndSearchFilterAction, new EntryEditorActionProxy( viewer,
             new CopySearchFilterAction( CopySearchFilterAction.MODE_AND ) ) );
-        this.entryEditorActionMap.put( copyOrSearchFilterAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( copyOrSearchFilterAction, new EntryEditorActionProxy( viewer,
             new CopySearchFilterAction( CopySearchFilterAction.MODE_OR ) ) );
 
-        this.entryEditorActionMap.put( deleteAllValuesAction, new EntryEditorActionProxy( viewer,
+        entryEditorActionMap.put( deleteAllValuesAction, new EntryEditorActionProxy( viewer,
             new DeleteAllValuesAction() ) );
 
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void dispose()
     {
-        if ( this.showOperationalAttributesAction != null )
+        if ( showOperationalAttributesAction != null )
         {
+            deactivateGlobalActionHandlers();
 
-            this.deactivateGlobalActionHandlers();
-
-            this.openEntryEditorPreferencePage = null;
-            this.showOperationalAttributesAction.dispose();
-            this.showOperationalAttributesAction = null;
-            this.expandAllAction.dispose();
-            this.expandAllAction = null;
-            this.collapseAllAction.dispose();
-            this.collapseAllAction = null;
+            openEntryEditorPreferencePage = null;
+            showOperationalAttributesAction = null;
+            expandAllAction.dispose();
+            expandAllAction = null;
+            collapseAllAction.dispose();
+            collapseAllAction = null;
         }
 
         super.dispose();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void fillToolBar( IToolBarManager toolBarManager )
     {
         toolBarManager.add( new Separator() );
-        toolBarManager.add( ( IAction ) this.entryEditorActionMap.get( newValueAction ) );
-        toolBarManager.add( ( IAction ) this.entryEditorActionMap.get( newAttributeAction ) );
+        toolBarManager.add( ( IAction ) entryEditorActionMap.get( newValueAction ) );
+        toolBarManager.add( ( IAction ) entryEditorActionMap.get( newAttributeAction ) );
         toolBarManager.add( new Separator() );
-        toolBarManager.add( ( IAction ) this.entryEditorActionMap.get( deleteAction ) );
-        toolBarManager.add( ( IAction ) this.entryEditorActionMap.get( deleteAllValuesAction ) );
+        toolBarManager.add( ( IAction ) entryEditorActionMap.get( deleteAction ) );
+        toolBarManager.add( ( IAction ) entryEditorActionMap.get( deleteAllValuesAction ) );
         toolBarManager.add( new Separator() );
-        toolBarManager.add( ( IAction ) this.entryEditorActionMap.get( refreshAttributesAction ) );
+        toolBarManager.add( ( IAction ) entryEditorActionMap.get( refreshAttributesAction ) );
         toolBarManager.add( new Separator() );
-        toolBarManager.add( this.expandAllAction );
-        toolBarManager.add( this.collapseAllAction );
+        toolBarManager.add( expandAllAction );
+        toolBarManager.add( collapseAllAction );
         toolBarManager.add( new Separator() );
-        toolBarManager.add( this.showQuickFilterAction );
+        toolBarManager.add( showQuickFilterAction );
         toolBarManager.update( true );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void fillMenu( IMenuManager menuManager )
     {
-        menuManager.add( this.openSortDialogAction );
+        menuManager.add( openSortDialogAction );
         menuManager.add( new Separator() );
-        menuManager.add( this.showOperationalAttributesAction );
-        menuManager.add( this.showRawValuesAction );
+        menuManager.add( showOperationalAttributesAction );
+        menuManager.add( showRawValuesAction );
         menuManager.add( new Separator() );
-        menuManager.add( this.openEntryEditorPreferencePage );
+        menuManager.add( openEntryEditorPreferencePage );
         menuManager.addMenuListener( new IMenuListener()
         {
             public void menuAboutToShow( IMenuManager manager )
@@ -249,25 +293,27 @@
     }
 
 
-    public void menuAboutToShow( IMenuManager menuManager )
+    /**
+     * {@inheritDoc}
+     */
+    protected void contextMenuAboutToShow( IMenuManager menuManager )
     {
-
         // new
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( newAttributeAction ) );
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( newValueAction ) );
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( newSearchAction ) );
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( newBatchOperationAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( newAttributeAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( newValueAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( newSearchAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( newBatchOperationAction ) );
         menuManager.add( new Separator() );
 
         // navigation
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( locateDnInDitAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( locateDnInDitAction ) );
         MenuManager schemaMenuManager = new MenuManager( "Open Schema Browser" );
-        schemaMenuManager.add( ( IAction ) this.entryEditorActionMap.get( showOcdAction ) );
-        schemaMenuManager.add( ( IAction ) this.entryEditorActionMap.get( showAtdAction ) );
-        schemaMenuManager.add( ( IAction ) this.entryEditorActionMap.get( showEqualityMrdAction ) );
-        schemaMenuManager.add( ( IAction ) this.entryEditorActionMap.get( showSubstringMrdAction ) );
-        schemaMenuManager.add( ( IAction ) this.entryEditorActionMap.get( showOrderingMrdAction ) );
-        schemaMenuManager.add( ( IAction ) this.entryEditorActionMap.get( showLsdAction ) );
+        schemaMenuManager.add( ( IAction ) entryEditorActionMap.get( showOcdAction ) );
+        schemaMenuManager.add( ( IAction ) entryEditorActionMap.get( showAtdAction ) );
+        schemaMenuManager.add( ( IAction ) entryEditorActionMap.get( showEqualityMrdAction ) );
+        schemaMenuManager.add( ( IAction ) entryEditorActionMap.get( showSubstringMrdAction ) );
+        schemaMenuManager.add( ( IAction ) entryEditorActionMap.get( showOrderingMrdAction ) );
+        schemaMenuManager.add( ( IAction ) entryEditorActionMap.get( showLsdAction ) );
         menuManager.add( schemaMenuManager );
         MenuManager showInSubMenu = new MenuManager( "Show In" );
         showInSubMenu.add( ContributionItemFactory.VIEWS_SHOW_IN.create( PlatformUI.getWorkbench()
@@ -277,54 +323,56 @@
         menuManager.add( new Separator() );
 
         // copy, paste, delete
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( copyAction ) );
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( pasteAction ) );
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( deleteAction ) );
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( selectAllAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( copyAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( pasteAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( deleteAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( selectAllAction ) );
         MenuManager advancedMenuManager = new MenuManager( "Advanced" );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyDnAction ) );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyUrlAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyDnAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyUrlAction ) );
         advancedMenuManager.add( new Separator() );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyAttriuteDescriptionAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyAttriuteDescriptionAction ) );
         advancedMenuManager.add( new Separator() );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyValueUtf8Action ) );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyValueBase64Action ) );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyValueHexAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyValueUtf8Action ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyValueBase64Action ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyValueHexAction ) );
         advancedMenuManager.add( new Separator() );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyValueAsLdifAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyValueAsLdifAction ) );
         advancedMenuManager.add( new Separator() );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copySearchFilterAction ) );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyNotSearchFilterAction ) );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyAndSearchFilterAction ) );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( copyOrSearchFilterAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copySearchFilterAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyNotSearchFilterAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyAndSearchFilterAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( copyOrSearchFilterAction ) );
         advancedMenuManager.add( new Separator() );
-        advancedMenuManager.add( ( IAction ) this.entryEditorActionMap.get( deleteAllValuesAction ) );
+        advancedMenuManager.add( ( IAction ) entryEditorActionMap.get( deleteAllValuesAction ) );
         menuManager.add( advancedMenuManager );
         menuManager.add( new Separator() );
 
         // edit
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( editAttributeDescriptionAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( editAttributeDescriptionAction ) );
         super.addEditMenu( menuManager );
         menuManager.add( new Separator() );
 
         // refresh
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( refreshAttributesAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( refreshAttributesAction ) );
         menuManager.add( new Separator() );
 
         // additions
         menuManager.add( new Separator( IWorkbenchActionConstants.MB_ADDITIONS ) );
 
         // properties
-        menuManager.add( ( IAction ) this.entryEditorActionMap.get( propertyDialogAction ) );
+        menuManager.add( ( IAction ) entryEditorActionMap.get( propertyDialogAction ) );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void activateGlobalActionHandlers()
     {
-
-        if ( this.actionBars != null )
+        if ( actionBars != null )
         {
-            actionBars.setGlobalActionHandler( ActionFactory.REFRESH.getId(), ( IAction ) this.entryEditorActionMap
+            actionBars.setGlobalActionHandler( ActionFactory.REFRESH.getId(), ( IAction ) entryEditorActionMap
                 .get( refreshAttributesAction ) );
         }
 
@@ -334,21 +382,22 @@
             ICommandService.class );
         if ( commandService != null )
         {
-            IAction naa = ( IAction ) this.entryEditorActionMap.get( newAttributeAction );
+            IAction naa = ( IAction ) entryEditorActionMap.get( newAttributeAction );
             commandService.getCommand( naa.getActionDefinitionId() ).setHandler( new ActionHandler( naa ) );
-            IAction lid = ( IAction ) this.entryEditorActionMap.get( locateDnInDitAction );
+            IAction lid = ( IAction ) entryEditorActionMap.get( locateDnInDitAction );
             commandService.getCommand( lid.getActionDefinitionId() ).setHandler( new ActionHandler( lid ) );
-            IAction eada = ( IAction ) this.entryEditorActionMap.get( editAttributeDescriptionAction );
-            commandService.getCommand( eada.getActionDefinitionId() ).setHandler(
-                new ActionHandler( eada ) );
+            IAction eada = ( IAction ) entryEditorActionMap.get( editAttributeDescriptionAction );
+            commandService.getCommand( eada.getActionDefinitionId() ).setHandler( new ActionHandler( eada ) );
         }
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void deactivateGlobalActionHandlers()
     {
-
-        if ( this.actionBars != null )
+        if ( actionBars != null )
         {
             actionBars.setGlobalActionHandler( ActionFactory.REFRESH.getId(), null );
         }
@@ -359,19 +408,24 @@
             ICommandService.class );
         if ( commandService != null )
         {
-            IAction naa = ( IAction ) this.entryEditorActionMap.get( newAttributeAction );
+            IAction naa = ( IAction ) entryEditorActionMap.get( newAttributeAction );
             commandService.getCommand( naa.getActionDefinitionId() ).setHandler( null );
-            IAction lid = ( IAction ) this.entryEditorActionMap.get( locateDnInDitAction );
+            IAction lid = ( IAction ) entryEditorActionMap.get( locateDnInDitAction );
             commandService.getCommand( lid.getActionDefinitionId() ).setHandler( null );
-            IAction eada = ( IAction ) this.entryEditorActionMap.get( editAttributeDescriptionAction );
+            IAction eada = ( IAction ) entryEditorActionMap.get( editAttributeDescriptionAction );
             commandService.getCommand( eada.getActionDefinitionId() ).setHandler( null );
         }
     }
 
 
+    /**
+     * Sets the input.
+     * 
+     * @param entry the input
+     */
     public void setInput( IEntry entry )
     {
-        for ( Iterator it = this.entryEditorActionMap.values().iterator(); it.hasNext(); )
+        for ( Iterator it = entryEditorActionMap.values().iterator(); it.hasNext(); )
         {
             EntryEditorActionProxy action = ( EntryEditorActionProxy ) it.next();
             action.inputChanged( entry );

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorConfiguration.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorConfiguration.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorConfiguration.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorConfiguration.java Sat Mar 17 14:09:54 2007
@@ -21,40 +21,38 @@
 package org.apache.directory.ldapstudio.browser.ui.editors.entry;
 
 
-import org.apache.directory.ldapstudio.browser.ui.widgets.entryeditor.EntryEditorWidget;
 import org.apache.directory.ldapstudio.browser.ui.widgets.entryeditor.EntryEditorWidgetConfiguration;
-import org.apache.directory.ldapstudio.browser.ui.widgets.entryeditor.EntryEditorWidgetContentProvider;
 import org.apache.directory.ldapstudio.browser.ui.widgets.entryeditor.EntryEditorWidgetFilter;
 
 
+/**
+ * The BrowserConfiguration contains the content provider, 
+ * label provider, sorter, filter the context menu manager and the
+ * preferences for the entry editor. 
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryEditorConfiguration extends EntryEditorWidgetConfiguration
 {
 
+    /**
+     * Creates a new instance of EntryEditorConfiguration.
+     */
     public EntryEditorConfiguration()
     {
-        super();
-    }
-
-
-    public void dispose()
-    {
-        super.dispose();
-    }
-
-
-    public EntryEditorWidgetContentProvider getContentProvider( EntryEditorWidget mainWidget )
-    {
-        if ( this.contentProvider == null )
-            this.contentProvider = new EntryEditorContentProvider( this.getPreferences(), mainWidget );
-
-        return contentProvider;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public EntryEditorWidgetFilter getFilter()
     {
-        if ( this.filter == null )
-            this.filter = new EntryEditorFilter( getPreferences() );
+        if ( filter == null )
+        {
+            filter = new EntryEditorFilter( getPreferences() );
+        }
 
         return filter;
     }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorFilter.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorFilter.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorFilter.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/EntryEditorFilter.java Sat Mar 17 14:09:54 2007
@@ -25,36 +25,61 @@
 import org.apache.directory.ldapstudio.browser.ui.widgets.entryeditor.EntryEditorWidgetPreferences;
 
 
+/**
+ * The EntryEditorFilter implements the filter for
+ * the entry editor.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryEditorFilter extends EntryEditorWidgetFilter
 {
 
+    /** The preferences. */
     private EntryEditorWidgetPreferences preferences;
 
 
+    /**
+     * Creates a new instance of EntryEditorFilter.
+     * 
+     * @param preferences the preferences
+     */
     public EntryEditorFilter( EntryEditorWidgetPreferences preferences )
     {
         this.preferences = preferences;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public boolean isShowMayAttributes()
     {
         return preferences.isShowMayAttributes();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public boolean isShowMustAttributes()
     {
         return preferences.isShowMustAttributes();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public boolean isShowObjectClassAttribute()
     {
         return preferences.isShowObjectClassAttribute();
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public boolean isShowOperationalAttributes()
     {
         return preferences.isShowOperationalAttributes();

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/OpenEntryEditorPreferencePageAction.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/OpenEntryEditorPreferencePageAction.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/OpenEntryEditorPreferencePageAction.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/OpenEntryEditorPreferencePageAction.java Sat Mar 17 14:09:54 2007
@@ -28,17 +28,29 @@
 import org.eclipse.ui.dialogs.PreferencesUtil;
 
 
+/**
+ * This action opens the prefence page of the entry editor.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class OpenEntryEditorPreferencePageAction extends Action
 {
 
+    /**
+     * Creates a new instance of OpenEntryEditorPreferencePageAction.
+     */
     public OpenEntryEditorPreferencePageAction()
     {
-        super.setText( "Preferences..." );
-        super.setToolTipText( "Preferences..." );
-        super.setEnabled( true );
+        setText( "Preferences..." );
+        setToolTipText( "Preferences..." );
+        setEnabled( true );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void run()
     {
         Shell shell = Display.getCurrent().getActiveShell();
@@ -46,11 +58,6 @@
         String attPageId = BrowserUIConstants.PREFERENCEPAGEID_ATTRIBUTES;
         PreferencesUtil.createPreferenceDialogOn( shell, eePageId, new String[]
             { eePageId, attPageId }, null ).open();
-    }
-
-
-    public void dispose()
-    {
     }
 
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowOperationalAttributesAction.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowOperationalAttributesAction.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowOperationalAttributesAction.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowOperationalAttributesAction.java Sat Mar 17 14:09:54 2007
@@ -26,41 +26,35 @@
 import org.eclipse.jface.action.Action;
 
 
+/**
+ * This action is used to toggle the "show operational attributes" preference.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ShowOperationalAttributesAction extends Action
 {
 
+    /**
+     * Creates a new instance of ShowOperationalAttributesAction.
+     */
     public ShowOperationalAttributesAction()
     {
         super( "Show Operational Attributes", AS_CHECK_BOX );
-        super.setToolTipText( getText() );
-        super.setEnabled( true );
-
-        super.setChecked( BrowserUIPlugin.getDefault().getPreferenceStore().getBoolean(
+        setToolTipText( getText() );
+        setEnabled( true );
+        setChecked( BrowserUIPlugin.getDefault().getPreferenceStore().getBoolean(
             BrowserUIConstants.PREFERENCE_ENTRYEDITOR_SHOW_OPERATIONAL_ATTRIBUTES ) );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public void run()
     {
         BrowserUIPlugin.getDefault().getPreferenceStore().setValue(
             BrowserUIConstants.PREFERENCE_ENTRYEDITOR_SHOW_OPERATIONAL_ATTRIBUTES, super.isChecked() );
-    }
-
-
-    public void setChecked( boolean checked )
-    {
-        super.setChecked( checked );
-    }
-
-
-    public boolean isChecked()
-    {
-        return super.isChecked();
-    }
-
-
-    public void dispose()
-    {
     }
 
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowQuickFilterAction.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowQuickFilterAction.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowQuickFilterAction.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/editors/entry/ShowQuickFilterAction.java Sat Mar 17 14:09:54 2007
@@ -28,22 +28,35 @@
 import org.eclipse.ui.texteditor.IWorkbenchActionDefinitionIds;
 
 
+/**
+ * This action shows/hides the instant search.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ShowQuickFilterAction extends Action
 {
 
+    /** The Constant SHOW_QUICKFILTER_DIALOGSETTING_KEY. */
     public static final String SHOW_QUICKFILTER_DIALOGSETTING_KEY = ShowQuickFilterAction.class.getName()
         + ".showQuickFilter";
 
+    /** The quick filter widget. */
     private EntryEditorWidgetQuickFilterWidget quickFilterWidget;
 
 
+    /**
+     * Creates a new instance of ShowQuickFilterAction.
+     * 
+     * @param quickFilterWidget the quick filter widget
+     */
     public ShowQuickFilterAction( EntryEditorWidgetQuickFilterWidget quickFilterWidget )
     {
         super( "Show Quick Filter", AS_CHECK_BOX );
-        super.setToolTipText( "Show Quick Filter" );
-        super.setImageDescriptor( BrowserUIPlugin.getDefault().getImageDescriptor( BrowserUIConstants.IMG_FILTER ) );
-        super.setActionDefinitionId( IWorkbenchActionDefinitionIds.FIND_REPLACE );
-        super.setEnabled( true );
+        setToolTipText( "Show Quick Filter" );
+        setImageDescriptor( BrowserUIPlugin.getDefault().getImageDescriptor( BrowserUIConstants.IMG_FILTER ) );
+        setActionDefinitionId( IWorkbenchActionDefinitionIds.FIND_REPLACE );
+        setEnabled( true );
 
         this.quickFilterWidget = quickFilterWidget;
 
@@ -51,42 +64,51 @@
         {
             BrowserUIPlugin.getDefault().getDialogSettings().put( SHOW_QUICKFILTER_DIALOGSETTING_KEY, false );
         }
+
+        // call the super implementation here because the local implementation
+        // does nothing.
         super.setChecked( BrowserUIPlugin.getDefault().getDialogSettings().getBoolean(
             SHOW_QUICKFILTER_DIALOGSETTING_KEY ) );
-        this.quickFilterWidget.setActive( super.isChecked() );
+        quickFilterWidget.setActive( isChecked() );
     }
 
 
+    /**
+     * {@inheritDoc}
+     * 
+     * This implementation toggles the checked state and 
+     * activates or deactivates the quick filter accordingly. 
+     */
     public void run()
     {
-
-        boolean checked = super.isChecked();
+        boolean checked = isChecked();
         super.setChecked( !checked );
 
-        BrowserUIPlugin.getDefault().getDialogSettings().put( SHOW_QUICKFILTER_DIALOGSETTING_KEY, super.isChecked() );
+        BrowserUIPlugin.getDefault().getDialogSettings().put( SHOW_QUICKFILTER_DIALOGSETTING_KEY, isChecked() );
 
-        if ( this.quickFilterWidget != null )
+        if ( quickFilterWidget != null )
         {
-            this.quickFilterWidget.setActive( super.isChecked() );
+            quickFilterWidget.setActive( isChecked() );
         }
     }
 
 
+    /**
+     * {@inheritDoc}
+     * 
+     * This implementation does nothing. Toggling of the checked state is done within the run() method.
+     */
     public void setChecked( boolean checked )
     {
-        // super.setChecked(checked);
-    }
-
-
-    public boolean isChecked()
-    {
-        return super.isChecked();
     }
 
 
+    /**
+     * Disposes this action.
+     */
     public void dispose()
     {
-        this.quickFilterWidget = null;
+        quickFilterWidget = null;
     }
 
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetActionGroup.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetActionGroup.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetActionGroup.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetActionGroup.java Sat Mar 17 14:09:54 2007
@@ -59,7 +59,7 @@
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
  */
-public class EntryEditorWidgetActionGroup implements IMenuListener
+public class EntryEditorWidgetActionGroup
 {
 
     /** The open sort dialog action. */
@@ -244,25 +244,31 @@
 
 
     /**
-     * Fills the context menu.
+     * Fills the context menu. Adds a menu listener to the given menu manager
+     * to fill the context menu whenever it pops up.
      * 
      * @param menuManager the menu manager
      */
     public void fillContextMenu( IMenuManager menuManager )
     {
         menuManager.setRemoveAllWhenShown( true );
-        menuManager.addMenuListener( this );
+        menuManager.addMenuListener( new IMenuListener()
+        {
+            public void menuAboutToShow( IMenuManager manager )
+            {
+                contextMenuAboutToShow( manager );
+            }
+        } );
     }
 
 
     /**
-     * {@inheritDoc}.
+     * Fills the context menu.
      * 
      * @param menuManager the menu manager
      */
-    public void menuAboutToShow( IMenuManager menuManager )
+    protected void contextMenuAboutToShow( IMenuManager menuManager )
     {
-
         // new
         menuManager.add( ( IAction ) entryEditorActionMap.get( newValueAction ) );
         menuManager.add( new Separator() );

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetConfiguration.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetConfiguration.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetConfiguration.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/widgets/entryeditor/EntryEditorWidgetConfiguration.java Sat Mar 17 14:09:54 2007
@@ -28,7 +28,7 @@
 /**
  * The BrowserConfiguration contains the content provider, 
  * label provider, sorter, filter the context menu manager and the
- * preferences for the browser widget. 
+ * preferences for the entry editor widget. 
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$

Modified: directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/wizards/NewEntryAttributesWizardPageActionGroup.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/wizards/NewEntryAttributesWizardPageActionGroup.java?view=diff&rev=519442&r1=519441&r2=519442
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/wizards/NewEntryAttributesWizardPageActionGroup.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/wizards/NewEntryAttributesWizardPageActionGroup.java Sat Mar 17 14:09:54 2007
@@ -99,7 +99,7 @@
     /**
      * {@inheritDoc}
      */
-    public void menuAboutToShow( IMenuManager menuManager )
+    protected void contextMenuAboutToShow( IMenuManager menuManager )
     {
         // new
         menuManager.add( ( IAction ) entryEditorActionMap.get( newAttributeAction ) );



Mime
View raw message