Return-Path: Delivered-To: apmail-directory-commits-archive@www.apache.org Received: (qmail 96632 invoked from network); 5 Jan 2007 19:15:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Jan 2007 19:15:22 -0000 Received: (qmail 57052 invoked by uid 500); 5 Jan 2007 19:15:28 -0000 Delivered-To: apmail-directory-commits-archive@directory.apache.org Received: (qmail 57026 invoked by uid 500); 5 Jan 2007 19:15:28 -0000 Mailing-List: contact commits-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@directory.apache.org Delivered-To: mailing list commits@directory.apache.org Received: (qmail 57015 invoked by uid 99); 5 Jan 2007 19:15:28 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 11:15:28 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2007 11:15:21 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id 0FA611A9820; Fri, 5 Jan 2007 11:14:24 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r493145 - in /directory/branches/shared/0.9.5/ldap/src: main/antlr/filter-parser.g test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java Date: Fri, 05 Jan 2007 19:14:23 -0000 To: commits@directory.apache.org From: akarasulu@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070105191424.0FA611A9820@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: akarasulu Date: Fri Jan 5 11:14:23 2007 New Revision: 493145 URL: http://svn.apache.org/viewvc?view=rev&rev=493145 Log: fixing bug where recognition exceptions were being swallowed up by the default error handler of the filter parser Modified: directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java Modified: directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g URL: http://svn.apache.org/viewvc/directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g?view=diff&rev=493145&r1=493144&r2=493145 ============================================================================== --- directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g (original) +++ directory/branches/shared/0.9.5/ldap/src/main/antlr/filter-parser.g Fri Jan 5 11:14:23 2007 @@ -51,6 +51,7 @@ { k = 5; importVocab = FilterLexer; + defaultErrorHandler=false; } Modified: directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java URL: http://svn.apache.org/viewvc/directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java?view=diff&rev=493145&r1=493144&r2=493145 ============================================================================== --- directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java (original) +++ directory/branches/shared/0.9.5/ldap/src/test/java/org/apache/directory/shared/ldap/filter/FilterParserImplTest.java Fri Jan 5 11:14:23 2007 @@ -175,22 +175,21 @@ assertEquals( AbstractExprNode.EQUALITY, node.getAssertionType() ); } - /* + public void testBadEqualsFilter() throws IOException, ParseException { try { - SimpleNode node = ( SimpleNode ) parser.parse( "ou = people" ); + parser.parse( "ou = people" ); // The parsing should fail - fail(); + fail( "should fail with bad filter" ); } catch( ParseException pe ) { - assertTrue( true ); } } - */ + public void testEqualsWithForwardSlashFilter() throws IOException, ParseException {